Newly introduced findings

List of Findings

Error: CPPCHECK_WARNING (CWE-398): [#def1]
avahi-0.9.rc3/avahi-common/strlst-test.c:94: style[constVariable]: Variable 'expected_sizes' can be declared as const array
#   92|           "null\0null","","quux","","","bar","foo=99","start","b","a","prefix",
#   93|       };
#   94|->     size_t expected_sizes[] = {
#   95|           3, 18, 67, 23, 7, 10, 9, 9, 0, 4, 0, 0, 3, 6, 5, 1, 1, 6,
#   96|       };

Error: CPPCHECK_WARNING (CWE-398): [#def2]
avahi-0.9.rc3/avahi-common/strlst-test.c:260: style[constParameterPointer]: Parameter 'a' can be declared as pointer to const
#  258|    * Verify copy semantics and equality checks.
#  259|    */
#  260|-> static void test_copy_and_equality(AvahiStringList *a) {
#  261|       AvahiStringList *b;
#  262|       char *t;

Error: GCC_ANALYZER_WARNING (CWE-404): [#def3]
avahi-0.9.rc3/avahi-common/strlst-test.c: scope_hint: In function ‘new_va_helper’
avahi-0.9.rc3/avahi-common/strlst-test.c:376:9: warning[-Wanalyzer-va-list-leak]: missing call to ‘va_end’
#  374|   
#  375|       va_start(va, first);
#  376|->     l = avahi_string_list_new_va(va);
#  377|       va_end(va);
#  378|   

Error: GCC_ANALYZER_WARNING (CWE-404): [#def4]
avahi-0.9.rc3/avahi-common/strlst-test.c: scope_hint: In function ‘add_many’
avahi-0.9.rc3/avahi-common/strlst-test.c:388:11: warning[-Wanalyzer-va-list-leak]: missing call to ‘va_end’
#  386|   
#  387|       va_start(ap, r);
#  388|->     ret = avahi_string_list_add_many_va(r, ap);
#  389|       va_end(ap);
#  390|   

Error: CPPCHECK_WARNING (CWE-398): [#def5]
avahi-0.9.rc3/avahi-common/strlst-test.c:1062: style[constVariable]: Variable 'text' can be declared as const array
# 1060|       size_t used;
# 1061|       uint8_t buf[300];
# 1062|->     char text[10] = "abcdefghi";
# 1063|       char long_text[300];
# 1064|   

Error: CPPCHECK_WARNING (CWE-398): [#def6]
avahi-0.9.rc3/avahi-common/strlst-test.c:1253: style[constVariablePointer]: Variable 'r' can be declared as pointer to const
# 1251|    */
# 1252|   static void test_avahi_string_list_add_vprintf_failures(void) {
# 1253|->     AvahiStringList *r;
# 1254|       char long_string[256];
# 1255|       int i;

Error: CPPCHECK_WARNING (CWE-398): [#def7]
avahi-0.9.rc3/avahi-common/strlst-test.c:1293: style[constVariablePointer]: Variable 'r' can be declared as pointer to const
# 1291|   static void test_string_list_add_anonymous_malloc_fail(void) {
# 1292|       AvahiStringList *l = (AvahiStringList *) 0xdeadbeef;
# 1293|->     AvahiStringList *r;
# 1294|   
# 1295|       /* Cause the next allocation to fail */

Error: CPPCHECK_WARNING (CWE-398): [#def8]
avahi-0.9.rc3/avahi-common/strlst-test.c:1317: style[constVariablePointer]: Variable 'r' can be declared as pointer to const
# 1315|   static void test_string_list_add_arbitrary_malloc_fail(void) {
# 1316|       AvahiStringList *l = (AvahiStringList *) 0xcafebabe;
# 1317|->     AvahiStringList *r;
# 1318|       const uint8_t text[] = { 0x01, 0x02, 0x03 };
# 1319|   

Error: CPPCHECK_WARNING (CWE-398): [#def9]
avahi-0.9.rc3/avahi-common/strlst-test.c:1368: style[constVariablePointer]: Variable 'r' can be declared as pointer to const
# 1366|   static void test_avahi_string_list_copy_failures(void) {
# 1367|       AvahiStringList *l = NULL;
# 1368|->     AvahiStringList *r = NULL;
# 1369|   
# 1370|       // Build a small list

Error: CPPCHECK_WARNING (CWE-398): [#def10]
avahi-0.9.rc3/avahi-common/strlst-test.c:1398: style[constVariablePointer]: Variable 'l' can be declared as pointer to const
# 1396|    */
# 1397|   static void test_avahi_string_list_add_pair_arbitrary_failures(void) {
# 1398|->     AvahiStringList *l = NULL;
# 1399|       AvahiStringList *existing;
# 1400|       const char *key = "foo";

Error: CPPCHECK_WARNING (CWE-398): [#def11]
avahi-0.9.rc3/avahi-common/strlst-test.c:1430: style[constVariablePointer]: Variable 's' can be declared as pointer to const
# 1428|   static void test_avahi_string_list_to_string_fail(void) {
# 1429|       AvahiStringList *l;
# 1430|->     char *s;
# 1431|   
# 1432|       // Build a normal list

Error: CPPCHECK_WARNING (CWE-398): [#def12]
avahi-0.9.rc3/avahi-common/strlst-test.c:1459: style[constVariablePointer]: Variable 'r' can be declared as pointer to const
# 1457|    */
# 1458|   static void test_avahi_string_list_add_many_va_failures(void) {
# 1459|->     AvahiStringList *r = NULL;
# 1460|   
# 1461|       // --- 1) First allocation fails ---

Error: GCC_ANALYZER_WARNING (CWE-404): [#def13]
avahi-0.9.rc3/avahi-common/strlst.c: scope_hint: In function 'avahi_string_list_free'
avahi-0.9.rc3/avahi-common/strlst.c:115:9: warning[-Wanalyzer-va-list-leak]: missing call to 'va_end'
#  113|       while (l) {
#  114|           n = l->next;
#  115|->         avahi_free(l);
#  116|           l = n;
#  117|       }

Error: GCC_ANALYZER_WARNING (CWE-404): [#def14]
avahi-0.9.rc3/avahi-common/strlst.c:115:9: warning[-Wanalyzer-va-list-leak]: missing call to ‘va_end’
avahi-0.9.rc3/avahi-common/strlst.c: scope_hint: In function ‘avahi_string_list_add_many_va’
#  113|       while (l) {
#  114|           n = l->next;
#  115|->         avahi_free(l);
#  116|           l = n;
#  117|       }

Scan Properties