Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-401): [#def1]
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/dri3/dri3_screen.c: scope_hint: In function ‘cache_formats_and_modifiers’
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/dri3/dri3_screen.c:186:8: warning[-Wanalyzer-malloc-leak]: leak of ‘((struct dri3_screen_priv)**screen.devPrivates).formats’
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/include/privates.h: scope_hint: In function ‘cache_formats_and_modifiers’
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/dri3/dri3_screen.c: scope_hint: In function ‘cache_formats_and_modifiers’
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/dri3/dri3_screen.c: scope_hint: In function ‘cache_formats_and_modifiers’
#  184|   
#  185|       ds->formats = calloc(num_formats, sizeof(dri3_dmabuf_format_rec));
#  186|->     if (!ds->formats)
#  187|           return BadAlloc;
#  188|   

Error: CLANG_WARNING: [#def2]
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/glamor/glamor_xv.c:389:34: warning[core.NullDereference]: Access to field 'fbo' results in a dereference of a null pointer
#  387|   
#  388|       glActiveTexture(GL_TEXTURE1);
#  389|->     glBindTexture(GL_TEXTURE_2D, src_pixmap_priv[1]->fbo->tex);
#  390|       glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
#  391|       glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);

Error: CLANG_WARNING: [#def3]
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/hw/xwayland/xwayland-glamor.c:955:10: warning[core.NullDereference]: Access to field 'class' results in a dereference of a null pointer (loaded from variable 'window_visual')
#  953|       }
#  954|   
#  955|->     if ((window_visual->class != TrueColor &&
#  956|            window_visual->class != DirectColor) ||
#  957|           window_visual->redMask != parent_visual->redMask ||

Error: GCC_ANALYZER_WARNING (CWE-476): [#def4]
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/hw/xwayland/xwayland-glamor.c: scope_hint: In function ‘xwl_avoid_implicit_redirect’
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/hw/xwayland/xwayland-glamor.c:955:23: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘window_visual’
#  953|       }
#  954|   
#  955|->     if ((window_visual->class != TrueColor &&
#  956|            window_visual->class != DirectColor) ||
#  957|           window_visual->redMask != parent_visual->redMask ||

Error: CLANG_WARNING: [#def5]
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/hw/xwayland/xwayland-window-buffers.c:185:16: warning[unix.Malloc]: Use of memory after it is freed
#  183|                                     link_buffer);
#  184|   
#  185|->         return oldest_available_buffer->time + BUFFER_TIMEOUT - time;
#  186|       }
#  187|   

Error: GCC_ANALYZER_WARNING (CWE-762): [#def6]
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/os/utils.c: scope_hint: In function ‘xstrtokenize’
xorg-x11-server-Xwayland-23.2.4-build/xwayland-23.2.4/os/utils.c:2071:17: warning[-Wanalyzer-mismatching-deallocation]: ‘list’ should have been deallocated with ‘free’ but was deallocated with ‘reallocarray’
# 2069|           goto error;
# 2070|       for (tok = strtok(tmp, separators); tok; tok = strtok(NULL, separators)) {
# 2071|->         nlist = reallocarray(list, num + 2, sizeof(*list));
# 2072|           if (!nlist)
# 2073|               goto error;

Scan Properties