Newly introduced findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-401): [#def1]
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/dri3/dri3_screen.c: scope_hint: In function ‘cache_formats_and_modifiers’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/dri3/dri3_screen.c:186:8: warning[-Wanalyzer-malloc-leak]: leak of ‘((struct dri3_screen_priv)**screen.devPrivates).formats’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/include/privates.h: scope_hint: In function ‘cache_formats_and_modifiers’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/dri3/dri3_screen.c: scope_hint: In function ‘cache_formats_and_modifiers’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/dri3/dri3_screen.c: scope_hint: In function ‘cache_formats_and_modifiers’
#  184|   
#  185|       ds->formats = calloc(num_formats, sizeof(dri3_dmabuf_format_rec));
#  186|->     if (!ds->formats) {
#  187|           free(formats);
#  188|           return BadAlloc;

Error: CLANG_WARNING: [#def2]
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/fb/fbscreen.c:179:59: warning[core.BitwiseShift]: Right operand is negative in left shift
#  177|       rootdepth = 0;
#  178|       if (!fbInitVisuals(&visuals, &depths, &nvisuals, &ndepths, &rootdepth,
#  179|->                        &defaultVisual, ((unsigned long) 1 << (bpp - 1)),
#  180|                          8))
#  181|           return FALSE;

Error: CLANG_WARNING: [#def3]
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/glamor/glamor_program.c:406:5: warning[unix.Malloc]: Attempt to free released memory
#  404|           prog->prog = 0;
#  405|       }
#  406|->     free(vs_prog_string);
#  407|       free(fs_prog_string);
#  408|       free(version_string);

Error: GCC_ANALYZER_WARNING (CWE-457): [#def4]
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/glamor/glamor_xv.c:505:53: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘src_pixmap_priv[1]’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/glamor/glamor_xv.c: scope_hint: In function ‘glamor_xv_render’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/glamor/glamor_xv.c:412:18: note: in expansion of macro ‘REGION_RECTS’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/glamor/glamor_xv.c: scope_hint: In function ‘glamor_xv_render’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/glamor/glamor_xv.c:413:16: note: in expansion of macro ‘REGION_NUM_RECTS’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/glamor/glamor_xv.c: scope_hint: In function ‘glamor_xv_render’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/include/privates.h: scope_hint: In function ‘glamor_xv_render’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/glamor/glamor_xv.c: scope_hint: In function ‘glamor_xv_render’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/glamor/glamor_xv.c: scope_hint: In function ‘glamor_xv_render’
#  503|   
#  504|           glActiveTexture(GL_TEXTURE1);
#  505|->         glBindTexture(GL_TEXTURE_2D, src_pixmap_priv[1]->fbo->tex);
#  506|           glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
#  507|           glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);

Error: GCC_ANALYZER_WARNING (CWE-401): [#def5]
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/hw/xwayland/xwayland-glamor-gbm.c: scope_hint: In function ‘xwl_dri3_create_syncobj’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/hw/xwayland/xwayland-glamor-gbm.c:1158:12: warning[-Wanalyzer-malloc-leak]: leak of ‘syncobj’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/include/cursor.h:53: included_from: Included from here.
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/include/scrnintstr.h:53: included_from: Included from here.
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/glamor/glamor.h:32: included_from: Included from here.
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/hw/xwayland/xwayland-glamor-gbm.c:49: included_from: Included from here.
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/include/privates.h: scope_hint: In function ‘xwl_dri3_create_syncobj’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/hw/xwayland/xwayland-glamor-gbm.c: scope_hint: In function ‘xwl_dri3_create_syncobj’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/hw/xwayland/xwayland-glamor-gbm.c: scope_hint: In function ‘xwl_dri3_create_syncobj’
# 1156|       syncobj->base.signaled_eventfd = xwl_dri3_syncobj_signaled_eventfd;
# 1157|       syncobj->base.submitted_eventfd = xwl_dri3_syncobj_submitted_eventfd;
# 1158|->     return &syncobj->base;
# 1159|   
# 1160|   fail:

Error: CLANG_WARNING: [#def6]
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/hw/xwayland/xwayland-window.c:1093:22: warning[unix.Malloc]: Use of memory after it is freed
# 1091|   
# 1092|       xorg_list_for_each_entry(window_output, &xwl_window->xwl_output_list, link) {
# 1093|->         xwl_output = window_output->xwl_output;
# 1094|           if (xwl_output->scale > scale)
# 1095|               scale = xwl_output->scale;

Error: GCC_ANALYZER_WARNING (CWE-762): [#def7]
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/os/string.c: scope_hint: In function ‘xstrtokenize’
xorg-x11-server-Xwayland-24.1.0-build/xwayland-24.1.0/os/string.c:55:17: warning[-Wanalyzer-mismatching-deallocation]: ‘list’ should have been deallocated with ‘free’ but was deallocated with ‘reallocarray’
#   53|           goto error;
#   54|       for (tok = strtok(tmp, separators); tok; tok = strtok(NULL, separators)) {
#   55|->         nlist = reallocarray(list, num + 2, sizeof(*list));
#   56|           if (!nlist)
#   57|               goto error;

Scan Properties

analyzer-version-clang18.1.8
analyzer-version-clippy1.80.1
analyzer-version-cppcheck2.15.0
analyzer-version-gcc14.2.1
analyzer-version-gcc-analyzer14.2.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clang18.1.8
diffbase-analyzer-version-clippy1.80.1
diffbase-analyzer-version-cppcheck2.15.0
diffbase-analyzer-version-gcc14.2.1
diffbase-analyzer-version-gcc-analyzer14.2.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclang, clippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-8.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namexorg-x11-server-Xwayland-23.2.4-3.fc40
diffbase-store-results-to/tmp/tmpaj91upmx/xorg-x11-server-Xwayland-23.2.4-3.fc40.tar.xz
diffbase-time-created2024-09-05 13:55:29
diffbase-time-finished2024-09-05 14:01:13
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,clang,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpaj91upmx/xorg-x11-server-Xwayland-23.2.4-3.fc40.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '/tmp/tmpaj91upmx/xorg-x11-server-Xwayland-23.2.4-3.fc40.src.rpm'
diffbase-tool-versioncsmock-3.6.1-1.el9
enabled-pluginsclang, clippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-8.us-west-2.compute.internal
mock-configfedora-rawhide-x86_64
project-namexorg-x11-server-Xwayland-24.1.0-2.fc41
store-results-to/tmp/tmpgv0f1pfn/xorg-x11-server-Xwayland-24.1.0-2.fc41.tar.xz
time-created2024-09-05 14:01:42
time-finished2024-09-05 14:07:03
titleNewly introduced findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,clang,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmpgv0f1pfn/xorg-x11-server-Xwayland-24.1.0-2.fc41.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '/tmp/tmpgv0f1pfn/xorg-x11-server-Xwayland-24.1.0-2.fc41.src.rpm'
tool-versioncsmock-3.6.1-1.el9