Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-476): [#def1]
util-linux-2.42.start/disk-utils/fdformat.c:129:49: warning[-Wanalyzer-possible-null-dereference]: dereference of possibly-NULL ‘xmalloc(track_size) + count’
util-linux-2.42.start/disk-utils/fdformat.c:20: included_from: Included from here.
#  127|   				}
#  128|   				for (count = 0; count < track_size; count++)
#  129|-> 					if (data[count] != FD_FILL_BYTE) {
#  130|   						if (retries_left) {
#  131|   							format_begin(ctrl);

Error: GCC_ANALYZER_WARNING (CWE-401): [#def2]
util-linux-2.42.start/include/xalloc.h:68:13: warning[-Wanalyzer-malloc-leak]: leak of ‘open_pidfds(n_pids,  parse_pids(n_pids,  argv + (long unsigned int)parse_options(argc,  argv) * 8))’
#   66|   	void *ret = calloc(nelems, size);
#   67|   
#   68|-> 	if (!ret && size && nelems)
#   69|   		err(XALLOC_EXIT_CODE, "cannot allocate %zu bytes", size);
#   70|   	return ret;

Error: GCC_ANALYZER_WARNING (CWE-401): [#def3]
util-linux-2.42.start/include/xalloc.h: scope_hint: In function ‘xcalloc’
util-linux-2.42.start/include/xalloc.h:68:13: warning[-Wanalyzer-malloc-leak]: leak of ‘parse_pids(n_pids,  argv + (long unsigned int)parse_options(argc,  argv) * 8)’
#   66|   	void *ret = calloc(nelems, size);
#   67|   
#   68|-> 	if (!ret && size && nelems)
#   69|   		err(XALLOC_EXIT_CODE, "cannot allocate %zu bytes", size);
#   70|   	return ret;

Error: GCC_ANALYZER_WARNING (CWE-401): [#def4]
util-linux-2.42.start/misc-utils/waitpid.c:33: included_from: Included from here.
util-linux-2.42.start/include/xalloc.h: scope_hint: In function ‘open_pidfds’
util-linux-2.42.start/include/xalloc.h:68:13: warning[-Wanalyzer-malloc-leak]: leak of ‘xcalloc(n_pids, 4)’
util-linux-2.42.start/misc-utils/waitpid.c:24: included_from: Included from here.
#   66|   	void *ret = calloc(nelems, size);
#   67|   
#   68|-> 	if (!ret && size && nelems)
#   69|   		err(XALLOC_EXIT_CODE, "cannot allocate %zu bytes", size);
#   70|   	return ret;

Error: GCC_ANALYZER_WARNING (CWE-401): [#def5]
util-linux-2.42.start/include/xalloc.h: scope_hint: In function ‘parse_pids’
util-linux-2.42.start/include/xalloc.h:68:13: warning[-Wanalyzer-malloc-leak]: leak of ‘xcalloc(n_strings, 4)’
util-linux-2.42.start/include/xalloc.h:19: included_from: Included from here.
util-linux-2.42.start/include/strutils.h:55:64: note: in definition of macro ‘strtopid_or_err’
util-linux-2.42.start/misc-utils/waitpid.c:53:55: note: in expansion of macro ‘_’
util-linux-2.42.start/misc-utils/waitpid.c:53:27: note: in expansion of macro ‘strtopid_or_err’
#   66|   	void *ret = calloc(nelems, size);
#   67|   
#   68|-> 	if (!ret && size && nelems)
#   69|   		err(XALLOC_EXIT_CODE, "cannot allocate %zu bytes", size);
#   70|   	return ret;

Error: GCC_ANALYZER_WARNING (CWE-465): [#def6]
util-linux-2.42.start/lib/pidutils.c: scope_hint: In function 'ul_parse_pid_str'
util-linux-2.42.start/lib/pidutils.c:46:24: warning[-Wanalyzer-deref-before-check]: check of 'end' for NULL after already dereferencing it
#   44|   		*end = '\0';
#   45|   	}
#   46|-> 	if (errno != 0 || ((end && *end != '\0') || pidstr >= end))
#   47|   		return -EINVAL;
#   48|   	return 0;

Error: GCC_ANALYZER_WARNING (CWE-401): [#def7]
util-linux-2.42.start/lsfd-cmd/lsfd.c: scope_hint: In function ‘new_filter’
util-linux-2.42.start/lsfd-cmd/lsfd.c:2394:28: warning[-Wanalyzer-malloc-leak]: leak of ‘xcalloc(17, 8) + i * 8’
util-linux-2.42.start/include/nls.h:27: included_from: Included from here.
util-linux-2.42.start/include/closestream.h:15: included_from: Included from here.
util-linux-2.42.start/lsfd-cmd/lsfd.c:51: included_from: Included from here.
util-linux-2.42.start/lsfd-cmd/lsfd.c:2308:35: note: in expansion of macro ‘_’
# 2392|   	struct libscols_counter *ct;
# 2393|   
# 2394|-> 	f = new_filter(spec->expr, false, ctl);
# 2395|   
# 2396|   	ct = scols_filter_new_counter(f);

Error: GCC_ANALYZER_WARNING (CWE-476): [#def8]
util-linux-2.42.start/misc-utils/blkid.c: scope_hint: In function ‘main’
util-linux-2.42.start/misc-utils/blkid.c:889:43: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc((long unsigned int)(argc - optind), 8) + (long unsigned int)numdev * 8’
util-linux-2.42.start/misc-utils/blkid.c:18: included_from: Included from here.
#  887|   				continue;
#  888|   
#  889|-> 			devices[numdev++] = dev;
#  890|   		}
#  891|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def9]
util-linux-2.42.start/misc-utils/logger.c:1050:34: warning[-Wanalyzer-possible-null-dereference]: dereference of possibly-NULL ‘xmalloc(*ctl.max_message_size + 4) + i’
# 1048|   
# 1049|   		while (c != EOF && c != '\n' && i < ctl->max_message_size) {
# 1050|-> 			buf[i++] = c;
# 1051|   			c = getchar();
# 1052|   		}

Error: GCC_ANALYZER_WARNING (CWE-476): [#def10]
util-linux-2.42.start/misc-utils/logger.c:1053:24: warning[-Wanalyzer-possible-null-dereference]: dereference of possibly-NULL ‘xmalloc(*ctl.max_message_size + 4) + i’
# 1051|   			c = getchar();
# 1052|   		}
# 1053|-> 		buf[i] = '\0';
# 1054|   
# 1055|   		if (i > 0 || !ctl->skip_empty_lines) {

Error: GCC_ANALYZER_WARNING (CWE-476): [#def11]
util-linux-2.42.start/misc-utils/waitpid.c: scope_hint: In function ‘parse_pids’
util-linux-2.42.start/misc-utils/waitpid.c:53:25: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc(n_strings, 4) + i * 4’
util-linux-2.42.start/include/strutils.h:55:64: note: in definition of macro ‘strtopid_or_err’
util-linux-2.42.start/misc-utils/waitpid.c:53:55: note: in expansion of macro ‘_’
#   51|   
#   52|   	for (size_t i = 0; i < n_strings; i++)
#   53|-> 		pids[i] = strtopid_or_err(strings[i], _("invalid PID argument"));
#   54|   
#   55|   	return pids;

Scan Properties