Task #89814 - added.err

back to task #89814
download
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/export.rs:52:5: warning: unneeded `return` statement
#     |
#  52 |     return Ok(Some((header.clone(), item)));
#     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
#  help: remove `return`
#     |
#  52 -     return Ok(Some((header.clone(), item)));
#  52 +     Ok(Some((header.clone(), item)))
#     |

Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/export.rs:164:21: warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
#      |
#  164 | /                     match &leaf_content {
#  165 | |                         LeafContent::Regular(reg) => match reg {
#  166 | |                             RegularFile::Inline(items) => {
#  167 | |                                 v[..hsize].copy_from_slice(items);
#  ...   |
#  178 | |                         _ => {}
#  179 | |                     }
#      | |_____________________^
#      |
#      = note: you might want to preserve the comments from inside the `match`
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#single_match
#      = note: `#[warn(clippy::single_match)]` on by default
#  help: try
#      |
#  164 ~                     if let LeafContent::Regular(reg) = &leaf_content { match reg {
#  165 +                         RegularFile::Inline(items) => {
#  166 +                             v[..hsize].copy_from_slice(items);
#  167 +                         }
#  168 + 
#  169 +                         RegularFile::External(obj_id, ..) => {
#  170 +                             let mut file = File::from(booted_cfs.repo.open_object(obj_id)?);
#  171 +                             file.read_exact(&mut v)?;
#  172 +                         }
#  173 +                     } }
#      |

Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/export.rs:210:36: warning: using `clone` on type `Option<&History>` which implements the `Copy` trait
#      |
#  210 |           let previous_description = history_entry
#      |  ____________________________________^
#  211 | |             .clone()
#      | |____________________^ help: try removing the `clone` call: `history_entry`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#clone_on_copy
#      = note: `#[warn(clippy::clone_on_copy)]` on by default