Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/lib/src/bootc_composefs/status.rs:417:5: warning: unneeded `return` statement
#      |
#  417 |     return true;
#      |     ^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
#  help: remove `return`
#      |
#  417 -     return true;
#  417 +     true
#      |

Error: CLIPPY_WARNING: [#def2]
crates/lib/src/bootc_composefs/status.rs:434:43: warning: deref which would be done by auto-deref
#      |
#  434 |     let booted_bls_entry = find_bls_entry(&*booted_cmdline.digest, &bls_entries)?
#      |                                           ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&booted_cmdline.digest`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#explicit_auto_deref
#      = note: `#[warn(clippy::explicit_auto_deref)]` on by default

Error: CLIPPY_WARNING: [#def3]
crates/lib/src/bootc_composefs/status.rs:473:8: warning: needless call to `as_bytes`
#      |
#  473 |     if depl_cmdline.as_bytes().len() != booted_cmdline.as_bytes().len() {
#      |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `depl_cmdline.len()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_as_bytes
#      = note: `#[warn(clippy::needless_as_bytes)]` on by default

Error: CLIPPY_WARNING: [#def4]
crates/lib/src/bootc_composefs/status.rs:473:41: warning: needless call to `as_bytes`
#      |
#  473 |     if depl_cmdline.as_bytes().len() != booted_cmdline.as_bytes().len() {
#      |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `booted_cmdline.len()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_as_bytes

Error: CLIPPY_WARNING: [#def5]
crates/lib/src/bootc_composefs/status.rs:478:5: warning: unneeded `return` statement
#      |
#  478 | /     return compare_cmdline_skip_cfs(depl_cmdline, booted_cmdline)
#  479 | |         && compare_cmdline_skip_cfs(booted_cmdline, depl_cmdline);
#      | |_________________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
#  help: remove `return`
#      |
#  478 ~     compare_cmdline_skip_cfs(depl_cmdline, booted_cmdline)
#  479 ~         && compare_cmdline_skip_cfs(booted_cmdline, depl_cmdline)
#      |

Scan Properties

analyzer-version-clippy1.92.0
analyzer-version-cppcheck2.18.3
analyzer-version-gcc15.2.1
analyzer-version-gcc-analyzer15.2.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.92.0
diffbase-analyzer-version-cppcheck2.18.3
diffbase-analyzer-version-gcc15.2.1
diffbase-analyzer-version-gcc-analyzer15.2.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-82.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20250521.132812.g8eff701.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namebootc-202512181152.gfa1726b161-1
diffbase-store-results-to/tmp/tmp5nvux2a5/bootc-202512181152.gfa1726b161-1.tar.xz
diffbase-time-created2025-12-18 16:07:23
diffbase-time-finished2025-12-18 16:21:05
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'cppcheck,unicontrol,gcc,shellcheck,clippy' '-o' '/tmp/tmp5nvux2a5/bootc-202512181152.gfa1726b161-1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmp5nvux2a5/bootc-202512181152.gfa1726b161-1.src.rpm'
diffbase-tool-versioncsmock-3.8.3.20251215.161544.g62de9a5-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-82.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20250521.132812.g8eff701.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namebootc-202512181307.g2a9d6d7e13-1
store-results-to/tmp/tmpbggm7mwi/bootc-202512181307.g2a9d6d7e13-1.tar.xz
time-created2025-12-18 16:21:34
time-finished2025-12-18 16:34:49
titleNewly introduced findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'cppcheck,unicontrol,gcc,shellcheck,clippy' '-o' '/tmp/tmpbggm7mwi/bootc-202512181307.g2a9d6d7e13-1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmpbggm7mwi/bootc-202512181307.g2a9d6d7e13-1.src.rpm'
tool-versioncsmock-3.8.3.20251215.161544.g62de9a5-1.el9