bootc-202511140046.gcc615a0e21-1

List of Findings

Error: COMPILER_WARNING (CWE-704): [#def1]
bootc-202511140046.gcc615a0e21/vendor/libz-sys/src/smoke.c: scope_hint: In function 'main'
bootc-202511140046.gcc615a0e21/vendor/libz-sys/src/smoke.c:4:10: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
#    2|   
#    3|   int main() {
#    4|->   return (int) adler32;
#    5|   }

Error: CLIPPY_WARNING: [#def2]
crates/etc-merge/src/lib.rs:78:5: warning: unneeded `return` statement
#     |
#  78 |     return true;
#     |     ^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_return
#     = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#     |
#  78 -     return true;
#  78 +     true
#     |

Error: CLIPPY_WARNING: [#def3]
crates/etc-merge/src/lib.rs:295:5: warning: doc list item without indentation
#      |
#  295 | /// Usually this will be obtained by remounting the EROFS image to a temporary location
#      |     ^
#      |
#      = help: if this is supposed to be its own paragraph, add a blank line
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#doc_lazy_continuation
#      = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
#  help: indent this line
#      |
#  295 | ///   Usually this will be obtained by remounting the EROFS image to a temporary location
#      |     ++

Error: CLIPPY_WARNING: [#def4]
crates/etc-merge/src/lib.rs:300:5: warning: doc list item without indentation
#      |
#  300 | /// again be usually obtained by mounting the new EROFS image to a temporary location. If merging
#      |     ^
#      |
#      = help: if this is supposed to be its own paragraph, add a blank line
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#doc_lazy_continuation
#  help: indent this line
#      |
#  300 | ///   again be usually obtained by mounting the new EROFS image to a temporary location. If merging
#      |     ++

Error: CLIPPY_WARNING: [#def5]
crates/etc-merge/src/lib.rs:301:5: warning: doc list item without indentation
#      |
#  301 | /// it will be necessary to make the `/etc` for the deployment writeable
#      |     ^
#      |
#      = help: if this is supposed to be its own paragraph, add a blank line
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#doc_lazy_continuation
#  help: indent this line
#      |
#  301 | ///   it will be necessary to make the `/etc` for the deployment writeable
#      |     ++

Error: CLIPPY_WARNING: [#def6]
crates/etc-merge/src/lib.rs:314:6: warning: very complex type used. Consider factoring parts into `type` definitions
#      |
#  314 |   ) -> anyhow::Result<(
#      |  ______^
#  315 | |     Directory<CustomMetadata>,
#  316 | |     Directory<CustomMetadata>,
#  317 | |     Option<Directory<CustomMetadata>>,
#  318 | | )> {
#      | |__^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#type_complexity
#      = note: `#[warn(clippy::type_complexity)]` on by default

Error: CLIPPY_WARNING: [#def7]
crates/etc-merge/src/lib.rs:338:5: warning: unneeded `return` statement
#      |
#  338 |     return Ok((pristine_etc_files, current_etc_files, new_etc_files));
#      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_return
#  help: remove `return`
#      |
#  338 -     return Ok((pristine_etc_files, current_etc_files, new_etc_files));
#  338 +     Ok((pristine_etc_files, current_etc_files, new_etc_files))
#      |

Error: CLIPPY_WARNING: [#def8]
crates/etc-merge/src/lib.rs:441:35: warning: useless use of `format!`
#      |
#  441 |         let entry = entry.context(format!("Getting entry"))?;
#      |                                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Getting entry".to_string()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_format
#      = note: `#[warn(clippy::useless_format)]` on by default

Error: CLIPPY_WARNING: [#def9]
crates/lib/src/bootc_composefs/boot.rs:589:1: warning: this function has too many arguments (8/7)
#      |
#  589 | / fn write_pe_to_esp(
#  590 | |     repo: &crate::store::ComposefsRepository,
#  591 | |     file: &RegularFile<Sha512HashValue>,
#  592 | |     file_path: &Utf8Path,
#  ...   |
#  597 | |     bootloader: &Bootloader,
#  598 | | ) -> Result<Option<UKILabels>> {
#      | |______________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Error: CLIPPY_WARNING: [#def10]
crates/lib/src/bootc_composefs/boot.rs:679:29: warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
#      |
#  679 |           PEType::UkiAddon => file_path
#      |  _____________________________^
#  680 | |             .components()
#  681 | |             .last()
#      | |______________-----^
#      |                |
#      |                help: try: `next_back()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#double_ended_iterator_last
#      = note: `#[warn(clippy::double_ended_iterator_last)]` on by default

Error: CLIPPY_WARNING: [#def11]
crates/lib/src/bootc_composefs/boot.rs:908:38: warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
#      |
#  908 |                       let addon_name = entry
#      |  ______________________________________^
#  909 | |                         .file_path
#  910 | |                         .components()
#  911 | |                         .last()
#      | |__________________________-----^
#      |                            |
#      |                            help: try: `next_back()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#double_ended_iterator_last

Error: CLIPPY_WARNING: [#def12]
crates/lib/src/bootc_composefs/boot.rs:1002:23: warning: using `.iter().next()` on an array
#       |
#  1002 |     let Some(entry) = entries.iter().next() else {
#       |                       ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()`
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#iter_next_slice
#       = note: `#[warn(clippy::iter_next_slice)]` on by default

Error: CLIPPY_WARNING: [#def13]
crates/lib/src/bootc_composefs/delete.rs:329:8: warning: taken reference of right operand
#      |
#  329 |     if deployment_id == &booted.verity {
#      |        ^^^^^^^^^^^^^^^^^--------------
#      |                         |
#      |                         help: use the right value directly: `booted.verity`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#op_ref
#      = note: `#[warn(clippy::op_ref)]` on by default

Error: CLIPPY_WARNING: [#def14]
crates/lib/src/bootc_composefs/delete.rs:343:27: warning: this `map_or` can be simplified
#      |
#  343 |       let deleting_staged = host
#      |  ___________________________^
#  344 | |         .status
#  345 | |         .staged
#  346 | |         .as_ref()
#  347 | |         .and_then(|s| s.composefs.as_ref())
#  348 | |         .map_or(false, |cfs| cfs.verity == deployment_id);
#      | |_________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_map_or
#      = note: `#[warn(clippy::unnecessary_map_or)]` on by default
#  help: use is_some_and instead
#      |
#  348 -         .map_or(false, |cfs| cfs.verity == deployment_id);
#  348 +         .is_some_and(|cfs| cfs.verity == deployment_id);
#      |

Error: CLIPPY_WARNING: [#def15]
crates/lib/src/bootc_composefs/repo.rs:74:16: warning: writing `&String` instead of `&str` involves a new object where a slice will do
#     |
#  74 |     transport: &String,
#     |                ^^^^^^^ help: change this to: `&str`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#ptr_arg
#     = note: `#[warn(clippy::ptr_arg)]` on by default

Error: CLIPPY_WARNING: [#def16]
crates/lib/src/bootc_composefs/repo.rs:75:12: warning: writing `&String` instead of `&str` involves a new object where a slice will do
#     |
#  75 |     image: &String,
#     |            ^^^^^^^ help: change this to: `&str`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#ptr_arg

Error: CLIPPY_WARNING: [#def17]
crates/lib/src/bootc_composefs/status.rs:145:19: warning: slow zero-filling initialization
#      |
#  145 |       let mut buf = Vec::with_capacity(manifest.config().size() as usize);
#      |  ___________________^
#  146 | |     buf.resize(manifest.config().size() as usize, 0);
#      | |____________________________________________________^ help: consider replacing this with: `vec![0; manifest.config().size() as usize]`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#slow_vector_initialization
#      = note: `#[warn(clippy::slow_vector_initialization)]` on by default

Error: CLIPPY_WARNING: [#def18]
crates/lib/src/bootc_composefs/switch.rs:50:23: warning: using `.iter().next()` on an array
#     |
#  50 |     let Some(entry) = entries.iter().next() else {
#     |                       ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#iter_next_slice

Error: CLIPPY_WARNING: [#def19]
crates/lib/src/bootc_composefs/update.rs:141:33: warning: `to_string` applied to a type that implements `Display` in `println!` args
#      |
#  141 |                     layer.size().to_string()
#      |                                 ^^^^^^^^^^^^ help: remove this
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#to_string_in_format_args
#      = note: `#[warn(clippy::to_string_in_format_args)]` on by default

Error: CLIPPY_WARNING: [#def20]
crates/lib/src/bootc_composefs/update.rs:153:23: warning: using `.iter().next()` on an array
#      |
#  153 |     let Some(entry) = entries.iter().next() else {
#      |                       ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#iter_next_slice

Error: CLIPPY_WARNING: [#def21]
crates/lib/src/cli.rs:1010:5: warning: unneeded `return` statement
#       |
#  1010 |     return Ok(target);
#       |     ^^^^^^^^^^^^^^^^^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_return
#       = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#       |
#  1010 -     return Ok(target);
#  1010 +     Ok(target)
#       |

Error: CLIPPY_WARNING: [#def22]
crates/lib/src/install.rs:645:16: warning: inequality checks against false are unnecessary
#      |
#  645 |             if self.composefs_opts.insecure != false {
#      |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.composefs_opts.insecure`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#bool_comparison
#      = note: `#[warn(clippy::bool_comparison)]` on by default

Error: CLIPPY_WARNING: [#def23]
crates/lib/src/install.rs:1461:16: warning: this `else { if .. }` block can be collapsed
#       |
#  1461 |           } else {
#       |  ________________^
#  1462 | |             if crate::bootloader::supports_bootupd(None)? {
#  1463 | |                 crate::spec::Bootloader::Grub
#  1464 | |             } else {
#  ...    |
#  1467 | |         }
#       | |_________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#collapsible_else_if
#       = note: `#[warn(clippy::collapsible_else_if)]` on by default
#  help: collapse nested if block
#       |
#  1461 ~         } else if crate::bootloader::supports_bootupd(None)? {
#  1462 +             crate::spec::Bootloader::Grub
#  1463 +         } else {
#  1464 +             crate::spec::Bootloader::Systemd
#  1465 +         }
#       |

Error: CLIPPY_WARNING: [#def24]
crates/lib/src/install.rs:1691:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#       |
#  1691 |       let source_image = opts
#       |  ________________________^
#  1692 | |         .source_opts
#  1693 | |         .source_imgref
#  1694 | |         .as_ref()
#  1695 | |         .map(|s| s.as_str())
#       | |____________________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#option_as_ref_deref
#       = note: `#[warn(clippy::option_as_ref_deref)]` on by default
#  help: consider using as_deref
#       |
#  1691 ~     let source_image = opts
#  1692 +         .source_opts
#  1693 +         .source_imgref.as_deref()
#       |

Error: CLIPPY_WARNING: [#def25]
crates/lib/src/install.rs:1945:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#       |
#  1945 |       let source_image = opts
#       |  ________________________^
#  1946 | |         .source_opts
#  1947 | |         .source_imgref
#  1948 | |         .as_ref()
#  1949 | |         .map(|s| s.as_str())
#       | |____________________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#option_as_ref_deref
#  help: consider using as_deref
#       |
#  1945 ~     let source_image = opts
#  1946 +         .source_opts
#  1947 +         .source_imgref.as_deref()
#       |

Error: CLIPPY_WARNING: [#def26]
crates/lib/src/install.rs:2206:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#       |
#  2206 |       let source_image = opts
#       |  ________________________^
#  2207 | |         .source_opts
#  2208 | |         .source_imgref
#  2209 | |         .as_ref()
#  2210 | |         .map(|s| s.as_str())
#       | |____________________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#option_as_ref_deref
#  help: consider using as_deref
#       |
#  2206 ~     let source_image = opts
#  2207 +         .source_opts
#  2208 +         .source_imgref.as_deref()
#       |

Error: CLIPPY_WARNING: [#def27]
crates/lib/src/lints.rs:763:43: warning: useless conversion to the same type: `cap_std_ext::cap_std::fs::ReadDir`
#      |
#  763 |       let entries: Result<BTreeSet<_>, _> = d
#      |  ___________________________________________^
#  764 | |         .entries()?
#  765 | |         .into_iter()
#      | |____________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
#      = note: `#[warn(clippy::useless_conversion)]` on by default
#  help: consider removing `.into_iter()`
#      |
#  763 ~     let entries: Result<BTreeSet<_>, _> = d
#  764 +         .entries()?
#      |

Error: CLIPPY_WARNING: [#def28]
crates/lib/src/parsers/bls_config.rs:20:5: warning: name `EFI` contains a capitalized acronym
#     |
#  20 |     EFI {
#     |     ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Efi`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#upper_case_acronyms
#     = note: `#[warn(clippy::upper_case_acronyms)]` on by default

Error: CLIPPY_WARNING: [#def29]
crates/lib/src/parsers/bls_config.rs:176:46: warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
#      |
#  176 |               BLSConfigType::EFI { efi } => Ok(efi
#      |  ______________________________________________^
#  177 | |                 .components()
#  178 | |                 .last()
#      | |__________________-----^
#      |                    |
#      |                    help: try: `next_back()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#double_ended_iterator_last

Error: CLIPPY_WARNING: [#def30]
crates/lib/src/parsers/grub_menuconfig.rs:109:12: warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
#      |
#  109 |           Ok(to_path
#      |  ____________^
#  110 | |             .components()
#  111 | |             .last()
#      | |______________-----^
#      |                |
#      |                help: try: `next_back()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#double_ended_iterator_last

Error: CLIPPY_WARNING: [#def31]
crates/lib/src/parsers/grub_menuconfig.rs:134:22: warning: redundant guard
#      |
#  134 |                 c if c == '\\' => {
#      |                      ^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#redundant_guards
#      = note: `#[warn(clippy::redundant_guards)]` on by default
#  help: try
#      |
#  134 -                 c if c == '\\' => {
#  134 +                 '\\' => {
#      |

Error: CLIPPY_WARNING: [#def32]
crates/lib/src/podstorage.rs:132:35: warning: the following explicit lifetimes could be elided: 'c
#      |
#  132 | pub fn set_additional_image_store<'c>(
#      |                                   ^^
#  133 |     cmd: &'c mut Command,
#      |           ^^
#  134 |     ais: impl AsRef<Utf8Path>,
#  135 | ) -> &'c mut Command {
#      |       ^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_lifetimes
#      = note: `#[warn(clippy::needless_lifetimes)]` on by default
#  help: elide the lifetimes
#      |
#  132 ~ pub fn set_additional_image_store(
#  133 ~     cmd: &mut Command,
#  134 |     ais: impl AsRef<Utf8Path>,
#  135 ~ ) -> &mut Command {
#      |

Error: CLIPPY_WARNING: [#def33]
crates/lib/src/utils.rs:247:13: warning: unneeded `return` statement
#      |
#  247 |             return Ok(loader);
#      |             ^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_return
#  help: remove `return`
#      |
#  247 -             return Ok(loader);
#  247 +             Ok(loader)
#      |

Error: CLIPPY_WARNING: [#def34]
crates/lib/src/utils.rs:251:13: warning: unneeded `return` statement
#      |
#  251 |             return Err(EfiError::MissingVar);
#      |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_return
#  help: remove `return`
#      |
#  251 -             return Err(EfiError::MissingVar);
#  251 +             Err(EfiError::MissingVar)
#      |

Error: CLIPPY_WARNING: [#def35]
crates/lib/src/utils.rs:271:14: warning: this `repeat().take()` can be written more concisely
#      |
#  271 |     let up = std::iter::repeat(Component::ParentDir).take(from.len() - common);
#      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(Component::ParentDir, from.len() - common)`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#manual_repeat_n
#      = note: `#[warn(clippy::manual_repeat_n)]` on by default

Error: CLIPPY_WARNING: [#def36]
crates/lib/src/utils.rs:277:5: warning: unneeded `return` statement
#      |
#  277 |     return Ok(final_path);
#      |     ^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_return
#  help: remove `return`
#      |
#  277 -     return Ok(final_path);
#  277 +     Ok(final_path)
#      |

Error: CLIPPY_WARNING: [#def37]
crates/ostree-ext/src/container/store.rs:945:5: warning: this function has too many arguments (10/7)
#      |
#  945 | /     fn write_merge_commit_impl(
#  946 | |         repo: &ostree::Repo,
#  947 | |         base_commit: Option<&str>,
#  948 | |         layer_commits: &[String],
#  ...   |
#  955 | |         cancellable: Option<&gio::Cancellable>,
#  956 | |     ) -> Result<Box<LayeredImageState>> {
#      | |_______________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Error: CLIPPY_WARNING: [#def38]
crates/ostree-ext/src/container/store.rs:1044:22: warning: derefed type is same as origin
#       |
#  1044 |         let parent = base_commit.as_deref();
#       |                      ^^^^^^^^^^^^^^^^^^^^^^ help: try: `base_commit`
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_option_as_deref
#       = note: `#[warn(clippy::needless_option_as_deref)]` on by default

Error: CLIPPY_WARNING: [#def39]
crates/ostree-ext/src/container/store.rs:1580:36: warning: using `clone` on type `Option<&History>` which implements the `Copy` trait
#       |
#  1580 |           let previous_description = history_entry
#       |  ____________________________________^
#  1581 | |             .clone()
#       | |____________________^ help: try removing the `clone` call: `history_entry`
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#clone_on_copy
#       = note: `#[warn(clippy::clone_on_copy)]` on by default

Error: CLIPPY_WARNING: [#def40]
crates/ostree-ext/src/ostree_prepareroot.rs:105:1: warning: this `impl` can be derived
#      |
#  105 | / impl Default for Tristate {
#  106 | |     fn default() -> Self {
#  107 | |         Self::Disabled
#  108 | |     }
#  109 | | }
#      | |_^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#derivable_impls
#      = note: `#[warn(clippy::derivable_impls)]` on by default
#  help: replace the manual implementation with a derive attribute and mark the default variant
#      |
#   81 + #[derive(Default)]
#   82 ~ pub enum Tristate {
#   83 |     /// Enabled
#   84 |     Enabled,
#   85 |     /// Disabled
#   86 ~     #[default]
#   87 ~     Disabled,
#      |

Error: CLIPPY_WARNING: [#def41]
crates/ostree-ext/src/sysroot.rs:107:5: warning: this `let...else` may be rewritten with the `?` operator
#      |
#  107 | /     let Some(statename) = name.strip_prefix(AUTO_STATEROOT_PREFIX) else {
#  108 | |         return None;
#  109 | |     };
#      | |______^ help: replace it with: `let statename = name.strip_prefix(AUTO_STATEROOT_PREFIX)?;`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#question_mark
#      = note: `#[warn(clippy::question_mark)]` on by default

Error: CLIPPY_WARNING: [#def42]
crates/ostree-ext/src/sysroot.rs:110:5: warning: this `let...else` may be rewritten with the `?` operator
#      |
#  110 | /     let Some((year, serial)) = statename.split_once("-") else {
#  111 | |         return None;
#  112 | |     };
#      | |______^ help: replace it with: `let (year, serial) = statename.split_once("-")?;`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#question_mark

Error: CLIPPY_WARNING: [#def43]
crates/tests-integration/src/composefs_bcvk.rs:2:1: warning: this import is redundant
#    |
#  2 | use bootc_kernel_cmdline;
#    | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely
#    |
#    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#single_component_path_imports
#    = note: `#[warn(clippy::single_component_path_imports)]` on by default

Error: CLIPPY_WARNING: [#def44]
crates/tests-integration/src/composefs_bcvk.rs:101:35: warning: useless conversion to the same type: `std::vec::Vec<libtest_mimic::Trial>`
#      |
#  101 |     libtest_mimic::run(&testargs, tests.into()).exit()
#      |                                   ^^^^^^^^^^^^ help: consider removing `.into()`: `tests`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
#      = note: `#[warn(clippy::useless_conversion)]` on by default

Error: CLIPPY_WARNING: [#def45]
crates/tests-integration/src/container.rs:56:5: warning: matching on `Some` with `ok()` is redundant
#     |
#  56 |     if let Some(variant) = std::env::var("BOOTC_variant").ok() {
#     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#match_result_ok
#     = note: `#[warn(clippy::match_result_ok)]` on by default
#  help: consider matching on `Ok(variant)` and removing the call to `ok` instead
#     |
#  56 -     if let Some(variant) = std::env::var("BOOTC_variant").ok() {
#  56 +     if let Ok(variant) = std::env::var("BOOTC_variant") {
#     |

Error: CLIPPY_WARNING: [#def46]
crates/tests-integration/src/container.rs:69:5: warning: matching on `Some` with `ok()` is redundant
#     |
#  69 |     if let Some(base) = std::env::var("BOOTC_base").ok() {
#     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#match_result_ok
#  help: consider matching on `Ok(base)` and removing the call to `ok` instead
#     |
#  69 -     if let Some(base) = std::env::var("BOOTC_base").ok() {
#  69 +     if let Ok(base) = std::env::var("BOOTC_base") {
#     |

Error: CLIPPY_WARNING: [#def47]
crates/xtask/src/man.rs:309:13: warning: returning the result of a `let` binding from a block
#      |
#  308 |             let path = find_command_path_for_filename(cli_structure, cmd_part);
#      |             ------------------------------------------------------------------- unnecessary `let` binding
#  309 |             path
#      |             ^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#let_and_return
#      = note: `#[warn(clippy::let_and_return)]` on by default
#  help: return the expression directly
#      |
#  308 ~             
#  309 ~             find_command_path_for_filename(cli_structure, cmd_part)
#      |

Error: CLIPPY_WARNING: [#def48]
crates/xtask/src/man.rs:606:5: warning: empty string literal in `println!`
#      |
#  606 |     println!("");
#      |     ^^^^^^^^^--^
#      |              |
#      |              help: remove the empty string
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#println_empty_string
#      = note: `#[warn(clippy::println_empty_string)]` on by default

Error: CLIPPY_WARNING: [#def49]
crates/xtask/src/man.rs:622:12: warning: this `map_or` can be simplified
#      |
#  622 |           if path
#      |  ____________^
#  623 | |             .extension()
#  624 | |             .and_then(|s| s.to_str())
#  625 | |             .map_or(false, |e| e.chars().all(|c| c.is_numeric()))
#      | |_________________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_map_or
#      = note: `#[warn(clippy::unnecessary_map_or)]` on by default
#  help: use is_some_and instead
#      |
#  625 -             .map_or(false, |e| e.chars().all(|c| c.is_numeric()))
#  625 +             .is_some_and(|e| e.chars().all(|c| c.is_numeric()))
#      |

Scan Properties