Task #77148 - bootc-202510222002.g4e04eb95da-1/scan-results.err
back to task #77148download
Error: COMPILER_WARNING (CWE-704):
bootc-202510222002.g4e04eb95da/vendor/libz-sys/src/smoke.c: scope_hint: In function 'main'
bootc-202510222002.g4e04eb95da/vendor/libz-sys/src/smoke.c:4:10: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
# 2|
# 3| int main() {
# 4|-> return (int) adler32;
# 5| }
Error: CLIPPY_WARNING:
crates/etc-merge/src/lib.rs:78:5: warning: unneeded `return` statement
# |
# 78 | return true;
# | ^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# = note: `#[warn(clippy::needless_return)]` on by default
# help: remove `return`
# |
# 78 - return true;
# 78 + true
# |
Error: CLIPPY_WARNING:
crates/etc-merge/src/lib.rs:295:5: warning: doc list item without indentation
# |
# 295 | /// Usually this will be obtained by remounting the EROFS image to a temporary location
# | ^
# |
# = help: if this is supposed to be its own paragraph, add a blank line
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
# = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
# help: indent this line
# |
# 295 | /// Usually this will be obtained by remounting the EROFS image to a temporary location
# | ++
Error: CLIPPY_WARNING:
crates/etc-merge/src/lib.rs:300:5: warning: doc list item without indentation
# |
# 300 | /// again be usually obtained by mounting the new EROFS image to a temporary location. If merging
# | ^
# |
# = help: if this is supposed to be its own paragraph, add a blank line
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
# help: indent this line
# |
# 300 | /// again be usually obtained by mounting the new EROFS image to a temporary location. If merging
# | ++
Error: CLIPPY_WARNING:
crates/etc-merge/src/lib.rs:301:5: warning: doc list item without indentation
# |
# 301 | /// it will be necessary to make the `/etc` for the deployment writeable
# | ^
# |
# = help: if this is supposed to be its own paragraph, add a blank line
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
# help: indent this line
# |
# 301 | /// it will be necessary to make the `/etc` for the deployment writeable
# | ++
Error: CLIPPY_WARNING:
crates/etc-merge/src/lib.rs:314:6: warning: very complex type used. Consider factoring parts into `type` definitions
# |
# 314 | ) -> anyhow::Result<(
# | ______^
# 315 | | Directory<CustomMetadata>,
# 316 | | Directory<CustomMetadata>,
# 317 | | Option<Directory<CustomMetadata>>,
# 318 | | )> {
# | |__^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
# = note: `#[warn(clippy::type_complexity)]` on by default
Error: CLIPPY_WARNING:
crates/etc-merge/src/lib.rs:338:5: warning: unneeded `return` statement
# |
# 338 | return Ok((pristine_etc_files, current_etc_files, new_etc_files));
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# help: remove `return`
# |
# 338 - return Ok((pristine_etc_files, current_etc_files, new_etc_files));
# 338 + Ok((pristine_etc_files, current_etc_files, new_etc_files))
# |
Error: CLIPPY_WARNING:
crates/etc-merge/src/lib.rs:441:35: warning: useless use of `format!`
# |
# 441 | let entry = entry.context(format!("Getting entry"))?;
# | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Getting entry".to_string()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
# = note: `#[warn(clippy::useless_format)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/boot.rs:175:5: warning: unneeded `return` statement
# |
# 175 | return Ok(parent);
# | ^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# = note: `#[warn(clippy::needless_return)]` on by default
# help: remove `return`
# |
# 175 - return Ok(parent);
# 175 + Ok(parent)
# |
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/boot.rs:376:39: warning: useless conversion to the same type: `std::string::String`
# |
# 376 | let mut cmdline_options = String::from(root_setup.kargs.join(" "));
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `root_setup.kargs.join(" ")`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
# = note: `#[warn(clippy::useless_conversion)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/boot.rs:564:1: warning: this function has too many arguments (8/7)
# |
# 564 | / fn write_pe_to_esp(
# 565 | | repo: &crate::store::ComposefsRepository,
# 566 | | file: &RegularFile<Sha512HashValue>,
# 567 | | file_path: &Utf8Path,
# ... |
# 572 | | bootloader: &Bootloader,
# 573 | | ) -> Result<Option<String>> {
# | |___________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
# = note: `#[warn(clippy::too_many_arguments)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/boot.rs:646:29: warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
# |
# 646 | PEType::UkiAddon => file_path
# | _____________________________^
# 647 | | .components()
# 648 | | .last()
# | |______________-----^
# | |
# | help: try: `next_back()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
# = note: `#[warn(clippy::double_ended_iterator_last)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/boot.rs:836:20: warning: length comparison to zero
# |
# 836 | if v.len() > 0 {
# | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
# = note: `#[warn(clippy::len_zero)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/boot.rs:885:38: warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
# |
# 885 | let addon_name = entry
# | ______________________________________^
# 886 | | .file_path
# 887 | | .components()
# 888 | | .last()
# | |__________________________-----^
# | |
# | help: try: `next_back()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/boot.rs:974:23: warning: using `.iter().next()` on an array
# |
# 974 | let Some(entry) = entries.iter().next() else {
# | ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice
# = note: `#[warn(clippy::iter_next_slice)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/repo.rs:74:16: warning: writing `&String` instead of `&str` involves a new object where a slice will do
# |
# 74 | transport: &String,
# | ^^^^^^^ help: change this to: `&str`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
# = note: `#[warn(clippy::ptr_arg)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/repo.rs:75:12: warning: writing `&String` instead of `&str` involves a new object where a slice will do
# |
# 75 | image: &String,
# | ^^^^^^^ help: change this to: `&str`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/rollback.rs:37:18: warning: useless use of `format!`
# |
# 37 | .context(format!("Reopening entries dir as owned fd"))?;
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Reopening entries dir as owned fd".to_string()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
# = note: `#[warn(clippy::useless_format)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/rollback.rs:39:32: warning: useless use of `format!`
# |
# 39 | fsync(entries_dir).context(format!("fsync entries dir"))?;
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"fsync entries dir".to_string()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/rollback.rs:63:26: warning: useless use of `format!`
# |
# 63 | .with_context(|| format!("Reopening /sysroot/boot/loader as owned fd"))?;
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Reopening /sysroot/boot/loader as owned fd".to_string()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/status.rs:144:19: warning: slow zero-filling initialization
# |
# 144 | let mut buf = Vec::with_capacity(manifest.config().size() as usize);
# | ___________________^
# 145 | | buf.resize(manifest.config().size() as usize, 0);
# | |____________________________________________________^ help: consider replacing this with: `vec![0; manifest.config().size() as usize]`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization
# = note: `#[warn(clippy::slow_vector_initialization)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/switch.rs:45:23: warning: using `.iter().next()` on an array
# |
# 45 | let Some(entry) = entries.iter().next() else {
# | ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/update.rs:33:23: warning: using `.iter().next()` on an array
# |
# 33 | let Some(entry) = entries.iter().next() else {
# | ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice
Error: CLIPPY_WARNING:
crates/lib/src/cli.rs:1007:5: warning: unneeded `return` statement
# |
# 1007 | return Ok(target);
# | ^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# help: remove `return`
# |
# 1007 - return Ok(target);
# 1007 + Ok(target)
# |
Error: CLIPPY_WARNING:
crates/lib/src/install.rs:570:16: warning: inequality checks against false are unnecessary
# |
# 570 | if self.composefs_opts.insecure != false {
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.composefs_opts.insecure`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
# = note: `#[warn(clippy::bool_comparison)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/install.rs:1385:16: warning: this `else { if .. }` block can be collapsed
# |
# 1385 | } else {
# | ________________^
# 1386 | | if crate::bootloader::supports_bootupd(None)? {
# 1387 | | crate::spec::Bootloader::Grub
# 1388 | | } else {
# ... |
# 1391 | | }
# | |_________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
# = note: `#[warn(clippy::collapsible_else_if)]` on by default
# help: collapse nested if block
# |
# 1385 ~ } else if crate::bootloader::supports_bootupd(None)? {
# 1386 + crate::spec::Bootloader::Grub
# 1387 + } else {
# 1388 + crate::spec::Bootloader::Systemd
# 1389 + }
# |
Error: CLIPPY_WARNING:
crates/lib/src/install.rs:1623:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
# |
# 1623 | let source_image = opts
# | ________________________^
# 1624 | | .source_opts
# 1625 | | .source_imgref
# 1626 | | .as_ref()
# 1627 | | .map(|s| s.as_str())
# | |____________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
# = note: `#[warn(clippy::option_as_ref_deref)]` on by default
# help: consider using as_deref
# |
# 1623 ~ let source_image = opts
# 1624 + .source_opts
# 1625 + .source_imgref.as_deref()
# |
Error: CLIPPY_WARNING:
crates/lib/src/install.rs:1878:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
# |
# 1878 | let source_image = opts
# | ________________________^
# 1879 | | .source_opts
# 1880 | | .source_imgref
# 1881 | | .as_ref()
# 1882 | | .map(|s| s.as_str())
# | |____________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
# help: consider using as_deref
# |
# 1878 ~ let source_image = opts
# 1879 + .source_opts
# 1880 + .source_imgref.as_deref()
# |
Error: CLIPPY_WARNING:
crates/lib/src/install.rs:2138:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
# |
# 2138 | let source_image = opts
# | ________________________^
# 2139 | | .source_opts
# 2140 | | .source_imgref
# 2141 | | .as_ref()
# 2142 | | .map(|s| s.as_str())
# | |____________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
# help: consider using as_deref
# |
# 2138 ~ let source_image = opts
# 2139 + .source_opts
# 2140 + .source_imgref.as_deref()
# |
Error: CLIPPY_WARNING:
crates/lib/src/lints.rs:764:43: warning: useless conversion to the same type: `cap_std_ext::cap_std::fs::ReadDir`
# |
# 764 | let entries: Result<BTreeSet<_>, _> = d
# | ___________________________________________^
# 765 | | .entries()?
# 766 | | .into_iter()
# | |____________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
# help: consider removing `.into_iter()`
# |
# 764 ~ let entries: Result<BTreeSet<_>, _> = d
# 765 + .entries()?
# |
Error: CLIPPY_WARNING:
crates/lib/src/parsers/bls_config.rs:16:5: warning: name `EFI` contains a capitalized acronym
# |
# 16 | EFI {
# | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Efi`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
# = note: `#[warn(clippy::upper_case_acronyms)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/parsers/grub_menuconfig.rs:118:22: warning: redundant guard
# |
# 118 | c if c == '\\' => {
# | ^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards
# = note: `#[warn(clippy::redundant_guards)]` on by default
# help: try
# |
# 118 - c if c == '\\' => {
# 118 + '\\' => {
# |
Error: CLIPPY_WARNING:
crates/lib/src/podstorage.rs:132:35: warning: the following explicit lifetimes could be elided: 'c
# |
# 132 | pub fn set_additional_image_store<'c>(
# | ^^
# 133 | cmd: &'c mut Command,
# | ^^
# 134 | ais: impl AsRef<Utf8Path>,
# 135 | ) -> &'c mut Command {
# | ^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
# = note: `#[warn(clippy::needless_lifetimes)]` on by default
# help: elide the lifetimes
# |
# 132 ~ pub fn set_additional_image_store(
# 133 ~ cmd: &mut Command,
# 134 | ais: impl AsRef<Utf8Path>,
# 135 ~ ) -> &mut Command {
# |
Error: CLIPPY_WARNING:
crates/lib/src/utils.rs:251:13: warning: unneeded `return` statement
# |
# 251 | return Ok(loader);
# | ^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# help: remove `return`
# |
# 251 - return Ok(loader);
# 251 + Ok(loader)
# |
Error: CLIPPY_WARNING:
crates/lib/src/utils.rs:255:13: warning: unneeded `return` statement
# |
# 255 | return Err(EfiError::MissingVar);
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# help: remove `return`
# |
# 255 - return Err(EfiError::MissingVar);
# 255 + Err(EfiError::MissingVar)
# |
Error: CLIPPY_WARNING:
crates/lib/src/utils.rs:276:14: warning: this `repeat().take()` can be written more concisely
# |
# 276 | let up = std::iter::repeat(Component::ParentDir).take(from.len() - common);
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(Component::ParentDir, from.len() - common)`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n
# = note: `#[warn(clippy::manual_repeat_n)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/utils.rs:282:5: warning: unneeded `return` statement
# |
# 282 | return Ok(final_path);
# | ^^^^^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# help: remove `return`
# |
# 282 - return Ok(final_path);
# 282 + Ok(final_path)
# |
Error: CLIPPY_WARNING:
crates/ostree-ext/src/container/store.rs:945:5: warning: this function has too many arguments (10/7)
# |
# 945 | / fn write_merge_commit_impl(
# 946 | | repo: &ostree::Repo,
# 947 | | base_commit: Option<&str>,
# 948 | | layer_commits: &[String],
# ... |
# 955 | | cancellable: Option<&gio::Cancellable>,
# 956 | | ) -> Result<Box<LayeredImageState>> {
# | |_______________________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
# = note: `#[warn(clippy::too_many_arguments)]` on by default
Error: CLIPPY_WARNING:
crates/ostree-ext/src/container/store.rs:1044:22: warning: derefed type is same as origin
# |
# 1044 | let parent = base_commit.as_deref();
# | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `base_commit`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref
# = note: `#[warn(clippy::needless_option_as_deref)]` on by default
Error: CLIPPY_WARNING:
crates/ostree-ext/src/container/store.rs:1580:36: warning: using `clone` on type `Option<&History>` which implements the `Copy` trait
# |
# 1580 | let previous_description = history_entry
# | ____________________________________^
# 1581 | | .clone()
# | |____________________^ help: try removing the `clone` call: `history_entry`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
# = note: `#[warn(clippy::clone_on_copy)]` on by default
Error: CLIPPY_WARNING:
crates/tests-integration/src/composefs_bcvk.rs:78:35: warning: useless conversion to the same type: `std::vec::Vec<libtest_mimic::Trial>`
# |
# 78 | libtest_mimic::run(&testargs, tests.into()).exit()
# | ^^^^^^^^^^^^ help: consider removing `.into()`: `tests`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
# = note: `#[warn(clippy::useless_conversion)]` on by default
Error: CLIPPY_WARNING:
crates/xtask/src/man.rs:309:13: warning: returning the result of a `let` binding from a block
# |
# 308 | let path = find_command_path_for_filename(cli_structure, cmd_part);
# | ------------------------------------------------------------------- unnecessary `let` binding
# 309 | path
# | ^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
# = note: `#[warn(clippy::let_and_return)]` on by default
# help: return the expression directly
# |
# 308 ~
# 309 ~ find_command_path_for_filename(cli_structure, cmd_part)
# |
Error: CLIPPY_WARNING:
crates/xtask/src/man.rs:606:5: warning: empty string literal in `println!`
# |
# 606 | println!("");
# | ^^^^^^^^^--^
# | |
# | help: remove the empty string
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
# = note: `#[warn(clippy::println_empty_string)]` on by default
Error: CLIPPY_WARNING:
crates/xtask/src/man.rs:622:12: warning: this `map_or` can be simplified
# |
# 622 | if path
# | ____________^
# 623 | | .extension()
# 624 | | .and_then(|s| s.to_str())
# 625 | | .map_or(false, |e| e.chars().all(|c| c.is_numeric()))
# | |_________________________________________________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
# = note: `#[warn(clippy::unnecessary_map_or)]` on by default
# help: use is_some_and instead
# |
# 625 - .map_or(false, |e| e.chars().all(|c| c.is_numeric()))
# 625 + .is_some_and(|e| e.chars().all(|c| c.is_numeric()))
# |
Error: CLIPPY_WARNING:
crates/xtask/src/xtask.rs:78:9: warning: unneeded `return` statement
# |
# 78 | return f(&sh);
# | ^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# = note: `#[warn(clippy::needless_return)]` on by default
# help: remove `return`
# |
# 78 - return f(&sh);
# 78 + f(&sh)
# |