Error: COMPILER_WARNING (CWE-704): [#def1] bootc-202510081816.ga58d0a3e82/vendor/libz-sys/src/smoke.c: scope_hint: In function 'main' bootc-202510081816.ga58d0a3e82/vendor/libz-sys/src/smoke.c:4:10: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size # 4 | return (int) adler32; # | ^ # 2| # 3| int main() { # 4|-> return (int) adler32; # 5| } Error: CLIPPY_WARNING: [#def2] crates/etc-merge/src/lib.rs:78:5: warning: unneeded `return` statement # | # 78 | return true; # | ^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # = note: `#[warn(clippy::needless_return)]` on by default # help: remove `return` # | # 78 - return true; # 78 + true # | Error: CLIPPY_WARNING: [#def3] crates/etc-merge/src/lib.rs:295:5: warning: doc list item without indentation # | # 295 | /// Usually this will be obtained by remounting the EROFS image to a temporary location # | ^ # | # = help: if this is supposed to be its own paragraph, add a blank line # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation # = note: `#[warn(clippy::doc_lazy_continuation)]` on by default # help: indent this line # | # 295 | /// Usually this will be obtained by remounting the EROFS image to a temporary location # | ++ Error: CLIPPY_WARNING: [#def4] crates/etc-merge/src/lib.rs:300:5: warning: doc list item without indentation # | # 300 | /// again be usually obtained by mounting the new EROFS image to a temporary location. If merging # | ^ # | # = help: if this is supposed to be its own paragraph, add a blank line # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation # help: indent this line # | # 300 | /// again be usually obtained by mounting the new EROFS image to a temporary location. If merging # | ++ Error: CLIPPY_WARNING: [#def5] crates/etc-merge/src/lib.rs:301:5: warning: doc list item without indentation # | # 301 | /// it will be necessary to make the `/etc` for the deployment writeable # | ^ # | # = help: if this is supposed to be its own paragraph, add a blank line # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation # help: indent this line # | # 301 | /// it will be necessary to make the `/etc` for the deployment writeable # | ++ Error: CLIPPY_WARNING: [#def6] crates/etc-merge/src/lib.rs:314:6: warning: very complex type used. Consider factoring parts into `type` definitions # | # 314 | ) -> anyhow::Result<( # | ______^ # 315 | | Directory<CustomMetadata>, # 316 | | Directory<CustomMetadata>, # 317 | | Option<Directory<CustomMetadata>>, # 318 | | )> { # | |__^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity # = note: `#[warn(clippy::type_complexity)]` on by default Error: CLIPPY_WARNING: [#def7] crates/etc-merge/src/lib.rs:338:5: warning: unneeded `return` statement # | # 338 | return Ok((pristine_etc_files, current_etc_files, new_etc_files)); # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # help: remove `return` # | # 338 - return Ok((pristine_etc_files, current_etc_files, new_etc_files)); # 338 + Ok((pristine_etc_files, current_etc_files, new_etc_files)) # | Error: CLIPPY_WARNING: [#def8] crates/etc-merge/src/lib.rs:441:35: warning: useless use of `format!` # | # 441 | let entry = entry.context(format!("Getting entry"))?; # | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Getting entry".to_string()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format # = note: `#[warn(clippy::useless_format)]` on by default Error: CLIPPY_WARNING: [#def9] crates/lib/src/bootc_composefs/boot.rs:170:5: warning: unneeded `return` statement # | # 170 | return Ok(parent); # | ^^^^^^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # = note: `#[warn(clippy::needless_return)]` on by default # help: remove `return` # | # 170 - return Ok(parent); # 170 + Ok(parent) # | Error: CLIPPY_WARNING: [#def10] crates/lib/src/bootc_composefs/boot.rs:371:39: warning: useless conversion to the same type: `std::string::String` # | # 371 | let mut cmdline_options = String::from(root_setup.kargs.join(" ")); # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `root_setup.kargs.join(" ")` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion # = note: `#[warn(clippy::useless_conversion)]` on by default Error: CLIPPY_WARNING: [#def11] crates/lib/src/bootc_composefs/boot.rs:571:1: warning: this function has too many arguments (8/7) # | # 571 | / fn write_pe_to_esp( # 572 | | repo: &crate::store::ComposefsRepository, # 573 | | file: &RegularFile<Sha512HashValue>, # 574 | | file_path: &Utf8Path, # ... | # 579 | | bootloader: &Bootloader, # 580 | | ) -> Result<Option<String>> { # | |___________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments # = note: `#[warn(clippy::too_many_arguments)]` on by default Error: CLIPPY_WARNING: [#def12] crates/lib/src/bootc_composefs/boot.rs:653:29: warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator # | # 653 | PEType::UkiAddon => file_path # | _____________________________^ # 654 | | .components() # 655 | | .last() # | |______________-----^ # | | # | help: try: `next_back()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last # = note: `#[warn(clippy::double_ended_iterator_last)]` on by default Error: CLIPPY_WARNING: [#def13] crates/lib/src/bootc_composefs/boot.rs:843:20: warning: length comparison to zero # | # 843 | if v.len() > 0 { # | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero # = note: `#[warn(clippy::len_zero)]` on by default Error: CLIPPY_WARNING: [#def14] crates/lib/src/bootc_composefs/boot.rs:901:38: warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator # | # 901 | let addon_name = entry # | ______________________________________^ # 902 | | .file_path # 903 | | .components() # 904 | | .last() # | |__________________________-----^ # | | # | help: try: `next_back()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last Error: CLIPPY_WARNING: [#def15] crates/lib/src/bootc_composefs/boot.rs:983:23: warning: using `.iter().next()` on an array # | # 983 | let Some(entry) = entries.iter().next() else { # | ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice # = note: `#[warn(clippy::iter_next_slice)]` on by default Error: CLIPPY_WARNING: [#def16] crates/lib/src/bootc_composefs/repo.rs:74:16: warning: writing `&String` instead of `&str` involves a new object where a slice will do # | # 74 | transport: &String, # | ^^^^^^^ help: change this to: `&str` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg # = note: `#[warn(clippy::ptr_arg)]` on by default Error: CLIPPY_WARNING: [#def17] crates/lib/src/bootc_composefs/repo.rs:75:12: warning: writing `&String` instead of `&str` involves a new object where a slice will do # | # 75 | image: &String, # | ^^^^^^^ help: change this to: `&str` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg Error: CLIPPY_WARNING: [#def18] crates/lib/src/bootc_composefs/rollback.rs:37:18: warning: useless use of `format!` # | # 37 | .context(format!("Reopening entries dir as owned fd"))?; # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Reopening entries dir as owned fd".to_string()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format # = note: `#[warn(clippy::useless_format)]` on by default Error: CLIPPY_WARNING: [#def19] crates/lib/src/bootc_composefs/rollback.rs:39:32: warning: useless use of `format!` # | # 39 | fsync(entries_dir).context(format!("fsync entries dir"))?; # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"fsync entries dir".to_string()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format Error: CLIPPY_WARNING: [#def20] crates/lib/src/bootc_composefs/rollback.rs:63:26: warning: useless use of `format!` # | # 63 | .with_context(|| format!("Reopening /sysroot/boot/loader as owned fd"))?; # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Reopening /sysroot/boot/loader as owned fd".to_string()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format Error: CLIPPY_WARNING: [#def21] crates/lib/src/bootc_composefs/status.rs:145:19: warning: slow zero-filling initialization # | # 145 | let mut buf = Vec::with_capacity(manifest.config().size() as usize); # | ___________________^ # 146 | | buf.resize(manifest.config().size() as usize, 0); # | |____________________________________________________^ help: consider replacing this with: `vec![0; manifest.config().size() as usize]` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization # = note: `#[warn(clippy::slow_vector_initialization)]` on by default Error: CLIPPY_WARNING: [#def22] crates/lib/src/bootc_composefs/switch.rs:42:23: warning: using `.iter().next()` on an array # | # 42 | let Some(entry) = entries.iter().next() else { # | ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice Error: CLIPPY_WARNING: [#def23] crates/lib/src/bootc_composefs/update.rs:32:23: warning: using `.iter().next()` on an array # | # 32 | let Some(entry) = entries.iter().next() else { # | ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice Error: CLIPPY_WARNING: [#def24] crates/lib/src/cli.rs:1007:5: warning: unneeded `return` statement # | # 1007 | return Ok(target); # | ^^^^^^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # help: remove `return` # | # 1007 - return Ok(target); # 1007 + Ok(target) # | Error: CLIPPY_WARNING: [#def25] crates/lib/src/install.rs:579:16: warning: inequality checks against false are unnecessary # | # 579 | if self.composefs_opts.insecure != false { # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.composefs_opts.insecure` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison # = note: `#[warn(clippy::bool_comparison)]` on by default Error: CLIPPY_WARNING: [#def26] crates/lib/src/install.rs:1602:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value # | # 1602 | let source_image = opts # | ________________________^ # 1603 | | .source_opts # 1604 | | .source_imgref # 1605 | | .as_ref() # 1606 | | .map(|s| s.as_str()) # | |____________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref # = note: `#[warn(clippy::option_as_ref_deref)]` on by default # help: consider using as_deref # | # 1602 ~ let source_image = opts # 1603 + .source_opts # 1604 + .source_imgref.as_deref() # | Error: CLIPPY_WARNING: [#def27] crates/lib/src/install.rs:1866:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value # | # 1866 | let source_image = opts # | ________________________^ # 1867 | | .source_opts # 1868 | | .source_imgref # 1869 | | .as_ref() # 1870 | | .map(|s| s.as_str()) # | |____________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref # help: consider using as_deref # | # 1866 ~ let source_image = opts # 1867 + .source_opts # 1868 + .source_imgref.as_deref() # | Error: CLIPPY_WARNING: [#def28] crates/lib/src/install.rs:2118:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value # | # 2118 | let source_image = opts # | ________________________^ # 2119 | | .source_opts # 2120 | | .source_imgref # 2121 | | .as_ref() # 2122 | | .map(|s| s.as_str()) # | |____________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref # help: consider using as_deref # | # 2118 ~ let source_image = opts # 2119 + .source_opts # 2120 + .source_imgref.as_deref() # | Error: CLIPPY_WARNING: [#def29] crates/lib/src/lints.rs:764:43: warning: useless conversion to the same type: `cap_std_ext::cap_std::fs::ReadDir` # | # 764 | let entries: Result<BTreeSet<_>, _> = d # | ___________________________________________^ # 765 | | .entries()? # 766 | | .into_iter() # | |____________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion # help: consider removing `.into_iter()` # | # 764 ~ let entries: Result<BTreeSet<_>, _> = d # 765 + .entries()? # | Error: CLIPPY_WARNING: [#def30] crates/lib/src/parsers/bls_config.rs:16:5: warning: name `EFI` contains a capitalized acronym # | # 16 | EFI { # | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Efi` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms # = note: `#[warn(clippy::upper_case_acronyms)]` on by default Error: CLIPPY_WARNING: [#def31] crates/lib/src/parsers/grub_menuconfig.rs:118:22: warning: redundant guard # | # 118 | c if c == '\\' => { # | ^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards # = note: `#[warn(clippy::redundant_guards)]` on by default # help: try # | # 118 - c if c == '\\' => { # 118 + '\\' => { # | Error: CLIPPY_WARNING: [#def32] crates/lib/src/podstorage.rs:132:35: warning: the following explicit lifetimes could be elided: 'c # | # 132 | pub fn set_additional_image_store<'c>( # | ^^ # 133 | cmd: &'c mut Command, # | ^^ # 134 | ais: impl AsRef<Utf8Path>, # 135 | ) -> &'c mut Command { # | ^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes # = note: `#[warn(clippy::needless_lifetimes)]` on by default # help: elide the lifetimes # | # 132 ~ pub fn set_additional_image_store( # 133 ~ cmd: &mut Command, # 134 | ais: impl AsRef<Utf8Path>, # 135 ~ ) -> &mut Command { # | Error: CLIPPY_WARNING: [#def33] crates/lib/src/utils.rs:237:13: warning: unneeded `return` statement # | # 237 | return Ok(loader); # | ^^^^^^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # help: remove `return` # | # 237 - return Ok(loader); # 237 + Ok(loader) # | Error: CLIPPY_WARNING: [#def34] crates/lib/src/utils.rs:241:13: warning: unneeded `return` statement # | # 241 | return Err(EfiError::MissingVar); # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # help: remove `return` # | # 241 - return Err(EfiError::MissingVar); # 241 + Err(EfiError::MissingVar) # | Error: CLIPPY_WARNING: [#def35] crates/lib/src/utils.rs:262:14: warning: this `repeat().take()` can be written more concisely # | # 262 | let up = std::iter::repeat(Component::ParentDir).take(from.len() - common); # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(Component::ParentDir, from.len() - common)` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n # = note: `#[warn(clippy::manual_repeat_n)]` on by default Error: CLIPPY_WARNING: [#def36] crates/lib/src/utils.rs:268:5: warning: unneeded `return` statement # | # 268 | return Ok(final_path); # | ^^^^^^^^^^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # help: remove `return` # | # 268 - return Ok(final_path); # 268 + Ok(final_path) # | Error: CLIPPY_WARNING: [#def37] crates/ostree-ext/src/container/store.rs:945:5: warning: this function has too many arguments (10/7) # | # 945 | / fn write_merge_commit_impl( # 946 | | repo: &ostree::Repo, # 947 | | base_commit: Option<&str>, # 948 | | layer_commits: &[String], # ... | # 955 | | cancellable: Option<&gio::Cancellable>, # 956 | | ) -> Result<Box<LayeredImageState>> { # | |_______________________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments # = note: `#[warn(clippy::too_many_arguments)]` on by default Error: CLIPPY_WARNING: [#def38] crates/ostree-ext/src/container/store.rs:1044:22: warning: derefed type is same as origin # | # 1044 | let parent = base_commit.as_deref(); # | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `base_commit` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref # = note: `#[warn(clippy::needless_option_as_deref)]` on by default Error: CLIPPY_WARNING: [#def39] crates/ostree-ext/src/container/store.rs:1580:36: warning: using `clone` on type `Option<&History>` which implements the `Copy` trait # | # 1580 | let previous_description = history_entry # | ____________________________________^ # 1581 | | .clone() # | |____________________^ help: try removing the `clone` call: `history_entry` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy # = note: `#[warn(clippy::clone_on_copy)]` on by default Error: CLIPPY_WARNING: [#def40] crates/xtask/src/man.rs:309:13: warning: returning the result of a `let` binding from a block # | # 308 | let path = find_command_path_for_filename(cli_structure, cmd_part); # | ------------------------------------------------------------------- unnecessary `let` binding # 309 | path # | ^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return # = note: `#[warn(clippy::let_and_return)]` on by default # help: return the expression directly # | # 308 ~ # 309 ~ find_command_path_for_filename(cli_structure, cmd_part) # | Error: CLIPPY_WARNING: [#def41] crates/xtask/src/man.rs:606:5: warning: empty string literal in `println!` # | # 606 | println!(""); # | ^^^^^^^^^--^ # | | # | help: remove the empty string # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string # = note: `#[warn(clippy::println_empty_string)]` on by default Error: CLIPPY_WARNING: [#def42] crates/xtask/src/man.rs:622:12: warning: this `map_or` can be simplified # | # 622 | if path # | ____________^ # 623 | | .extension() # 624 | | .and_then(|s| s.to_str()) # 625 | | .map_or(false, |e| e.chars().all(|c| c.is_numeric())) # | |_________________________________________________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or # = note: `#[warn(clippy::unnecessary_map_or)]` on by default # help: use is_some_and instead # | # 625 - .map_or(false, |e| e.chars().all(|c| c.is_numeric())) # 625 + .is_some_and(|e| e.chars().all(|c| c.is_numeric())) # | Error: CLIPPY_WARNING: [#def43] crates/xtask/src/xtask.rs:78:9: warning: unneeded `return` statement # | # 78 | return f(&sh); # | ^^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # = note: `#[warn(clippy::needless_return)]` on by default # help: remove `return` # | # 78 - return f(&sh); # 78 + f(&sh) # |
| analyzer-version-clippy | 1.90.0 |
| analyzer-version-cppcheck | 2.18.3 |
| analyzer-version-gcc | 15.2.1 |
| analyzer-version-gcc-analyzer | 15.2.1 |
| analyzer-version-shellcheck | 0.11.0 |
| analyzer-version-unicontrol | 0.0.2 |
| enabled-plugins | clippy, cppcheck, gcc, shellcheck, unicontrol |
| exit-code | 0 |
| host | ip-172-16-1-85.us-west-2.compute.internal |
| known-false-positives | /usr/share/csmock/known-false-positives.js |
| known-false-positives-rpm | known-false-positives-0.0.0.20250521.132812.g8eff701.main-1.el9.noarch |
| mock-config | fedora-rawhide-x86_64 |
| project-name | bootc-202510081816.ga58d0a3e82-1 |
| store-results-to | /tmp/tmpuv6989mf/bootc-202510081816.ga58d0a3e82-1.tar.xz |
| time-created | 2025-10-08 19:10:47 |
| time-finished | 2025-10-08 19:24:30 |
| tool | csmock |
| tool-args | '/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,cppcheck,shellcheck,clippy,unicontrol' '-o' '/tmp/tmpuv6989mf/bootc-202510081816.ga58d0a3e82-1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmpuv6989mf/bootc-202510081816.ga58d0a3e82-1.src.rpm' |
| tool-version | csmock-3.8.2.20251001.130531.g1d8e3a4-1.el9 |