Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/lib/src/bootc_composefs/boot.rs:153:5: warning: unneeded `return` statement
#      |
#  153 |     return Ok(parent);
#      |     ^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#      = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#      |
#  153 -     return Ok(parent);
#  153 +     Ok(parent)
#      |

Error: CLIPPY_WARNING: [#def2]
crates/lib/src/bootc_composefs/boot.rs:354:39: warning: useless conversion to the same type: `std::string::String`
#      |
#  354 |             let mut cmdline_options = String::from(root_setup.kargs.join(" "));
#      |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `root_setup.kargs.join(" ")`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
#      = note: `#[warn(clippy::useless_conversion)]` on by default

Error: CLIPPY_WARNING: [#def3]
crates/lib/src/bootc_composefs/boot.rs:549:1: warning: this function has too many arguments (8/7)
#      |
#  549 | / fn write_pe_to_esp(
#  550 | |     repo: &ComposefsRepository<Sha256HashValue>,
#  551 | |     file: &RegularFile<Sha256HashValue>,
#  552 | |     file_path: &PathBuf,
#  ...   |
#  557 | |     bootloader: &Bootloader,
#  558 | | ) -> Result<Option<String>> {
#      | |___________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Error: CLIPPY_WARNING: [#def4]
crates/lib/src/bootc_composefs/boot.rs:552:16: warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
#      |
#  552 |     file_path: &PathBuf,
#      |                ^^^^^^^^ help: change this to: `&Path`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
#      = note: `#[warn(clippy::ptr_arg)]` on by default

Error: CLIPPY_WARNING: [#def5]
crates/lib/src/bootc_composefs/boot.rs:630:29: warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
#      |
#  630 |           PEType::UkiAddon => file_path
#      |  _____________________________^
#  631 | |             .components()
#  632 | |             .last()
#      | |______________-----^
#      |                |
#      |                help: try: `next_back()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
#      = note: `#[warn(clippy::double_ended_iterator_last)]` on by default

Error: CLIPPY_WARNING: [#def6]
crates/lib/src/bootc_composefs/boot.rs:821:20: warning: length comparison to zero
#      |
#  821 |                 if v.len() > 0 {
#      |                    ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
#      = note: `#[warn(clippy::len_zero)]` on by default

Error: CLIPPY_WARNING: [#def7]
crates/lib/src/bootc_composefs/boot.rs:879:38: warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
#      |
#  879 |                       let addon_name = entry
#      |  ______________________________________^
#  880 | |                         .file_path
#  881 | |                         .components()
#  882 | |                         .last()
#      | |__________________________-----^
#      |                            |
#      |                            help: try: `next_back()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last

Error: CLIPPY_WARNING: [#def8]
crates/lib/src/bootc_composefs/boot.rs:960:23: warning: using `.iter().next()` on an array
#      |
#  960 |     let Some(entry) = entries.iter().next() else {
#      |                       ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice
#      = note: `#[warn(clippy::iter_next_slice)]` on by default

Error: CLIPPY_WARNING: [#def9]
crates/lib/src/bootc_composefs/repo.rs:84:6: warning: very complex type used. Consider factoring parts into `type` definitions
#     |
#  84 |   ) -> Result<(
#     |  ______^
#  85 | |     ComposefsRepository<Sha256HashValue>,
#  86 | |     Vec<ComposefsBootEntry<Sha256HashValue>>,
#  87 | |     Sha256HashValue,
#  88 | |     FileSystem<Sha256HashValue>,
#  89 | | )> {
#     | |__^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
#     = note: `#[warn(clippy::type_complexity)]` on by default

Error: CLIPPY_WARNING: [#def10]
crates/lib/src/bootc_composefs/rollback.rs:37:18: warning: useless use of `format!`
#     |
#  37 |         .context(format!("Reopening entries dir as owned fd"))?;
#     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Reopening entries dir as owned fd".to_string()`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
#     = note: `#[warn(clippy::useless_format)]` on by default

Error: CLIPPY_WARNING: [#def11]
crates/lib/src/bootc_composefs/rollback.rs:39:32: warning: useless use of `format!`
#     |
#  39 |     fsync(entries_dir).context(format!("fsync entries dir"))?;
#     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"fsync entries dir".to_string()`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

Error: CLIPPY_WARNING: [#def12]
crates/lib/src/bootc_composefs/rollback.rs:63:26: warning: useless use of `format!`
#     |
#  63 |         .with_context(|| format!("Reopening /sysroot/boot/loader as owned fd"))?;
#     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Reopening /sysroot/boot/loader as owned fd".to_string()`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

Error: CLIPPY_WARNING: [#def13]
crates/lib/src/bootc_composefs/status.rs:145:19: warning: slow zero-filling initialization
#      |
#  145 |       let mut buf = Vec::with_capacity(manifest.config().size() as usize);
#      |  ___________________^
#  146 | |     buf.resize(manifest.config().size() as usize, 0);
#      | |____________________________________________________^ help: consider replacing this with: `vec![0; manifest.config().size() as usize]`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization
#      = note: `#[warn(clippy::slow_vector_initialization)]` on by default

Error: CLIPPY_WARNING: [#def14]
crates/lib/src/bootc_composefs/switch.rs:42:23: warning: using `.iter().next()` on an array
#     |
#  42 |     let Some(entry) = entries.iter().next() else {
#     |                       ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice

Error: CLIPPY_WARNING: [#def15]
crates/lib/src/bootc_composefs/update.rs:32:23: warning: using `.iter().next()` on an array
#     |
#  32 |     let Some(entry) = entries.iter().next() else {
#     |                       ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `entries.first()`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice

Error: CLIPPY_WARNING: [#def16]
crates/lib/src/cfsctl.rs:16:52: warning: unused import: `Sha512HashValue`
#     |
#  16 |     fsverity::{FsVerityHashValue, Sha256HashValue, Sha512HashValue},
#     |                                                    ^^^^^^^^^^^^^^^
#     |
#     = note: `#[warn(unused_imports)]` on by default

Error: CLIPPY_WARNING: [#def17]
crates/lib/src/install.rs:583:16: warning: inequality checks against false are unnecessary
#      |
#  583 |             if self.composefs_opts.insecure != false {
#      |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.composefs_opts.insecure`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
#      = note: `#[warn(clippy::bool_comparison)]` on by default

Error: CLIPPY_WARNING: [#def18]
crates/lib/src/parsers/bls_config.rs:15:5: warning: name `EFI` contains a capitalized acronym
#     |
#  15 |     EFI {
#     |     ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Efi`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
#     = note: `#[warn(clippy::upper_case_acronyms)]` on by default

Error: CLIPPY_WARNING: [#def19]
crates/lib/src/utils.rs:237:13: warning: unneeded `return` statement
#      |
#  237 |             return Ok(loader);
#      |             ^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#  help: remove `return`
#      |
#  237 -             return Ok(loader);
#  237 +             Ok(loader)
#      |

Error: CLIPPY_WARNING: [#def20]
crates/lib/src/utils.rs:241:13: warning: unneeded `return` statement
#      |
#  241 |             return Err(EfiError::MissingVar);
#      |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#  help: remove `return`
#      |
#  241 -             return Err(EfiError::MissingVar);
#  241 +             Err(EfiError::MissingVar)
#      |

Error: CLIPPY_WARNING: [#def21]
crates/lib/src/utils.rs:262:14: warning: this `repeat().take()` can be written more concisely
#      |
#  262 |     let up = std::iter::repeat(Component::ParentDir).take(from.len() - common);
#      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(Component::ParentDir, from.len() - common)`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n
#      = note: `#[warn(clippy::manual_repeat_n)]` on by default

Error: CLIPPY_WARNING: [#def22]
crates/lib/src/utils.rs:268:5: warning: unneeded `return` statement
#      |
#  268 |     return Ok(final_path);
#      |     ^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#  help: remove `return`
#      |
#  268 -     return Ok(final_path);
#  268 +     Ok(final_path)
#      |

Scan Properties