bootc-202509181305.g856a7fba7c-1

List of Findings

Error: COMPILER_WARNING (CWE-704): [#def1]
bootc-202509181305.g856a7fba7c/vendor/libz-sys/src/smoke.c: scope_hint: In function 'main'
bootc-202509181305.g856a7fba7c/vendor/libz-sys/src/smoke.c:4:10: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
#    2|   
#    3|   int main() {
#    4|->   return (int) adler32;
#    5|   }

Error: CLIPPY_WARNING: [#def2]
crates/etc-merge/src/lib.rs:78:5: warning: unneeded `return` statement
#     |
#  78 |     return true;
#     |     ^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#     = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#     |
#  78 -     return true;
#  78 +     true
#     |

Error: CLIPPY_WARNING: [#def3]
crates/etc-merge/src/lib.rs:295:5: warning: doc list item without indentation
#      |
#  295 | /// Usually this will be obtained by remounting the EROFS image to a temporary location
#      |     ^
#      |
#      = help: if this is supposed to be its own paragraph, add a blank line
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
#      = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
#  help: indent this line
#      |
#  295 | ///   Usually this will be obtained by remounting the EROFS image to a temporary location
#      |     ++

Error: CLIPPY_WARNING: [#def4]
crates/etc-merge/src/lib.rs:300:5: warning: doc list item without indentation
#      |
#  300 | /// again be usually obtained by mounting the new EROFS image to a temporary location. If merging
#      |     ^
#      |
#      = help: if this is supposed to be its own paragraph, add a blank line
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
#  help: indent this line
#      |
#  300 | ///   again be usually obtained by mounting the new EROFS image to a temporary location. If merging
#      |     ++

Error: CLIPPY_WARNING: [#def5]
crates/etc-merge/src/lib.rs:301:5: warning: doc list item without indentation
#      |
#  301 | /// it will be necessary to make the `/etc` for the deployment writeable
#      |     ^
#      |
#      = help: if this is supposed to be its own paragraph, add a blank line
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
#  help: indent this line
#      |
#  301 | ///   it will be necessary to make the `/etc` for the deployment writeable
#      |     ++

Error: CLIPPY_WARNING: [#def6]
crates/etc-merge/src/lib.rs:330:5: warning: unneeded `return` statement
#      |
#  330 |     return Ok((pristine_etc_files, current_etc_files, new_etc_files));
#      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#  help: remove `return`
#      |
#  330 -     return Ok((pristine_etc_files, current_etc_files, new_etc_files));
#  330 +     Ok((pristine_etc_files, current_etc_files, new_etc_files))
#      |

Error: CLIPPY_WARNING: [#def7]
crates/etc-merge/src/lib.rs:434:35: warning: useless use of `format!`
#      |
#  434 |         let entry = entry.context(format!("Getting entry"))?;
#      |                                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Getting entry".to_string()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
#      = note: `#[warn(clippy::useless_format)]` on by default

Error: CLIPPY_WARNING: [#def8]
crates/lib/src/cli.rs:988:5: warning: unneeded `return` statement
#      |
#  988 |     return Ok(target);
#      |     ^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#      = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#      |
#  988 -     return Ok(target);
#  988 +     Ok(target)
#      |

Error: CLIPPY_WARNING: [#def9]
crates/lib/src/install.rs:1553:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#       |
#  1553 |       let source_image = opts
#       |  ________________________^
#  1554 | |         .source_opts
#  1555 | |         .source_imgref
#  1556 | |         .as_ref()
#  1557 | |         .map(|s| s.as_str())
#       | |____________________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
#       = note: `#[warn(clippy::option_as_ref_deref)]` on by default
#  help: consider using as_deref
#       |
#  1553 ~     let source_image = opts
#  1554 +         .source_opts
#  1555 +         .source_imgref.as_deref()
#       |

Error: CLIPPY_WARNING: [#def10]
crates/lib/src/install.rs:1817:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#       |
#  1817 |       let source_image = opts
#       |  ________________________^
#  1818 | |         .source_opts
#  1819 | |         .source_imgref
#  1820 | |         .as_ref()
#  1821 | |         .map(|s| s.as_str())
#       | |____________________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
#  help: consider using as_deref
#       |
#  1817 ~     let source_image = opts
#  1818 +         .source_opts
#  1819 +         .source_imgref.as_deref()
#       |

Error: CLIPPY_WARNING: [#def11]
crates/lib/src/install.rs:2069:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#       |
#  2069 |       let source_image = opts
#       |  ________________________^
#  2070 | |         .source_opts
#  2071 | |         .source_imgref
#  2072 | |         .as_ref()
#  2073 | |         .map(|s| s.as_str())
#       | |____________________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
#  help: consider using as_deref
#       |
#  2069 ~     let source_image = opts
#  2070 +         .source_opts
#  2071 +         .source_imgref.as_deref()
#       |

Error: CLIPPY_WARNING: [#def12]
crates/lib/src/parsers/grub_menuconfig.rs:118:22: warning: redundant guard
#      |
#  118 |                 c if c == '\\' => {
#      |                      ^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards
#      = note: `#[warn(clippy::redundant_guards)]` on by default
#  help: try
#      |
#  118 -                 c if c == '\\' => {
#  118 +                 '\\' => {
#      |

Error: CLIPPY_WARNING: [#def13]
crates/ostree-ext/src/container/store.rs:945:5: warning: this function has too many arguments (10/7)
#      |
#  945 | /     fn write_merge_commit_impl(
#  946 | |         repo: &ostree::Repo,
#  947 | |         base_commit: Option<&str>,
#  948 | |         layer_commits: &[String],
#  ...   |
#  955 | |         cancellable: Option<&gio::Cancellable>,
#  956 | |     ) -> Result<Box<LayeredImageState>> {
#      | |_______________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Error: CLIPPY_WARNING: [#def14]
crates/ostree-ext/src/container/store.rs:1044:22: warning: derefed type is same as origin
#       |
#  1044 |         let parent = base_commit.as_deref();
#       |                      ^^^^^^^^^^^^^^^^^^^^^^ help: try: `base_commit`
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref
#       = note: `#[warn(clippy::needless_option_as_deref)]` on by default

Error: CLIPPY_WARNING: [#def15]
crates/ostree-ext/src/container/store.rs:1580:36: warning: using `clone` on type `Option<&History>` which implements the `Copy` trait
#       |
#  1580 |           let previous_description = history_entry
#       |  ____________________________________^
#  1581 | |             .clone()
#       | |____________________^ help: try removing the `clone` call: `history_entry`
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
#       = note: `#[warn(clippy::clone_on_copy)]` on by default

Error: CLIPPY_WARNING: [#def16]
crates/xtask/src/man.rs:295:13: warning: returning the result of a `let` binding from a block
#      |
#  294 |             let path = find_command_path_for_filename(cli_structure, cmd_part);
#      |             ------------------------------------------------------------------- unnecessary `let` binding
#  295 |             path
#      |             ^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
#      = note: `#[warn(clippy::let_and_return)]` on by default
#  help: return the expression directly
#      |
#  294 ~             
#  295 ~             find_command_path_for_filename(cli_structure, cmd_part)
#      |

Error: CLIPPY_WARNING: [#def17]
crates/xtask/src/man.rs:590:5: warning: empty string literal in `println!`
#      |
#  590 |     println!("");
#      |     ^^^^^^^^^--^
#      |              |
#      |              help: remove the empty string
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
#      = note: `#[warn(clippy::println_empty_string)]` on by default

Error: CLIPPY_WARNING: [#def18]
crates/xtask/src/man.rs:605:12: warning: this `map_or` can be simplified
#      |
#  605 |           if path
#      |  ____________^
#  606 | |             .extension()
#  607 | |             .and_then(|s| s.to_str())
#  608 | |             .map_or(false, |e| e.chars().all(|c| c.is_numeric()))
#      | |_________________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
#      = note: `#[warn(clippy::unnecessary_map_or)]` on by default
#  help: use is_some_and instead
#      |
#  608 -             .map_or(false, |e| e.chars().all(|c| c.is_numeric()))
#  608 +             .is_some_and(|e| e.chars().all(|c| c.is_numeric()))
#      |

Scan Properties