bootc-202509051822.g39b0a32752-1

List of Findings

Error: COMPILER_WARNING (CWE-704): [#def1]
bootc-202509051822.g39b0a32752/vendor/libz-sys/src/smoke.c: scope_hint: In function 'main'
bootc-202509051822.g39b0a32752/vendor/libz-sys/src/smoke.c:4:10: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
#    2|   
#    3|   int main() {
#    4|->   return (int) adler32;
#    5|   }

Error: CLIPPY_WARNING: [#def2]
crates/etc-merge/src/lib.rs:76:5: warning: unneeded `return` statement
#     |
#  76 |     return true;
#     |     ^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#     = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#     |
#  76 -     return true;
#  76 +     true
#     |

Error: CLIPPY_WARNING: [#def3]
crates/etc-merge/src/lib.rs:293:5: warning: doc list item without indentation
#      |
#  293 | /// Usually this will be obtained by remounting the EROFS image to a temporary location
#      |     ^
#      |
#      = help: if this is supposed to be its own paragraph, add a blank line
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
#      = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
#  help: indent this line
#      |
#  293 | ///   Usually this will be obtained by remounting the EROFS image to a temporary location
#      |     ++

Error: CLIPPY_WARNING: [#def4]
crates/etc-merge/src/lib.rs:298:5: warning: doc list item without indentation
#      |
#  298 | /// again be usually obtained by mounting the new EROFS image to a temporary location. If merging
#      |     ^
#      |
#      = help: if this is supposed to be its own paragraph, add a blank line
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
#  help: indent this line
#      |
#  298 | ///   again be usually obtained by mounting the new EROFS image to a temporary location. If merging
#      |     ++

Error: CLIPPY_WARNING: [#def5]
crates/etc-merge/src/lib.rs:299:5: warning: doc list item without indentation
#      |
#  299 | /// it will be necessary to make the `/etc` for the deployment writeable
#      |     ^
#      |
#      = help: if this is supposed to be its own paragraph, add a blank line
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
#  help: indent this line
#      |
#  299 | ///   it will be necessary to make the `/etc` for the deployment writeable
#      |     ++

Error: CLIPPY_WARNING: [#def6]
crates/etc-merge/src/lib.rs:328:5: warning: unneeded `return` statement
#      |
#  328 |     return Ok((pristine_etc_files, current_etc_files, new_etc_files));
#      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#  help: remove `return`
#      |
#  328 -     return Ok((pristine_etc_files, current_etc_files, new_etc_files));
#  328 +     Ok((pristine_etc_files, current_etc_files, new_etc_files))
#      |

Error: CLIPPY_WARNING: [#def7]
crates/etc-merge/src/lib.rs:432:35: warning: useless use of `format!`
#      |
#  432 |         let entry = entry.context(format!("Getting entry"))?;
#      |                                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Getting entry".to_string()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
#      = note: `#[warn(clippy::useless_format)]` on by default

Error: CLIPPY_WARNING: [#def8]
crates/lib/src/install.rs:1481:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#       |
#  1481 |       let source_image = opts
#       |  ________________________^
#  1482 | |         .source_opts
#  1483 | |         .source_imgref
#  1484 | |         .as_ref()
#  1485 | |         .map(|s| s.as_str())
#       | |____________________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
#       = note: `#[warn(clippy::option_as_ref_deref)]` on by default
#  help: consider using as_deref
#       |
#  1481 ~     let source_image = opts
#  1482 +         .source_opts
#  1483 +         .source_imgref.as_deref()
#       |

Error: CLIPPY_WARNING: [#def9]
crates/lib/src/install.rs:1726:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#       |
#  1726 |       let source_image = opts
#       |  ________________________^
#  1727 | |         .source_opts
#  1728 | |         .source_imgref
#  1729 | |         .as_ref()
#  1730 | |         .map(|s| s.as_str())
#       | |____________________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
#  help: consider using as_deref
#       |
#  1726 ~     let source_image = opts
#  1727 +         .source_opts
#  1728 +         .source_imgref.as_deref()
#       |

Error: CLIPPY_WARNING: [#def10]
crates/lib/src/install.rs:1978:24: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#       |
#  1978 |       let source_image = opts
#       |  ________________________^
#  1979 | |         .source_opts
#  1980 | |         .source_imgref
#  1981 | |         .as_ref()
#  1982 | |         .map(|s| s.as_str())
#       | |____________________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
#  help: consider using as_deref
#       |
#  1978 ~     let source_image = opts
#  1979 +         .source_opts
#  1980 +         .source_imgref.as_deref()
#       |

Error: CLIPPY_WARNING: [#def11]
crates/ostree-ext/src/container/store.rs:1551:36: warning: using `clone` on type `Option<&History>` which implements the `Copy` trait
#       |
#  1551 |           let previous_description = history_entry
#       |  ____________________________________^
#  1552 | |             .clone()
#       | |____________________^ help: try removing the `clone` call: `history_entry`
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
#       = note: `#[warn(clippy::clone_on_copy)]` on by default

Scan Properties