Fixed findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/lib/src/deploy.rs:142:1: warning: this function has too many arguments (9/7)
#      |
#  142 | / async fn handle_layer_progress_print(
#  143 | |     mut layers: tokio::sync::mpsc::Receiver<ostree_container::store::ImportProgress>,
#  144 | |     mut layer_bytes: tokio::sync::watch::Receiver<Option<ostree_container::store::LayerProgress>>,
#  145 | |     digest: Box<str>,
#  ...   |
#  151 | |     quiet: bool,
#  152 | | ) -> ProgressWriter {
#      | |___________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Error: CLIPPY_WARNING: [#def2]
crates/lib/src/deploy.rs:334:1: warning: large size difference between variants
#      |
#  334 | / pub(crate) enum PreparedPullResult {
#  335 | |     Ready(PreparedImportMeta),
#      | |     ------------------------- the largest variant contains at least 288 bytes
#  336 | |     AlreadyPresent(Box<ImageState>),
#      | |     ------------------------------- the second-largest variant contains at least 8 bytes
#  337 | | }
#      | |_^ the entire enum is at least 288 bytes
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
#      = note: `#[warn(clippy::large_enum_variant)]` on by default
#  help: consider boxing the large fields to reduce the total size of the enum
#      |
#  335 -     Ready(PreparedImportMeta),
#  335 +     Ready(Box<PreparedImportMeta>),
#      |

Error: CLIPPY_WARNING: [#def3]
crates/lib/src/spec.rs:101:5: warning: this `let...else` may be rewritten with the `?` operator
#      |
#  101 | /     let Some(digest) = reference.digest() else {
#  102 | |         return None;
#  103 | |     };
#      | |______^ help: replace it with: `let digest = reference.digest()?;`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
#      = note: `#[warn(clippy::question_mark)]` on by default

Error: CLIPPY_WARNING: [#def4]
crates/sysusers/src/lib.rs:132:75: warning: use of a disallowed method `str::len`
#      |
#  132 |                 let idx = s.find(|c: char| c.is_whitespace()).unwrap_or(s.len());
#      |                                                                           ^^^
#      |
#      = note: use <str>.as_bytes().len() instead
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#disallowed_methods
#      = note: requested on the command line with `-D clippy::disallowed-methods`

Error: CLIPPY_WARNING: [#def5]
crates/tmpfiles/src/lib.rs:318:1: warning: this function has too many arguments (8/7)
#      |
#  318 | / fn convert_path_to_tmpfiles_d_recurse<U: uzers::Users, G: uzers::Groups>(
#  319 | |     out_entries: &mut BTreeSet<String>,
#  320 | |     out_unsupported: &mut Vec<PathBuf>,
#  321 | |     users: &U,
#  ...   |
#  326 | |     readonly: bool,
#  327 | | ) -> Result<()> {
#      | |_______________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Scan Properties

analyzer-version-clippy1.89.0
analyzer-version-cppcheck2.18.1
analyzer-version-gcc15.2.1
analyzer-version-gcc-analyzer15.2.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.89.0
diffbase-analyzer-version-cppcheck2.18.1
diffbase-analyzer-version-gcc15.2.1
diffbase-analyzer-version-gcc-analyzer15.2.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-29.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20250521.132812.g8eff701.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namebootc-202508261413.gc23c9ae54c-1
diffbase-store-results-to/tmp/tmpwvtgkvyd/bootc-202508261413.gc23c9ae54c-1.tar.xz
diffbase-time-created2025-08-26 14:47:51
diffbase-time-finished2025-08-26 14:54:51
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,shellcheck,gcc,clippy,cppcheck' '-o' '/tmp/tmpwvtgkvyd/bootc-202508261413.gc23c9ae54c-1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmpwvtgkvyd/bootc-202508261413.gc23c9ae54c-1.src.rpm'
diffbase-tool-versioncsmock-3.8.2.20250811.215846.gf3b3dbf-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-29.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20250521.132812.g8eff701.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namebootc-202508261339.gea360d6d09-1
store-results-to/tmp/tmpcdp_mets/bootc-202508261339.gea360d6d09-1.tar.xz
time-created2025-08-26 14:40:16
time-finished2025-08-26 14:47:34
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,shellcheck,gcc,clippy,cppcheck' '-o' '/tmp/tmpcdp_mets/bootc-202508261339.gea360d6d09-1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmpcdp_mets/bootc-202508261339.gea360d6d09-1.src.rpm'
tool-versioncsmock-3.8.2.20250811.215846.gf3b3dbf-1.el9