Task #66565 - bootc-202508151846.g00dea6e440-1/scan-results.err
back to task #66565download
Error: COMPILER_WARNING (CWE-704):
bootc-202508151846.g00dea6e440/vendor/libz-sys/src/smoke.c: scope_hint: In function 'main'
bootc-202508151846.g00dea6e440/vendor/libz-sys/src/smoke.c:4:10: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
# 2|
# 3| int main() {
# 4|-> return (int) adler32;
# 5| }
Error: CLIPPY_WARNING:
crates/blockdev/src/blockdev.rs:52:9: warning: this `map_or` can be simplified
# |
# 52 | self.children.as_ref().map_or(false, |v| !v.is_empty())
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
# = note: `#[warn(clippy::unnecessary_map_or)]` on by default
# help: use is_some_and instead
# |
# 52 - self.children.as_ref().map_or(false, |v| !v.is_empty())
# 52 + self.children.as_ref().is_some_and(|v| !v.is_empty())
# |
Error: CLIPPY_WARNING:
crates/lib/src/cfsctl.rs:153:14: warning: redundant closure
# |
# 153 | .map(|value| FsVerityHashValue::from_hex(value))
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `FsVerityHashValue::from_hex`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
# = note: `#[warn(clippy::redundant_closure)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/cli.rs:793:35: warning: this `map_or` can be simplified
# |
# 793 | let booted_incompatible = host
# | ___________________________________^
# 794 | | .status
# 795 | | .booted
# 796 | | .as_ref()
# 797 | | .map_or(false, |b| b.incompatible);
# | |______________________________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
# = note: `#[warn(clippy::unnecessary_map_or)]` on by default
# help: use is_some_and instead
# |
# 797 - .map_or(false, |b| b.incompatible);
# 797 + .is_some_and(|b| b.incompatible);
# |
Error: CLIPPY_WARNING:
crates/lib/src/cli.rs:799:35: warning: this `map_or` can be simplified
# |
# 799 | let staged_incompatible = host
# | ___________________________________^
# 800 | | .status
# 801 | | .staged
# 802 | | .as_ref()
# 803 | | .map_or(false, |b| b.incompatible);
# | |______________________________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
# help: use is_some_and instead
# |
# 803 - .map_or(false, |b| b.incompatible);
# 803 + .is_some_and(|b| b.incompatible);
# |
Error: CLIPPY_WARNING:
crates/lib/src/deploy.rs:142:1: warning: this function has too many arguments (9/7)
# |
# 142 | / async fn handle_layer_progress_print(
# 143 | | mut layers: tokio::sync::mpsc::Receiver<ostree_container::store::ImportProgress>,
# 144 | | mut layer_bytes: tokio::sync::watch::Receiver<Option<ostree_container::store::LayerProgress>>,
# 145 | | digest: Box<str>,
# ... |
# 151 | | quiet: bool,
# 152 | | ) -> ProgressWriter {
# | |___________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
# = note: `#[warn(clippy::too_many_arguments)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/deploy.rs:204:33: warning: useless use of `format!`
# |
# 204 | ... id: format!("{short_digest}").clone().into(),
# | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `short_digest.to_string()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
# = note: `#[warn(clippy::useless_format)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/deploy.rs:333:1: warning: large size difference between variants
# |
# 333 | / pub(crate) enum PreparedPullResult {
# 334 | | Ready(PreparedImportMeta),
# | | ------------------------- the largest variant contains at least 288 bytes
# 335 | | AlreadyPresent(Box<ImageState>),
# | | ------------------------------- the second-largest variant contains at least 8 bytes
# 336 | | }
# | |_^ the entire enum is at least 288 bytes
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
# = note: `#[warn(clippy::large_enum_variant)]` on by default
# help: consider boxing the large fields to reduce the total size of the enum
# |
# 334 - Ready(PreparedImportMeta),
# 334 + Ready(Box<PreparedImportMeta>),
# |
Error: CLIPPY_WARNING:
crates/lib/src/fsck.rs:215:24: warning: using `clone` on type `bool` which implements the `Copy` trait
# |
# 215 | let expected = expected.clone();
# | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `expected`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
# = note: `#[warn(clippy::clone_on_copy)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/imgstorage.rs:285:16: warning: useless conversion to the same type: `anyhow::Error`
# |
# 285 | .await?
# | ________________^
# | |________________|
# 286 | || .map_err(Into::into)
# | ||____________________________^
# 287 | | }
# | |_____- help: consider removing
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
# = note: `#[warn(clippy::useless_conversion)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/lints.rs:158:13: warning: redundant field names in struct initialization
# |
# 158 | name: name,
# | ^^^^^^^^^^ help: replace it with: `name`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
# = note: `#[warn(clippy::redundant_field_names)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/lints.rs:161:13: warning: redundant field names in struct initialization
# |
# 161 | description: description,
# | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
Error: CLIPPY_WARNING:
crates/lib/src/lints.rs:172:13: warning: redundant field names in struct initialization
# |
# 172 | name: name,
# | ^^^^^^^^^^ help: replace it with: `name`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
Error: CLIPPY_WARNING:
crates/lib/src/lints.rs:175:13: warning: redundant field names in struct initialization
# |
# 175 | description: description,
# | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
Error: CLIPPY_WARNING:
crates/lib/src/lints.rs:293:51: warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
# |
# 293 | let mut recursive_lints = BTreeSet::from_iter(recursive_lints.into_iter());
# | ^^^^^^^^^^^^^^^------------
# | |
# | help: consider removing the `.into_iter()`
# |
# note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
# --> /builddir/build/BUILD/rustc-1.89.0-src/library/core/src/iter/traits/collect.rs:152:21
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Error: CLIPPY_WARNING:
crates/lib/src/lints.rs:330:48: warning: unnecessary map of the identity function
# |
# 330 | results.extend(recursive_errors.into_iter().map(|(lint, e)| (lint, e)));
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the call to `map`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
# = note: `#[warn(clippy::map_identity)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/lints.rs:514:12: warning: this boolean expression can be simplified
# |
# 514 | if !target.to_str().is_some() {
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target.to_str().is_none()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
# = note: `#[warn(clippy::nonminimal_bool)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/lints.rs:757:25: warning: useless use of `format!`
# |
# 757 | return lint_err(format!("Missing /boot directory"));
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Missing /boot directory".to_string()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
Error: CLIPPY_WARNING:
crates/lib/src/spec.rs:98:5: warning: this block may be rewritten with the `?` operator
# |
# 98 | / if reference.tag().is_none() {
# 99 | | return None;
# 100 | | }
# | |_____^ help: replace it with: `reference.tag()?;`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
# = note: `#[warn(clippy::question_mark)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/spec.rs:103:5: warning: this `let...else` may be rewritten with the `?` operator
# |
# 103 | / let Some(digest) = reference.digest() else {
# 104 | | return None;
# 105 | | };
# | |______^ help: replace it with: `let digest = reference.digest()?;`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
Error: CLIPPY_WARNING:
crates/lib/src/spec.rs:129:17: warning: unneeded `return` statement
# |
# 129 | return Ok(r);
# | ^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# = note: `#[warn(clippy::needless_return)]` on by default
# help: remove `return`
# |
# 129 - return Ok(r);
# 129 + Ok(r)
# |
Error: CLIPPY_WARNING:
crates/lib/src/store/mod.rs:11:1: warning: this import is redundant
# |
# 11 | use composefs;
# | ^^^^^^^^^^^^^^ help: remove it entirely
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
# = note: `#[warn(clippy::single_component_path_imports)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/store/mod.rs:154:42: warning: useless conversion to the same type: `anyhow::Error`
# |
# 154 | .context("update_timestamps")
# | __________________________________________^
# | |__________________________________________|
# 155 | || .map_err(Into::into)
# | ||________________________________^
# 156 | | }
# | |_____- help: consider removing
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Error: CLIPPY_WARNING:
crates/ostree-ext/src/chunking.rs:465:5: warning: doc list item overindented
# |
# 465 | /// Aggressively detects outliers in size and classifies them by
# | ^^^^^ help: try using ` ` (2 spaces)
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
# = note: `#[warn(clippy::doc_overindented_list_items)]` on by default
Error: CLIPPY_WARNING:
crates/ostree-ext/src/chunking.rs:466:5: warning: doc list item overindented
# |
# 466 | /// high, medium, low. The high size and low size are separate partitions
# | ^^^^^ help: try using ` ` (2 spaces)
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
Error: CLIPPY_WARNING:
crates/ostree-ext/src/chunking.rs:467:5: warning: doc list item overindented
# |
# 467 | /// and deserve bins of their own
# | ^^^^^ help: try using ` ` (2 spaces)
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
Error: CLIPPY_WARNING:
crates/ostree-ext/src/chunking.rs:469:5: warning: doc list item overindented
# |
# 469 | /// The medium partition from the previous step is less aggressively
# | ^^^^^ help: try using ` ` (2 spaces)
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
Error: CLIPPY_WARNING:
crates/ostree-ext/src/chunking.rs:470:5: warning: doc list item overindented
# |
# 470 | /// classified by using mean for both size and frequency
# | ^^^^^ help: try using ` ` (2 spaces)
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
Error: CLIPPY_WARNING:
crates/ostree-ext/src/cli.rs:1053:34: warning: struct pattern is not needed for a unit variant
# |
# 1053 | ContainerOpts::Commit {} => container_commit().await,
# | ^^^ help: remove the struct pattern
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern
# = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default
Error: CLIPPY_WARNING:
crates/ostree-ext/src/container/store.rs:640:28: warning: this `map_or` can be simplified
# |
# 640 | let bootable = config_labels.map_or(false, |l| {
# | ____________________________^
# 641 | | l.contains_key(bootable_key.as_str()) || l.contains_key(BOOTC_LABEL)
# 642 | | });
# | |______________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
# = note: `#[warn(clippy::unnecessary_map_or)]` on by default
# help: use is_some_and instead
# |
# 640 - let bootable = config_labels.map_or(false, |l| {
# 640 + let bootable = config_labels.is_some_and(|l| {
# |
Error: CLIPPY_WARNING:
crates/ostree-ext/src/tar/export.rs:109:9: warning: unneeded `return` statement
# |
# 109 | return p;
# | ^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# = note: `#[warn(clippy::needless_return)]` on by default
# help: remove `return`
# |
# 109 - return p;
# 109 + p
# |
Error: CLIPPY_WARNING:
crates/ostree-ext/src/tar/import.rs:129:35: warning: needless call to `as_bytes`
# |
# 129 | if !(parentname.is_ascii() && parentname.as_bytes().len() == 2) {
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `parentname.len()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
# = note: `#[warn(clippy::needless_as_bytes)]` on by default
Error: CLIPPY_WARNING:
crates/ostree-ext/src/tar/import.rs:150:38: warning: needless call to `as_bytes`
# |
# 150 | if !(checksum_rest.is_ascii() && checksum_rest.as_bytes().len() == 62) {
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `checksum_rest.len()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
Error: CLIPPY_WARNING:
crates/sysusers/src/lib.rs:64:37: warning: manual check for common ascii range
# |
# 64 | } else if s.chars().all(|c| matches!(c, '0'..='9')) {
# | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check
# = note: `#[warn(clippy::manual_is_ascii_check)]` on by default
Error: CLIPPY_WARNING:
crates/sysusers/src/lib.rs:134:32: warning: needless call to `as_bytes`
# |
# 134 | .unwrap_or(s.as_bytes().len());
# | ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
# = note: `#[warn(clippy::needless_as_bytes)]` on by default
Error: CLIPPY_WARNING:
crates/sysusers/src/lib.rs:138:17: warning: this `let...else` may be rewritten with the `?` operator
# |
# 138 | / let Some(end) = rest.find(|c: char| c == '"') else {
# 139 | | return None;
# 140 | | };
# | |__________________^ help: replace it with: `let end = rest.find(|c: char| c == '"')?;`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
# = note: `#[warn(clippy::question_mark)]` on by default
Error: CLIPPY_WARNING:
crates/sysusers/src/lib.rs:138:43: warning: this manual char comparison can be written more succinctly
# |
# 138 | let Some(end) = rest.find(|c: char| c == '"') else {
# | ^^^^^^^^^^^^^^^^^^ help: consider using a `char`: `'"'`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
# = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default
Error: CLIPPY_WARNING:
crates/sysusers/src/lib.rs:167:57: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
# |
# 167 | let (ftype, s) = Self::next_token(s).ok_or_else(err.clone())?;
# | ^^^^^^^^^^^ help: try removing the `clone` call: `err`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
# = note: `#[warn(clippy::clone_on_copy)]` on by default
Error: CLIPPY_WARNING:
crates/sysusers/src/lib.rs:170:70: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
# |
# 170 | let (name, s) = Self::next_token_owned(s).ok_or_else(err.clone())?;
# | ^^^^^^^^^^^ help: try removing the `clone` call: `err`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Error: CLIPPY_WARNING:
crates/sysusers/src/lib.rs:197:70: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
# |
# 197 | let (name, s) = Self::next_token_owned(s).ok_or_else(err.clone())?;
# | ^^^^^^^^^^^ help: try removing the `clone` call: `err`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Error: CLIPPY_WARNING:
crates/sysusers/src/lib.rs:203:70: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
# |
# 203 | let (_, s) = Self::next_optional_token(s).ok_or_else(err.clone())?;
# | ^^^^^^^^^^^ help: try removing the `clone` call: `err`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Error: CLIPPY_WARNING:
crates/sysusers/src/lib.rs:204:65: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
# |
# 204 | let (range, _) = Self::next_token(s).ok_or_else(err.clone())?;
# | ^^^^^^^^^^^ help: try removing the `clone` call: `err`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Error: CLIPPY_WARNING:
crates/sysusers/src/lib.rs:205:69: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
# |
# 205 | let (start, end) = range.split_once('-').ok_or_else(err.clone())?;
# | ^^^^^^^^^^^ help: try removing the `clone` call: `err`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Error: CLIPPY_WARNING:
crates/tmpfiles/src/lib.rs:85:5: warning: matching on `Some` with `ok()` is redundant
# |
# 85 | if let Some(s) = path.as_os_str().as_str().ok() {
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok
# = note: `#[warn(clippy::match_result_ok)]` on by default
# help: consider matching on `Ok(s)` and removing the call to `ok` instead
# |
# 85 - if let Some(s) = path.as_os_str().as_str().ok() {
# 85 + if let Ok(s) = path.as_os_str().as_str() {
# |
Error: CLIPPY_WARNING:
crates/tmpfiles/src/lib.rs:141:21: warning: unnecessary closure used to substitute value for `Option::None`
# |
# 141 | / src.next()
# 142 | | .ok_or_else(|| Error::MalformedTmpfilesPath)?
# | |____________________________________________________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
# = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
# help: use `ok_or` instead
# |
# 142 - .ok_or_else(|| Error::MalformedTmpfilesPath)?
# 142 + .ok_or(Error::MalformedTmpfilesPath)?
# |
Error: CLIPPY_WARNING:
crates/tmpfiles/src/lib.rs:146:21: warning: unnecessary closure used to substitute value for `Option::None`
# |
# 146 | / src.next()
# 147 | | .ok_or_else(|| Error::MalformedTmpfilesPath)?
# | |____________________________________________________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
# help: use `ok_or` instead
# |
# 147 - .ok_or_else(|| Error::MalformedTmpfilesPath)?
# 147 + .ok_or(Error::MalformedTmpfilesPath)?
# |
Error: CLIPPY_WARNING:
crates/tmpfiles/src/lib.rs:165:12: warning: redundant pattern matching, consider using `is_some()`
# |
# 165 | if let Some(_) = src.next_if_eq(&b'"') {
# | -------^^^^^^^------------------------ help: try: `if src.next_if_eq(&b'"').is_some()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
# = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
Error: CLIPPY_WARNING:
crates/tmpfiles/src/lib.rs:326:1: warning: this function has too many arguments (8/7)
# |
# 326 | / fn convert_path_to_tmpfiles_d_recurse<U: uzers::Users, G: uzers::Groups>(
# 327 | | out_entries: &mut BTreeSet<String>,
# 328 | | out_unsupported: &mut Vec<PathBuf>,
# 329 | | users: &U,
# ... |
# 334 | | readonly: bool,
# 335 | | ) -> Result<()> {
# | |_______________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
# = note: `#[warn(clippy::too_many_arguments)]` on by default
Error: CLIPPY_WARNING:
crates/tmpfiles/src/lib.rs:357:28: warning: unnecessary closure used to substitute value for `Option::None`
# |
# 357 | let user = users
# | ____________________________^
# 358 | | .get_user_by_uid(meta.uid())
# 359 | | .ok_or_else(|| Error::UserNotFound(uid))?;
# | |____________________________________________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
# help: use `ok_or` instead
# |
# 359 - .ok_or_else(|| Error::UserNotFound(uid))?;
# 359 + .ok_or(Error::UserNotFound(uid))?;
# |
Error: CLIPPY_WARNING:
crates/tmpfiles/src/lib.rs:365:29: warning: unnecessary closure used to substitute value for `Option::None`
# |
# 365 | let group = groups
# | _____________________________^
# 366 | | .get_group_by_gid(gid)
# 367 | | .ok_or_else(|| Error::GroupNotFound(gid))?;
# | |_____________________________________________________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
# help: use `ok_or` instead
# |
# 367 - .ok_or_else(|| Error::GroupNotFound(gid))?;
# 367 + .ok_or(Error::GroupNotFound(gid))?;
# |
Error: CLIPPY_WARNING:
crates/tmpfiles/src/lib.rs:502:15: warning: redundant pattern matching, consider using `is_some()`
# |
# 502 | while let Some(_) = it.next_if(|c| c.is_ascii_whitespace()) {}
# | ----------^^^^^^^------------------------------------------ help: try: `while it.next_if(|c| c.is_ascii_whitespace()).is_some()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
Error: CLIPPY_WARNING:
crates/tmpfiles/src/lib.rs:505:15: warning: redundant pattern matching, consider using `is_some()`
# |
# 505 | while let Some(_) = it.next_if(|c| !c.is_ascii_whitespace()) {
# | ----------^^^^^^^------------------------------------------- help: try: `while it.next_if(|c| !c.is_ascii_whitespace()).is_some()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
Error: CLIPPY_WARNING:
crates/tmpfiles/src/lib.rs:512:15: warning: redundant pattern matching, consider using `is_some()`
# |
# 512 | while let Some(_) = it.next_if(|c| c.is_ascii_whitespace()) {}
# | ----------^^^^^^^------------------------------------------ help: try: `while it.next_if(|c| c.is_ascii_whitespace()).is_some()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
Error: CLIPPY_WARNING:
crates/utils/src/iterators.rs:25:5: warning: this block may be rewritten with the `?` operator
# |
# 25 | / if it.peek().is_none() {
# 26 | | return None;
# 27 | | }
# | |_____^ help: replace it with: `it.peek()?;`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
# = note: `#[warn(clippy::question_mark)]` on by default
Error: CLIPPY_WARNING:
crates/utils/src/iterators.rs:29:5: warning: this loop could be written as a `for` loop
# |
# 29 | while let Some(next) = it.next() {
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in it.by_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
# = note: `#[warn(clippy::while_let_on_iterator)]` on by default
Error: CLIPPY_WARNING:
crates/utils/src/path.rs:34:9: warning: unneeded `return` statement
# |
# 34 | return Err(std::fmt::Error);
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
# = note: `#[warn(clippy::needless_return)]` on by default
# help: remove `return`
# |
# 34 - return Err(std::fmt::Error);
# 34 + Err(std::fmt::Error)
# |
Error: CLIPPY_WARNING:
crates/utils/src/timestamp.rs:2:1: warning: this import is redundant
# |
# 2 | use chrono;
# | ^^^^^^^^^^^ help: remove it entirely
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
# = note: `#[warn(clippy::single_component_path_imports)]` on by default