Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/lib/src/install.rs:1341:1: warning: this function has too many arguments (8/7)
#       |
#  1341 | / async fn install_with_sysroot(
#  1342 | |     state: &State,
#  1343 | |     rootfs: &RootSetup,
#  1344 | |     sysroot: &Storage,
#  ...    |
#  1349 | |     prog: ProgressWriter,
#  1350 | | ) -> Result<()> {
#       | |_______________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Error: CLIPPY_WARNING: [#def2]
crates/lib/src/progress_aggregator.rs:21:40: warning: called `unwrap` on `visual_filter` after checking its variant with `is_some`
#     |
#  20 |         let renderer = if std::io::stderr().is_terminal() && visual_filter.is_some() {
#     |                                                              ----------------------- the check is happening here
#  21 |             Some(ProgressRenderer::new(visual_filter.unwrap()))
#     |                                        ^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: try using `if let` or `match`
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
#     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default

Error: CLIPPY_WARNING: [#def3]
crates/lib/src/progress_renderer.rs:139:5: warning: this function has too many arguments (9/7)
#      |
#  139 | /     fn update_bytes_progress(
#  140 | |         &mut self,
#  141 | |         task: &str,
#  142 | |         _description: &str,
#  ...   |
#  148 | |         subtasks: &[SubTaskBytes<'_>],
#  149 | |     ) -> Result<()> {
#      | |___________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Error: CLIPPY_WARNING: [#def4]
crates/lib/src/progress_renderer.rs:150:22: warning: variables can be used directly in the `format!` string
#      |
#  150 |         let bar_id = format!("{}:{}", task, id);
#      |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  150 -         let bar_id = format!("{}:{}", task, id);
#  150 +         let bar_id = format!("{task}:{id}");
#      |

Error: CLIPPY_WARNING: [#def5]
crates/lib/src/progress_renderer.rs:199:22: warning: variables can be used directly in the `format!` string
#      |
#  199 |         let bar_id = format!("{}:{}", task, id);
#      |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  199 -         let bar_id = format!("{}:{}", task, id);
#  199 +         let bar_id = format!("{task}:{id}");
#      |

Error: CLIPPY_WARNING: [#def6]
crates/lib/src/progress_renderer.rs:206:28: warning: variables can be used directly in the `format!` string
#      |
#  206 |             pb.set_message(format!("{} ({})", description, task));
#      |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  206 -             pb.set_message(format!("{} ({})", description, task));
#  206 +             pb.set_message(format!("{description} ({task})"));
#      |

Scan Properties