netconsd-v0.4.1-1.20250725173117528262.pr23.13.g5604988

List of Findings

Error: COMPILER_WARNING: [#def1]
netconsd-v0.4.1/modules/logger.cc: scope_hint: In function ‘netconsd_output_init’
netconsd-v0.4.1/modules/logger.cc:152:76: warning[-Walloc-size-larger-than=]: argument 1 value ‘18446744073709551615’ exceeds maximum object size 9223372036854775807
#  152 |         maps = new std::unordered_map<struct in6_addr, struct logtarget>[nr];
#      |                                                                            ^
/usr/include/c++/15/new:140:26: note: in a call to allocation function ‘operator new []’ declared here
#  140 | _GLIBCXX_NODISCARD void* operator new[](std::size_t)
#      |                          ^
#  150|   extern "C" int netconsd_output_init(int nr)
#  151|   {
#  152|-> 	maps = new std::unordered_map<struct in6_addr, struct logtarget>[nr];
#  153|   	return 0;
#  154|   }

Error: COMPILER_WARNING: [#def2]
netconsd-v0.4.1/util/netconsblaster.c: scope_hint: In function ‘blaster_thread’
netconsd-v0.4.1/util/netconsblaster.c:197:56: warning[-Wformat-truncation=]: ‘%s’ directive output truncated writing 63 bytes into a region of size 56
#  151 | static const char *filler = "012345678901234567890123456789012345678901234567890123456789012";
#      |                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#......
#  197 |                 snprintf(pkt->payload + nr, len - nr, "%s", filler);
#      |                                                        ^~
/usr/include/bits/stdio2.h:68:10: note: ‘__snprintf_chk’ output 64 bytes into a destination of size 56
#   68 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
#      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#   69 |                                    __glibc_objsize (__s), __fmt,
#      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#   70 |                                    __va_arg_pack ());
#      |                                    ~~~~~~~~~~~~~~~~~
#  195|   		      md->lvl, md->seq, md->ts, contflag(md->cont));
#  196|   	if (nr < len) {
#  197|-> 		snprintf(pkt->payload + nr, len - nr, "%s", filler);
#  198|   	}
#  199|   	pkt->payload[len - 1] = '\n';

Error: GCC_ANALYZER_WARNING (CWE-401): [#def3]
netconsd-v0.4.1/util/netconsblaster.c: scope_hint: In function ‘blaster_thread’
netconsd-v0.4.1/util/netconsblaster.c:248:24: warning[-Wanalyzer-malloc-leak]: leak of ‘alloc_metadata_array(*(struct blaster_state *)arg.bits)’
#  246|   	struct netcons_metadata *ret;
#  247|   
#  248|-> 	ret = calloc(1 << bits, sizeof(*ret));
#  249|   	if (!ret) {
#  250|   		fatal("ENOMEM allocating metadata\n");

Error: GCC_ANALYZER_WARNING (CWE-775): [#def4]
netconsd-v0.4.1/util/netconsblaster.c:301:17: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘get_raw_socket()’
#  299|   	fd = get_raw_socket();
#  300|   	pkt = alloc_packet();
#  301|-> 	mdarr = alloc_metadata_array(_blaster_state->bits);
#  302|   	memcpy(&src, &_blaster_state->src, sizeof(src));
#  303|   	_blaster_state->seed = syscall(SYS_gettid);

Error: GCC_ANALYZER_WARNING (CWE-401): [#def5]
netconsd-v0.4.1/util/netconsblaster.c:301:17: warning[-Wanalyzer-malloc-leak]: leak of ‘alloc_packet()’
#  299|   	fd = get_raw_socket();
#  300|   	pkt = alloc_packet();
#  301|-> 	mdarr = alloc_metadata_array(_blaster_state->bits);
#  302|   	memcpy(&src, &_blaster_state->src, sizeof(src));
#  303|   	_blaster_state->seed = syscall(SYS_gettid);

Scan Properties