Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
src/engine/strat_engine/backstore/blockdev/mod.rs:145:12: warning: associated function `from_bd` is never used
#      |
#  144 | impl LockedBlockdev {
#      | ------------------- associated function in this implementation
#  145 |     pub fn from_bd(bd: &dyn BlockDev) -> Self {
#      |            ^^^^^^^
#      |
#      = note: `-D dead-code` implied by `-D unused`
#      = help: to override `-D unused` add `#[allow(dead_code)]`

Error: CLIPPY_WARNING: [#def2]
src/engine/strat_engine/backstore/blockdev/mod.rs:169:9: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#      |
#  169 |         self.user_info.as_ref().map(|s| s.as_str())
#      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `self.user_info.as_deref()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
#      = note: `-D clippy::option-as-ref-deref` implied by `-D clippy::all`
#      = help: to override `-D clippy::all` add `#[allow(clippy::option_as_ref_deref)]`

Error: CLIPPY_WARNING: [#def3]
src/engine/strat_engine/backstore/blockdev/mod.rs:173:9: warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value
#      |
#  173 |         self.hardware_info.as_ref().map(|s| s.as_str())
#      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `self.hardware_info.as_deref()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref

Error: CLIPPY_WARNING: [#def4]
src/engine/strat_engine/backstore/blockdev/mod.rs:185:9: warning: using `clone` on type `Option<Sectors>` which implements the `Copy` trait
#      |
#  185 |         self.new_size.clone()
#      |         ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.new_size`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
#      = note: `-D clippy::clone-on-copy` implied by `-D clippy::all`
#      = help: to override `-D clippy::all` add `#[allow(clippy::clone_on_copy)]`

Error: CLIPPY_WARNING: [#def5]
src/engine/strat_engine/pool/mod.rs:39:1: warning: more than 3 bools in a struct
#     |
#  39 | / pub struct LockedPool {
#  40 | |     blockdevs: Vec<(DevUuid, BlockDevTier, LockedBlockdev)>,
#  41 | |     filesystems: Vec<(Name, FilesystemUuid, LockedFilesystem)>,
#  42 | |     total_physical_size: Sectors,
#  ...  |
#  56 | |     volume_key_is_loaded: StratisResult<bool>,
#  57 | | }
#     | |_^
#     |
#     = help: consider using a state machine or refactoring bools into two-variant enums
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#struct_excessive_bools
#     = note: requested on the command line with `-D clippy::struct-excessive-bools`

Error: CLIPPY_WARNING: [#def6]
src/engine/strat_engine/pool/mod.rs:60:8: warning: associated function `from_pool` is never used
#     |
#  59 | impl LockedPool {
#     | --------------- associated function in this implementation
#  60 |     fn from_pool(p: &dyn Pool, pool_uuid: PoolUuid) -> Self {
#     |        ^^^^^^^^^

Error: CLIPPY_WARNING: [#def7]
src/engine/strat_engine/pool/mod.rs:197:9: warning: using `clone` on type `Option<Sectors>` which implements the `Copy` trait
#      |
#  197 |         self.total_physical_used.clone()
#      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.total_physical_used`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def8]
src/engine/strat_engine/thinpool/filesystem.rs:615:12: warning: associated function `from_fs` is never used
#      |
#  614 | impl LockedFilesystem {
#      | --------------------- associated function in this implementation
#  615 |     pub fn from_fs(fs: &dyn Filesystem) -> Self {
#      |            ^^^^^^^

Error: CLIPPY_WARNING: [#def9]
src/engine/strat_engine/thinpool/filesystem.rs:650:9: warning: using `clone` on type `Option<Sectors>` which implements the `Copy` trait
#      |
#  650 |         self.size_limit.clone()
#      |         ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.size_limit`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def10]
src/engine/strat_engine/thinpool/filesystem.rs:654:9: warning: using `clone` on type `Option<FilesystemUuid>` which implements the `Copy` trait
#      |
#  654 |         self.origin.clone()
#      |         ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.origin`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Scan Properties