bootc-202507120040.g83e93cd1cf-1

List of Findings

Error: CLIPPY_WARNING: [#def1]
blockdev/src/blockdev.rs:53:9: warning: this `map_or` can be simplified
#     |
#  53 |         self.children.as_ref().map_or(false, |v| !v.is_empty())
#     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
#     = note: `#[warn(clippy::unnecessary_map_or)]` on by default
#  help: use is_some_and instead
#     |
#  53 -         self.children.as_ref().map_or(false, |v| !v.is_empty())
#  53 +         self.children.as_ref().is_some_and(|v| !v.is_empty())
#     |

Error: COMPILER_WARNING (CWE-704): [#def2]
bootc-202507120040.g83e93cd1cf/vendor/libz-sys/src/smoke.c: scope_hint: In function ‘main’
bootc-202507120040.g83e93cd1cf/vendor/libz-sys/src/smoke.c:4:10: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
#    4 |   return (int) adler32;
#      |          ^
#    2|   
#    3|   int main() {
#    4|->   return (int) adler32;
#    5|   }

Error: CLIPPY_WARNING: [#def3]
lib/src/cli.rs:772:35: warning: this `map_or` can be simplified
#      |
#  772 |           let booted_incompatible = host
#      |  ___________________________________^
#  773 | |             .status
#  774 | |             .booted
#  775 | |             .as_ref()
#  776 | |             .map_or(false, |b| b.incompatible);
#      | |______________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
#      = note: `#[warn(clippy::unnecessary_map_or)]` on by default
#  help: use is_some_and instead
#      |
#  776 -             .map_or(false, |b| b.incompatible);
#  776 +             .is_some_and(|b| b.incompatible);
#      |

Error: CLIPPY_WARNING: [#def4]
lib/src/cli.rs:778:35: warning: this `map_or` can be simplified
#      |
#  778 |           let staged_incompatible = host
#      |  ___________________________________^
#  779 | |             .status
#  780 | |             .staged
#  781 | |             .as_ref()
#  782 | |             .map_or(false, |b| b.incompatible);
#      | |______________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
#  help: use is_some_and instead
#      |
#  782 -             .map_or(false, |b| b.incompatible);
#  782 +             .is_some_and(|b| b.incompatible);
#      |

Error: CLIPPY_WARNING: [#def5]
lib/src/deploy.rs:142:1: warning: this function has too many arguments (9/7)
#      |
#  142 | / async fn handle_layer_progress_print(
#  143 | |     mut layers: tokio::sync::mpsc::Receiver<ostree_container::store::ImportProgress>,
#  144 | |     mut layer_bytes: tokio::sync::watch::Receiver<Option<ostree_container::store::LayerProgress>>,
#  145 | |     digest: Box<str>,
#  ...   |
#  151 | |     quiet: bool,
#  152 | | ) -> ProgressWriter {
#      | |___________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Error: CLIPPY_WARNING: [#def6]
lib/src/deploy.rs:204:33: warning: useless use of `format!`
#      |
#  204 | ...                   id: format!("{short_digest}").clone().into(),
#      |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `short_digest.to_string()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
#      = note: `#[warn(clippy::useless_format)]` on by default

Error: CLIPPY_WARNING: [#def7]
lib/src/deploy.rs:333:1: warning: large size difference between variants
#      |
#  333 | / pub(crate) enum PreparedPullResult {
#  334 | |     Ready(PreparedImportMeta),
#      | |     ------------------------- the largest variant contains at least 288 bytes
#  335 | |     AlreadyPresent(Box<ImageState>),
#      | |     ------------------------------- the second-largest variant contains at least 8 bytes
#  336 | | }
#      | |_^ the entire enum is at least 288 bytes
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
#      = note: `#[warn(clippy::large_enum_variant)]` on by default
#  help: consider boxing the large fields to reduce the total size of the enum
#      |
#  334 -     Ready(PreparedImportMeta),
#  334 +     Ready(Box<PreparedImportMeta>),
#      |

Error: CLIPPY_WARNING: [#def8]
lib/src/fsck.rs:215:24: warning: using `clone` on type `bool` which implements the `Copy` trait
#      |
#  215 |         let expected = expected.clone();
#      |                        ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `expected`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
#      = note: `#[warn(clippy::clone_on_copy)]` on by default

Error: CLIPPY_WARNING: [#def9]
lib/src/imgstorage.rs:120:20: warning: variables can be used directly in the `format!` string
#      |
#  120 |     let run_root = format!("/proc/self/fd/{}", STORAGE_RUN_FD);
#      |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#      = note: `#[warn(clippy::uninlined_format_args)]` on by default
#  help: change this to
#      |
#  120 -     let run_root = format!("/proc/self/fd/{}", STORAGE_RUN_FD);
#  120 +     let run_root = format!("/proc/self/fd/{STORAGE_RUN_FD}");
#      |

Error: CLIPPY_WARNING: [#def10]
lib/src/imgstorage.rs:285:16: warning: useless conversion to the same type: `anyhow::Error`
#      |
#  285 |            .await?
#      |   ________________^
#      |  |________________|
#  286 | ||         .map_err(Into::into)
#      | ||____________________________^
#  287 | |      }
#      | |_____- help: consider removing
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
#      = note: `#[warn(clippy::useless_conversion)]` on by default

Error: CLIPPY_WARNING: [#def11]
lib/src/install.rs:1477:38: warning: variables can be used directly in the `format!` string
#       |
#  1477 |             sysroot_dir.atomic_write(format!("etc/{}", DESTRUCTIVE_CLEANUP), b"")?;
#       |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#       |
#  1477 -             sysroot_dir.atomic_write(format!("etc/{}", DESTRUCTIVE_CLEANUP), b"")?;
#  1477 +             sysroot_dir.atomic_write(format!("etc/{DESTRUCTIVE_CLEANUP}"), b"")?;
#       |

Error: CLIPPY_WARNING: [#def12]
lib/src/lints.rs:158:13: warning: redundant field names in struct initialization
#      |
#  158 |             name: name,
#      |             ^^^^^^^^^^ help: replace it with: `name`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
#      = note: `#[warn(clippy::redundant_field_names)]` on by default

Error: CLIPPY_WARNING: [#def13]
lib/src/lints.rs:161:13: warning: redundant field names in struct initialization
#      |
#  161 |             description: description,
#      |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Error: CLIPPY_WARNING: [#def14]
lib/src/lints.rs:172:13: warning: redundant field names in struct initialization
#      |
#  172 |             name: name,
#      |             ^^^^^^^^^^ help: replace it with: `name`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Error: CLIPPY_WARNING: [#def15]
lib/src/lints.rs:175:13: warning: redundant field names in struct initialization
#      |
#  175 |             description: description,
#      |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Error: CLIPPY_WARNING: [#def16]
lib/src/lints.rs:293:51: warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
#      |
#  293 |     let mut recursive_lints = BTreeSet::from_iter(recursive_lints.into_iter());
#      |                                                   ^^^^^^^^^^^^^^^------------
#      |                                                                  |
#      |                                                                  help: consider removing the `.into_iter()`
#      |
#  note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
#     --> /builddir/build/BUILD/rustc-1.88.0-src/library/core/src/iter/traits/collect.rs:152:21
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Error: CLIPPY_WARNING: [#def17]
lib/src/lints.rs:330:48: warning: unnecessary map of the identity function
#      |
#  330 |     results.extend(recursive_errors.into_iter().map(|(lint, e)| (lint, e)));
#      |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the call to `map`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
#      = note: `#[warn(clippy::map_identity)]` on by default

Error: CLIPPY_WARNING: [#def18]
lib/src/lints.rs:514:12: warning: this boolean expression can be simplified
#      |
#  514 |         if !target.to_str().is_some() {
#      |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target.to_str().is_none()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
#      = note: `#[warn(clippy::nonminimal_bool)]` on by default

Error: CLIPPY_WARNING: [#def19]
lib/src/lints.rs:757:25: warning: useless use of `format!`
#      |
#  757 |         return lint_err(format!("Missing /boot directory"));
#      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Missing /boot directory".to_string()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

Error: CLIPPY_WARNING: [#def20]
lib/src/progress_jsonl.rs:251:13: warning: variables can be used directly in the `format!` string
#      |
#  251 |             eprintln!("Failed to write to jsonl: {}", e);
#      |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  251 -             eprintln!("Failed to write to jsonl: {}", e);
#  251 +             eprintln!("Failed to write to jsonl: {e}");
#      |

Error: CLIPPY_WARNING: [#def21]
lib/src/progress_jsonl.rs:261:13: warning: variables can be used directly in the `format!` string
#      |
#  261 |             eprintln!("Failed to write to jsonl: {}", e);
#      |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  261 -             eprintln!("Failed to write to jsonl: {}", e);
#  261 +             eprintln!("Failed to write to jsonl: {e}");
#      |

Error: CLIPPY_WARNING: [#def22]
lib/src/spec.rs:98:5: warning: this block may be rewritten with the `?` operator
#      |
#  98  | /     if reference.tag().is_none() {
#  99  | |         return None;
#  100 | |     }
#      | |_____^ help: replace it with: `reference.tag()?;`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
#      = note: `#[warn(clippy::question_mark)]` on by default

Error: CLIPPY_WARNING: [#def23]
lib/src/spec.rs:103:5: warning: this `let...else` may be rewritten with the `?` operator
#      |
#  103 | /     let Some(digest) = reference.digest() else {
#  104 | |         return None;
#  105 | |     };
#      | |______^ help: replace it with: `let digest = reference.digest()?;`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

Error: CLIPPY_WARNING: [#def24]
lib/src/spec.rs:129:17: warning: unneeded `return` statement
#      |
#  129 |                 return Ok(r);
#      |                 ^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#      = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#      |
#  129 -                 return Ok(r);
#  129 +                 Ok(r)
#      |

Error: CLIPPY_WARNING: [#def25]
lib/src/status.rs:456:21: warning: variables can be used directly in the `format!` string
#      |
#  456 |                     writeln!(out, "ostree-remote:{}", remote)?;
#      |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  456 -                     writeln!(out, "ostree-remote:{}", remote)?;
#  456 +                     writeln!(out, "ostree-remote:{remote}")?;
#      |

Error: CLIPPY_WARNING: [#def26]
lib/src/store/mod.rs:122:42: warning: useless conversion to the same type: `anyhow::Error`
#      |
#  122 |                .context("update_timestamps")
#      |   __________________________________________^
#      |  |__________________________________________|
#  123 | ||             .map_err(Into::into)
#      | ||________________________________^
#  124 | |      }
#      | |_____- help: consider removing
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Error: CLIPPY_WARNING: [#def27]
lib/src/utils.rs:163:9: warning: variables can be used directly in the `format!` string
#      |
#  163 |         print!("{}...", msg);
#      |         ^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  163 -         print!("{}...", msg);
#  163 +         print!("{msg}...");
#      |

Error: CLIPPY_WARNING: [#def28]
ostree-ext/src/chunking.rs:377:33: warning: variables can be used directly in the `format!` string
#      |
#  377 | ...                   write!(acc, " and {}", v).unwrap();
#      |                       ^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  377 -                                 write!(acc, " and {}", v).unwrap();
#  377 +                                 write!(acc, " and {v}").unwrap();
#      |

Error: CLIPPY_WARNING: [#def29]
ostree-ext/src/chunking.rs:456:5: warning: doc list item overindented
#      |
#  456 | ///      Aggressively detects outliers in size and classifies them by
#      |     ^^^^^ help: try using `  ` (2 spaces)
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
#      = note: `#[warn(clippy::doc_overindented_list_items)]` on by default

Error: CLIPPY_WARNING: [#def30]
ostree-ext/src/chunking.rs:457:5: warning: doc list item overindented
#      |
#  457 | ///      high, medium, low. The high size and low size are separate partitions
#      |     ^^^^^ help: try using `  ` (2 spaces)
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items

Error: CLIPPY_WARNING: [#def31]
ostree-ext/src/chunking.rs:458:5: warning: doc list item overindented
#      |
#  458 | ///      and deserve bins of their own
#      |     ^^^^^ help: try using `  ` (2 spaces)
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items

Error: CLIPPY_WARNING: [#def32]
ostree-ext/src/chunking.rs:460:5: warning: doc list item overindented
#      |
#  460 | ///      The medium partition from the previous step is less aggressively
#      |     ^^^^^ help: try using `  ` (2 spaces)
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items

Error: CLIPPY_WARNING: [#def33]
ostree-ext/src/chunking.rs:461:5: warning: doc list item overindented
#      |
#  461 | ///      classified by using mean for both size and frequency
#      |     ^^^^^ help: try using `  ` (2 spaces)
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items

Error: CLIPPY_WARNING: [#def34]
ostree-ext/src/cli.rs:585:5: warning: variables can be used directly in the `format!` string
#      |
#  585 |     println!("Imported: {}", imported);
#      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#      = note: `#[warn(clippy::uninlined_format_args)]` on by default
#  help: change this to
#      |
#  585 -     println!("Imported: {}", imported);
#  585 +     println!("Imported: {imported}");
#      |

Error: CLIPPY_WARNING: [#def35]
ostree-ext/src/cli.rs:851:5: warning: variables can be used directly in the `format!` string
#      |
#  851 |     println!("{}", pushed);
#      |     ^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  851 -     println!("{}", pushed);
#  851 +     println!("{pushed}");
#      |

Error: CLIPPY_WARNING: [#def36]
ostree-ext/src/cli.rs:858:5: warning: variables can be used directly in the `format!` string
#      |
#  858 |     println!("{} digest: {}", imgref, digest);
#      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  858 -     println!("{} digest: {}", imgref, digest);
#  858 +     println!("{imgref} digest: {digest}");
#      |

Error: CLIPPY_WARNING: [#def37]
ostree-ext/src/cli.rs:1038:34: warning: struct pattern is not needed for a unit variant
#       |
#  1038 |             ContainerOpts::Commit {} => container_commit().await,
#       |                                  ^^^ help: remove the struct pattern
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern
#       = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default

Error: CLIPPY_WARNING: [#def38]
ostree-ext/src/cli.rs:1091:25: warning: variables can be used directly in the `format!` string
#       |
#  1091 |                         println!("{}", image);
#       |                         ^^^^^^^^^^^^^^^^^^^^^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#       |
#  1091 -                         println!("{}", image);
#  1091 +                         println!("{image}");
#       |

Error: CLIPPY_WARNING: [#def39]
ostree-ext/src/cli.rs:1239:21: warning: variables can be used directly in the `format!` string
#       |
#  1239 |                     println!("Pushed: {}", digest);
#       |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#       |
#  1239 -                     println!("Pushed: {}", digest);
#  1239 +                     println!("Pushed: {digest}");
#       |

Error: CLIPPY_WARNING: [#def40]
ostree-ext/src/cli.rs:1333:46: warning: variables can be used directly in the `format!` string
#       |
#  1333 | ...                   .with_context(|| format!("Failed to write commitid to {}", p))?;
#       |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#       |
#  1333 -                             .with_context(|| format!("Failed to write commitid to {}", p))?;
#  1333 +                             .with_context(|| format!("Failed to write commitid to {p}"))?;
#       |

Error: CLIPPY_WARNING: [#def41]
ostree-ext/src/container/encapsulate.rs:275:20: warning: variables can be used directly in the `format!` string
#      |
#  275 |         Cow::Owned(format!("ostree export of commit {}", commit))
#      |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  275 -         Cow::Owned(format!("ostree export of commit {}", commit))
#  275 +         Cow::Owned(format!("ostree export of commit {commit}"))
#      |

Error: CLIPPY_WARNING: [#def42]
ostree-ext/src/container/mod.rs:300:17: warning: variables can be used directly in the `format!` string
#      |
#  300 |                 write!(f, "{}:{}", sigverify, imgref)
#      |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  300 -                 write!(f, "{}:{}", sigverify, imgref)
#  300 +                 write!(f, "{sigverify}:{imgref}")
#      |

Error: CLIPPY_WARNING: [#def43]
ostree-ext/src/container/store.rs:514:14: warning: variables can be used directly in the `format!` string
#      |
#  514 |             &format!("Fetching {}", imgref),
#      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  514 -             &format!("Fetching {}", imgref),
#  514 +             &format!("Fetching {imgref}"),
#      |

Error: CLIPPY_WARNING: [#def44]
ostree-ext/src/container/store.rs:640:28: warning: this `map_or` can be simplified
#      |
#  640 |               let bootable = config_labels.map_or(false, |l| {
#      |  ____________________________^
#  641 | |                 l.contains_key(bootable_key.as_str()) || l.contains_key(BOOTC_LABEL)
#  642 | |             });
#      | |______________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
#      = note: `#[warn(clippy::unnecessary_map_or)]` on by default
#  help: use is_some_and instead
#      |
#  640 -             let bootable = config_labels.map_or(false, |l| {
#  640 +             let bootable = config_labels.is_some_and(|l| {
#      |

Error: CLIPPY_WARNING: [#def45]
ostree-ext/src/container/store.rs:1839:19: warning: variables can be used directly in the `format!` string
#       |
#  1839 |     let objpath = format!("objects/{}/{}.file", prefix, suffix);
#       |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#       |
#  1839 -     let objpath = format!("objects/{}/{}.file", prefix, suffix);
#  1839 +     let objpath = format!("objects/{prefix}/{suffix}.file");
#       |

Error: CLIPPY_WARNING: [#def46]
ostree-ext/src/container/store.rs:1881:53: warning: variables can be used directly in the `format!` string
#       |
#  1881 |                     let subpath = Utf8PathBuf::from(format!("{}/", path));
#       |                                                     ^^^^^^^^^^^^^^^^^^^^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#       |
#  1881 -                     let subpath = Utf8PathBuf::from(format!("{}/", path));
#  1881 +                     let subpath = Utf8PathBuf::from(format!("{path}/"));
#       |

Error: CLIPPY_WARNING: [#def47]
ostree-ext/src/container/unencapsulate.rs:178:36: warning: variables can be used directly in the `format!` string
#      |
#  178 |                 Err(worker.context(format!("proxy failure: {} and client error", text)))
#      |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  178 -                 Err(worker.context(format!("proxy failure: {} and client error", text)))
#  178 +                 Err(worker.context(format!("proxy failure: {text} and client error")))
#      |

Error: CLIPPY_WARNING: [#def48]
ostree-ext/src/diff.rs:107:35: warning: variables can be used directly in the `format!` string
#      |
#  107 |                     let subpath = format!("{}/", path);
#      |                                   ^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  107 -                     let subpath = format!("{}/", path);
#  107 +                     let subpath = format!("{path}/");
#      |

Error: CLIPPY_WARNING: [#def49]
ostree-ext/src/repair.rs:174:5: warning: variables can be used directly in the `format!` string
#      |
#  174 |     println!("{}", inodes);
#      |     ^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  174 -     println!("{}", inodes);
#  174 +     println!("{inodes}");
#      |

Error: CLIPPY_WARNING: [#def50]
ostree-ext/src/tar/export.rs:109:9: warning: unneeded `return` statement
#      |
#  109 |         return p;
#      |         ^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#      = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#      |
#  109 -         return p;
#  109 +         p
#      |

Error: CLIPPY_WARNING: [#def51]
ostree-ext/src/tar/export.rs:138:14: warning: variables can be used directly in the `format!` string
#      |
#  138 |         o => panic!("Unexpected object type: {:?}", o),
#      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  138 -         o => panic!("Unexpected object type: {:?}", o),
#  138 +         o => panic!("Unexpected object type: {o:?}"),
#      |

Error: CLIPPY_WARNING: [#def52]
ostree-ext/src/tar/export.rs:141:5: warning: variables can be used directly in the `format!` string
#      |
#  141 |     format!("{}/repo/objects/{}/{}.{}", OSTREEDIR, first, rest, suffix).into()
#      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  141 -     format!("{}/repo/objects/{}/{}.{}", OSTREEDIR, first, rest, suffix).into()
#  141 +     format!("{OSTREEDIR}/repo/objects/{first}/{rest}.{suffix}").into()
#      |

Error: CLIPPY_WARNING: [#def53]
ostree-ext/src/tar/export.rs:146:5: warning: variables can be used directly in the `format!` string
#      |
#  146 |     format!("{}/repo/objects/{}/{}.file-xattrs", OSTREEDIR, first, rest).into()
#      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  146 -     format!("{}/repo/objects/{}/{}.file-xattrs", OSTREEDIR, first, rest).into()
#  146 +     format!("{OSTREEDIR}/repo/objects/{first}/{rest}.file-xattrs").into()
#      |

Error: CLIPPY_WARNING: [#def54]
ostree-ext/src/tar/export.rs:151:5: warning: variables can be used directly in the `format!` string
#      |
#  151 | /     format!(
#  152 | |         "{}/repo/objects/{}/{}.file-xattrs-link",
#  153 | |         OSTREEDIR, first, rest
#  154 | |     )
#      | |_____^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args

Error: CLIPPY_WARNING: [#def55]
ostree-ext/src/tar/export.rs:250:35: warning: variables can be used directly in the `format!` string
#      |
#  250 |         let objdir: Utf8PathBuf = format!("{}/repo/objects", OSTREEDIR).into();
#      |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  250 -         let objdir: Utf8PathBuf = format!("{}/repo/objects", OSTREEDIR).into();
#  250 +         let objdir: Utf8PathBuf = format!("{OSTREEDIR}/repo/objects").into();
#      |

Error: CLIPPY_WARNING: [#def56]
ostree-ext/src/tar/export.rs:266:37: warning: variables can be used directly in the `format!` string
#      |
#  266 |             let path: Utf8PathBuf = format!("{}/{:02x}", objdir, d).into();
#      |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  266 -             let path: Utf8PathBuf = format!("{}/{:02x}", objdir, d).into();
#  266 +             let path: Utf8PathBuf = format!("{objdir}/{d:02x}").into();
#      |

Error: CLIPPY_WARNING: [#def57]
ostree-ext/src/tar/export.rs:281:37: warning: variables can be used directly in the `format!` string
#      |
#  281 |             let path: Utf8PathBuf = format!("{}/repo/{}", OSTREEDIR, d).into();
#      |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  281 -             let path: Utf8PathBuf = format!("{}/repo/{}", OSTREEDIR, d).into();
#  281 +             let path: Utf8PathBuf = format!("{OSTREEDIR}/repo/{d}").into();
#      |

Error: CLIPPY_WARNING: [#def58]
ostree-ext/src/tar/export.rs:287:24: warning: variables can be used directly in the `format!` string
#      |
#  287 |             let path = format!("{}/repo/config", OSTREEDIR);
#      |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  287 -             let path = format!("{}/repo/config", OSTREEDIR);
#  287 +             let path = format!("{OSTREEDIR}/repo/config");
#      |

Error: CLIPPY_WARNING: [#def59]
ostree-ext/src/tar/export.rs:366:18: warning: variables can be used directly in the `format!` string
#      |
#  366 |             o => panic!("Unexpected object type: {:?}", o),
#      |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  366 -             o => panic!("Unexpected object type: {:?}", o),
#  366 +             o => panic!("Unexpected object type: {o:?}"),
#      |

Error: CLIPPY_WARNING: [#def60]
ostree-ext/src/tar/export.rs:476:38: warning: variables can be used directly in the `format!` string
#      |
#  476 |                     .with_context(|| format!("Writing regfile {}", checksum))?;
#      |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  476 -                     .with_context(|| format!("Writing regfile {}", checksum))?;
#  476 +                     .with_context(|| format!("Writing regfile {checksum}"))?;
#      |

Error: CLIPPY_WARNING: [#def61]
ostree-ext/src/tar/export.rs:486:34: warning: variables can be used directly in the `format!` string
#      |
#  486 |                 let context = || format!("Writing content symlink: {}", checksum);
#      |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  486 -                 let context = || format!("Writing content symlink: {}", checksum);
#  486 +                 let context = || format!("Writing content symlink: {checksum}");
#      |

Error: CLIPPY_WARNING: [#def62]
ostree-ext/src/tar/import.rs:129:35: warning: needless call to `as_bytes`
#      |
#  129 |     if !(parentname.is_ascii() && parentname.as_bytes().len() == 2) {
#      |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `parentname.len()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
#      = note: `#[warn(clippy::needless_as_bytes)]` on by default

Error: CLIPPY_WARNING: [#def63]
ostree-ext/src/tar/import.rs:150:38: warning: needless call to `as_bytes`
#      |
#  150 |     if !(checksum_rest.is_ascii() && checksum_rest.as_bytes().len() == 62) {
#      |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `checksum_rest.len()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes

Error: CLIPPY_WARNING: [#def64]
ostree-ext/src/tar/import.rs:153:23: warning: variables can be used directly in the `format!` string
#      |
#  153 |     let reassembled = format!("{}{}", parent, checksum_rest);
#      |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  153 -     let reassembled = format!("{}{}", parent, checksum_rest);
#  153 +     let reassembled = format!("{parent}{checksum_rest}");
#      |

Error: CLIPPY_WARNING: [#def65]
system-reinstall-bootc/src/podman.rs:115:9: warning: variables can be used directly in the `format!` string
#      |
#  115 |         println!("Image {} is already present locally, skipping pull.", image);
#      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#      = note: `#[warn(clippy::uninlined_format_args)]` on by default
#  help: change this to
#      |
#  115 -         println!("Image {} is already present locally, skipping pull.", image);
#  115 +         println!("Image {image} is already present locally, skipping pull.");
#      |

Error: CLIPPY_WARNING: [#def66]
system-reinstall-bootc/src/podman.rs:118:9: warning: variables can be used directly in the `format!` string
#      |
#  118 |         println!("Image {} is not present locally, pulling it now.", image);
#      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  118 -         println!("Image {} is not present locally, pulling it now.", image);
#  118 +         println!("Image {image} is not present locally, pulling it now.");
#      |

Error: CLIPPY_WARNING: [#def67]
system-reinstall-bootc/src/podman.rs:122:22: warning: variables can be used directly in the `format!` string
#      |
#  122 |             .context(format!("pulling image {}", image))?;
#      |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  122 -             .context(format!("pulling image {}", image))?;
#  122 +             .context(format!("pulling image {image}"))?;
#      |

Error: CLIPPY_WARNING: [#def68]
system-reinstall-bootc/src/users.rs:174:69: warning: variables can be used directly in the `format!` string
#      |
#  174 |       let user_config = uzers::get_user_by_name(command_user).context(format!(
#      |  _____________________________________________________________________^
#  175 | |         "authorized_keys_command_user {} not found",
#  176 | |         command_user
#  177 | |     ))?;
#      | |_____^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args

Error: CLIPPY_WARNING: [#def69]
system-reinstall-bootc/src/users.rs:183:18: warning: variables can be used directly in the `format!` string
#      |
#  183 |         .context(format!("running authorized_keys_command {}", command))?;
#      |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  183 -         .context(format!("running authorized_keys_command {}", command))?;
#  183 +         .context(format!("running authorized_keys_command {command}"))?;
#      |

Error: CLIPPY_WARNING: [#def70]
system-reinstall-bootc/src/users.rs:204:22: warning: variables can be used directly in the `format!` string
#      |
#  204 |             .context(format!("user {} not found", user_name))?;
#      |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  204 -             .context(format!("user {} not found", user_name))?;
#  204 +             .context(format!("user {user_name} not found"))?;
#      |

Error: CLIPPY_WARNING: [#def71]
sysusers/src/lib.rs:64:37: warning: manual check for common ascii range
#     |
#  64 |         } else if s.chars().all(|c| matches!(c, '0'..='9')) {
#     |                                     ^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check
#     = note: `#[warn(clippy::manual_is_ascii_check)]` on by default

Error: CLIPPY_WARNING: [#def72]
sysusers/src/lib.rs:134:32: warning: needless call to `as_bytes`
#      |
#  134 |                     .unwrap_or(s.as_bytes().len());
#      |                                ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
#      = note: `#[warn(clippy::needless_as_bytes)]` on by default

Error: CLIPPY_WARNING: [#def73]
sysusers/src/lib.rs:138:17: warning: this `let...else` may be rewritten with the `?` operator
#      |
#  138 | /                 let Some(end) = rest.find(|c: char| c == '"') else {
#  139 | |                     return None;
#  140 | |                 };
#      | |__________________^ help: replace it with: `let end = rest.find(|c: char| c == '"')?;`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
#      = note: `#[warn(clippy::question_mark)]` on by default

Error: CLIPPY_WARNING: [#def74]
sysusers/src/lib.rs:138:43: warning: this manual char comparison can be written more succinctly
#      |
#  138 |                 let Some(end) = rest.find(|c: char| c == '"') else {
#      |                                           ^^^^^^^^^^^^^^^^^^ help: consider using a `char`: `'"'`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
#      = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default

Error: CLIPPY_WARNING: [#def75]
sysusers/src/lib.rs:167:57: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
#      |
#  167 |         let (ftype, s) = Self::next_token(s).ok_or_else(err.clone())?;
#      |                                                         ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
#      = note: `#[warn(clippy::clone_on_copy)]` on by default

Error: CLIPPY_WARNING: [#def76]
sysusers/src/lib.rs:170:70: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
#      |
#  170 |                 let (name, s) = Self::next_token_owned(s).ok_or_else(err.clone())?;
#      |                                                                      ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def77]
sysusers/src/lib.rs:197:70: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
#      |
#  197 |                 let (name, s) = Self::next_token_owned(s).ok_or_else(err.clone())?;
#      |                                                                      ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def78]
sysusers/src/lib.rs:203:70: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
#      |
#  203 |                 let (_, s) = Self::next_optional_token(s).ok_or_else(err.clone())?;
#      |                                                                      ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def79]
sysusers/src/lib.rs:204:65: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
#      |
#  204 |                 let (range, _) = Self::next_token(s).ok_or_else(err.clone())?;
#      |                                                                 ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def80]
sysusers/src/lib.rs:205:69: warning: using `clone` on type `{closure@lib.rs:166:19}` which implements the `Copy` trait
#      |
#  205 |                 let (start, end) = range.split_once('-').ok_or_else(err.clone())?;
#      |                                                                     ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def81]
sysusers/src/nameservice/group.rs:52:34: warning: variables can be used directly in the `format!` string
#     |
#  52 |             line.with_context(|| format!("failed to read group entry at line {}", line_num))?;
#     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#     = note: `#[warn(clippy::uninlined_format_args)]` on by default
#  help: change this to
#     |
#  52 -             line.with_context(|| format!("failed to read group entry at line {}", line_num))?;
#  52 +             line.with_context(|| format!("failed to read group entry at line {line_num}"))?;
#     |

Error: CLIPPY_WARNING: [#def82]
sysusers/src/nameservice/passwd.rs:57:34: warning: variables can be used directly in the `format!` string
#     |
#  57 |             line.with_context(|| format!("failed to read passwd entry at line {}", line_num))?;
#     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#     |
#  57 -             line.with_context(|| format!("failed to read passwd entry at line {}", line_num))?;
#  57 +             line.with_context(|| format!("failed to read passwd entry at line {line_num}"))?;
#     |

Error: CLIPPY_WARNING: [#def83]
sysusers/src/nameservice/shadow.rs:43:9: warning: variables can be used directly in the `format!` string
#     |
#  43 |         format!("{}", number)
#     |         ^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#     |
#  43 -         format!("{}", number)
#  43 +         format!("{number}")
#     |

Error: CLIPPY_WARNING: [#def84]
tests-integration/src/system_reinstall.rs:44:5: warning: variables can be used directly in the `format!` string
#     |
#  44 |     println!("Using deployment directory: {}", hash_str);
#     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#     = note: `#[warn(clippy::uninlined_format_args)]` on by default
#  help: change this to
#     |
#  44 -     println!("Using deployment directory: {}", hash_str);
#  44 +     println!("Using deployment directory: {hash_str}");
#     |

Error: CLIPPY_WARNING: [#def85]
tmpfiles/src/lib.rs:85:5: warning: matching on `Some` with `ok()` is redundant
#     |
#  85 |     if let Some(s) = path.as_os_str().as_str().ok() {
#     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok
#     = note: `#[warn(clippy::match_result_ok)]` on by default
#  help: consider matching on `Ok(s)` and removing the call to `ok` instead
#     |
#  85 -     if let Some(s) = path.as_os_str().as_str().ok() {
#  85 +     if let Ok(s) = path.as_os_str().as_str() {
#     |

Error: CLIPPY_WARNING: [#def86]
tmpfiles/src/lib.rs:102:22: warning: variables can be used directly in the `format!` string
#      |
#  102 |                 o => write!(out, "\\x{:02x}", o)?,
#      |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#      = note: `#[warn(clippy::uninlined_format_args)]` on by default
#  help: change this to
#      |
#  102 -                 o => write!(out, "\\x{:02x}", o)?,
#  102 +                 o => write!(out, "\\x{o:02x}")?,
#      |

Error: CLIPPY_WARNING: [#def87]
tmpfiles/src/lib.rs:141:21: warning: unnecessary closure used to substitute value for `Option::None`
#      |
#  141 | /                     src.next()
#  142 | |                         .ok_or_else(|| Error::MalformedTmpfilesPath)?
#      | |____________________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
#      = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
#  help: use `ok_or` instead
#      |
#  142 -                         .ok_or_else(|| Error::MalformedTmpfilesPath)?
#  142 +                         .ok_or(Error::MalformedTmpfilesPath)?
#      |

Error: CLIPPY_WARNING: [#def88]
tmpfiles/src/lib.rs:146:21: warning: unnecessary closure used to substitute value for `Option::None`
#      |
#  146 | /                     src.next()
#  147 | |                         .ok_or_else(|| Error::MalformedTmpfilesPath)?
#      | |____________________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
#  help: use `ok_or` instead
#      |
#  147 -                         .ok_or_else(|| Error::MalformedTmpfilesPath)?
#  147 +                         .ok_or(Error::MalformedTmpfilesPath)?
#      |

Error: CLIPPY_WARNING: [#def89]
tmpfiles/src/lib.rs:165:12: warning: redundant pattern matching, consider using `is_some()`
#      |
#  165 |     if let Some(_) = src.next_if_eq(&b'"') {
#      |     -------^^^^^^^------------------------ help: try: `if src.next_if_eq(&b'"').is_some()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
#      = note: `#[warn(clippy::redundant_pattern_matching)]` on by default

Error: CLIPPY_WARNING: [#def90]
tmpfiles/src/lib.rs:224:5: warning: variables can be used directly in the `format!` string
#      |
#  224 |     write!(bufwr, "{} ", filetype_char)?;
#      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  224 -     write!(bufwr, "{} ", filetype_char)?;
#  224 +     write!(bufwr, "{filetype_char} ")?;
#      |

Error: CLIPPY_WARNING: [#def91]
tmpfiles/src/lib.rs:326:1: warning: this function has too many arguments (8/7)
#      |
#  326 | / fn convert_path_to_tmpfiles_d_recurse<U: uzers::Users, G: uzers::Groups>(
#  327 | |     out_entries: &mut BTreeSet<String>,
#  328 | |     out_unsupported: &mut Vec<PathBuf>,
#  329 | |     users: &U,
#  ...   |
#  334 | |     readonly: bool,
#  335 | | ) -> Result<()> {
#      | |_______________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Error: CLIPPY_WARNING: [#def92]
tmpfiles/src/lib.rs:357:28: warning: unnecessary closure used to substitute value for `Option::None`
#      |
#  357 |                   let user = users
#      |  ____________________________^
#  358 | |                     .get_user_by_uid(meta.uid())
#  359 | |                     .ok_or_else(|| Error::UserNotFound(uid))?;
#      | |____________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
#  help: use `ok_or` instead
#      |
#  359 -                     .ok_or_else(|| Error::UserNotFound(uid))?;
#  359 +                     .ok_or(Error::UserNotFound(uid))?;
#      |

Error: CLIPPY_WARNING: [#def93]
tmpfiles/src/lib.rs:365:29: warning: unnecessary closure used to substitute value for `Option::None`
#      |
#  365 |                   let group = groups
#      |  _____________________________^
#  366 | |                     .get_group_by_gid(gid)
#  367 | |                     .ok_or_else(|| Error::GroupNotFound(gid))?;
#      | |_____________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
#  help: use `ok_or` instead
#      |
#  367 -                     .ok_or_else(|| Error::GroupNotFound(gid))?;
#  367 +                     .ok_or(Error::GroupNotFound(gid))?;
#      |

Error: CLIPPY_WARNING: [#def94]
tmpfiles/src/lib.rs:502:15: warning: redundant pattern matching, consider using `is_some()`
#      |
#  502 |     while let Some(_) = it.next_if(|c| c.is_ascii_whitespace()) {}
#      |     ----------^^^^^^^------------------------------------------ help: try: `while it.next_if(|c| c.is_ascii_whitespace()).is_some()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching

Error: CLIPPY_WARNING: [#def95]
tmpfiles/src/lib.rs:505:15: warning: redundant pattern matching, consider using `is_some()`
#      |
#  505 |     while let Some(_) = it.next_if(|c| !c.is_ascii_whitespace()) {
#      |     ----------^^^^^^^------------------------------------------- help: try: `while it.next_if(|c| !c.is_ascii_whitespace()).is_some()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching

Error: CLIPPY_WARNING: [#def96]
tmpfiles/src/lib.rs:512:15: warning: redundant pattern matching, consider using `is_some()`
#      |
#  512 |     while let Some(_) = it.next_if(|c| c.is_ascii_whitespace()) {}
#      |     ----------^^^^^^^------------------------------------------ help: try: `while it.next_if(|c| c.is_ascii_whitespace()).is_some()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching

Error: CLIPPY_WARNING: [#def97]
utils/src/iterators.rs:25:5: warning: this block may be rewritten with the `?` operator
#     |
#  25 | /     if it.peek().is_none() {
#  26 | |         return None;
#  27 | |     }
#     | |_____^ help: replace it with: `it.peek()?;`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
#     = note: `#[warn(clippy::question_mark)]` on by default

Error: CLIPPY_WARNING: [#def98]
utils/src/iterators.rs:29:5: warning: this loop could be written as a `for` loop
#     |
#  29 |     while let Some(next) = it.next() {
#     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in it.by_ref()`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
#     = note: `#[warn(clippy::while_let_on_iterator)]` on by default

Error: CLIPPY_WARNING: [#def99]
utils/src/path.rs:34:9: warning: unneeded `return` statement
#     |
#  34 |         return Err(std::fmt::Error);
#     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#     = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#     |
#  34 -         return Err(std::fmt::Error);
#  34 +         Err(std::fmt::Error)
#     |

Error: CLIPPY_WARNING: [#def100]
utils/src/timestamp.rs:2:1: warning: this import is redundant
#    |
#  2 | use chrono;
#    | ^^^^^^^^^^^ help: remove it entirely
#    |
#    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
#    = note: `#[warn(clippy::single_component_path_imports)]` on by default

Error: CLIPPY_WARNING: [#def101]
xtask/src/xtask.rs:377:17: warning: variables can be used directly in the `format!` string
#      |
#  377 |                 writeln!(o, "{}", line)?;
#      |                 ^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#      = note: `#[warn(clippy::uninlined_format_args)]` on by default
#  help: change this to
#      |
#  377 -                 writeln!(o, "{}", line)?;
#  377 +                 writeln!(o, "{line}")?;
#      |

Error: CLIPPY_WARNING: [#def102]
xtask/src/xtask.rs:422:17: warning: variables can be used directly in the `format!` string
#      |
#  422 |                 writeln!(o, "{}", line)?;
#      |                 ^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
#  help: change this to
#      |
#  422 -                 writeln!(o, "{}", line)?;
#  422 +                 writeln!(o, "{line}")?;
#      |

Scan Properties