Fixed defects

List of Defects

Error: CPPCHECK_WARNING (CWE-398): [#def1]
avahi-0.9.rc1-build/avahi-0.9.rc1/examples/client-publish-service.c:135: style[clarifyCondition]: Suspicious condition (assignment + comparison); Clarify expression with parentheses.
#  133|   
#  134|           /* Add an additional (hypothetic) subtype */
#  135|->         if ((ret = avahi_entry_group_add_service_subtype(group, AVAHI_IF_UNSPEC, AVAHI_PROTO_UNSPEC, 0, name, "_printer._tcp", NULL, "_magic._sub._printer._tcp") < 0)) {
#  136|               fprintf(stderr, "Failed to add subtype _magic._sub._printer._tcp: %s\n", avahi_strerror(ret));
#  137|               goto fail;

Error: CPPCHECK_WARNING (CWE-398): [#def2]
avahi-0.9.rc1-build/avahi-0.9.rc1/examples/core-publish-service.c:115: style[clarifyCondition]: Suspicious condition (assignment + comparison); Clarify expression with parentheses.
#  113|   
#  114|       /* Add an additional (hypothetic) subtype */
#  115|->     if ((ret = avahi_server_add_service_subtype(s, group, AVAHI_IF_UNSPEC, AVAHI_PROTO_UNSPEC, 0, name, "_printer._tcp", NULL, "_magic._sub._printer._tcp") < 0)) {
#  116|           fprintf(stderr, "Failed to add subtype _magic._sub._printer._tcp: %s\n", avahi_strerror(ret));
#  117|           goto fail;

Scan Properties

analyzer-version-clippy1.80.1
analyzer-version-cppcheck2.14.2
analyzer-version-gcc14.1.1
analyzer-version-gcc-analyzer14.1.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.80.1
diffbase-analyzer-version-cppcheck2.14.2
diffbase-analyzer-version-gcc14.1.1
diffbase-analyzer-version-gcc-analyzer14.1.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-47.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-nameavahi-0.9.rc1-29.20240820114655213175.pr635.54.g8e7e956
diffbase-store-results-to/tmp/tmpkgkrrk0i/avahi-0.9.rc1-29.20240820114655213175.pr635.54.g8e7e956.tar.xz
diffbase-time-created2024-08-20 15:44:53
diffbase-time-finished2024-08-20 15:48:00
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'clippy,gcc,cppcheck,shellcheck,unicontrol' '-o' '/tmp/tmpkgkrrk0i/avahi-0.9.rc1-29.20240820114655213175.pr635.54.g8e7e956.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--cppcheck-add-flag=--enable=style' '/tmp/tmpkgkrrk0i/avahi-0.9.rc1-29.20240820114655213175.pr635.54.g8e7e956.src.rpm'
diffbase-tool-versioncsmock-3.6.1-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-47.us-west-2.compute.internal
mock-configfedora-rawhide-x86_64
project-nameavahi-0.9.rc1-29.20240819212535207647.master.52.g9cbc63c
store-results-to/tmp/tmpde8mlfsj/avahi-0.9.rc1-29.20240819212535207647.master.52.g9cbc63c.tar.xz
time-created2024-08-20 15:41:07
time-finished2024-08-20 15:44:39
titleFixed defects
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'clippy,gcc,cppcheck,shellcheck,unicontrol' '-o' '/tmp/tmpde8mlfsj/avahi-0.9.rc1-29.20240819212535207647.master.52.g9cbc63c.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--cppcheck-add-flag=--enable=style' '/tmp/tmpde8mlfsj/avahi-0.9.rc1-29.20240819212535207647.master.52.g9cbc63c.src.rpm'
tool-versioncsmock-3.6.1-1.el9