fido-device-onboard-0.5.5-1.20250606135918621927.pr3

List of Findings

Error: SHELLCHECK_WARNING (CWE-457): [#def1]
/usr/lib/dracut/modules.d/52fdo/module-setup.sh:6:18: warning[SC2154]: moddir is referenced but not assigned.
#    4|       unit="$1"; shift
#    5|       target="$1"; shift
#    6|->     inst_simple "$moddir/$unit" "$systemdsystemunitdir/$unit"
#    7|       # note we `|| exit 1` here so we error out if e.g. the units are missing
#    8|       # see https://github.com/coreos/fedora-coreos-config/issues/799

Error: SHELLCHECK_WARNING (CWE-457): [#def2]
/usr/lib/dracut/modules.d/52fdo/module-setup.sh:6:34: warning[SC2154]: systemdsystemunitdir is referenced but not assigned.
#    4|       unit="$1"; shift
#    5|       target="$1"; shift
#    6|->     inst_simple "$moddir/$unit" "$systemdsystemunitdir/$unit"
#    7|       # note we `|| exit 1` here so we error out if e.g. the units are missing
#    8|       # see https://github.com/coreos/fedora-coreos-config/issues/799

Error: SHELLCHECK_WARNING (CWE-457): [#def3]
/usr/lib/dracut/modules.d/52fdo/module-setup.sh:9:26: warning[SC2154]: initdir is referenced but not assigned.
#    7|       # note we `|| exit 1` here so we error out if e.g. the units are missing
#    8|       # see https://github.com/coreos/fedora-coreos-config/issues/799
#    9|->     systemctl -q --root="$initdir" add-requires "$target" "$unit" || exit 1
#   10|   }
#   11|   

Error: SHELLCHECK_WARNING (CWE-457): [#def4]
/usr/lib/dracut/modules.d/52fdo/module-setup.sh:16:10: warning[SC2154]: systemdutildir is referenced but not assigned.
#   14|   
#   15|       inst_simple "$moddir/manufacturing-client-generator" \
#   16|->         "$systemdutildir/system-generators/manufacturing-client-generator"
#   17|   
#   18|       inst_script "$moddir/manufacturing-client-service" \

Error: CLIPPY_WARNING: [#def5]
owner-onboarding-server/src/main.rs:111:35: warning: `to_string` applied to a type that implements `Display` in `warn!` args
#      |
#  111 |                 ov.header().guid().to_string(),
#      |                                   ^^^^^^^^^^^^ help: remove this
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
#      = note: `#[warn(clippy::to_string_in_format_args)]` on by default

Error: CLIPPY_WARNING: [#def6]
owner-onboarding-server/src/main.rs:192:50: warning: `to_string` applied to a type that implements `Display` in `warn!` args
#      |
#  192 | ...                   ov.header().guid().to_string(), udt.ov_registration_period);
#      |                                         ^^^^^^^^^^^^ help: remove this
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Error: CLIPPY_WARNING: [#def7]
owner-onboarding-server/src/main.rs:195:43: warning: `to_string` applied to a type that implements `Display` in `warn!` args
#      |
#  195 |                         ov.header().guid().to_string(), udt.ov_re_registration_window, udt.ov_registration_period);
#      |                                           ^^^^^^^^^^^^ help: remove this
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Error: CLIPPY_WARNING: [#def8]
owner-onboarding-server/src/main.rs:202:39: warning: `to_string` applied to a type that implements `Display` in `warn!` args
#      |
#  202 |                     ov.header().guid().to_string()
#      |                                       ^^^^^^^^^^^^ help: remove this
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Error: CLIPPY_WARNING: [#def9]
owner-onboarding-server/src/main.rs:264:33: warning: `to_string` applied to a type that implements `Display` in `info!` args
#      |
#  264 |                 ov_header.guid().to_string(),
#      |                                 ^^^^^^^^^^^^ help: remove this
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Error: CLIPPY_WARNING: [#def10]
owner-onboarding-server/src/main.rs:305:33: warning: `to_string` applied to a type that implements `Display` in `info!` args
#      |
#  305 |                 ov_header.guid().to_string(),
#      |                                 ^^^^^^^^^^^^ help: remove this
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Error: CLIPPY_WARNING: [#def11]
store/src/directory.rs:153:68: warning: `to_string` applied to a type that implements `Display` in `trace!` args
#      |
#  153 |                         log::trace!("Error checking {}: {}", key, e.to_string());
#      |                                                                    ^^^^^^^^^^^^ help: remove this
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
#      = note: `#[warn(clippy::to_string_in_format_args)]` on by default

Error: CLIPPY_WARNING: [#def12]
store/src/directory.rs:172:72: warning: `to_string` applied to a type that implements `Display` in `trace!` args
#      |
#  172 | ...                   log::trace!("Error checking {}: {}", key, e.to_string());
#      |                                                                  ^^^^^^^^^^^^ help: remove this
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Error: CLIPPY_WARNING: [#def13]
store/src/directory.rs:184:59: warning: `to_string` applied to a type that implements `Display` in `trace!` args
#      |
#  184 |                     log::trace!("Error opening file {}", e.to_string());
#      |                                                           ^^^^^^^^^^^^ help: remove this
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Error: CLIPPY_WARNING: [#def14]
util/src/servers/mod.rs:122:20: warning: manual implementation of `ok`
#      |
#  122 |           Some(v) => match v.into_string() {
#      |  ____________________^
#  123 | |             Ok(s) => Some(s),
#  124 | |             Err(_) => None,
#  125 | |         },
#      | |_________^ help: replace with: `v.into_string().ok()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
#      = note: `#[warn(clippy::manual_ok_err)]` on by default

Scan Properties