Error: CLIPPY_WARNING: [#def1] blockdev/src/blockdev.rs:53:9: warning: this `map_or` can be simplified # | # 53 | self.children.as_ref().map_or(false, |v| !v.is_empty()) # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or # = note: `#[warn(clippy::unnecessary_map_or)]` on by default # help: use is_some_and instead # | # 53 - self.children.as_ref().map_or(false, |v| !v.is_empty()) # 53 + self.children.as_ref().is_some_and(|v| !v.is_empty()) # | Error: COMPILER_WARNING (CWE-704): [#def2] bootc-202505122117.g8785dcb3da/vendor/libz-sys/src/smoke.c: scope_hint: In function ‘main’ bootc-202505122117.g8785dcb3da/vendor/libz-sys/src/smoke.c:4:10: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size # 2| # 3| int main() { # 4|-> return (int) adler32; # 5| } Error: CLIPPY_WARNING: [#def3] lib/src/cli.rs:762:35: warning: this `map_or` can be simplified # | # 762 | let booted_incompatible = host # | ___________________________________^ # 763 | | .status # 764 | | .booted # 765 | | .as_ref() # 766 | | .map_or(false, |b| b.incompatible); # | |______________________________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or # = note: `#[warn(clippy::unnecessary_map_or)]` on by default # help: use is_some_and instead # | # 766 - .map_or(false, |b| b.incompatible); # 766 + .is_some_and(|b| b.incompatible); # | Error: CLIPPY_WARNING: [#def4] lib/src/cli.rs:768:35: warning: this `map_or` can be simplified # | # 768 | let staged_incompatible = host # | ___________________________________^ # 769 | | .status # 770 | | .staged # 771 | | .as_ref() # 772 | | .map_or(false, |b| b.incompatible); # | |______________________________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or # help: use is_some_and instead # | # 772 - .map_or(false, |b| b.incompatible); # 772 + .is_some_and(|b| b.incompatible); # | Error: CLIPPY_WARNING: [#def5] lib/src/deploy.rs:142:1: warning: this function has too many arguments (9/7) # | # 142 | / async fn handle_layer_progress_print( # 143 | | mut layers: tokio::sync::mpsc::Receiver<ostree_container::store::ImportProgress>, # 144 | | mut layer_bytes: tokio::sync::watch::Receiver<Option<ostree_container::store::LayerProgress>>, # 145 | | digest: Box<str>, # ... | # 151 | | quiet: bool, # 152 | | ) -> ProgressWriter { # | |___________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments # = note: `#[warn(clippy::too_many_arguments)]` on by default Error: CLIPPY_WARNING: [#def6] lib/src/deploy.rs:204:33: warning: useless use of `format!` # | # 204 | ... id: format!("{short_digest}").clone().into(), # | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `short_digest.to_string()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format # = note: `#[warn(clippy::useless_format)]` on by default Error: CLIPPY_WARNING: [#def7] lib/src/fsck.rs:214:24: warning: using `clone` on type `bool` which implements the `Copy` trait # | # 214 | let expected = expected.clone(); # | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `expected` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy # = note: `#[warn(clippy::clone_on_copy)]` on by default Error: CLIPPY_WARNING: [#def8] lib/src/imgstorage.rs:285:16: warning: useless conversion to the same type: `anyhow::Error` # | # 285 | .await? # | ________________^ # | |________________| # 286 | || .map_err(Into::into) # | ||____________________________^ # 287 | | } # | |_____- help: consider removing # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion # = note: `#[warn(clippy::useless_conversion)]` on by default Error: CLIPPY_WARNING: [#def9] lib/src/lints.rs:149:13: warning: redundant field names in struct initialization # | # 149 | name: name, # | ^^^^^^^^^^ help: replace it with: `name` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names # = note: `#[warn(clippy::redundant_field_names)]` on by default Error: CLIPPY_WARNING: [#def10] lib/src/lints.rs:152:13: warning: redundant field names in struct initialization # | # 152 | description: description, # | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names Error: CLIPPY_WARNING: [#def11] lib/src/lints.rs:163:13: warning: redundant field names in struct initialization # | # 163 | name: name, # | ^^^^^^^^^^ help: replace it with: `name` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names Error: CLIPPY_WARNING: [#def12] lib/src/lints.rs:166:13: warning: redundant field names in struct initialization # | # 166 | description: description, # | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names Error: CLIPPY_WARNING: [#def13] lib/src/lints.rs:229:51: warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` # | # 229 | let mut recursive_lints = BTreeSet::from_iter(recursive_lints.into_iter()); # | ^^^^^^^^^^^^^^^------------ # | | # | help: consider removing the `.into_iter()` # | # note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` # --> /builddir/build/BUILD/rustc-1.86.0-src/library/core/src/iter/traits/collect.rs:152:21 # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion Error: CLIPPY_WARNING: [#def14] lib/src/lints.rs:266:48: warning: unnecessary map of the identity function # | # 266 | results.extend(recursive_errors.into_iter().map(|(lint, e)| (lint, e))); # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the call to `map` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity # = note: `#[warn(clippy::map_identity)]` on by default Error: CLIPPY_WARNING: [#def15] lib/src/lints.rs:448:12: warning: this boolean expression can be simplified # | # 448 | if !target.to_str().is_some() { # | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target.to_str().is_none()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool # = note: `#[warn(clippy::nonminimal_bool)]` on by default Error: CLIPPY_WARNING: [#def16] lib/src/lints.rs:727:25: warning: useless use of `format!` # | # 727 | return lint_err(format!("Missing /boot directory")); # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Missing /boot directory".to_string()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format Error: CLIPPY_WARNING: [#def17] lib/src/spec.rs:98:5: warning: this block may be rewritten with the `?` operator # | # 98 | / if reference.tag().is_none() { # 99 | | return None; # 100 | | } # | |_____^ help: replace it with: `reference.tag()?;` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark # = note: `#[warn(clippy::question_mark)]` on by default Error: CLIPPY_WARNING: [#def18] lib/src/spec.rs:103:5: warning: this `let...else` may be rewritten with the `?` operator # | # 103 | / let Some(digest) = reference.digest() else { # 104 | | return None; # 105 | | }; # | |______^ help: replace it with: `let digest = reference.digest()?;` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark Error: CLIPPY_WARNING: [#def19] lib/src/spec.rs:129:17: warning: unneeded `return` statement # | # 129 | return Ok(r); # | ^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # = note: `#[warn(clippy::needless_return)]` on by default # help: remove `return` # | # 129 - return Ok(r); # 129 + Ok(r) # | Error: CLIPPY_WARNING: [#def20] lib/src/store/mod.rs:117:42: warning: useless conversion to the same type: `anyhow::Error` # | # 117 | .context("update_timestamps") # | __________________________________________^ # | |__________________________________________| # 118 | || .map_err(Into::into) # | ||________________________________^ # 119 | | } # | |_____- help: consider removing # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion Error: CLIPPY_WARNING: [#def21] ostree-ext/src/chunking.rs:425:5: warning: doc list item overindented # | # 425 | /// Aggressively detects outliers in size and classifies them by # | ^^^^^ help: try using ` ` (2 spaces) # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items # = note: `#[warn(clippy::doc_overindented_list_items)]` on by default Error: CLIPPY_WARNING: [#def22] ostree-ext/src/chunking.rs:426:5: warning: doc list item overindented # | # 426 | /// high, medium, low. The high size and low size are separate partitions # | ^^^^^ help: try using ` ` (2 spaces) # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items Error: CLIPPY_WARNING: [#def23] ostree-ext/src/chunking.rs:427:5: warning: doc list item overindented # | # 427 | /// and deserve bins of their own # | ^^^^^ help: try using ` ` (2 spaces) # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items Error: CLIPPY_WARNING: [#def24] ostree-ext/src/chunking.rs:429:5: warning: doc list item overindented # | # 429 | /// The medium partition from the previous step is less aggressively # | ^^^^^ help: try using ` ` (2 spaces) # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items Error: CLIPPY_WARNING: [#def25] ostree-ext/src/chunking.rs:430:5: warning: doc list item overindented # | # 430 | /// classified by using mean for both size and frequency # | ^^^^^ help: try using ` ` (2 spaces) # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items Error: CLIPPY_WARNING: [#def26] ostree-ext/src/cli.rs:1034:34: warning: struct pattern is not needed for a unit variant # | # 1034 | ContainerOpts::Commit {} => container_commit().await, # | ^^^ help: remove the struct pattern # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern # = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default Error: CLIPPY_WARNING: [#def27] ostree-ext/src/container/store.rs:625:28: warning: this `map_or` can be simplified # | # 625 | let bootable = config_labels.map_or(false, |l| { # | ____________________________^ # 626 | | l.contains_key(bootable_key.as_str()) || l.contains_key(BOOTC_LABEL) # 627 | | }); # | |______________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or # = note: `#[warn(clippy::unnecessary_map_or)]` on by default # help: use is_some_and instead # | # 625 - let bootable = config_labels.map_or(false, |l| { # 625 + let bootable = config_labels.is_some_and(|l| { # | Error: CLIPPY_WARNING: [#def28] ostree-ext/src/tar/export.rs:88:9: warning: unneeded `return` statement # | # 88 | return p; # | ^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # = note: `#[warn(clippy::needless_return)]` on by default # help: remove `return` # | # 88 - return p; # 88 + p # | Error: CLIPPY_WARNING: [#def29] ostree-ext/src/tar/import.rs:129:35: warning: needless call to `as_bytes` # | # 129 | if !(parentname.is_ascii() && parentname.as_bytes().len() == 2) { # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `parentname.len()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes # = note: `#[warn(clippy::needless_as_bytes)]` on by default Error: CLIPPY_WARNING: [#def30] ostree-ext/src/tar/import.rs:150:38: warning: needless call to `as_bytes` # | # 150 | if !(checksum_rest.is_ascii() && checksum_rest.as_bytes().len() == 62) { # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `checksum_rest.len()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes Error: CLIPPY_WARNING: [#def31] sysusers/src/lib.rs:60:38: warning: manual check for common ascii range # | # 60 | let r = if s.chars().all(|c| matches!(c, '0'..='9')) { # | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check # = note: `#[warn(clippy::manual_is_ascii_check)]` on by default Error: CLIPPY_WARNING: [#def32] sysusers/src/lib.rs:102:32: warning: needless call to `as_bytes` # | # 102 | .unwrap_or(s.as_bytes().len()); # | ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes # = note: `#[warn(clippy::needless_as_bytes)]` on by default Error: CLIPPY_WARNING: [#def33] sysusers/src/lib.rs:106:17: warning: this `let...else` may be rewritten with the `?` operator # | # 106 | / let Some(end) = rest.find(|c: char| c == '"') else { # 107 | | return None; # 108 | | }; # | |__________________^ help: replace it with: `let end = rest.find(|c: char| c == '"')?;` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark # = note: `#[warn(clippy::question_mark)]` on by default Error: CLIPPY_WARNING: [#def34] sysusers/src/lib.rs:106:43: warning: this manual char comparison can be written more succinctly # | # 106 | let Some(end) = rest.find(|c: char| c == '"') else { # | ^^^^^^^^^^^^^^^^^^ help: consider using a `char`: `'"'` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison # = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default Error: CLIPPY_WARNING: [#def35] sysusers/src/lib.rs:135:57: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait # | # 135 | let (ftype, s) = Self::next_token(s).ok_or_else(err.clone())?; # | ^^^^^^^^^^^ help: try removing the `clone` call: `err` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy # = note: `#[warn(clippy::clone_on_copy)]` on by default Error: CLIPPY_WARNING: [#def36] sysusers/src/lib.rs:138:70: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait # | # 138 | let (name, s) = Self::next_token_owned(s).ok_or_else(err.clone())?; # | ^^^^^^^^^^^ help: try removing the `clone` call: `err` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Error: CLIPPY_WARNING: [#def37] sysusers/src/lib.rs:139:71: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait # | # 139 | let (id, s) = Self::next_optional_token(s).ok_or_else(err.clone())?; # | ^^^^^^^^^^^ help: try removing the `clone` call: `err` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Error: CLIPPY_WARNING: [#def38] sysusers/src/lib.rs:151:71: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait # | # 151 | let (gecos, s) = Self::next_token_owned(s).ok_or_else(err.clone())?; # | ^^^^^^^^^^^ help: try removing the `clone` call: `err` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Error: CLIPPY_WARNING: [#def39] sysusers/src/lib.rs:164:70: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait # | # 164 | let (name, s) = Self::next_token_owned(s).ok_or_else(err.clone())?; # | ^^^^^^^^^^^ help: try removing the `clone` call: `err` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Error: CLIPPY_WARNING: [#def40] sysusers/src/lib.rs:165:71: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait # | # 165 | let (id, _) = Self::next_optional_token(s).ok_or_else(err.clone())?; # | ^^^^^^^^^^^ help: try removing the `clone` call: `err` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Error: CLIPPY_WARNING: [#def41] sysusers/src/lib.rs:170:70: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait # | # 170 | let (_, s) = Self::next_optional_token(s).ok_or_else(err.clone())?; # | ^^^^^^^^^^^ help: try removing the `clone` call: `err` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Error: CLIPPY_WARNING: [#def42] sysusers/src/lib.rs:171:65: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait # | # 171 | let (range, _) = Self::next_token(s).ok_or_else(err.clone())?; # | ^^^^^^^^^^^ help: try removing the `clone` call: `err` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Error: CLIPPY_WARNING: [#def43] sysusers/src/lib.rs:172:69: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait # | # 172 | let (start, end) = range.split_once('-').ok_or_else(err.clone())?; # | ^^^^^^^^^^^ help: try removing the `clone` call: `err` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Error: CLIPPY_WARNING: [#def44] tmpfiles/src/lib.rs:85:5: warning: matching on `Some` with `ok()` is redundant # | # 85 | if let Some(s) = path.as_os_str().as_str().ok() { # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok # = note: `#[warn(clippy::match_result_ok)]` on by default # help: consider matching on `Ok(s)` and removing the call to `ok` instead # | # 85 - if let Some(s) = path.as_os_str().as_str().ok() { # 85 + if let Ok(s) = path.as_os_str().as_str() { # | Error: CLIPPY_WARNING: [#def45] tmpfiles/src/lib.rs:141:21: warning: unnecessary closure used to substitute value for `Option::None` # | # 141 | / src.next() # 142 | | .ok_or_else(|| Error::MalformedTmpfilesPath)? # | |____________________________________________________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations # = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default # help: use `ok_or` instead # | # 142 - .ok_or_else(|| Error::MalformedTmpfilesPath)? # 142 + .ok_or(Error::MalformedTmpfilesPath)? # | Error: CLIPPY_WARNING: [#def46] tmpfiles/src/lib.rs:146:21: warning: unnecessary closure used to substitute value for `Option::None` # | # 146 | / src.next() # 147 | | .ok_or_else(|| Error::MalformedTmpfilesPath)? # | |____________________________________________________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations # help: use `ok_or` instead # | # 147 - .ok_or_else(|| Error::MalformedTmpfilesPath)? # 147 + .ok_or(Error::MalformedTmpfilesPath)? # | Error: CLIPPY_WARNING: [#def47] tmpfiles/src/lib.rs:165:12: warning: redundant pattern matching, consider using `is_some()` # | # 165 | if let Some(_) = src.next_if_eq(&b'"') { # | -------^^^^^^^------------------------ help: try: `if src.next_if_eq(&b'"').is_some()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching # = note: `#[warn(clippy::redundant_pattern_matching)]` on by default Error: CLIPPY_WARNING: [#def48] tmpfiles/src/lib.rs:326:1: warning: this function has too many arguments (8/7) # | # 326 | / fn convert_path_to_tmpfiles_d_recurse<U: uzers::Users, G: uzers::Groups>( # 327 | | out_entries: &mut BTreeSet<String>, # 328 | | out_unsupported: &mut Vec<PathBuf>, # 329 | | users: &U, # ... | # 334 | | readonly: bool, # 335 | | ) -> Result<()> { # | |_______________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments # = note: `#[warn(clippy::too_many_arguments)]` on by default Error: CLIPPY_WARNING: [#def49] tmpfiles/src/lib.rs:357:28: warning: unnecessary closure used to substitute value for `Option::None` # | # 357 | let user = users # | ____________________________^ # 358 | | .get_user_by_uid(meta.uid()) # 359 | | .ok_or_else(|| Error::UserNotFound(uid))?; # | |____________________________________________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations # help: use `ok_or` instead # | # 359 - .ok_or_else(|| Error::UserNotFound(uid))?; # 359 + .ok_or(Error::UserNotFound(uid))?; # | Error: CLIPPY_WARNING: [#def50] tmpfiles/src/lib.rs:365:29: warning: unnecessary closure used to substitute value for `Option::None` # | # 365 | let group = groups # | _____________________________^ # 366 | | .get_group_by_gid(gid) # 367 | | .ok_or_else(|| Error::GroupNotFound(gid))?; # | |_____________________________________________________________^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations # help: use `ok_or` instead # | # 367 - .ok_or_else(|| Error::GroupNotFound(gid))?; # 367 + .ok_or(Error::GroupNotFound(gid))?; # | Error: CLIPPY_WARNING: [#def51] tmpfiles/src/lib.rs:502:15: warning: redundant pattern matching, consider using `is_some()` # | # 502 | while let Some(_) = it.next_if(|c| c.is_ascii_whitespace()) {} # | ----------^^^^^^^------------------------------------------ help: try: `while it.next_if(|c| c.is_ascii_whitespace()).is_some()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching Error: CLIPPY_WARNING: [#def52] tmpfiles/src/lib.rs:505:15: warning: redundant pattern matching, consider using `is_some()` # | # 505 | while let Some(_) = it.next_if(|c| !c.is_ascii_whitespace()) { # | ----------^^^^^^^------------------------------------------- help: try: `while it.next_if(|c| !c.is_ascii_whitespace()).is_some()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching Error: CLIPPY_WARNING: [#def53] tmpfiles/src/lib.rs:512:15: warning: redundant pattern matching, consider using `is_some()` # | # 512 | while let Some(_) = it.next_if(|c| c.is_ascii_whitespace()) {} # | ----------^^^^^^^------------------------------------------ help: try: `while it.next_if(|c| c.is_ascii_whitespace()).is_some()` # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching Error: CLIPPY_WARNING: [#def54] utils/src/path.rs:22:6: warning: the following explicit lifetimes could be elided: 'a # | # 22 | impl<'a> Display for PathQuotedDisplay<'a> { # | ^^ ^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes # = note: `#[warn(clippy::needless_lifetimes)]` on by default # help: elide the lifetimes # | # 22 - impl<'a> Display for PathQuotedDisplay<'a> { # 22 + impl Display for PathQuotedDisplay<'_> { # | Error: CLIPPY_WARNING: [#def55] utils/src/path.rs:34:9: warning: unneeded `return` statement # | # 34 | return Err(std::fmt::Error); # | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ # | # = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return # = note: `#[warn(clippy::needless_return)]` on by default # help: remove `return` # | # 34 - return Err(std::fmt::Error); # 34 + Err(std::fmt::Error) # |
| analyzer-version-clippy | 1.86.0 |
| analyzer-version-cppcheck | 2.17.1 |
| analyzer-version-gcc | 15.1.1 |
| analyzer-version-gcc-analyzer | 15.1.1 |
| analyzer-version-shellcheck | 0.10.0 |
| analyzer-version-unicontrol | 0.0.2 |
| enabled-plugins | clippy, cppcheck, gcc, shellcheck, unicontrol |
| exit-code | 0 |
| host | ip-172-16-1-41.us-west-2.compute.internal |
| known-false-positives | /usr/share/csmock/known-false-positives.js |
| known-false-positives-rpm | known-false-positives-0.0.0.20250509.165649.g41c6174.main-1.el9.noarch |
| mock-config | fedora-rawhide-x86_64 |
| project-name | bootc-202505122117.g8785dcb3da-1 |
| store-results-to | /tmp/tmph2etbjgs/bootc-202505122117.g8785dcb3da-1.tar.xz |
| time-created | 2025-05-12 21:53:29 |
| time-finished | 2025-05-12 22:00:52 |
| tool | csmock |
| tool-args | '/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,cppcheck,gcc,clippy,shellcheck' '-o' '/tmp/tmph2etbjgs/bootc-202505122117.g8785dcb3da-1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmph2etbjgs/bootc-202505122117.g8785dcb3da-1.src.rpm' |
| tool-version | csmock-3.8.1.20250422.172604.g26bc3d6-1.el9 |