Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-477): [#def1]
spglib-2.6.0/python/py_bindings.cpp: scope_hint: In function ‘std::optional<pybind11::list> spglib::layer_dataset(array_double, array_double, array_int, pybind11::int_, pybind11::float_)’
spglib-2.6.0/python/py_bindings.cpp:254:41: warning[-Wdeprecated-declarations]: ‘SpglibDataset* spg_get_layer_dataset(const double (*)[3], const double (*)[3], const int*, int, int, double)’ is deprecated: Experimental interface. May be removed in next major release.
#  254 |     if ((dataset = spg_get_layer_dataset(
#      |                    ~~~~~~~~~~~~~~~~~~~~~^
#  255 |              (double (*)[3])lattice.data(), (double (*)[3])positions.data(),
#      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  256 |              atom_types.data(), atom_types.size(), aperiodic_dir, symprec)) ==
#      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
spglib-2.6.0/python/py_bindings.cpp:4: included_from: Included from here.
spglib-2.6.0/include/spglib.h:212:24: note: declared here
#  212 | SPG_API SpglibDataset *spg_get_layer_dataset(
#      |                        ^~~~~~~~~~~~~~~~~~~~~
#  252|                                                 py::float_ symprec) {
#  253|       SpglibDataset* dataset;
#  254|->     if ((dataset = spg_get_layer_dataset(
#  255|                (double (*)[3])lattice.data(), (double (*)[3])positions.data(),
#  256|                atom_types.data(), atom_types.size(), aperiodic_dir, symprec)) ==

Error: COMPILER_WARNING (CWE-457): [#def2]
spglib-2.6.0/src/spacegroup.c:1064:17: warning[-Wmaybe-uninitialized]: ‘num_free_axes’ may be used uninitialized
# 1064 |             if (match_hall_symbol_db_ortho(origin_shift, conv_lattice,
#      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1065 |                                            orig_lattice, hall_number, centering,
#      |                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1066 |                                            symmetry, num_free_axes, symprec)) {
#      |                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
spglib-2.6.0/src/spacegroup.c: scope_hint: In function ‘search_hall_number’
spglib-2.6.0/src/spacegroup.c:996:19: note: ‘num_free_axes’ was declared here
#  996 |     int is_found, num_free_axes;
#      |                   ^~~~~~~~~~~~~
# 1062|               }
# 1063|   
# 1064|->             if (match_hall_symbol_db_ortho(origin_shift, conv_lattice,
# 1065|                                              orig_lattice, hall_number, centering,
# 1066|                                              symmetry, num_free_axes, symprec)) {

Scan Properties