Newly introduced findings

List of Findings

Error: COMPILER_WARNING (CWE-477): [#def1]
spglib-2.6.0/python/py_bindings.cpp: scope_hint: In function ‘std::optional<pybind11::list> spglib::layer_dataset(array_double, array_double, array_int, pybind11::int_, pybind11::float_)’
spglib-2.6.0/python/py_bindings.cpp:256:41: warning[-Wdeprecated-declarations]: ‘SpglibDataset* spg_get_layer_dataset(const double (*)[3], const double (*)[3], const int*, int, int, double)’ is deprecated: Experimental interface. May be removed in next major release.
#  256 |     if ((dataset = spg_get_layer_dataset((double (*)[3])lattice.data(),
#      |                    ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  257 |                                          (double (*)[3])positions.data(),
#      |                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  258 |                                          atom_types.data(), atom_types.size(),
#      |                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  259 |                                          aperiodic_dir, symprec)) == nullptr)
#      |                                          ~~~~~~~~~~~~~~~~~~~~~~~
spglib-2.6.0/python/py_bindings.cpp:4: included_from: Included from here.
spglib-2.6.0/include/spglib.h:213:1: note: declared here
#  213 | spg_get_layer_dataset(double const lattice[3][3], double const position[][3],
#      | ^~~~~~~~~~~~~~~~~~~~~
#  254|                                                 py::float_ symprec) {
#  255|       SpglibDataset *dataset;
#  256|->     if ((dataset = spg_get_layer_dataset((double (*)[3])lattice.data(),
#  257|                                            (double (*)[3])positions.data(),
#  258|                                            atom_types.data(), atom_types.size(),

Error: COMPILER_WARNING (CWE-457): [#def2]
spglib-2.6.0/src/spacegroup.c:1066:13: warning[-Wmaybe-uninitialized]: ‘num_free_axes’ may be used uninitialized
# 1066 |         if (match_hall_symbol_db_ortho(origin_shift, conv_lattice, orig_lattice,
#      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1067 |                                        hall_number, centering, symmetry,
#      |                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# 1068 |                                        num_free_axes, symprec)) {
#      |                                        ~~~~~~~~~~~~~~~~~~~~~~~
spglib-2.6.0/src/spacegroup.c: scope_hint: In function ‘search_hall_number’
spglib-2.6.0/src/spacegroup.c:999:19: note: ‘num_free_axes’ was declared here
#  999 |     int is_found, num_free_axes;
#      |                   ^~~~~~~~~~~~~
# 1064|           }
# 1065|   
# 1066|->         if (match_hall_symbol_db_ortho(origin_shift, conv_lattice, orig_lattice,
# 1067|                                          hall_number, centering, symmetry,
# 1068|                                          num_free_axes, symprec)) {

Scan Properties