Task #54 - flatpak-1.15.8-1.fc41/scan-results.err
back to task #54download
Error: SHELLCHECK_WARNING (CWE-758):
/etc/profile.d/flatpak.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
# 1|-> if command -v flatpak > /dev/null; then
# 2| # set XDG_DATA_DIRS to include Flatpak installations
# 3|
Error: SHELLCHECK_WARNING (CWE-758):
/usr/libexec/installed-tests/Flatpak/installed-tests.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
# 1|-> # Copyright 2024 Collabora Ltd.
# 2| # SPDX-License-Identifier: LGPL-2.1-or-later
# 3|
Error: SHELLCHECK_WARNING (CWE-563):
/usr/libexec/installed-tests/Flatpak/installed-tests.sh:4:1: warning[SC2034]: FUSERMOUNT appears unused. Verify use (or export if used externally).
# 2| # SPDX-License-Identifier: LGPL-2.1-or-later
# 3|
# 4|-> FUSERMOUNT='/usr/bin/fusermount3'
Error: SHELLCHECK_WARNING (CWE-758):
/usr/libexec/installed-tests/Flatpak/libtest.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
# 1|-> # Source library for shell script tests
# 2| #
# 3| # Copyright (C) 2016 Alexander Larsson <alexl@redhat.com>
Error: SHELLCHECK_WARNING (CWE-88):
/usr/libexec/installed-tests/Flatpak/libtest.sh:52:10: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
# 50| assert_not_reached () {
# 51| { { local BASH_XTRACEFD=3; } 2> /dev/null
# 52|-> echo $@ 1>&2; exit 1
# 53| } 3> /dev/null
# 54| }
Error: SHELLCHECK_WARNING (CWE-138):
/usr/libexec/installed-tests/Flatpak/libtest.sh:58:18: error[SC2145]: Argument mixes string and array. Use * or separate argument.
# 56| ok () {
# 57| { { local BASH_XTRACEFD=3; } 2> /dev/null
# 58|-> echo "ok $@";
# 59| echo "================ $(basename ${BASH_SOURCE[1]}):${BASH_LINENO[0]} - $@ ================" >&2;
# 60| } 3> /dev/null
Error: SHELLCHECK_WARNING (CWE-138):
/usr/libexec/installed-tests/Flatpak/libtest.sh:59:82: error[SC2145]: Argument mixes string and array. Use * or separate argument.
# 57| { { local BASH_XTRACEFD=3; } 2> /dev/null
# 58| echo "ok $@";
# 59|-> echo "================ $(basename ${BASH_SOURCE[1]}):${BASH_LINENO[0]} - $@ ================" >&2;
# 60| } 3> /dev/null
# 61| }
Error: SHELLCHECK_WARNING (CWE-571):
/usr/libexec/installed-tests/Flatpak/libtest.sh:128:8: warning[SC2155]: Declare and assign separately to avoid masking return values.
# 126| export USERDIR=${TEST_DATA_DIR}/home/share/flatpak
# 127| export SYSTEMDIR=${TEST_DATA_DIR}/system
# 128|-> export ARCH=`flatpak --default-arch`
# 129|
# 130| if [ x${SUMMARY_FORMAT-} == xold ] ; then
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/libtest.sh:278:77: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 276| assert_remote_has_no_config () {
# 277| { { local BASH_XTRACEFD=3; } 2> /dev/null
# 278|-> if ostree config --repo=$FL_DIR/repo get --group 'remote "'"$1"'"' "$2" > /dev/null &> /dev/null; then
# 279| echo 1>&2 "Remote '$1' unexpectedly has key '$2' at $(basename ${BASH_SOURCE[1]}):${BASH_LINENO[0]}"
# 280| exit 1
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/libtest.sh:278:90: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 276| assert_remote_has_no_config () {
# 277| { { local BASH_XTRACEFD=3; } 2> /dev/null
# 278|-> if ostree config --repo=$FL_DIR/repo get --group 'remote "'"$1"'"' "$2" > /dev/null &> /dev/null; then
# 279| echo 1>&2 "Remote '$1' unexpectedly has key '$2' at $(basename ${BASH_SOURCE[1]}):${BASH_LINENO[0]}"
# 280| exit 1
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/libtest.sh:290:4: warning[SC2046]: Quote this to prevent word splitting.
# 288| mkdir -p ${FL_GPG_HOMEDIR2}
# 289| # This need to be writable, so copy the keys
# 290|-> cp $(dirname $0)/test-keyring/*.gpg ${FL_GPG_HOMEDIR}/
# 291| cp $(dirname $0)/test-keyring2/*.gpg ${FL_GPG_HOMEDIR2}/
# 292|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/libtest.sh:291:4: warning[SC2046]: Quote this to prevent word splitting.
# 289| # This need to be writable, so copy the keys
# 290| cp $(dirname $0)/test-keyring/*.gpg ${FL_GPG_HOMEDIR}/
# 291|-> cp $(dirname $0)/test-keyring2/*.gpg ${FL_GPG_HOMEDIR2}/
# 292|
# 293| export FL_GPG_ID=7B0961FD
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/libtest.sh:316:17: warning[SC2046]: Quote this to prevent word splitting.
# 314| flock -s 200
# 315| if [ ! -d ${RUNTIME_REPO} ]; then
# 316|-> $(dirname $0)/make-test-runtime.sh ${RUNTIME_REPO} org.test.Platform ${BRANCH} "" "" > /dev/null
# 317| fi
# 318| ) 200>${TEST_DATA_DIR}/runtime-repo-lock
Error: SHELLCHECK_WARNING (CWE-685):
/usr/libexec/installed-tests/Flatpak/libtest.sh:334:1: warning[SC2120]: httpd references arguments, but none are ever passed.
# 332| }
# 333|
# 334|-> httpd () {
# 335| COMMAND=${1:-web-server.py}
# 336| DIR=${2:-repos}
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/libtest.sh:340:24: warning[SC2046]: Quote this to prevent word splitting.
# 338| rm -f httpd-pipe
# 339| mkfifo httpd-pipe
# 340|-> PYTHONUNBUFFERED=1 $(dirname $0)/$COMMAND "$DIR" 3> httpd-pipe 2>&1 | tee --append httpd-log >&2 &
# 341| read < httpd-pipe
# 342| }
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/libtest.sh:358:41: warning[SC2046]: Quote this to prevent word splitting.
# 356|
# 357| make_runtime "${REPONAME}" "${COLLECTION_ID}" "${BRANCH}" "${GPGARGS:-${FL_GPGARGS}}"
# 358|-> GPGARGS="${GPGARGS:-${FL_GPGARGS}}" $(dirname $0)/make-test-app.sh repos/${REPONAME} "" "${BRANCH}" "${COLLECTION_ID}" > /dev/null
# 359| update_repo $REPONAME "${COLLECTION_ID}"
# 360| if [ $REPONAME == "test" ]; then
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/libtest.sh:448:72: warning[SC2046]: Quote this to prevent word splitting.
# 446| RUNTIME_BRANCH=${6:-$BRANCH}
# 447|
# 448|-> RUNTIME_BRANCH=$RUNTIME_BRANCH GPGARGS="${GPGARGS:-${FL_GPGARGS}}" $(dirname $0)/make-test-app.sh repos/${REPONAME} "${APP_ID}" "${BRANCH}" "${COLLECTION_ID}" "${TEXT}" > /dev/null
# 449| update_repo $REPONAME "${COLLECTION_ID}"
# 450| }
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/libtest.sh:462:41: warning[SC2046]: Quote this to prevent word splitting.
# 460| TEXT=${4:-UPDATED}
# 461|
# 462|-> GPGARGS="${GPGARGS:-${FL_GPGARGS}}" $(dirname $0)/make-test-runtime.sh repos/${REPONAME} org.test.Platform "${BRANCH}" "${COLLECTION_ID}" "${TEXT}" > /dev/null
# 463| update_repo $REPONAME "${COLLECTION_ID}"
# 464| }
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/libtest.sh:475:43: warning[SC2046]: Quote this to prevent word splitting.
# 473| BRANCH=${3:-master}
# 474|
# 475|-> GPGARGS="${GPGARGS:-${FL_GPGARGS}}" . $(dirname $0)/make-test-runtime.sh repos/${REPONAME} org.test.Sdk "${BRANCH}" "${COLLECTION_ID}" "" make mkdir cp touch > /dev/null
# 476| update_repo $REPONAME "${COLLECTION_ID}"
# 477| }
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/libtest.sh:500:114: warning[SC2046]: Quote this to prevent word splitting.
# 498| BUSSOCK=$(mktemp ${test_tmpdir}/bus.XXXXXX)
# 499| rm -rf ${BUSSOCK}
# 500|-> run --command=socat --filesystem=${test_tmpdir} org.test.Hello unix-listen:${BUSSOCK} unix-connect:/run/user/`id -u`/bus &
# 501| while [ ! -e ${BUSSOCK} ]; do sleep 1; done
# 502| DBUS_SESSION_BUS_ADDRESS="unix:path=${BUSSOCK}" "$@"
Error: SHELLCHECK_WARNING (CWE-571):
/usr/libexec/installed-tests/Flatpak/libtest.sh:595:8: warning[SC2155]: Declare and assign separately to avoid masking return values.
# 593| dbus-daemon --fork --config-file=session.conf --print-address=3 --print-pid=4 \
# 594| 3> dbus-session-bus-address 4> dbus-session-bus-pid
# 595|-> export DBUS_SESSION_BUS_ADDRESS="$(cat dbus-session-bus-address)"
# 596| DBUS_SESSION_BUS_PID="$(cat dbus-session-bus-pid)"
# 597|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/libtest.sh:616:10: warning[SC2046]: Quote this to prevent word splitting.
# 614| gpg-connect-agent --homedir "${FL_GPG_HOMEDIR}" killagent /bye >&2 || true
# 615| "${FUSERMOUNT}" -u $XDG_RUNTIME_DIR/doc >&2 || :
# 616|-> kill $(jobs -p) &> /dev/null || true
# 617| if test -n "${TEST_SKIP_CLEANUP:-}"; then
# 618| echo "# Skipping cleanup of ${TEST_DATA_DIR}"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/make-multi-collection-id-repo.sh:28:3: warning[SC2046]: Quote this to prevent word splitting.
# 26| set -e
# 27|
# 28|-> . $(dirname $0)/libtest.sh
# 29|
# 30| REPO_DIR=$1
Error: SHELLCHECK_WARNING (CWE-563):
/usr/libexec/installed-tests/Flatpak/make-multi-collection-id-repo.sh:31:1: warning[SC2034]: REPO_NAME appears unused. Verify use (or export if used externally).
# 29|
# 30| REPO_DIR=$1
# 31|-> REPO_NAME=$(basename $REPO_DIR)
# 32|
# 33| COLLECTION_ID_PREFIX=org.test.Collection
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/make-multi-collection-id-repo.sh:43:5: warning[SC2046]: Quote this to prevent word splitting.
# 41| COLLECTION_ID=${COLLECTION_ID_PREFIX}${i}
# 42|
# 43|-> $(dirname $0)/make-test-app.sh repos/${APP_REPO} ${APP_ID} master ${COLLECTION_ID}
# 44| ref=$(ostree --repo=${APP_REPO_DIR} refs | grep ${APP_ID})
# 45|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/make-test-app.sh:118:4: warning[SC2046]: Quote this to prevent word splitting.
# 116|
# 117| mkdir -p ${DIR}/files/share/icons/hicolor/64x64/apps
# 118|-> cp $(dirname $0)/org.test.Hello.png ${DIR}/files/share/icons/hicolor/64x64/apps/${APP_ID}.png
# 119| cp $(dirname $0)/org.test.Hello.png ${DIR}/files/share/icons/hicolor/64x64/apps/dont-export.png
# 120| mkdir -p ${DIR}/files/share/icons/HighContrast/64x64/apps
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/make-test-app.sh:119:4: warning[SC2046]: Quote this to prevent word splitting.
# 117| mkdir -p ${DIR}/files/share/icons/hicolor/64x64/apps
# 118| cp $(dirname $0)/org.test.Hello.png ${DIR}/files/share/icons/hicolor/64x64/apps/${APP_ID}.png
# 119|-> cp $(dirname $0)/org.test.Hello.png ${DIR}/files/share/icons/hicolor/64x64/apps/dont-export.png
# 120| mkdir -p ${DIR}/files/share/icons/HighContrast/64x64/apps
# 121| cp $(dirname $0)/org.test.Hello.png ${DIR}/files/share/icons/HighContrast/64x64/apps/${APP_ID}.png
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/make-test-app.sh:121:4: warning[SC2046]: Quote this to prevent word splitting.
# 119| cp $(dirname $0)/org.test.Hello.png ${DIR}/files/share/icons/hicolor/64x64/apps/dont-export.png
# 120| mkdir -p ${DIR}/files/share/icons/HighContrast/64x64/apps
# 121|-> cp $(dirname $0)/org.test.Hello.png ${DIR}/files/share/icons/HighContrast/64x64/apps/${APP_ID}.png
# 122|
# 123|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/make-test-app.sh:167:4: warning[SC2046]: Quote this to prevent word splitting.
# 165| gzip -c ${DIR}/files/share/metainfo/${APP_ID}.metainfo.xml > ${DIR}/files/share/app-info/xmls/${APP_ID}.xml.gz
# 166| gzip -c ${DIR}/files/share/appdata/${APP_ID}.cmd.appdata.xml > ${DIR}/files/share/app-info/xmls/${APP_ID}.cmd.xml.gz
# 167|-> cp $(dirname $0)/org.test.Hello.png ${DIR}/files/share/app-info/icons/flatpak/64x64/${APP_ID}.png
# 168|
# 169| if [ x$COLLECTION_ID != x ]; then
Error: SHELLCHECK_WARNING (CWE-571):
/usr/libexec/installed-tests/Flatpak/make-test-runtime.sh:66:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
# 64| (ldd "${f}" | sed "s/.* => //" | awk '{ print $1}' | grep ^/ | sort -u -o $LIBS $LIBS -) || true
# 65|
# 66|-> local shebang=$(sed -n '1s/^#!\([^ ]*\).*/\1/p' "${f}")
# 67| if [ x$shebang != x ]; then
# 68| add_bin "$shebang"
Error: SHELLCHECK_WARNING (CWE-88):
/usr/libexec/installed-tests/Flatpak/make-test-runtime.sh:72:10: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
# 70| }
# 71|
# 72|-> for i in $@ bash ls cat echo readlink socat; do
# 73| I=$(type -P "$i")
# 74| add_bin "$I"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-auth.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-auth.sh:30:18: warning[SC2046]: Quote this to prevent word splitting.
# 28|
# 29| commit_to_obj () {
# 30|-> echo objects/$(echo $1 | cut -b 1-2)/$(echo $1 | cut -b 3-).commit
# 31| }
# 32|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-auth.sh:30:42: warning[SC2046]: Quote this to prevent word splitting.
# 28|
# 29| commit_to_obj () {
# 30|-> echo objects/$(echo $1 | cut -b 1-2)/$(echo $1 | cut -b 3-).commit
# 31| }
# 32|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-auth.sh:39:34: warning[SC2046]: Quote this to prevent word splitting.
# 37|
# 38| COMMIT=$(cat repos/$REPO/refs/heads/$REF)
# 39|-> echo -n $TOKEN > repos/$REPO/$(commit_to_obj $COMMIT).need_token
# 40| }
# 41|
Error: SHELLCHECK_WARNING (CWE-685):
/usr/libexec/installed-tests/Flatpak/test-auth.sh:42:1: warning[SC2120]: assert_failed_with_401 references arguments, but none are ever passed.
# 40| }
# 41|
# 42|-> assert_failed_with_401 () {
# 43| LOGFILE=${1:-install-error-log}
# 44| assert_file_has_content $LOGFILE "401"
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-auth.sh:89:76: warning[SC2154]: port is referenced but not assigned.
# 87| ${FLATPAK} ${U} install -y test-repo org.test.Hello master >&2
# 88| assert_file_has_content ${XDG_RUNTIME_DIR}/request "^remote: test-repo$"
# 89|-> assert_file_has_content ${XDG_RUNTIME_DIR}/request "^uri: http://127.0.0.1:${port}/test$"
# 90| if [ x${USE_COLLECTIONS_IN_CLIENT-} == xyes ] ; then
# 91| assert_file_has_content ${XDG_RUNTIME_DIR}/request "^options: .*'collection-id': <'org.test.Collection.test'>"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-basic.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| # This test looks for specific localized strings.
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-basic.sh:31:15: warning[SC2154]: test_builddir is referenced but not assigned.
# 29| ${FLATPAK} --version > version_out
# 30|
# 31|-> VERSION=`cat "$test_builddir/package_version.txt"`
# 32| assert_file_has_content version_out "^Flatpak $VERSION$"
# 33|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-basic.sh:46:14: warning[SC2046]: Quote this to prevent word splitting.
# 44| ${FLATPAK} --supported-arches > arches
# 45|
# 46|-> assert_streq `head -1 arches` `cat arch`
# 47|
# 48| ok "default arch"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-basic.sh:46:31: warning[SC2046]: Quote this to prevent word splitting.
# 44| ${FLATPAK} --supported-arches > arches
# 45|
# 46|-> assert_streq `head -1 arches` `cat arch`
# 47|
# 48| ok "default arch"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-build-update-repo.sh:25:3: warning[SC2046]: Quote this to prevent word splitting.
# 23| set -euo pipefail
# 24|
# 25|-> . $(dirname $0)/libtest.sh
# 26|
# 27| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:33:54: warning[SC2046]: Quote this to prevent word splitting.
# 31| setup_repo
# 32|
# 33|-> ${FLATPAK} build-bundle repos/test --repo-url=file://`pwd`/repos/test --gpg-keys=${FL_GPG_HOMEDIR}/pubring.gpg bundles/hello.flatpak org.test.Hello >&2
# 34| assert_has_file bundles/hello.flatpak
# 35|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:36:64: warning[SC2046]: Quote this to prevent word splitting.
# 34| assert_has_file bundles/hello.flatpak
# 35|
# 36|-> ${FLATPAK} build-bundle repos/test --runtime --repo-url=file://`pwd`/repos/test --gpg-keys=${FL_GPG_HOMEDIR}/pubring.gpg bundles/platform.flatpak org.test.Platform >&2
# 37| assert_has_file bundles/platform.flatpak
# 38|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:43:56: warning[SC2046]: Quote this to prevent word splitting.
# 41| rm bundles/hello.flatpak
# 42| ${FLATPAK} ${U} install -y test-repo org.test.Hello >&2
# 43|-> ${FLATPAK} build-bundle $FL_DIR/repo --repo-url=file://`pwd`/repos/test --gpg-keys=${FL_GPG_HOMEDIR}/pubring.gpg bundles/hello.flatpak org.test.Hello >&2
# 44| assert_has_file bundles/hello.flatpak
# 45|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:56:38: warning[SC2046]: Quote this to prevent word splitting.
# 54| assert_has_file $FL_DIR/repo/refs/remotes/hello-origin/app/org.test.Hello/$ARCH/master
# 55| APP_COMMIT=`cat $FL_DIR/repo/refs/remotes/hello-origin/app/org.test.Hello/$ARCH/master`
# 56|-> assert_has_file $FL_DIR/repo/objects/$(echo $APP_COMMIT | cut -b 1-2)/$(echo $APP_COMMIT | cut -b 3-).commit
# 57| assert_has_file $FL_DIR/repo/objects/$(echo $APP_COMMIT | cut -b 1-2)/$(echo $APP_COMMIT | cut -b 3-).commitmeta
# 58|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:56:71: warning[SC2046]: Quote this to prevent word splitting.
# 54| assert_has_file $FL_DIR/repo/refs/remotes/hello-origin/app/org.test.Hello/$ARCH/master
# 55| APP_COMMIT=`cat $FL_DIR/repo/refs/remotes/hello-origin/app/org.test.Hello/$ARCH/master`
# 56|-> assert_has_file $FL_DIR/repo/objects/$(echo $APP_COMMIT | cut -b 1-2)/$(echo $APP_COMMIT | cut -b 3-).commit
# 57| assert_has_file $FL_DIR/repo/objects/$(echo $APP_COMMIT | cut -b 1-2)/$(echo $APP_COMMIT | cut -b 3-).commitmeta
# 58|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:57:38: warning[SC2046]: Quote this to prevent word splitting.
# 55| APP_COMMIT=`cat $FL_DIR/repo/refs/remotes/hello-origin/app/org.test.Hello/$ARCH/master`
# 56| assert_has_file $FL_DIR/repo/objects/$(echo $APP_COMMIT | cut -b 1-2)/$(echo $APP_COMMIT | cut -b 3-).commit
# 57|-> assert_has_file $FL_DIR/repo/objects/$(echo $APP_COMMIT | cut -b 1-2)/$(echo $APP_COMMIT | cut -b 3-).commitmeta
# 58|
# 59| assert_has_dir $FL_DIR/app/org.test.Hello
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:57:71: warning[SC2046]: Quote this to prevent word splitting.
# 55| APP_COMMIT=`cat $FL_DIR/repo/refs/remotes/hello-origin/app/org.test.Hello/$ARCH/master`
# 56| assert_has_file $FL_DIR/repo/objects/$(echo $APP_COMMIT | cut -b 1-2)/$(echo $APP_COMMIT | cut -b 3-).commit
# 57|-> assert_has_file $FL_DIR/repo/objects/$(echo $APP_COMMIT | cut -b 1-2)/$(echo $APP_COMMIT | cut -b 3-).commitmeta
# 58|
# 59| assert_has_dir $FL_DIR/app/org.test.Hello
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:104:38: warning[SC2046]: Quote this to prevent word splitting.
# 102| assert_has_file $FL_DIR/repo/refs/remotes/platform-origin/runtime/org.test.Platform/$ARCH/master
# 103| RUNTIME_COMMIT=`cat $FL_DIR/repo/refs/remotes/platform-origin/runtime/org.test.Platform/$ARCH/master`
# 104|-> assert_has_file $FL_DIR/repo/objects/$(echo $RUNTIME_COMMIT | cut -b 1-2)/$(echo $RUNTIME_COMMIT | cut -b 3-).commit
# 105| assert_has_file $FL_DIR/repo/objects/$(echo $RUNTIME_COMMIT | cut -b 1-2)/$(echo $RUNTIME_COMMIT | cut -b 3-).commitmeta
# 106|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:104:75: warning[SC2046]: Quote this to prevent word splitting.
# 102| assert_has_file $FL_DIR/repo/refs/remotes/platform-origin/runtime/org.test.Platform/$ARCH/master
# 103| RUNTIME_COMMIT=`cat $FL_DIR/repo/refs/remotes/platform-origin/runtime/org.test.Platform/$ARCH/master`
# 104|-> assert_has_file $FL_DIR/repo/objects/$(echo $RUNTIME_COMMIT | cut -b 1-2)/$(echo $RUNTIME_COMMIT | cut -b 3-).commit
# 105| assert_has_file $FL_DIR/repo/objects/$(echo $RUNTIME_COMMIT | cut -b 1-2)/$(echo $RUNTIME_COMMIT | cut -b 3-).commitmeta
# 106|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:105:38: warning[SC2046]: Quote this to prevent word splitting.
# 103| RUNTIME_COMMIT=`cat $FL_DIR/repo/refs/remotes/platform-origin/runtime/org.test.Platform/$ARCH/master`
# 104| assert_has_file $FL_DIR/repo/objects/$(echo $RUNTIME_COMMIT | cut -b 1-2)/$(echo $RUNTIME_COMMIT | cut -b 3-).commit
# 105|-> assert_has_file $FL_DIR/repo/objects/$(echo $RUNTIME_COMMIT | cut -b 1-2)/$(echo $RUNTIME_COMMIT | cut -b 3-).commitmeta
# 106|
# 107| assert_has_dir $FL_DIR/runtime/org.test.Platform
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:105:75: warning[SC2046]: Quote this to prevent word splitting.
# 103| RUNTIME_COMMIT=`cat $FL_DIR/repo/refs/remotes/platform-origin/runtime/org.test.Platform/$ARCH/master`
# 104| assert_has_file $FL_DIR/repo/objects/$(echo $RUNTIME_COMMIT | cut -b 1-2)/$(echo $RUNTIME_COMMIT | cut -b 3-).commit
# 105|-> assert_has_file $FL_DIR/repo/objects/$(echo $RUNTIME_COMMIT | cut -b 1-2)/$(echo $RUNTIME_COMMIT | cut -b 3-).commitmeta
# 106|
# 107| assert_has_dir $FL_DIR/runtime/org.test.Platform
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-bundle.sh:161:54: warning[SC2046]: Quote this to prevent word splitting.
# 159| make_updated_app test org.test.Collection.test master UPDATED2
# 160|
# 161|-> ${FLATPAK} build-bundle repos/test --repo-url=file://`pwd`/repos/test --gpg-keys=${FL_GPG_HOMEDIR}/pubring.gpg bundles/hello2.flatpak org.test.Hello >&2
# 162| assert_has_file bundles/hello2.flatpak
# 163|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-completion.sh:23:3: warning[SC2046]: Quote this to prevent word splitting.
# 21|
# 22| #FLATPAK=flatpak
# 23|-> . $(dirname $0)/libtest.sh
# 24|
# 25| skip_revokefs_without_fuse
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-config.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| # This test looks for specific localized strings.
Error: SHELLCHECK_WARNING (CWE-563):
/usr/libexec/installed-tests/Flatpak/test-default-remotes.sh:22:1: warning[SC2034]: USE_SYSTEMDIR appears unused. Verify use (or export if used externally).
# 20| set -euo pipefail
# 21|
# 22|-> USE_SYSTEMDIR=yes
# 23|
# 24| . $(dirname $0)/libtest.sh
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-default-remotes.sh:24:3: warning[SC2046]: Quote this to prevent word splitting.
# 22| USE_SYSTEMDIR=yes
# 23|
# 24|-> . $(dirname $0)/libtest.sh
# 25|
# 26| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-default-remotes.sh:118:14: warning[SC2154]: test_builddir is referenced but not assigned.
# 116|
# 117| cp added-default.flatpakrepo $FLATPAK_CONFIG_DIR/remotes.d/
# 118|-> echo "Filter=${test_builddir}/test.filter" >> $FLATPAK_CONFIG_DIR/remotes.d/added-default.flatpakrepo
# 119|
# 120| ${FLATPAK} --system remotes > remotes
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-extensions.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-571):
/usr/libexec/installed-tests/Flatpak/test-extensions.sh:32:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
# 30| local VERSION=$2
# 31|
# 32|-> local DIR=`mktemp -d`
# 33|
# 34| cat > ${DIR}/metadata <<EOF
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-extensions.sh:99:1: warning[SC2046]: Quote this to prevent word splitting.
# 97| mkdir -p repos
# 98| ostree init --repo=repos/test --mode=archive-z2
# 99|-> $(dirname $0)/make-test-runtime.sh repos/test org.test.Platform master "" "" bash ls cat echo readlink > /dev/null
# 100| $(dirname $0)/make-test-app.sh repos/test "" master "" > /dev/null
# 101|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-extensions.sh:100:1: warning[SC2046]: Quote this to prevent word splitting.
# 98| ostree init --repo=repos/test --mode=archive-z2
# 99| $(dirname $0)/make-test-runtime.sh repos/test org.test.Platform master "" "" bash ls cat echo readlink > /dev/null
# 100|-> $(dirname $0)/make-test-app.sh repos/test "" master "" > /dev/null
# 101|
# 102| # Modify platform metadata
Error: SHELLCHECK_WARNING (CWE-563):
/usr/libexec/installed-tests/Flatpak/test-history.sh:7:1: warning[SC2034]: USE_SYSTEMDIR appears unused. Verify use (or export if used externally).
# 5| set -euo pipefail
# 6|
# 7|-> USE_SYSTEMDIR=yes
# 8|
# 9| . $(dirname $0)/libtest.sh
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-history.sh:9:3: warning[SC2046]: Quote this to prevent word splitting.
# 7| USE_SYSTEMDIR=yes
# 8|
# 9|-> . $(dirname $0)/libtest.sh
# 10|
# 11| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-http-utils.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| httpd http-utils-test-server.py .
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-http-utils.sh:37:10: warning[SC2154]: test_builddir is referenced but not assigned.
# 35| local=$3
# 36|
# 37|-> out=`${test_builddir}/httpcache $compressed "http://localhost:$port$remote" $local || :`
# 38|
# 39| case "$out" in
Error: SHELLCHECK_WARNING (CWE-88):
/usr/libexec/installed-tests/Flatpak/test-http-utils.sh:51:42: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
# 49|
# 50| assert_cached() {
# 51|-> assert_result "Reusing cached value" $@
# 52| }
# 53|
Error: SHELLCHECK_WARNING (CWE-88):
/usr/libexec/installed-tests/Flatpak/test-http-utils.sh:55:48: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
# 53|
# 54| assert_304() {
# 55|-> assert_result "Server returned status 304" $@
# 56| }
# 57|
Error: SHELLCHECK_WARNING (CWE-88):
/usr/libexec/installed-tests/Flatpak/test-http-utils.sh:59:48: error[SC2068]: Double quote array expansions to avoid re-splitting elements.
# 57|
# 58| assert_ok() {
# 59|-> assert_result "Server returned status 200" $@
# 60| }
# 61|
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-http-utils.sh:71:15: warning[SC2154]: test_tmpdir is referenced but not assigned.
# 69|
# 70| # Without anything else, cached for 30 minutes
# 71|-> assert_ok "/" $test_tmpdir/output
# 72| assert_cached "/" $test_tmpdir/output
# 73| rm -f $test_tmpdir/output*
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-info.sh:5:3: warning[SC2046]: Quote this to prevent word splitting.
# 3| set -euo pipefail
# 4|
# 5|-> . $(dirname $0)/libtest.sh
# 6|
# 7| skip_revokefs_without_fuse
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-metadata-validation.sh:9:3: warning[SC2046]: Quote this to prevent word splitting.
# 7| set -euo pipefail
# 8|
# 9|-> . $(dirname $0)/libtest.sh
# 10|
# 11| echo "1..7"
Error: SHELLCHECK_WARNING (CWE-571):
/usr/libexec/installed-tests/Flatpak/test-metadata-validation.sh:19:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
# 17| create_app () {
# 18| local OPTIONS="$1"
# 19|-> local DIR=`mktemp -d`
# 20|
# 21| mkdir ${DIR}/files
Error: SHELLCHECK_WARNING (CWE-571):
/usr/libexec/installed-tests/Flatpak/test-metadata-validation.sh:44:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
# 42| echo -e "\nfilesystems=home;" >> ${DIR}/metadata
# 43| fi
# 44|-> local XA_METADATA=--add-metadata-string=xa.metadata="$(head -n6 ${DIR}/metadata)"$'\n'
# 45| if [[ $OPTIONS =~ "no-xametadata" ]]; then
# 46| XA_METADATA="--add-metadata-string=xa.nometadata=1"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-oci-registry.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-oci-registry.sh:32:17: warning[SC2154]: test_srcdir is referenced but not assigned.
# 30| httpd oci-registry-server.py .
# 31| port=$(cat httpd-port)
# 32|-> client="python3 $test_srcdir/oci-registry-client.py 127.0.0.1:$port"
# 33|
# 34| setup_repo_no_add oci
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-oci-registry.sh:39:29: warning[SC2046]: Quote this to prevent word splitting.
# 37|
# 38| ${FLATPAK} build-bundle --runtime --oci $FL_GPGARGS repos/oci oci/platform-image org.test.Platform >&2
# 39|-> $client add platform latest $(pwd)/oci/platform-image
# 40|
# 41| ${FLATPAK} build-bundle --oci $FL_GPGARGS repos/oci oci/app-image org.test.Hello >&2
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-oci-registry.sh:42:26: warning[SC2046]: Quote this to prevent word splitting.
# 40|
# 41| ${FLATPAK} build-bundle --oci $FL_GPGARGS repos/oci oci/app-image org.test.Hello >&2
# 42|-> $client add hello latest $(pwd)/oci/app-image
# 43|
# 44| # Add an OCI remote
Error: SHELLCHECK_WARNING (CWE-140):
/usr/libexec/installed-tests/Flatpak/test-oci-registry.sh:82:23: warning[SC2206]: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
# 80| # Replace with the app image with detached icons, check that the icons work
# 81|
# 82|-> old_icon_hash=(md5sum $icondir/64x64/org.test.Hello.png)
# 83| rm $icondir/64x64/org.test.Hello.png
# 84| $client delete hello latest
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-oci-registry.sh:85:42: warning[SC2046]: Quote this to prevent word splitting.
# 83| rm $icondir/64x64/org.test.Hello.png
# 84| $client delete hello latest
# 85|-> $client add --detach-icons hello latest $(pwd)/oci/app-image
# 86| ${FLATPAK} update ${U} --appstream oci-registry >&2
# 87| assert_has_file $icondir/64x64/org.test.Hello.png
Error: SHELLCHECK_WARNING (CWE-140):
/usr/libexec/installed-tests/Flatpak/test-oci-registry.sh:88:23: warning[SC2206]: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
# 86| ${FLATPAK} update ${U} --appstream oci-registry >&2
# 87| assert_has_file $icondir/64x64/org.test.Hello.png
# 88|-> new_icon_hash=(md5sum $icondir/64x64/org.test.Hello.png)
# 89| assert_streq $old_icon_hash $new_icon_hash
# 90|
Error: SHELLCHECK_WARNING (CWE-670):
/usr/libexec/installed-tests/Flatpak/test-oci-registry.sh:89:14: warning[SC2128]: Expanding an array without an index only gives the first element.
# 87| assert_has_file $icondir/64x64/org.test.Hello.png
# 88| new_icon_hash=(md5sum $icondir/64x64/org.test.Hello.png)
# 89|-> assert_streq $old_icon_hash $new_icon_hash
# 90|
# 91| ok "detached icons"
Error: SHELLCHECK_WARNING (CWE-670):
/usr/libexec/installed-tests/Flatpak/test-oci-registry.sh:89:29: warning[SC2128]: Expanding an array without an index only gives the first element.
# 87| assert_has_file $icondir/64x64/org.test.Hello.png
# 88| new_icon_hash=(md5sum $icondir/64x64/org.test.Hello.png)
# 89|-> assert_streq $old_icon_hash $new_icon_hash
# 90|
# 91| ok "detached icons"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-oci-registry.sh:106:26: warning[SC2046]: Quote this to prevent word splitting.
# 104| ${FLATPAK} build-bundle --oci $FL_GPGARGS repos/oci oci/app-image org.test.Hello >&2
# 105|
# 106|-> $client add hello latest $(pwd)/oci/app-image
# 107|
# 108| OLD_COMMIT=`${FLATPAK} ${U} info --show-commit org.test.Hello`
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-oci.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-oci.sh:38:11: warning[SC2046]: Quote this to prevent word splitting.
# 36|
# 37| for i in oci/image/blobs/sha256/*; do
# 38|-> echo $(basename $i) $i >> sums
# 39| done
# 40| sha256sum -c sums >&2
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-override.sh:5:3: warning[SC2046]: Quote this to prevent word splitting.
# 3| set -euo pipefail
# 4|
# 5|-> . $(dirname $0)/libtest.sh
# 6| if [ -e "${test_builddir}/.libs/libpreload.so" ]; then
# 7| install "${test_builddir}/.libs/libpreload.so" "${test_tmpdir}"
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-override.sh:6:10: warning[SC2154]: test_builddir is referenced but not assigned.
# 4|
# 5| . $(dirname $0)/libtest.sh
# 6|-> if [ -e "${test_builddir}/.libs/libpreload.so" ]; then
# 7| install "${test_builddir}/.libs/libpreload.so" "${test_tmpdir}"
# 8| else
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-override.sh:7:53: warning[SC2154]: test_tmpdir is referenced but not assigned.
# 5| . $(dirname $0)/libtest.sh
# 6| if [ -e "${test_builddir}/.libs/libpreload.so" ]; then
# 7|-> install "${test_builddir}/.libs/libpreload.so" "${test_tmpdir}"
# 8| else
# 9| install "${test_builddir}/libpreload.so" "${test_tmpdir}"
Error: SHELLCHECK_WARNING (CWE-480):
/usr/libexec/installed-tests/Flatpak/test-override.sh:238:9: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
# 236| # Warnings need to be made temporarily non-fatal here.
# 237| e=0
# 238|-> G_DEBUG= ${FLATPAK} override --user --nofilesystem=/foo:rw org.test.Hello 2>log || e=$?
# 239| assert_file_has_content log "Filesystem suffix \"rw\" is not applicable for --nofilesystem"
# 240| assert_streq "$e" 0
Error: SHELLCHECK_WARNING (CWE-480):
/usr/libexec/installed-tests/Flatpak/test-override.sh:245:9: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
# 243| # Warnings need to be made temporarily non-fatal here.
# 244| e=0
# 245|-> G_DEBUG= ${FLATPAK} override --user --filesystem=/foo:bar org.test.Hello 2>log || e=$?
# 246| assert_file_has_content log "Unexpected filesystem suffix bar, ignoring"
# 247| assert_streq "$e" 0
Error: SHELLCHECK_WARNING (CWE-480):
/usr/libexec/installed-tests/Flatpak/test-override.sh:252:9: warning[SC1007]: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
# 250| # Warnings need to be made temporarily non-fatal here.
# 251| e=0
# 252|-> G_DEBUG= ${FLATPAK} override --user --nofilesystem=/foo:bar org.test.Hello 2>log || e=$?
# 253| assert_file_has_content log "Unexpected filesystem suffix bar, ignoring"
# 254| assert_streq "$e" 0
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-prune.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| echo "1..5"
Error: SHELLCHECK_WARNING (CWE-571):
/usr/libexec/installed-tests/Flatpak/test-prune.sh:33:15: warning[SC2155]: Declare and assign separately to avoid masking return values.
# 31| local DEPTH=${3}
# 32|
# 33|-> local F=$(mktemp -d files.XXXXXX)
# 34|
# 35| # Each commit has:
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-repair.sh:9:3: warning[SC2046]: Quote this to prevent word splitting.
# 7| set -euo pipefail
# 8|
# 9|-> . $(dirname $0)/libtest.sh
# 10|
# 11| echo "1..1"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-repo.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-repo.sh:59:67: warning[SC2046]: Quote this to prevent word splitting.
# 57| fi
# 58|
# 59|-> ${FLATPAK} remote-add ${U} --no-gpg-verify local-test-no-gpg-repo `pwd`/repos/test-no-gpg >&2
# 60|
# 61| #alternative gpg key repo
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-repo.sh:289:59: warning[SC2046]: Quote this to prevent word splitting.
# 287| fi
# 288|
# 289|-> REQUIRED_VERSION="${VERSION}" GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test ${APP_ID} master "${CID}" > /dev/null
# 290| }
# 291|
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-repo.sh:292:23: warning[SC2154]: test_builddir is referenced but not assigned.
# 290| }
# 291|
# 292|-> CURRENT_VERSION=`cat "$test_builddir/package_version.txt"`
# 293| V=( ${CURRENT_VERSION//./ } ) # Split parts to array
# 294|
Error: SHELLCHECK_WARNING (CWE-140):
/usr/libexec/installed-tests/Flatpak/test-repo.sh:293:5: warning[SC2206]: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
# 291|
# 292| CURRENT_VERSION=`cat "$test_builddir/package_version.txt"`
# 293|-> V=( ${CURRENT_VERSION//./ } ) # Split parts to array
# 294|
# 295| make_required_version_app org.test.SameVersion "${V[0]}.${V[1]}.${V[2]}"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-repo.sh:439:25: warning[SC2046]: Quote this to prevent word splitting.
# 437|
# 438| ${FLATPAK} build-commit-from --no-update-summary --end-of-life-rebase=org.test.Hello=org.test.NewHello --src-repo=repos/test ${FL_GPGARGS} repos/test-rebase app/org.test.Hello/$ARCH/master runtime/org.test.Hello.Locale/$ARCH/master >&2
# 439|-> GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test-rebase org.test.NewHello master "${REBASE_COLLECTION_ID}" "NEW" > /dev/null
# 440| update_repo test-rebase
# 441|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-repo.sh:793:43: warning[SC2046]: Quote this to prevent word splitting.
# 791| # Test that remote-ls can take a file:// URI
# 792| ${FLATPAK} build-update-repo ${BUILD_UPDATE_REPO_FLAGS-} --no-update-appstream repos/test >&2
# 793|-> ${FLATPAK} remote-ls --columns=ref file://`pwd`/repos/test > repo-list
# 794| assert_file_has_content repo-list "org\.test\.Hello/"
# 795|
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-repo.sh:928:4: warning[SC2154]: test_srcdir is referenced but not assigned.
# 926|
# 927| # Make a copy so we can remove it later
# 928|-> cp ${test_srcdir}/test.filter test.filter
# 929| ${FLATPAK} ${U} remote-modify test-repo --filter $(pwd)/test.filter >&2
# 930|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-repo.sh:929:50: warning[SC2046]: Quote this to prevent word splitting.
# 927| # Make a copy so we can remove it later
# 928| cp ${test_srcdir}/test.filter test.filter
# 929|-> ${FLATPAK} ${U} remote-modify test-repo --filter $(pwd)/test.filter >&2
# 930|
# 931| ${FLATPAK} ${U} remote-ls --columns=ref -a test-repo > remote-ls-log
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-run.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-run.sh:195:37: warning[SC2046]: Quote this to prevent word splitting.
# 193| ok "error handling for invalid refs"
# 194|
# 195|-> run_sh org.test.Hello cat /run/user/`id -u`/flatpak-info > fpi
# 196| assert_file_has_content fpi '^name=org\.test\.Hello$'
# 197|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-run.sh:202:18: warning[SC2046]: Quote this to prevent word splitting.
# 200| run_sh org.test.Hello readlink /proc/self/ns/net > unshared_net_ns
# 201| ARGS="--share=network" run_sh org.test.Hello readlink /proc/self/ns/net > shared_net_ns
# 202|-> assert_not_streq `cat unshared_net_ns` `readlink /proc/self/ns/net`
# 203| assert_streq `cat shared_net_ns` `readlink /proc/self/ns/net`
# 204|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-run.sh:202:40: warning[SC2046]: Quote this to prevent word splitting.
# 200| run_sh org.test.Hello readlink /proc/self/ns/net > unshared_net_ns
# 201| ARGS="--share=network" run_sh org.test.Hello readlink /proc/self/ns/net > shared_net_ns
# 202|-> assert_not_streq `cat unshared_net_ns` `readlink /proc/self/ns/net`
# 203| assert_streq `cat shared_net_ns` `readlink /proc/self/ns/net`
# 204|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-run.sh:203:14: warning[SC2046]: Quote this to prevent word splitting.
# 201| ARGS="--share=network" run_sh org.test.Hello readlink /proc/self/ns/net > shared_net_ns
# 202| assert_not_streq `cat unshared_net_ns` `readlink /proc/self/ns/net`
# 203|-> assert_streq `cat shared_net_ns` `readlink /proc/self/ns/net`
# 204|
# 205| run_sh org.test.Hello readlink /proc/self/ns/ipc > unshared_ipc_ns
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-run.sh:203:34: warning[SC2046]: Quote this to prevent word splitting.
# 201| ARGS="--share=network" run_sh org.test.Hello readlink /proc/self/ns/net > shared_net_ns
# 202| assert_not_streq `cat unshared_net_ns` `readlink /proc/self/ns/net`
# 203|-> assert_streq `cat shared_net_ns` `readlink /proc/self/ns/net`
# 204|
# 205| run_sh org.test.Hello readlink /proc/self/ns/ipc > unshared_ipc_ns
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-run.sh:207:18: warning[SC2046]: Quote this to prevent word splitting.
# 205| run_sh org.test.Hello readlink /proc/self/ns/ipc > unshared_ipc_ns
# 206| ARGS="--share=ipc" run_sh org.test.Hello readlink /proc/self/ns/ipc > shared_ipc_ns
# 207|-> assert_not_streq `cat unshared_ipc_ns` `readlink /proc/self/ns/ipc`
# 208| assert_streq `cat shared_ipc_ns` `readlink /proc/self/ns/ipc`
# 209|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-run.sh:207:40: warning[SC2046]: Quote this to prevent word splitting.
# 205| run_sh org.test.Hello readlink /proc/self/ns/ipc > unshared_ipc_ns
# 206| ARGS="--share=ipc" run_sh org.test.Hello readlink /proc/self/ns/ipc > shared_ipc_ns
# 207|-> assert_not_streq `cat unshared_ipc_ns` `readlink /proc/self/ns/ipc`
# 208| assert_streq `cat shared_ipc_ns` `readlink /proc/self/ns/ipc`
# 209|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-run.sh:208:14: warning[SC2046]: Quote this to prevent word splitting.
# 206| ARGS="--share=ipc" run_sh org.test.Hello readlink /proc/self/ns/ipc > shared_ipc_ns
# 207| assert_not_streq `cat unshared_ipc_ns` `readlink /proc/self/ns/ipc`
# 208|-> assert_streq `cat shared_ipc_ns` `readlink /proc/self/ns/ipc`
# 209|
# 210| # We try the filesystem namespace tests several times with different
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-run.sh:208:34: warning[SC2046]: Quote this to prevent word splitting.
# 206| ARGS="--share=ipc" run_sh org.test.Hello readlink /proc/self/ns/ipc > shared_ipc_ns
# 207| assert_not_streq `cat unshared_ipc_ns` `readlink /proc/self/ns/ipc`
# 208|-> assert_streq `cat shared_ipc_ns` `readlink /proc/self/ns/ipc`
# 209|
# 210| # We try the filesystem namespace tests several times with different
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-run.sh:248:26: warning[SC2154]: test_builddir is referenced but not assigned.
# 246| }
# 247|
# 248|-> test_filesystem_binding "${test_builddir}"
# 249|
# 250| mkdir "${TEST_DATA_DIR}/shareable"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-seccomp.sh:7:3: warning[SC2046]: Quote this to prevent word splitting.
# 5| set -euo pipefail
# 6|
# 7|-> . $(dirname $0)/libtest.sh
# 8|
# 9| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-seccomp.sh:16:39: warning[SC2154]: test_tmpdir is referenced but not assigned.
# 14| install_repo
# 15|
# 16|-> cp -a "$G_TEST_BUILDDIR/try-syscall" "$test_tmpdir/try-syscall"
# 17|
# 18| # How this works:
Error: SHELLCHECK_WARNING (CWE-563):
/usr/libexec/installed-tests/Flatpak/test-sideload.sh:22:1: warning[SC2034]: USE_COLLECTIONS_IN_SERVER appears unused. Verify use (or export if used externally).
# 20| set -euo pipefail
# 21|
# 22|-> USE_COLLECTIONS_IN_SERVER=yes
# 23| USE_COLLECTIONS_IN_CLIENT=yes
# 24|
Error: SHELLCHECK_WARNING (CWE-563):
/usr/libexec/installed-tests/Flatpak/test-sideload.sh:23:1: warning[SC2034]: USE_COLLECTIONS_IN_CLIENT appears unused. Verify use (or export if used externally).
# 21|
# 22| USE_COLLECTIONS_IN_SERVER=yes
# 23|-> USE_COLLECTIONS_IN_CLIENT=yes
# 24|
# 25| . $(dirname $0)/libtest.sh
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-sideload.sh:25:3: warning[SC2046]: Quote this to prevent word splitting.
# 23| USE_COLLECTIONS_IN_CLIENT=yes
# 24|
# 25|-> . $(dirname $0)/libtest.sh
# 26|
# 27| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-sideload.sh:55:58: warning[SC2154]: port is referenced but not assigned.
# 53| ok "created sideloaded repo"
# 54|
# 55|-> ${FLATPAK} ${U} remote-modify --url="http://no.127.0.0.1:${port}/test" test-repo >&2
# 56|
# 57| if ${FLATPAK} ${U} install -y test-repo org.test.Hello &> /dev/null; then
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-subset.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-subset.sh:39:57: warning[SC2046]: Quote this to prevent word splitting.
# 37| assert_file_has_content repo-all.txt "runtime/org\.test\.Platform/$ARCH/master"
# 38|
# 39|-> EXPORT_ARGS="--subset=subset1 " GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test org.test.SubsetOne master ""
# 40| EXPORT_ARGS="--subset=subset2 " GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test org.test.SubsetTwo master ""
# 41| EXPORT_ARGS="" GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test org.test.NoSubset master ""
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-subset.sh:40:57: warning[SC2046]: Quote this to prevent word splitting.
# 38|
# 39| EXPORT_ARGS="--subset=subset1 " GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test org.test.SubsetOne master ""
# 40|-> EXPORT_ARGS="--subset=subset2 " GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test org.test.SubsetTwo master ""
# 41| EXPORT_ARGS="" GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test org.test.NoSubset master ""
# 42| ${FLATPAK} build-update-repo ${BUILD_UPDATE_REPO_FLAGS-} ${FL_GPGARGS} repos/test >&2
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-subset.sh:41:40: warning[SC2046]: Quote this to prevent word splitting.
# 39| EXPORT_ARGS="--subset=subset1 " GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test org.test.SubsetOne master ""
# 40| EXPORT_ARGS="--subset=subset2 " GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test org.test.SubsetTwo master ""
# 41|-> EXPORT_ARGS="" GPGARGS="${FL_GPGARGS}" $(dirname $0)/make-test-app.sh repos/test org.test.NoSubset master ""
# 42| ${FLATPAK} build-update-repo ${BUILD_UPDATE_REPO_FLAGS-} ${FL_GPGARGS} repos/test >&2
# 43|
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-summaries.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| echo "1..2"
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-summaries.sh:71:8: warning[SC2046]: Quote this to prevent word splitting.
# 69| </components>
# 70| EOF
# 71|-> cp $(dirname $0)/org.test.Hello.png ${DIR}/files/share/app-info/icons/flatpak/64x64/${APP_ID}.png
# 72|
# 73| $FLATPAK build-finish --command=hello.sh ${DIR} &> /dev/null
Error: SHELLCHECK_WARNING (CWE-563):
/usr/libexec/installed-tests/Flatpak/test-summaries.sh:111:9: warning[SC2034]: FROM appears unused. Verify use (or export if used externally).
# 109| for DELTA_FILE in $REPO/summaries/*.delta; do
# 110| DELTA=$(basename $DELTA_FILE .delta)
# 111|-> FROM=$(echo $DELTA | cut -d "-" -f 1)
# 112| TO=$(echo $DELTA | cut -d "-" -f 2)
# 113|
Error: SHELLCHECK_WARNING (CWE-477):
/usr/libexec/installed-tests/Flatpak/test-summaries.sh:139:22: warning[SC2166]: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
# 137|
# 138| # A non-default arch (that isn't compatible)
# 139|-> if [ $ARCH == x86_64 -o $ARCH == i386 ]; then
# 140| OTHER_ARCH=aarch64
# 141| else
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-summaries.sh:150:8: warning[SC2124]: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
# 148| arches[$A]=1
# 149| done
# 150|-> ARCHES=${!arches[@]}
# 151|
# 152| for A in $ARCHES; do
Error: SHELLCHECK_WARNING (CWE-563):
/usr/libexec/installed-tests/Flatpak/test-summaries.sh:225:1: warning[SC2034]: OLD_OLD_ACTIVE_SUBSET appears unused. Verify use (or export if used externally).
# 223| $FLATPAK build-commit-from ${GPGARGS} --src-ref=app/org.app.App1/$OTHER_ARCH/master repos/test app/org.app.App1.NEW2/$OTHER_ARCH/master >&2
# 224|
# 225|-> OLD_OLD_ACTIVE_SUBSET=$OLD_ACTIVE_SUBSET
# 226| OLD_OLD_ACTIVE_SUBSET_OTHER=$OLD_ACTIVE_SUBSET_OTHER
# 227| OLD_ACTIVE_SUBSET=$ACTIVE_SUBSET
Error: SHELLCHECK_WARNING (CWE-563):
/usr/libexec/installed-tests/Flatpak/test-summaries.sh:226:1: warning[SC2034]: OLD_OLD_ACTIVE_SUBSET_OTHER appears unused. Verify use (or export if used externally).
# 224|
# 225| OLD_OLD_ACTIVE_SUBSET=$OLD_ACTIVE_SUBSET
# 226|-> OLD_OLD_ACTIVE_SUBSET_OTHER=$OLD_ACTIVE_SUBSET_OTHER
# 227| OLD_ACTIVE_SUBSET=$ACTIVE_SUBSET
# 228| OLD_ACTIVE_SUBSET_OTHER=$ACTIVE_SUBSET_OTHER
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:25:3: warning[SC2046]: Quote this to prevent word splitting.
# 23| export USE_SYSTEMDIR=yes
# 24|
# 25|-> . $(dirname $0)/libtest.sh
# 26|
# 27| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:32:19: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 30| echo "1..3"
# 31|
# 32|-> setup_empty_repo &> /dev/null > /dev/null
# 33|
# 34| # Manually add the user remote too
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:32:31: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 30| echo "1..3"
# 31|
# 32|-> setup_empty_repo &> /dev/null > /dev/null
# 33|
# 34| # Manually add the user remote too
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:35:99: warning[SC2154]: port is referenced but not assigned.
# 33|
# 34| # Manually add the user remote too
# 35|-> $FLATPAK remote-add --user --gpg-import=${FL_GPG_HOMEDIR}/pubring.gpg test-repo "http://127.0.0.1:${port}/test" >&2
# 36|
# 37|
Error: SHELLCHECK_WARNING (CWE-571):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:70:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
# 68|
# 69| local BRANCH=stable
# 70|-> local DIR=`mktemp -d`
# 71|
# 72| mkdir ${DIR}/files
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:86:55: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 84| fi
# 85|
# 86|-> $FLATPAK build-finish $DIR ${finish_args[$ID]:-} &> /dev/null > /dev/null
# 87| $FLATPAK build-export -v ${FL_GPGARGS} --disable-sandbox --runtime repos/test ${DIR} ${BRANCH} &> /dev/null > /dev/null
# 88| rm -rf ${DIR}
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:86:67: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 84| fi
# 85|
# 86|-> $FLATPAK build-finish $DIR ${finish_args[$ID]:-} &> /dev/null > /dev/null
# 87| $FLATPAK build-export -v ${FL_GPGARGS} --disable-sandbox --runtime repos/test ${DIR} ${BRANCH} &> /dev/null > /dev/null
# 88| rm -rf ${DIR}
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:87:101: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 85|
# 86| $FLATPAK build-finish $DIR ${finish_args[$ID]:-} &> /dev/null > /dev/null
# 87|-> $FLATPAK build-export -v ${FL_GPGARGS} --disable-sandbox --runtime repos/test ${DIR} ${BRANCH} &> /dev/null > /dev/null
# 88| rm -rf ${DIR}
# 89| }
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:87:113: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 85|
# 86| $FLATPAK build-finish $DIR ${finish_args[$ID]:-} &> /dev/null > /dev/null
# 87|-> $FLATPAK build-export -v ${FL_GPGARGS} --disable-sandbox --runtime repos/test ${DIR} ${BRANCH} &> /dev/null > /dev/null
# 88| rm -rf ${DIR}
# 89| }
Error: SHELLCHECK_WARNING (CWE-571):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:97:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
# 95|
# 96| local BRANCH=stable
# 97|-> local DIR=`mktemp -d`
# 98|
# 99| mkdir ${DIR}/files
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:113:58: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 111|
# 112| set -x
# 113|-> $FLATPAK build-finish ${DIR} ${finish_args[$ID]:-} &> /dev/null > /dev/null
# 114|
# 115| $FLATPAK build-export ${FL_GPGARGS} --disable-sandbox repos/test ${DIR} ${BRANCH} &> /dev/null > /dev/null
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:113:70: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 111|
# 112| set -x
# 113|-> $FLATPAK build-finish ${DIR} ${finish_args[$ID]:-} &> /dev/null > /dev/null
# 114|
# 115| $FLATPAK build-export ${FL_GPGARGS} --disable-sandbox repos/test ${DIR} ${BRANCH} &> /dev/null > /dev/null
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:115:88: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 113| $FLATPAK build-finish ${DIR} ${finish_args[$ID]:-} &> /dev/null > /dev/null
# 114|
# 115|-> $FLATPAK build-export ${FL_GPGARGS} --disable-sandbox repos/test ${DIR} ${BRANCH} &> /dev/null > /dev/null
# 116| rm -rf ${DIR}
# 117| }
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:115:100: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 113| $FLATPAK build-finish ${DIR} ${finish_args[$ID]:-} &> /dev/null > /dev/null
# 114|
# 115|-> $FLATPAK build-export ${FL_GPGARGS} --disable-sandbox repos/test ${DIR} ${BRANCH} &> /dev/null > /dev/null
# 116| rm -rf ${DIR}
# 117| }
Error: SHELLCHECK_WARNING (CWE-140):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:236:13: warning[SC2206]: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
# 234| fi
# 235|
# 236|-> apps+=( $ID )
# 237| apps_runtime[$ID]="$RUNTIME"
# 238| apps_sdk[$ID]="$SDK"
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:258:19: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 256| create_app "$app" "${apps_runtime[$app]}" "${apps_sdk[$app]}"
# 257| done
# 258|-> update_repo &> /dev/null > /dev/null
# 259|
# 260| for runtime in "${runtimes[@]}"; do
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:258:31: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 256| create_app "$app" "${apps_runtime[$app]}" "${apps_sdk[$app]}"
# 257| done
# 258|-> update_repo &> /dev/null > /dev/null
# 259|
# 260| for runtime in "${runtimes[@]}"; do
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:263:121: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 261| local in=${installs_in[${runtime}]:-system}
# 262| if test $in = system -o $in = both; then
# 263|-> $FLATPAK install -y --system --no-deps --no-related --no-auto-pin test-repo runtime/$runtime/$ARCH/stable &> /dev/null > /dev/null
# 264| fi
# 265| if test $in = user -o $in = both; then
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:263:133: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 261| local in=${installs_in[${runtime}]:-system}
# 262| if test $in = system -o $in = both; then
# 263|-> $FLATPAK install -y --system --no-deps --no-related --no-auto-pin test-repo runtime/$runtime/$ARCH/stable &> /dev/null > /dev/null
# 264| fi
# 265| if test $in = user -o $in = both; then
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:266:119: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 264| fi
# 265| if test $in = user -o $in = both; then
# 266|-> $FLATPAK install -y --user --no-deps --no-related --no-auto-pin test-repo runtime/$runtime/$ARCH/stable &> /dev/null > /dev/null
# 267| fi
# 268| if test "x${runtimes_pinned[$runtime]:-}" == "xyes"; then
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:266:131: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 264| fi
# 265| if test $in = user -o $in = both; then
# 266|-> $FLATPAK install -y --user --no-deps --no-related --no-auto-pin test-repo runtime/$runtime/$ARCH/stable &> /dev/null > /dev/null
# 267| fi
# 268| if test "x${runtimes_pinned[$runtime]:-}" == "xyes"; then
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:275:113: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 273| local in=${installs_in[$app]:-system}
# 274| if test $in = system -o $in = both; then
# 275|-> $FLATPAK install -y --system --no-deps --no-related --no-auto-pin test-repo app/$app/$ARCH/stable &> /dev/null > /dev/null
# 276| fi
# 277| if test $in = user -o $in = both; then
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:275:125: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 273| local in=${installs_in[$app]:-system}
# 274| if test $in = system -o $in = both; then
# 275|-> $FLATPAK install -y --system --no-deps --no-related --no-auto-pin test-repo app/$app/$ARCH/stable &> /dev/null > /dev/null
# 276| fi
# 277| if test $in = user -o $in = both; then
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:278:111: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 276| fi
# 277| if test $in = user -o $in = both; then
# 278|-> $FLATPAK install -y --user --no-deps --no-related --no-auto-pin test-repo app/$app/$ARCH/stable &> /dev/null > /dev/null
# 279| fi
# 280| done
Error: SHELLCHECK_WARNING (CWE-569):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:278:123: error[SC2261]: Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.
# 276| fi
# 277| if test $in = user -o $in = both; then
# 278|-> $FLATPAK install -y --user --no-deps --no-related --no-auto-pin test-repo app/$app/$ARCH/stable &> /dev/null > /dev/null
# 279| fi
# 280| done
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:394:1: warning[SC2154]: test_builddir is referenced but not assigned.
# 392| assert_not_file_has_content user-installed.txt USED_EXT_K
# 393|
# 394|-> ${test_builddir}/list-unused | sed s@^app/@@g | sed s@^runtime/@@g | sort > unused.txt
# 395|
# 396| verify_unused
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-unused.sh:430:6: warning[SC2046]: Quote this to prevent word splitting.
# 428|
# 429| comm -13 old-unused.txt unused.txt > newly-unused.txt
# 430|-> if [ $(cat newly-unused.txt | wc -l) -ne 10 ]; then
# 431| assert_not_reached "Unexpected unused ref"
# 432| fi
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-update-portal.sh:22:3: warning[SC2046]: Quote this to prevent word splitting.
# 20| set -euo pipefail
# 21|
# 22|-> . $(dirname $0)/libtest.sh
# 23|
# 24| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-457):
/usr/libexec/installed-tests/Flatpak/test-update-portal.sh:32:24: warning[SC2154]: test_builddir is referenced but not assigned.
# 30| install_repo
# 31|
# 32|-> run_with_sandboxed_bus ${test_builddir}/test-update-portal monitor monitor.pid > update-monitor.out
# 33| MONITOR_PID=$(cat monitor.pid)
# 34|
Error: SHELLCHECK_WARNING (CWE-398):
/usr/libexec/installed-tests/Flatpak/test-update-portal.sh:84:1: warning[SC2038]: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames.
# 82| # Break the repo so that the update fails
# 83| cp -r repos/test/objects repos/test/orig-objects
# 84|-> find repos/test/objects -name "*.filez" | xargs -I FILENAME mv FILENAME FILENAME.broken
# 85|
# 86| run_with_sandboxed_bus ${test_builddir}/test-update-portal update-fail monitor.pid >&2
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-update-remote-configuration.sh:25:3: warning[SC2046]: Quote this to prevent word splitting.
# 23| set -euo pipefail
# 24|
# 25|-> . $(dirname $0)/libtest.sh
# 26|
# 27| skip_without_bwrap
Error: SHELLCHECK_WARNING (CWE-156):
/usr/libexec/installed-tests/Flatpak/test-webserver.sh:9:1: warning[SC2046]: Quote this to prevent word splitting.
# 7| rm -f httpd-pipe
# 8| mkfifo httpd-pipe
# 9|-> $(dirname $0)/web-server.py "$dir" 3> httpd-pipe &
# 10| read < httpd-pipe
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-builtins-build-commit-from.c:388:11: warning[deadcode.DeadStores]: Value stored to 'n_dst_refs' is never read
# 386| g_ptr_array_add (src_refs, g_strdup (keys[i]));
# 387| }
# 388|-> n_dst_refs = src_refs->len;
# 389| dst_refs = (const char **) src_refs->pdata;
# 390| }
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-builtins-build-commit-from.c:649:19: warning[core.uninitialized.Assign]: Assigned value is garbage or undefined
# 647| timestamp = ostree_commit_get_timestamp (src_commitv);
# 648| if (opt_timestamp)
# 649|-> timestamp = ts.tv_sec;
# 650|
# 651| metadata = g_variant_ref_sink (g_variant_builder_end (&metadata_builder));
Error: GCC_ANALYZER_WARNING (CWE-688):
flatpak-1.15.8/app/flatpak-builtins-config.c: scope_hint: In function ‘looks_like_a_locale’
flatpak-1.15.8/app/flatpak-builtins-config.c:112:14: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
/usr/include/glib-2.0/glib/gi18n.h:23: included_from: Included from here.
flatpak-1.15.8/app/flatpak-builtins-config.c:28: included_from: Included from here.
flatpak-1.15.8/app/flatpak-builtins-config.c:109:30: note: in expansion of macro ‘g_strdup’
flatpak-1.15.8/app/flatpak-builtins-config.c: scope_hint: In function ‘looks_like_a_locale’
<built-in>: note: argument 1 of ‘__builtin_strchr’ must be non-null
# 110| gchar *language, *territory, *codeset, *modifier;
# 111|
# 112|-> modifier = strchr (locale, '@');
# 113| if (modifier != NULL)
# 114| *modifier++ = '\0';
Error: GCC_ANALYZER_WARNING (CWE-775):
flatpak-1.15.8/app/flatpak-builtins-document-export.c: scope_hint: In function ‘flatpak_builtin_document_export’
flatpak-1.15.8/app/flatpak-builtins-document-export.c:134:10: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘open(g_path_get_dirname(file), 2621440)’
# 132|
# 133| if (opt_noexist)
# 134|-> fd = open (dirname, O_PATH | O_CLOEXEC);
# 135| else
# 136| fd = open (file, O_PATH | O_CLOEXEC);
Error: GCC_ANALYZER_WARNING (CWE-775):
flatpak-1.15.8/app/flatpak-builtins-document-export.c:136:10: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘open(file, 2621440)’
# 134| fd = open (dirname, O_PATH | O_CLOEXEC);
# 135| else
# 136|-> fd = open (file, O_PATH | O_CLOEXEC);
# 137|
# 138| if (fd == -1)
Error: GCC_ANALYZER_WARNING (CWE-476):
flatpak-1.15.8/app/flatpak-builtins-document-unexport.c: scope_hint: In function ‘flatpak_builtin_document_unexport’
flatpak-1.15.8/app/flatpak-builtins-document-unexport.c:90:7: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘doc_id’
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
/usr/include/glib-2.0/glib/gi18n.h:23: included_from: Included from here.
flatpak-1.15.8/app/flatpak-builtins-document-unexport.c:29: included_from: Included from here.
flatpak-1.15.8/app/flatpak-builtins-document-unexport.c:86:14: note: in expansion of macro ‘g_strdup’
flatpak-1.15.8/app/flatpak-builtins-document-unexport.c: scope_hint: In function ‘flatpak_builtin_document_unexport’
# 88| return FALSE;
# 89|
# 90|-> if (strcmp (doc_id, "") == 0)
# 91| {
# 92| g_print (_("Not exported\n"));
Error: GCC_ANALYZER_WARNING (CWE-775):
flatpak-1.15.8/app/flatpak-builtins-enter.c:214:18: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘open(path, 0)’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:116:3: note: in expansion of macro ‘g_assert’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:116:3: note: in expansion of macro ‘g_assert’
# 212| user_base_ino = path_stat.st_ino;
# 213|
# 214|-> ns_fd[i] = open (path, O_RDONLY);
# 215| if (ns_fd[i] == -1)
# 216| return flatpak_fail (error, _("Can't open %s namespace: %s"), ns_name[i], g_strerror (errno));
Error: GCC_ANALYZER_WARNING (CWE-688):
flatpak-1.15.8/app/flatpak-builtins-enter.c:248:68: warning[-Wanalyzer-null-argument]: use of NULL ‘e’ where non-null expected
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:116:3: note: in expansion of macro ‘g_assert’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:116:3: note: in expansion of macro ‘g_assert’
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
/usr/include/glib-2.0/glib/gstrfuncs.h:170:46: note: in expansion of macro ‘_G_STR_NONNULL’
flatpak-1.15.8/app/flatpak-builtins-enter.c:251:12: note: in expansion of macro ‘g_str_has_prefix’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1245:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gstrfuncs.h:166:11: note: in expansion of macro ‘G_UNLIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:252:12: note: in expansion of macro ‘g_str_has_prefix’
flatpak-1.15.8/app/flatpak-builtins-enter.c:252:12: note: in expansion of macro ‘g_str_has_prefix’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1245:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gstrfuncs.h:166:11: note: in expansion of macro ‘G_UNLIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:253:12: note: in expansion of macro ‘g_str_has_prefix’
flatpak-1.15.8/app/flatpak-builtins-enter.c:253:12: note: in expansion of macro ‘g_str_has_prefix’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1245:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gstrfuncs.h:166:11: note: in expansion of macro ‘G_UNLIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:254:12: note: in expansion of macro ‘g_str_has_prefix’
flatpak-1.15.8/app/flatpak-builtins-enter.c:254:12: note: in expansion of macro ‘g_str_has_prefix’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1245:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gstrfuncs.h:166:11: note: in expansion of macro ‘G_UNLIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:255:12: note: in expansion of macro ‘g_str_has_prefix’
flatpak-1.15.8/app/flatpak-builtins-enter.c:255:12: note: in expansion of macro ‘g_str_has_prefix’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1245:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gstrfuncs.h:166:11: note: in expansion of macro ‘G_UNLIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:257:15: note: in expansion of macro ‘g_str_has_prefix’
flatpak-1.15.8/app/flatpak-builtins-enter.c:257:15: note: in expansion of macro ‘g_str_has_prefix’
flatpak-1.15.8/app/flatpak-builtins-enter.c:259:40: note: in expansion of macro ‘g_strdup’
flatpak-1.15.8/app/flatpak-builtins-enter.c: scope_hint: In function ‘flatpak_builtin_enter’
<built-in>: note: argument 1 of ‘__builtin_strlen’ must be non-null
# 246|
# 247| envp_array = g_ptr_array_new_with_free_func (g_free);
# 248|-> for (e = environment; e < environment + environment_len; e = e + strlen (e) + 1)
# 249| {
# 250| if (*e != 0 &&
Error: GCC_ANALYZER_WARNING (CWE-775):
flatpak-1.15.8/app/flatpak-builtins-enter.c: scope_hint: In function ‘flatpak_builtin_enter’
flatpak-1.15.8/app/flatpak-builtins-enter.c:299:1: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘ns_fd[0]’
/usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here.
/usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
/usr/include/glib-2.0/glib/gi18n.h:23: included_from: Included from here.
flatpak-1.15.8/app/flatpak-builtins-enter.c:30: included_from: Included from here.
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:116:3: note: in expansion of macro ‘g_assert’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/app/flatpak-builtins-enter.c:116:3: note: in expansion of macro ‘g_assert’
flatpak-1.15.8/app/flatpak-builtins-enter.c: scope_hint: In function ‘flatpak_builtin_enter’
/usr/include/glib-2.0/glib/gi18n.h:25: included_from: Included from here.
flatpak-1.15.8/app/flatpak-builtins-enter.c:191:44: note: in expansion of macro ‘_’
/usr/include/glib-2.0/glib/gmacros.h:1358:7: note: in expansion of macro ‘_GLIB_AUTOPTR_CLEAR_FUNC_NAME’
/usr/include/glib-2.0/glib/gmacros.h:1372:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’
/usr/include/glib-2.0/glib/glib-autocleanups.h:63:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’
/usr/include/glib-2.0/glib/gmacros.h:1372:3: note: in expansion of macro ‘_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS’
/usr/include/glib-2.0/glib/glib-autocleanups.h:63:1: note: in expansion of macro ‘G_DEFINE_AUTOPTR_CLEANUP_FUNC’
flatpak-1.15.8/app/flatpak-builtins-enter.c: scope_hint: In function ‘flatpak_builtin_enter’
flatpak-1.15.8/app/flatpak-builtins-enter.c: scope_hint: In function ‘flatpak_builtin_enter’
# 297|
# 298| exit (status);
# 299|-> }
# 300|
# 301| gboolean
Error: GCC_ANALYZER_WARNING (CWE-688):
flatpak-1.15.8/app/flatpak-builtins-info.c: scope_hint: In function ‘flatpak_builtin_info’
flatpak-1.15.8/app/flatpak-builtins-info.c:238:11: warning[-Wanalyzer-null-argument]: use of NULL ‘latest’ where non-null expected
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
/usr/include/glib-2.0/glib/gi18n.h:23: included_from: Included from here.
flatpak-1.15.8/app/flatpak-builtins-info.c:28: included_from: Included from here.
/usr/include/glib-2.0/glib/gstrfuncs.h:324:38: note: in definition of macro ‘g_strdup’
flatpak-1.15.8/app/flatpak-builtins-info.c:196:28: note: in expansion of macro ‘_’
flatpak-1.15.8/app/flatpak-builtins-info.c:196:18: note: in expansion of macro ‘g_strdup’
flatpak-1.15.8/app/flatpak-builtins-info.c: scope_hint: In function ‘flatpak_builtin_info’
/usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here.
/usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
/usr/include/glib-2.0/glib/gmacros.h:933:29: note: in definition of macro ‘MAX’
flatpak-1.15.8/app/flatpak-builtins-info.c:217:38: note: in expansion of macro ‘_’
flatpak-1.15.8/app/flatpak-builtins-info.c:218:13: note: in expansion of macro ‘MAX’
flatpak-1.15.8/app/flatpak-builtins-info.c:219:13: note: in expansion of macro ‘MAX’
flatpak-1.15.8/app/flatpak-builtins-info.c:220:13: note: in expansion of macro ‘MAX’
flatpak-1.15.8/app/flatpak-builtins-info.c:228:13: note: in expansion of macro ‘MAX’
flatpak-1.15.8/app/flatpak-builtins-info.c:26: included_from: Included from here.
/usr/include/string.h:156:12: note: argument 2 of ‘strcmp’ must be non-null
# 236| if (subject)
# 237| len = MAX (len, g_utf8_strlen (_("Subject:"), -1));
# 238|-> if (strcmp (commit, latest) != 0)
# 239| {
# 240| len = MAX (len, g_utf8_strlen (_("Active commit:"), -1));
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-builtins-info.c:481:15: warning[deadcode.DeadStores]: Value stored to 'size' is never read
# 479| origin = NULL;
# 480| ext_installation = g_strdup (_("unknown"));
# 481|-> size = 0;
# 482| ext_formatted_size = g_strdup (_("unknown"));
# 483| ext_subpaths = NULL;
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-builtins-remote-ls.c:218:49: warning[core.NullDereference]: Array access (from variable 'arches') results in a null pointer dereference
# 216| if (!opt_all && opt_arch == NULL &&
# 217| /* Hide non-primary arches if the primary arch exists */
# 218|-> !flatpak_decomposed_is_arch (ref, arches[0]))
# 219| {
# 220| g_autoptr(FlatpakDecomposed) alt_arch = flatpak_decomposed_new_from_decomposed (ref, 0, NULL, arches[0], NULL, NULL);
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-builtins-remote-ls.c:336:48: warning[core.CallAndMessage]: 1st function call argument is an uninitialized value
# 334| else if (strcmp (columns[j].name, "installed-size") == 0)
# 335| {
# 336|-> g_autofree char *installed = g_format_size (installed_size);
# 337| flatpak_table_printer_add_decimal_column (printer, installed);
# 338| }
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-builtins-remote-ls.c:341:47: warning[core.CallAndMessage]: 1st function call argument is an uninitialized value
# 339| else if (strcmp (columns[j].name, "download-size") == 0)
# 340| {
# 341|-> g_autofree char *download = g_format_size (download_size);
# 342| flatpak_table_printer_add_decimal_column (printer, download);
# 343| }
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-builtins-utils.c:875:16: warning[unix.Malloc]: Potential leak of memory pointed to by 'result'
# 873| int idx = find_column (columns, cols[i], error);
# 874| if (idx < 0)
# 875|-> return NULL;
# 876| result[i] = columns[idx];
# 877| }
Error: GCC_ANALYZER_WARNING (CWE-688):
flatpak-1.15.8/app/flatpak-builtins-utils.c: scope_hint: In function ‘ellipsize_string_full’
flatpak-1.15.8/app/flatpak-builtins-utils.c:1030:17: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
/usr/include/glib-2.0/glib/gi18n.h:23: included_from: Included from here.
flatpak-1.15.8/app/flatpak-builtins-utils.c:23: included_from: Included from here.
flatpak-1.15.8/app/flatpak-builtins-utils.c:1011:26: note: in expansion of macro ‘g_strdup’
flatpak-1.15.8/app/flatpak-builtins-utils.c: scope_hint: In function ‘ellipsize_string_full’
<built-in>: note: argument 1 of ‘__builtin_strlen’ must be non-null
# 1028|
# 1029| p = ret;
# 1030|-> q = ret + strlen (ret);
# 1031|
# 1032| for (i = 0; i < l1; i++)
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-complete.c:273:15: warning[core.NonNullParamChecker]: Null pointer passed to 2nd parameter expecting 'nonnull'
# 271| * not for "org.foo" or other shorter prefixes.
# 272| */
# 273|-> if (strncmp (parts[element], cur_parts[element], last_dot - parts[element] - 1) != 0)
# 274| continue;
# 275| }
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-complete.c:278:47: warning[core.NonNullParamChecker]: Null pointer passed to 1st parameter expecting 'nonnull'
# 276|
# 277| comp = g_string_new (pref);
# 278|-> g_string_append (comp, parts[element] + strlen (cur_parts[element]));
# 279|
# 280| /* Only complete on the last part if the user explicitly adds a / */
Error: CPPCHECK_WARNING (CWE-457):
flatpak-1.15.8/app/flatpak-main.c:466: error[legacyUninitvar]: Uninitialized variable: dir
# 464| g_assert_not_reached ();
# 465|
# 466|-> g_ptr_array_add (dirs, dir);
# 467| }
# 468|
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-main.c:840:5: warning[deadcode.DeadStores]: Value stored to 'polkit_agent' is never read
# 838| g_strcmp0 (command->name, "build") != 0 &&
# 839| g_strcmp0 (command->name, "history") != 0)
# 840|-> polkit_agent = install_polkit_agent ();
# 841|
# 842| /* g_vfs_get_default can spawn threads */
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-table-printer.c:507:11: warning[unix.Malloc]: Potential leak of memory pointed to by 'rwidths'
# 505| }
# 506|
# 507|-> width = printer->n_columns - 1;
# 508| for (i = 0; i < printer->n_columns; i++)
# 509| width += widths[i];
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-table-printer.c:639:15: warning[deadcode.DeadStores]: Value stored to 'freeme' is never read
# 637| {
# 638| len -= shrinks[i];
# 639|-> freeme = title = ellipsize_string (title, len);
# 640| }
# 641|
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-table-printer.c:684:15: warning[deadcode.DeadStores]: Value stored to 'freeme' is never read
# 682| {
# 683| len -= shrinks[j];
# 684|-> freeme = text = ellipsize_string_full (text, len, col->ellipsize);
# 685| }
# 686|
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-table-printer.c:711:7: warning[unix.Malloc]: Potential leak of memory pointed to by 'lwidths'
# 709| }
# 710|
# 711|-> if (table_width)
# 712| *table_width = width;
# 713| if (table_height)
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-table-printer.c:711:7: warning[unix.Malloc]: Potential leak of memory pointed to by 'shrinks'
# 709| }
# 710|
# 711|-> if (table_width)
# 712| *table_width = width;
# 713| if (table_height)
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-table-printer.c:711:7: warning[unix.Malloc]: Potential leak of memory pointed to by 'widths'
# 709| }
# 710|
# 711|-> if (table_width)
# 712| *table_width = width;
# 713| if (table_height)
Error: CLANG_WARNING:
flatpak-1.15.8/app/flatpak-tty-utils.c:376:16: warning[unix.Malloc]: Potential leak of memory pointed to by 'choice'
# 374| numbers = flatpak_parse_numbers (buf, min, max);
# 375| if (numbers)
# 376|-> return numbers;
# 377| }
# 378| }
Error: CLANG_WARNING:
flatpak-1.15.8/common/flatpak-appdata.c:298:7: warning[core.NonNullParamChecker]: Null pointer passed to 1st parameter expecting 'nonnull'
# 296| /* avoid picking up <id> elements from e.g. <provides> */
# 297| if (g_str_equal (element_name, "id") &&
# 298|-> g_str_equal (parent, "component"))
# 299| {
# 300| component->id = g_steal_pointer (&text);
Error: CLANG_WARNING:
flatpak-1.15.8/common/flatpak-bwrap.c:378:8: warning[unix.Malloc]: Potential leak of memory pointed to by 'ptr'
# 376| return FALSE;
# 377|
# 378|-> fd = g_steal_fd (&args_tmpf.fd);
# 379|
# 380| g_debug ("bwrap --args %d = ...", fd);
Error: GCC_ANALYZER_WARNING (CWE-688):
flatpak-1.15.8/common/flatpak-context.c: scope_hint: In function ‘get_xdg_user_dir_from_string’
flatpak-1.15.8/common/flatpak-context.c:583:11: warning[-Wanalyzer-null-argument]: use of NULL ‘filesystem’ where non-null expected
/usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
/usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here.
/usr/include/glib-2.0/glib-object.h:24: included_from: Included from here.
/usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here.
/usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here.
/usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here.
flatpak-1.15.8/subprojects/libglnx/libglnx.h:24: included_from: Included from here.
flatpak-1.15.8/common/flatpak-context-private.h:24: included_from: Included from here.
flatpak-1.15.8/common/flatpak-context.c:22: included_from: Included from here.
/usr/lib64/glib-2.0/include/glibconfig.h:103:51: note: in definition of macro ‘GPOINTER_TO_INT’
/usr/include/glib-2.0/glib.h:64: included_from: Included from here.
flatpak-1.15.8/common/flatpak-context.c:2586:7: note: in expansion of macro ‘g_info’
/usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here.
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1245:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gstrfuncs.h:166:11: note: in expansion of macro ‘G_UNLIKELY’
flatpak-1.15.8/common/flatpak-context.c:2610:11: note: in expansion of macro ‘g_str_has_prefix’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1245:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gstrfuncs.h:166:11: note: in expansion of macro ‘G_UNLIKELY’
flatpak-1.15.8/common/flatpak-context.c:2610:11: note: in expansion of macro ‘g_str_has_prefix’
<built-in>: note: argument 1 of ‘__builtin_strchr’ must be non-null
# 581| gsize len;
# 582|
# 583|-> slash = strchr (filesystem, '/');
# 584|
# 585| if (slash)
Error: GCC_ANALYZER_WARNING (CWE-401):
flatpak-1.15.8/common/flatpak-context.c: scope_hint: In function ‘flatpak_context_export’
flatpak-1.15.8/common/flatpak-context.c:2534:13: warning[-Wanalyzer-malloc-leak]: leak of ‘opendir("/")’
/usr/lib64/glib-2.0/include/glibconfig.h:103:51: note: in definition of macro ‘GPOINTER_TO_INT’
flatpak-1.15.8/common/flatpak-context.c:2530:7: note: in expansion of macro ‘g_info’
# 2532|
# 2533| /* Bind mount most dirs in / into the new root */
# 2534|-> dir = opendir ("/");
# 2535| if (dir != NULL)
# 2536| {
Error: CLANG_WARNING:
flatpak-1.15.8/common/flatpak-exports.c:674:10: warning[deadcode.DeadStores]: Although the value stored to 'canonical' is used in the enclosing expression, the value is never actually read from 'canonical'
# 672|
# 673| /* Syntactic canonicalization only, no need to use host_fd */
# 674|-> path = canonical = flatpak_canonicalize_filename (path);
# 675|
# 676| parts = g_strsplit (path + 1, "/", -1);
Error: CLANG_WARNING:
flatpak-1.15.8/common/flatpak-oci-registry.c:1023:13: warning[deadcode.DeadStores]: Although the value stored to 'default_scope' is used in the enclosing expression, the value is never actually read from 'default_scope'
# 1021| scope = g_hash_table_lookup (params, "scope");
# 1022| if (scope == NULL)
# 1023|-> scope = default_scope = g_strdup_printf("repository:%s:pull", repository);
# 1024|
# 1025| flatpak_uri_encode_query_arg (args, "scope", (char *)scope);
Error: CLANG_WARNING:
flatpak-1.15.8/common/flatpak-oci-registry.c:1884:12: warning[unix.Malloc]: Potential leak of memory pointed to by 'buffer1'
# 1882|
# 1883| if (!g_input_stream_read_all (in_raw, header, sizeof(header), NULL, cancellable, error))
# 1884|-> return FALSE;
# 1885|
# 1886| if (memcmp (header, DELTA_HEADER, DELTA_HEADER_LEN) != 0)
Error: CLANG_WARNING:
flatpak-1.15.8/common/flatpak-oci-registry.c:1884:12: warning[unix.Malloc]: Potential leak of memory pointed to by 'buffer2'
# 1882|
# 1883| if (!g_input_stream_read_all (in_raw, header, sizeof(header), NULL, cancellable, error))
# 1884|-> return FALSE;
# 1885|
# 1886| if (memcmp (header, DELTA_HEADER, DELTA_HEADER_LEN) != 0)
Error: CLANG_WARNING:
flatpak-1.15.8/common/flatpak-prune.c:753:36: warning[unix.Malloc]: Potential leak of memory pointed to by 'reachable'
# 751| if (ostree_repo_get_mode (repo) != OSTREE_REPO_MODE_ARCHIVE)
# 752| {
# 753|-> OstreeRepoPruneFlags flags = OSTREE_REPO_PRUNE_FLAGS_REFS_ONLY;
# 754| if (dry_run)
# 755| flags |= OSTREE_REPO_PRUNE_FLAGS_NO_PRUNE;
Error: CLANG_WARNING:
flatpak-1.15.8/common/flatpak-ref-utils.c:1502:26: warning[core.NonNullParamChecker]: Null pointer passed to 1st parameter expecting 'nonnull'
# 1500| const char *end;
# 1501|
# 1502|-> slash = (const char *) strchr (*partial_ref, '/');
# 1503| if (slash != NULL)
# 1504| {
Error: GCC_ANALYZER_WARNING (CWE-476):
flatpak-1.15.8/common/flatpak-ref-utils.c: scope_hint: In function ‘_flatpak_split_partial_ref_arg’
flatpak-1.15.8/common/flatpak-ref-utils.c:1576:12: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘local_error’
# 1574|
# 1575| if (validate && !flatpak_is_valid_name (id, -1, &local_error))
# 1576|-> return flatpak_fail_error (error, FLATPAK_ERROR_INVALID_REF, _("Invalid id %s: %s"), id, local_error->message);
# 1577|
# 1578| arch_start = partial_ref;
Error: GCC_ANALYZER_WARNING (CWE-775):
flatpak-1.15.8/common/flatpak-run-dbus.c: scope_hint: In function ‘add_bwrap_wrapper’
flatpak-1.15.8/common/flatpak-run-dbus.c:44:17: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘open(app_info_path, 524288)’
# 42| g_autofree char *proxy_socket_dir = g_build_filename (user_runtime_dir, ".dbus-proxy/", NULL);
# 43|
# 44|-> app_info_fd = open (app_info_path, O_RDONLY | O_CLOEXEC);
# 45| if (app_info_fd == -1)
# 46| return glnx_throw_errno_prefix (error, _("Failed to open app info file"));
Error: CLANG_WARNING:
flatpak-1.15.8/common/flatpak-transaction.c:4130:9: warning[deadcode.DeadStores]: Value stored to 'old' is never read
# 4128| g_hash_table_insert (need_token_ht, op->remote, g_list_append (NULL, op));
# 4129| else
# 4130|-> old = g_list_append (old, op);
# 4131| }
# 4132|
Error: CLANG_WARNING:
flatpak-1.15.8/portal/flatpak-portal.c:1054:54: warning[core.NullDereference]: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')
# 1052| G_DBUS_ERROR_INVALID_ARGS,
# 1053| "Could not load environment for \"flatpak run\": %s",
# 1054|-> error->message);
# 1055| return G_DBUS_METHOD_INVOCATION_HANDLED;
# 1056| }
Error: CLANG_WARNING:
flatpak-1.15.8/portal/flatpak-portal.c:1269:7: warning[deadcode.DeadStores]: Value stored to 'instance_id_out_stream' is never read
# 1267| GInputStream *in_stream = G_INPUT_STREAM (g_unix_input_stream_new (pipe_fds[0], TRUE));
# 1268| /* This is saved to ensure the portal's end gets closed after the exec. */
# 1269|-> instance_id_out_stream = G_OUTPUT_STREAM (g_unix_output_stream_new (pipe_fds[1], TRUE));
# 1270|
# 1271| instance_id_read_data = g_new0 (InstanceIdReadData, 1);
Error: GCC_ANALYZER_WARNING (CWE-465):
flatpak-1.15.8/portal/flatpak-portal.c: scope_hint: In function ‘handle_spawn’
flatpak-1.15.8/portal/flatpak-portal.c:1466:6: warning[-Wanalyzer-deref-before-check]: check of ‘arg_cwd_path’ for NULL after already dereferencing it
/usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here.
/usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
/usr/include/glib-2.0/glib-unix.h:36: included_from: Included from here.
flatpak-1.15.8/portal/flatpak-portal.c:34: included_from: Included from here.
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/portal/flatpak-portal.c:811:3: note: in expansion of macro ‘g_assert’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/portal/flatpak-portal.c:816:3: note: in expansion of macro ‘g_assert’
/usr/include/glib-2.0/glib.h:64: included_from: Included from here.
flatpak-1.15.8/portal/flatpak-portal.c:818:3: note: in expansion of macro ‘g_info’
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
flatpak-1.15.8/portal/flatpak-portal.c:1061:36: note: in expansion of macro ‘g_strdup’
flatpak-1.15.8/portal/flatpak-portal.c: scope_hint: In function ‘handle_spawn’
# 1464| }
# 1465|
# 1466|-> if (arg_cwd_path != NULL)
# 1467| g_ptr_array_add (flatpak_argv, g_strdup_printf ("--cwd=%s", arg_cwd_path));
# 1468|
Error: CLANG_WARNING:
flatpak-1.15.8/portal/portal-impl.c:56:12: warning[unix.Malloc]: Potential leak of memory pointed to by 'impl'
# 54|
# 55| if (!g_key_file_load_from_file (keyfile, path, G_KEY_FILE_NONE, error))
# 56|-> return FALSE;
# 57|
# 58| impl->source = g_path_get_basename (path);
Error: CLANG_WARNING:
flatpak-1.15.8/redhat-linux-build/flatpak-scan.c:202:16: warning[deadcode.DeadStores]: Although the value stored to 'event_num' is used in the enclosing expression, the value is never actually read from 'event_num'
Error: CLANG_WARNING:
flatpak-1.15.8/redhat-linux-build/tmp-introspecthnt0ql6t/Flatpak-1.0.c:799:27: warning[core.NullDereference]: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')
Error: CLANG_WARNING:
flatpak-1.15.8/revokefs/writer.c:91:3: warning[deadcode.DeadStores]: Value stored to 'locker' is never read
# 89| }
# 90|
# 91|-> locker = g_mutex_locker_new (&mutex);
# 92| written_size = TEMP_FAILURE_RETRY (writev (writer_socket, write_vecs, n_write_vecs));
# 93| if (written_size == -1)
Error: CLANG_WARNING:
flatpak-1.15.8/revokefs/writer.c:112:7: warning[deadcode.DeadStores]: Value stored to 'response_max_size' is never read
# 110| read_vecs[n_read_vecs].iov_base = response_data;
# 111| read_vecs[n_read_vecs++].iov_len = response_data_size;
# 112|-> response_max_size += response_data_size;
# 113| }
# 114|
Error: CLANG_WARNING:
flatpak-1.15.8/session-helper/flatpak-session-helper.c:867:3: warning[deadcode.DeadStores]: Value stored to 'm_resolv_conf' is never read
# 865| }
# 866|
# 867|-> m_resolv_conf = setup_file_monitor ("/etc/resolv.conf");
# 868| m_host_conf = setup_file_monitor ("/etc/host.conf");
# 869| m_hosts = setup_file_monitor ("/etc/hosts");
Error: CLANG_WARNING:
flatpak-1.15.8/session-helper/flatpak-session-helper.c:868:3: warning[deadcode.DeadStores]: Value stored to 'm_host_conf' is never read
# 866|
# 867| m_resolv_conf = setup_file_monitor ("/etc/resolv.conf");
# 868|-> m_host_conf = setup_file_monitor ("/etc/host.conf");
# 869| m_hosts = setup_file_monitor ("/etc/hosts");
# 870| m_gai_conf = setup_file_monitor ("/etc/gai.conf");
Error: CLANG_WARNING:
flatpak-1.15.8/session-helper/flatpak-session-helper.c:869:3: warning[deadcode.DeadStores]: Value stored to 'm_hosts' is never read
# 867| m_resolv_conf = setup_file_monitor ("/etc/resolv.conf");
# 868| m_host_conf = setup_file_monitor ("/etc/host.conf");
# 869|-> m_hosts = setup_file_monitor ("/etc/hosts");
# 870| m_gai_conf = setup_file_monitor ("/etc/gai.conf");
# 871| m_localtime = setup_file_monitor ("/etc/localtime");
Error: CLANG_WARNING:
flatpak-1.15.8/session-helper/flatpak-session-helper.c:870:3: warning[deadcode.DeadStores]: Value stored to 'm_gai_conf' is never read
# 868| m_host_conf = setup_file_monitor ("/etc/host.conf");
# 869| m_hosts = setup_file_monitor ("/etc/hosts");
# 870|-> m_gai_conf = setup_file_monitor ("/etc/gai.conf");
# 871| m_localtime = setup_file_monitor ("/etc/localtime");
# 872|
Error: CLANG_WARNING:
flatpak-1.15.8/session-helper/flatpak-session-helper.c:871:3: warning[deadcode.DeadStores]: Value stored to 'm_localtime' is never read
# 869| m_hosts = setup_file_monitor ("/etc/hosts");
# 870| m_gai_conf = setup_file_monitor ("/etc/gai.conf");
# 871|-> m_localtime = setup_file_monitor ("/etc/localtime");
# 872|
# 873| flags = G_BUS_NAME_OWNER_FLAGS_ALLOW_REPLACEMENT;
Error: CLANG_WARNING:
flatpak-1.15.8/subprojects/libglnx/glnx-fdio.c:526:16: warning[unix.Malloc]: Potential leak of memory pointed to by 'buf'
# 524|
# 525| if (g_cancellable_set_error_if_cancelled (cancellable, error))
# 526|-> return FALSE;
# 527|
# 528| gssize bytes_read;
Error: CLANG_WARNING:
flatpak-1.15.8/subprojects/libglnx/glnx-fdio.c:674:16: warning[unix.Malloc]: Potential leak of memory pointed to by 'c'
# 672| ssize_t n = TEMP_FAILURE_RETRY (readlinkat (dfd, subpath, c, l-1));
# 673| if (n < 0)
# 674|-> return glnx_null_throw_errno_prefix (error, "readlinkat");
# 675|
# 676| if ((size_t) n < l-1)
Error: GCC_ANALYZER_WARNING (CWE-775):
flatpak-1.15.8/subprojects/libglnx/libglnx.h:30: included_from: Included from here.
flatpak-1.15.8/common/flatpak-run-dbus-private.h:23: included_from: Included from here.
flatpak-1.15.8/common/flatpak-run-dbus.c:22: included_from: Included from here.
flatpak-1.15.8/subprojects/libglnx/glnx-local-alloc.h: scope_hint: In function ‘glnx_close_fd’
flatpak-1.15.8/subprojects/libglnx/glnx-local-alloc.h:74:1: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘fd’
/usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here.
/usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
/usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here.
/usr/include/glib-2.0/glib-object.h:24: included_from: Included from here.
/usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here.
/usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here.
/usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here.
flatpak-1.15.8/subprojects/libglnx/libglnx.h:24: included_from: Included from here.
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/subprojects/libglnx/glnx-local-alloc.h:64:3: note: in expansion of macro ‘g_assert’
flatpak-1.15.8/subprojects/libglnx/glnx-local-alloc.h: scope_hint: In function ‘glnx_close_fd’
# 72| errno = errsv;
# 73| }
# 74|-> }
# 75|
# 76| /**
Error: GCC_ANALYZER_WARNING (CWE-688):
flatpak-1.15.8/subprojects/libglnx/glnx-lockfile.c: scope_hint: In function ‘glnx_make_lock_file’
flatpak-1.15.8/subprojects/libglnx/glnx-lockfile.c:91:22: warning[-Wanalyzer-null-argument]: use of NULL ‘p’ where non-null expected
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
/usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here.
/usr/include/glib-2.0/glib-object.h:24: included_from: Included from here.
/usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here.
/usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here.
/usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here.
flatpak-1.15.8/subprojects/libglnx/glnx-backport-autoptr.h:27: included_from: Included from here.
flatpak-1.15.8/subprojects/libglnx/glnx-lockfile.h:26: included_from: Included from here.
flatpak-1.15.8/subprojects/libglnx/glnx-lockfile.c:40: included_from: Included from here.
flatpak-1.15.8/subprojects/libglnx/glnx-lockfile.c:80:13: note: in expansion of macro ‘g_strdup’
/usr/include/features.h:511: included_from: Included from here.
/usr/include/bits/libc-header-start.h:33: included_from: Included from here.
/usr/include/stdlib.h:26: included_from: Included from here.
flatpak-1.15.8/subprojects/libglnx/glnx-lockfile.c:28: included_from: Included from here.
/usr/include/fcntl.h:237:12: note: argument 2 of ‘openat’ must be non-null
# 89| struct stat st;
# 90|
# 91|-> fd = openat(dfd, p, O_CREAT|O_RDWR|O_NOFOLLOW|O_CLOEXEC|O_NOCTTY, 0600);
# 92| if (fd < 0)
# 93| return glnx_throw_errno(error);
Error: CLANG_WARNING:
flatpak-1.15.8/subprojects/libglnx/glnx-xattrs.c:200:16: warning[unix.Malloc]: Potential leak of memory pointed to by 'xattr_names'
# 198| }
# 199|
# 200|-> ret_xattrs = g_variant_builder_end (&builder);
# 201| builder_initialized = FALSE;
# 202| g_variant_ref_sink (ret_xattrs);
Error: CLANG_WARNING:
flatpak-1.15.8/system-helper/flatpak-system-helper.c:1473:20: warning[unix.Malloc]: Potential leak of memory pointed to by 'buf'
# 1471| continue;
# 1472| }
# 1473|-> else if (err == 0) /* User SYSTEM_HELPER_USER 's record was not found*/
# 1474| {
# 1475| g_set_error (error, G_IO_ERROR, G_IO_ERROR_NOT_FOUND,
Error: GCC_ANALYZER_WARNING (CWE-476):
flatpak-1.15.8/system-helper/flatpak-system-helper.c: scope_hint: In function ‘flatpak_authorize_method_handler’
flatpak-1.15.8/system-helper/flatpak-system-helper.c:2086:15: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘sys_error’
# 2084| if (system == NULL)
# 2085| {
# 2086|-> g_dbus_method_invocation_return_error (invocation, G_DBUS_ERROR, G_DBUS_ERROR_FAILED,
# 2087| "Error getting installation %s: %s", installation, sys_error->message);
# 2088| return FALSE;
Error: CLANG_WARNING:
flatpak-1.15.8/system-helper/flatpak-system-helper.c:2087:105: warning[core.NullDereference]: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'sys_error')
# 2085| {
# 2086| g_dbus_method_invocation_return_error (invocation, G_DBUS_ERROR, G_DBUS_ERROR_FAILED,
# 2087|-> "Error getting installation %s: %s", installation, sys_error->message);
# 2088| return FALSE;
# 2089| }
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/test-context.c: scope_hint: In function ‘context_parse_args’
flatpak-1.15.8/tests/test-context.c:151:15: warning[-Wanalyzer-va-list-exhausted]: ‘ap’ has no more arguments (2 consumed)
/usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here.
/usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:56: included_from: Included from here.
flatpak-1.15.8/tests/test-context.c:22: included_from: Included from here.
flatpak-1.15.8/tests/test-context.c:152:28: note: in expansion of macro ‘g_strdup’
flatpak-1.15.8/tests/test-context.c: scope_hint: In function ‘context_parse_args’
flatpak-1.15.8/tests/test-context.c:152:28: note: in expansion of macro ‘g_strdup’
flatpak-1.15.8/tests/test-context.c: scope_hint: In function ‘context_parse_args’
# 149| va_start (ap, error);
# 150|
# 151|-> while ((arg = va_arg (ap, const char *)) != NULL)
# 152| g_ptr_array_add (args, g_strdup (arg));
# 153|
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/testapp.c: scope_hint: In function ‘assert_numbers’
flatpak-1.15.8/tests/testapp.c:150:9: warning[-Wanalyzer-va-list-exhausted]: ‘args’ has no more arguments (1 consumed)
/usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here.
/usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
flatpak-1.15.8/tests/testapp.c:7: included_from: Included from here.
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
/usr/include/glib-2.0/glib.h:89: included_from: Included from here.
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
# 148| for (i = 0; num[i]; i++)
# 149| {
# 150|-> n = va_arg (args, int);
# 151| g_assert_true (n == num[i]);
# 152| }
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/testapp.c:150:9: warning[-Wanalyzer-va-list-exhausted]: ‘args’ has no more arguments (2 consumed)
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
/usr/include/glib-2.0/glib/glist.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/ghash.h:36: included_from: Included from here.
/usr/include/glib-2.0/glib.h:52: included_from: Included from here.
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
# 148| for (i = 0; num[i]; i++)
# 149| {
# 150|-> n = va_arg (args, int);
# 151| g_assert_true (n == num[i]);
# 152| }
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/testapp.c:150:9: warning[-Wanalyzer-va-list-exhausted]: ‘args’ has no more arguments (3 consumed)
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:174:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:174:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:178:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:178:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
# 148| for (i = 0; num[i]; i++)
# 149| {
# 150|-> n = va_arg (args, int);
# 151| g_assert_true (n == num[i]);
# 152| }
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/testapp.c:150:9: warning[-Wanalyzer-va-list-exhausted]: ‘args’ has no more arguments (4 consumed)
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
# 148| for (i = 0; num[i]; i++)
# 149| {
# 150|-> n = va_arg (args, int);
# 151| g_assert_true (n == num[i]);
# 152| }
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/testapp.c:150:9: warning[-Wanalyzer-va-list-exhausted]: ‘args’ has no more arguments (5 consumed)
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:174:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:174:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:178:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:178:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:188:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:188:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
# 148| for (i = 0; num[i]; i++)
# 149| {
# 150|-> n = va_arg (args, int);
# 151| g_assert_true (n == num[i]);
# 152| }
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/testapp.c:154:5: warning[-Wanalyzer-va-list-exhausted]: ‘args’ has no more arguments (1 consumed)
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
# 152| }
# 153|
# 154|-> n = va_arg (args, int);
# 155| g_assert_true (n == 0);
# 156| va_end (args);
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/testapp.c:154:5: warning[-Wanalyzer-va-list-exhausted]: ‘args’ has no more arguments (2 consumed)
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
# 152| }
# 153|
# 154|-> n = va_arg (args, int);
# 155| g_assert_true (n == 0);
# 156| va_end (args);
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/testapp.c:154:5: warning[-Wanalyzer-va-list-exhausted]: ‘args’ has no more arguments (3 consumed)
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:174:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:174:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:178:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:178:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
# 152| }
# 153|
# 154|-> n = va_arg (args, int);
# 155| g_assert_true (n == 0);
# 156| va_end (args);
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/testapp.c:154:5: warning[-Wanalyzer-va-list-exhausted]: ‘args’ has no more arguments (4 consumed)
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
# 152| }
# 153|
# 154|-> n = va_arg (args, int);
# 155| g_assert_true (n == 0);
# 156| va_end (args);
Error: GCC_ANALYZER_WARNING (CWE-685):
flatpak-1.15.8/tests/testapp.c:154:5: warning[-Wanalyzer-va-list-exhausted]: ‘args’ has no more arguments (5 consumed)
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:166:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:170:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:174:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:174:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:178:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:178:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:155:3: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:188:3: note: in expansion of macro ‘g_clear_pointer’
flatpak-1.15.8/tests/testapp.c:188:3: note: in expansion of macro ‘g_clear_pointer’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:228:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
flatpak-1.15.8/tests/testapp.c:151:7: note: in expansion of macro ‘g_assert_true’
# 152| }
# 153|
# 154|-> n = va_arg (args, int);
# 155| g_assert_true (n == 0);
# 156| va_end (args);
Error: GCC_ANALYZER_WARNING (CWE-476):
flatpak-1.15.8/tests/testlib.c: scope_hint: In function ‘tests_dbus_daemon_setup’
flatpak-1.15.8/tests/testlib.c:223:12: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘newline’
/usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here.
/usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here.
/usr/include/glib-2.0/glib.h:32: included_from: Included from here.
flatpak-1.15.8/tests/testlib.h:21: included_from: Included from here.
flatpak-1.15.8/tests/testlib.c:19: included_from: Included from here.
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:175:3: note: in expansion of macro ‘g_return_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1237:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:176:3: note: in expansion of macro ‘g_return_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:176:3: note: in expansion of macro ‘g_return_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1237:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:177:3: note: in expansion of macro ‘g_return_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:177:3: note: in expansion of macro ‘g_return_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1237:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:178:3: note: in expansion of macro ‘g_return_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:178:3: note: in expansion of macro ‘g_return_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gtestutils.h:255:49: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:222:3: note: in expansion of macro ‘g_assert_nonnull’
/usr/include/glib-2.0/glib.h:89: included_from: Included from here.
flatpak-1.15.8/tests/testlib.c:222:3: note: in expansion of macro ‘g_assert_nonnull’
# 221| newline = strchr (address_buffer, '\n');
# 222| g_assert_nonnull (newline);
# 223|-> *newline = '\0';
# 224| self->dbus_address = g_strdup (address_buffer);
# 225| }
Error: GCC_ANALYZER_WARNING (CWE-775):
flatpak-1.15.8/tests/testlib.c: scope_hint: In function ‘tests_stdout_to_stderr_begin’
flatpak-1.15.8/tests/testlib.c:265:6: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘dup2(2, 1)’
# 263| g_error ("fcntl F_DUPFD_CLOEXEC: %s", g_strerror (errno));
# 264|
# 265|-> if (dup2 (STDERR_FILENO, STDOUT_FILENO) < 0)
# 266| g_error ("dup2: %s", g_strerror (errno));
# 267|
Error: GCC_ANALYZER_WARNING (CWE-775):
flatpak-1.15.8/tests/testlib.c: scope_hint: In function ‘tests_stdout_to_stderr_end’
flatpak-1.15.8/tests/testlib.c:279:6: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘dup2(*original.fd, 1)’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:276:3: note: in expansion of macro ‘g_return_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1237:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:277:3: note: in expansion of macro ‘g_return_if_fail’
/usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’
/usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’
/usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’
flatpak-1.15.8/tests/testlib.c:277:3: note: in expansion of macro ‘g_return_if_fail’
# 277| g_return_if_fail (original->fd >= 0);
# 278|
# 279|-> if (dup2 (original->fd, STDOUT_FILENO) < 0)
# 280| g_error ("dup2: %s", g_strerror (errno));
# 281|
Error: GCC_ANALYZER_WARNING:
flatpak-1.15.8/tests/try-syscall.c: scope_hint: In function ‘main’
flatpak-1.15.8/tests/try-syscall.c:166:15: warning[-Wanalyzer-fd-use-without-check]: ‘listen’ on possibly invalid file descriptor ‘-1’
# 164| {
# 165| /* If not blocked by seccomp, this will fail with EBADF */
# 166|-> if (listen (-1, 42) != 0)
# 167| {
# 168| errsv = errno;