Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-476): [#def1]
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/cal.c: scope_hint: In function ‘monthly’
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/cal.c:1085:28: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc((long unsigned int)*ctl.months_in_row, 208) + (sizetype)i * 208’
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/cal.c:79: included_from: Included from here.
# 1083|   
# 1084|   	for (i = 0; i < ctl->months_in_row - 1; i++)
# 1085|-> 		ms[i].next = &ms[i + 1];
# 1086|   
# 1087|   	rows = (ctl->num_months - 1) / ctl->months_in_row;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def2]
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/hardlink.c: scope_hint: In function ‘get_sorted_xattr_name_table’
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/hardlink.c:529:26: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc((long unsigned int)n, 8) + (long unsigned int)i * 8’
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/hardlink.c: scope_hint: In function ‘get_sorted_xattr_name_table’
util-linux-2.42.start-build/util-linux-2.42.start/include/optutils.h:8: included_from: Included from here.
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/hardlink.c:58: included_from: Included from here.
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/hardlink.c:55: included_from: Included from here.
#  527|   
#  528|   	for (i = 0; i < n; i++) {
#  529|-> 		table[i] = names;
#  530|   		names += strlen(names) + 1;
#  531|   	}

Error: GCC_ANALYZER_WARNING (CWE-476): [#def3]
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/waitpid.c: scope_hint: In function ‘parse_pids’
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/waitpid.c:54:25: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc(n_strings, 4) + i * 4’
util-linux-2.42.start-build/util-linux-2.42.start/include/strutils.h:53:64: note: in definition of macro ‘strtopid_or_err’
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/waitpid.c:54:55: note: in expansion of macro ‘_’
#   52|   
#   53|   	for (size_t i = 0; i < n_strings; i++)
#   54|-> 		pids[i] = strtopid_or_err(strings[i], _("failed to parse pid"));
#   55|   
#   56|   	return pids;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def4]
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/waitpid.c: scope_hint: In function ‘open_pidfds’
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/waitpid.c:64:27: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc(n_pids, 4)’
util-linux-2.42.start-build/util-linux-2.42.start/include/strutils.h:53:64: note: in definition of macro ‘strtopid_or_err’
util-linux-2.42.start-build/util-linux-2.42.start/misc-utils/waitpid.c:54:55: note: in expansion of macro ‘_’
#   62|   
#   63|   	for (size_t i = 0; i < n_pids; i++) {
#   64|-> 		pidfds[i] = pidfd_open(pids[i], 0);
#   65|   		if (pidfds[i] == -1) {
#   66|   			if (allow_exited && errno == ESRCH) {

Scan Properties

analyzer-version-clippy1.85.1
analyzer-version-cppcheck2.17.1
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.85.1
diffbase-analyzer-version-cppcheck2.17.1
diffbase-analyzer-version-gcc15.0.1
diffbase-analyzer-version-gcc-analyzer15.0.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-63.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-nameutil-linux-2.42.start-1.20250403044139981537.pr3504.192.g35aa1f394
diffbase-store-results-to/tmp/tmpaiym7fl_/util-linux-2.42.start-1.20250403044139981537.pr3504.192.g35aa1f394.tar.xz
diffbase-time-created2025-04-03 05:09:16
diffbase-time-finished2025-04-03 05:17:16
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'cppcheck,shellcheck,unicontrol,clippy,gcc' '-o' '/tmp/tmpaiym7fl_/util-linux-2.42.start-1.20250403044139981537.pr3504.192.g35aa1f394.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmpaiym7fl_/util-linux-2.42.start-1.20250403044139981537.pr3504.192.g35aa1f394.src.rpm'
diffbase-tool-versioncsmock-3.8.0-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-63.us-west-2.compute.internal
mock-configfedora-rawhide-x86_64
project-nameutil-linux-2.42.start-1.20250401131045352971.master.190.ge8e30931b
store-results-to/tmp/tmpdpnnetak/util-linux-2.42.start-1.20250401131045352971.master.190.ge8e30931b.tar.xz
time-created2025-04-03 04:59:33
time-finished2025-04-03 05:08:43
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'cppcheck,shellcheck,unicontrol,clippy,gcc' '-o' '/tmp/tmpdpnnetak/util-linux-2.42.start-1.20250401131045352971.master.190.ge8e30931b.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmpdpnnetak/util-linux-2.42.start-1.20250401131045352971.master.190.ge8e30931b.src.rpm'
tool-versioncsmock-3.8.0-1.el9