Task #473 - gnome-software-46.2-1.fc41/scan-results.err
back to task #473download
Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-list.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-list.c:463:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 461| g_return_if_fail (GS_IS_APP_LIST (list)); # 462| g_return_if_fail (GS_IS_APP (app)); # 463|-> locker = g_mutex_locker_new (&list->mutex); # 464| gs_app_list_add_safe (list, app, GS_APP_LIST_ADD_FLAG_CHECK_FOR_DUPE); # 465| Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-list.c:491:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 489| g_return_val_if_fail (GS_IS_APP (app), FALSE); # 490| # 491|-> locker = g_mutex_locker_new (&list->mutex); # 492| removed = g_ptr_array_remove (list->array, app); # 493| if (removed) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-list.c:523:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 521| g_return_if_fail (list != donor); # 522| # 523|-> locker = g_mutex_locker_new (&list->mutex); # 524| # 525| /* add each app */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-list.c:595:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 593| g_autoptr(GMutexLocker) locker = NULL; # 594| g_return_if_fail (GS_IS_APP_LIST (list)); # 595|-> locker = g_mutex_locker_new (&list->mutex); # 596| gs_app_list_remove_all_safe (list); # 597| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-list.c:620:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 618| g_return_if_fail (func != NULL); # 619| # 620|-> locker = g_mutex_locker_new (&list->mutex); # 621| # 622| /* deep copy to a temp list and clear the current one */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-list.c:664:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 662| GsAppListSortHelper helper; # 663| g_return_if_fail (GS_IS_APP_LIST (list)); # 664|-> locker = g_mutex_locker_new (&list->mutex); # 665| helper.func = func; # 666| helper.user_data = user_data; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-list.c:698:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 696| # 697| /* remove the apps in the positions larger than the length */ # 698|-> locker = g_mutex_locker_new (&list->mutex); # 699| g_ptr_array_set_size (list->array, length); # 700| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-list.c:720:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 718| g_return_if_fail (GS_IS_APP_LIST (list)); # 719| # 720|-> locker = g_mutex_locker_new (&list->mutex); # 721| # 722| if (!gs_app_list_length (list)) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-list.c:833:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 831| g_return_if_fail (GS_IS_APP_LIST (list)); # 832| # 833|-> locker = g_mutex_locker_new (&list->mutex); # 834| # 835| /* a hash table to hold apps with unique app ids */ Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-permissions.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: GCC_ANALYZER_WARNING (CWE-688): gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-query.c: scope_hint: In function ‘gs_app_query_sanitize_keywords’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-query.c:142:21: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-query.c:47: included_from: Included from here. gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-query.c:140:42: note: in expansion of macro ‘g_strdup’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-query.c:140:42: note: in expansion of macro ‘g_strdup’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-query.c: scope_hint: In function ‘gs_app_query_sanitize_keywords’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-app-query.c:141:17: note: in expansion of macro ‘g_strstrip’ <built-in>: note: argument 1 of ‘__builtin_strchr’ must be non-null # 140| g_autofree gchar *term = g_strdup (terms[0]); # 141| g_strstrip (term); # 142|-> if (strchr (term, ' ')) { # 143| g_auto(GStrv) split = g_strsplit (term, " ", -1); # 144| for (guint i = 0; split[i] != NULL; i++) { Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:546:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 544| klass = GS_APP_GET_CLASS (app); # 545| # 546|-> locker = g_mutex_locker_new (&priv->mutex); # 547| # 548| g_string_append_printf (str, " [%p]\n", app); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:862:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 860| g_autoptr(GMutexLocker) locker = NULL; # 861| g_return_if_fail (GS_IS_APP (app)); # 862|-> locker = g_mutex_locker_new (&priv->mutex); # 863| if (_g_set_str (&priv->id, id)) # 864| priv->unique_id_valid = FALSE; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1258:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1256| g_autoptr(GMutexLocker) locker = NULL; # 1257| g_return_if_fail (GS_IS_APP (app)); # 1258|-> locker = g_mutex_locker_new (&priv->mutex); # 1259| if (priv->progress == percentage) # 1260| return; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1287:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1285| g_autoptr(GMutexLocker) locker = NULL; # 1286| g_return_if_fail (GS_IS_APP (app)); # 1287|-> locker = g_mutex_locker_new (&priv->mutex); # 1288| if (priv->allow_cancel == allow_cancel) # 1289| return; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1337:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1335| g_return_if_fail (GS_IS_APP (app)); # 1336| # 1337|-> locker = g_mutex_locker_new (&priv->mutex); # 1338| # 1339| if (gs_app_set_state_internal (app, state)) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1400:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1398| g_return_if_fail (GS_IS_APP (app)); # 1399| # 1400|-> locker = g_mutex_locker_new (&priv->mutex); # 1401| # 1402| /* same */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1471:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1469| g_autoptr(GMutexLocker) locker = NULL; # 1470| g_return_val_if_fail (GS_IS_APP (app), NULL); # 1471|-> locker = g_mutex_locker_new (&priv->mutex); # 1472| return gs_app_get_unique_id_unlocked (app); # 1473| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1492:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1490| g_return_if_fail (GS_IS_APP (app)); # 1491| # 1492|-> locker = g_mutex_locker_new (&priv->mutex); # 1493| # 1494| /* check for sanity */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1538:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1536| g_return_if_fail (GS_IS_APP (app)); # 1537| # 1538|-> locker = g_mutex_locker_new (&priv->mutex); # 1539| # 1540| /* only save this if the data is sufficiently high quality */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1582:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1580| g_autoptr(GMutexLocker) locker = NULL; # 1581| g_return_if_fail (GS_IS_APP (app)); # 1582|-> locker = g_mutex_locker_new (&priv->mutex); # 1583| _g_set_str (&priv->renamed_from, renamed_from); # 1584| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1619:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1617| g_autoptr(GMutexLocker) locker = NULL; # 1618| g_return_if_fail (GS_IS_APP (app)); # 1619|-> locker = g_mutex_locker_new (&priv->mutex); # 1620| if (_g_set_str (&priv->branch, branch)) # 1621| priv->unique_id_valid = FALSE; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1664:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1662| g_return_if_fail (source != NULL); # 1663| # 1664|-> locker = g_mutex_locker_new (&priv->mutex); # 1665| # 1666| /* check source doesn't already exist */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1710:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1708| g_autoptr(GMutexLocker) locker = NULL; # 1709| g_return_if_fail (GS_IS_APP (app)); # 1710|-> locker = g_mutex_locker_new (&priv->mutex); # 1711| _g_set_ptr_array (&priv->sources, sources); # 1712| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1766:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1764| g_autoptr(GMutexLocker) locker = NULL; # 1765| g_return_if_fail (GS_IS_APP (app)); # 1766|-> locker = g_mutex_locker_new (&priv->mutex); # 1767| g_ptr_array_set_size (priv->source_ids, 0); # 1768| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1786:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1784| g_autoptr(GMutexLocker) locker = NULL; # 1785| g_return_if_fail (GS_IS_APP (app)); # 1786|-> locker = g_mutex_locker_new (&priv->mutex); # 1787| _g_set_ptr_array (&priv->source_ids, source_ids); # 1788| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1871:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1869| g_autoptr(GMutexLocker) locker = NULL; # 1870| g_return_if_fail (GS_IS_APP (app)); # 1871|-> locker = g_mutex_locker_new (&priv->mutex); # 1872| _g_set_str (&priv->project_group, project_group); # 1873| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:1890:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1888| g_autoptr(GMutexLocker) locker = NULL; # 1889| g_return_if_fail (GS_IS_APP (app)); # 1890|-> locker = g_mutex_locker_new (&priv->mutex); # 1891| _g_set_str (&priv->developer_name, developer_name); # 1892| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2073:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2071| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2072| # 2073|-> locker = g_mutex_locker_new (&priv->mutex); # 2074| # 2075| if (priv->icons == NULL || priv->icons->len == 0) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2104:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2102| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2103| # 2104|-> locker = g_mutex_locker_new (&priv->mutex); # 2105| # 2106| if (priv->icons == NULL || priv->icons->len == 0) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2135:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2133| g_return_val_if_fail (GS_IS_APP (app), FALSE); # 2134| # 2135|-> locker = g_mutex_locker_new (&priv->mutex); # 2136| # 2137| return priv->icons != NULL && priv->icons->len > 0; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2178:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2176| g_return_if_fail (G_IS_ICON (icon)); # 2177| # 2178|-> locker = g_mutex_locker_new (&priv->mutex); # 2179| # 2180| if (priv->icons == NULL) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2203:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2201| g_autoptr(GMutexLocker) locker = NULL; # 2202| g_return_if_fail (GS_IS_APP (app)); # 2203|-> locker = g_mutex_locker_new (&priv->mutex); # 2204| # 2205| if (priv->icons != NULL) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2243:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2241| g_autoptr(GMutexLocker) locker = NULL; # 2242| g_return_if_fail (GS_IS_APP (app)); # 2243|-> locker = g_mutex_locker_new (&priv->mutex); # 2244| _g_set_str (&priv->agreement, agreement); # 2245| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2282:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2280| g_autoptr(GMutexLocker) locker = NULL; # 2281| g_return_if_fail (GS_IS_APP (app)); # 2282|-> locker = g_mutex_locker_new (&priv->mutex); # 2283| g_set_object (&priv->local_file, local_file); # 2284| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2302:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2300| g_autoptr(GMutexLocker) locker = NULL; # 2301| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2302|-> locker = g_mutex_locker_new (&priv->mutex); # 2303| return (priv->content_rating != NULL) ? g_object_ref (priv->content_rating) : NULL; # 2304| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2321:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2319| g_autoptr(GMutexLocker) locker = NULL; # 2320| g_return_if_fail (GS_IS_APP (app)); # 2321|-> locker = g_mutex_locker_new (&priv->mutex); # 2322| if (g_set_object (&priv->content_rating, content_rating)) # 2323| gs_app_queue_notify (app, obj_props[PROP_CONTENT_RATING]); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2361:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2359| g_return_if_fail (GS_IS_APP (runtime)); # 2360| g_return_if_fail (app != runtime); # 2361|-> locker = g_mutex_locker_new (&priv->mutex); # 2362| g_set_object (&priv->runtime, runtime); # 2363| Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2384:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2382| g_autoptr(GMutexLocker) locker = NULL; # 2383| g_return_if_fail (GS_IS_APP (app)); # 2384|-> locker = g_mutex_locker_new (&priv->mutex); # 2385| g_set_object (&priv->action_screenshot, action_screenshot); # 2386| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2551:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2549| g_return_if_fail (GS_IS_APP (app)); # 2550| # 2551|-> locker = g_mutex_locker_new (&priv->mutex); # 2552| # 2553| if (_g_set_str (&priv->version, version)) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2594:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2592| g_return_if_fail (GS_IS_APP (app)); # 2593| # 2594|-> locker = g_mutex_locker_new (&priv->mutex); # 2595| # 2596| /* only save this if the data is sufficiently high quality */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2639:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2637| g_return_if_fail (GS_IS_APP (app)); # 2638| # 2639|-> locker = g_mutex_locker_new (&priv->mutex); # 2640| # 2641| /* only save this if the data is sufficiently high quality */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2665:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2663| g_autoptr(GMutexLocker) locker = NULL; # 2664| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2665|-> locker = g_mutex_locker_new (&priv->mutex); # 2666| # 2667| if (priv->urls == NULL) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2692:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2690| g_return_if_fail (GS_IS_APP (app)); # 2691| # 2692|-> locker = g_mutex_locker_new (&priv->mutex); # 2693| # 2694| if (priv->urls == NULL) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2727:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2725| g_autoptr(GMutexLocker) locker = NULL; # 2726| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2727|-> locker = g_mutex_locker_new (&priv->mutex); # 2728| return priv->url_missing; # 2729| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2747:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2745| g_autoptr(GMutexLocker) locker = NULL; # 2746| g_return_if_fail (GS_IS_APP (app)); # 2747|-> locker = g_mutex_locker_new (&priv->mutex); # 2748| # 2749| if (g_strcmp0 (priv->url_missing, url) == 0) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2773:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2771| g_autoptr(GMutexLocker) locker = NULL; # 2772| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2773|-> locker = g_mutex_locker_new (&priv->mutex); # 2774| return g_hash_table_lookup (priv->launchables, # 2775| as_launchable_kind_to_string (kind)); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2796:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2794| g_autoptr(GMutexLocker) locker = NULL; # 2795| g_return_if_fail (GS_IS_APP (app)); # 2796|-> locker = g_mutex_locker_new (&priv->mutex); # 2797| key = as_launchable_kind_to_string (kind); # 2798| if (g_hash_table_lookup_extended (priv->launchables, key, NULL, ¤t_value)) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2863:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2861| g_return_if_fail (GS_IS_APP (app)); # 2862| # 2863|-> locker = g_mutex_locker_new (&priv->mutex); # 2864| # 2865| /* only save this if the data is sufficiently high quality */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:2911:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2909| g_autoptr(GMutexLocker) locker = NULL; # 2910| g_return_if_fail (GS_IS_APP (app)); # 2911|-> locker = g_mutex_locker_new (&priv->mutex); # 2912| _g_set_str (&priv->summary_missing, summary_missing); # 2913| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3000:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2998| g_autoptr(GMutexLocker) locker = NULL; # 2999| g_return_if_fail (GS_IS_APP (app)); # 3000|-> locker = g_mutex_locker_new (&priv->mutex); # 3001| _g_set_strv (&priv->menu_path, menu_path); # 3002| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3038:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3036| g_return_if_fail (GS_IS_APP (app)); # 3037| # 3038|-> locker = g_mutex_locker_new (&priv->mutex); # 3039| # 3040| /* same */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3094:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3092| g_return_if_fail (GS_IS_APP (app)); # 3093| # 3094|-> locker = g_mutex_locker_new (&priv->mutex); # 3095| # 3096| /* same */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3148:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3146| g_return_if_fail (GS_IS_APP (app)); # 3147| # 3148|-> locker = g_mutex_locker_new (&priv->mutex); # 3149| # 3150| /* same */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3192:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3190| g_return_if_fail (AS_IS_SCREENSHOT (screenshot)); # 3191| # 3192|-> locker = g_mutex_locker_new (&priv->mutex); # 3193| g_ptr_array_add (priv->screenshots, g_object_ref (screenshot)); # 3194| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3280:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3278| g_autoptr(GMutexLocker) locker = NULL; # 3279| g_return_if_fail (GS_IS_APP (app)); # 3280|-> locker = g_mutex_locker_new (&priv->mutex); # 3281| gs_app_set_update_version_internal (app, update_version); # 3282| gs_app_queue_notify (app, obj_props[PROP_VERSION]); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3321:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3319| g_autoptr(GMutexLocker) locker = NULL; # 3320| g_return_if_fail (GS_IS_APP (app)); # 3321|-> locker = g_mutex_locker_new (&priv->mutex); # 3322| priv->update_details_set = TRUE; # 3323| _g_set_str (&priv->update_details_markup, markup); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3345:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3343| g_autoptr(GMutexLocker) locker = NULL; # 3344| g_return_if_fail (GS_IS_APP (app)); # 3345|-> locker = g_mutex_locker_new (&priv->mutex); # 3346| priv->update_details_set = TRUE; # 3347| if (text == NULL) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3373:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3371| g_autoptr(GMutexLocker) locker = NULL; # 3372| g_return_val_if_fail (GS_IS_APP (app), FALSE); # 3373|-> locker = g_mutex_locker_new (&priv->mutex); # 3374| return priv->update_details_set; # 3375| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3480:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3478| g_return_if_fail (management_plugin == NULL || GS_IS_PLUGIN (management_plugin)); # 3479| # 3480|-> locker = g_mutex_locker_new (&priv->mutex); # 3481| # 3482| /* plugins cannot adopt wildcard packages */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3543:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3541| g_autoptr(GMutexLocker) locker = NULL; # 3542| g_return_if_fail (GS_IS_APP (app)); # 3543|-> locker = g_mutex_locker_new (&priv->mutex); # 3544| if (rating == priv->rating) # 3545| return; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3583:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3581| g_autoptr(GMutexLocker) locker = NULL; # 3582| g_return_if_fail (GS_IS_APP (app)); # 3583|-> locker = g_mutex_locker_new (&priv->mutex); # 3584| _g_set_array (&priv->review_ratings, review_ratings); # 3585| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3621:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3619| g_return_if_fail (GS_IS_APP (app)); # 3620| g_return_if_fail (AS_IS_REVIEW (review)); # 3621|-> locker = g_mutex_locker_new (&priv->mutex); # 3622| g_ptr_array_add (priv->reviews, g_object_ref (review)); # 3623| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3640:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3638| g_autoptr(GMutexLocker) locker = NULL; # 3639| g_return_if_fail (GS_IS_APP (app)); # 3640|-> locker = g_mutex_locker_new (&priv->mutex); # 3641| g_ptr_array_remove (priv->reviews, review); # 3642| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:3709:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3707| g_return_if_fail (kind != AS_PROVIDED_KIND_UNKNOWN && kind < AS_PROVIDED_KIND_LAST); # 3708| # 3709|-> locker = g_mutex_locker_new (&priv->mutex); # 3710| prov = gs_app_get_provided_for_kind (app, kind); # 3711| if (prov == NULL) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:4271:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4269| g_return_if_fail (GS_IS_APP (app)); # 4270| # 4271|-> locker = g_mutex_locker_new (&priv->mutex); # 4272| # 4273| /* if no value, then remove the key */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:4317:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4315| g_autoptr(GMutexLocker) locker = NULL; # 4316| g_return_val_if_fail (GS_IS_APP (app), NULL); # 4317|-> locker = g_mutex_locker_new (&priv->mutex); # 4318| return (priv->addons != NULL) ? g_object_ref (priv->addons) : NULL; # 4319| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:4344:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4342| return; # 4343| # 4344|-> locker = g_mutex_locker_new (&priv->mutex); # 4345| # 4346| if (priv->addons != NULL) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:4371:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4369| g_return_if_fail (GS_IS_APP (app)); # 4370| g_return_if_fail (GS_IS_APP (addon)); # 4371|-> locker = g_mutex_locker_new (&priv->mutex); # 4372| # 4373| if (priv->addons != NULL) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:4414:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4412| g_return_if_fail (GS_IS_APP (app2)); # 4413| # 4414|-> locker = g_mutex_locker_new (&priv->mutex); # 4415| # 4416| /* if the app is updatable-live and any related app is not then Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:4465:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4463| g_return_if_fail (GS_IS_APP (app)); # 4464| g_return_if_fail (GS_IS_APP (app2)); # 4465|-> locker = g_mutex_locker_new (&priv->mutex); # 4466| gs_app_list_add (priv->history, app2); # 4467| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:4650:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4648| g_return_if_fail (GS_IS_APP (app)); # 4649| g_return_if_fail (categories != NULL); # 4650|-> locker = g_mutex_locker_new (&priv->mutex); # 4651| _g_set_ptr_array (&priv->categories, categories); # 4652| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:4670:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4668| g_return_if_fail (GS_IS_APP (app)); # 4669| g_return_if_fail (category != NULL); # 4670|-> locker = g_mutex_locker_new (&priv->mutex); # 4671| if (gs_app_has_category (app, category)) # 4672| return; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:4697:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4695| g_return_val_if_fail (GS_IS_APP (app), FALSE); # 4696| # 4697|-> locker = g_mutex_locker_new (&priv->mutex); # 4698| # 4699| for (i = 0; i < priv->categories->len; i++) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:4899:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4897| g_return_if_fail (GS_IS_APP (app)); # 4898| g_return_if_fail (key_colors != NULL); # 4899|-> locker = g_mutex_locker_new (&priv->mutex); # 4900| priv->user_key_colors = FALSE; # 4901| if (_g_set_array (&priv->key_colors, key_colors)) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:5144:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5142| return; # 5143| # 5144|-> locker = g_mutex_locker_new (&priv->mutex); # 5145| priv->quirk |= quirk; # 5146| gs_app_queue_notify (app, obj_props[PROP_QUIRK]); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:5169:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5167| return; # 5168| # 5169|-> locker = g_mutex_locker_new (&priv->mutex); # 5170| priv->quirk &= ~quirk; # 5171| gs_app_queue_notify (app, obj_props[PROP_QUIRK]); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:5284:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5282| g_return_val_if_fail (GS_IS_APP (app), NULL); # 5283| # 5284|-> locker = g_mutex_locker_new (&priv->mutex); # 5285| # 5286| if (priv->cancellable == NULL || g_cancellable_is_cancelled (priv->cancellable)) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:5312:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5310| g_return_val_if_fail (GS_IS_APP (app), NULL); # 5311| # 5312|-> locker = g_mutex_locker_new (&priv->mutex); # 5313| if (priv->cancellable) # 5314| return g_object_ref (priv->cancellable); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:5333:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5331| g_autoptr(GMutexLocker) locker = NULL; # 5332| g_return_val_if_fail (GS_IS_APP (app), GS_PLUGIN_ACTION_UNKNOWN); # 5333|-> locker = g_mutex_locker_new (&priv->mutex); # 5334| return priv->pending_action; # 5335| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:5351:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5349| g_autoptr(GMutexLocker) locker = NULL; # 5350| g_return_if_fail (GS_IS_APP (app)); # 5351|-> locker = g_mutex_locker_new (&priv->mutex); # 5352| gs_app_set_pending_action_internal (app, action); # 5353| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6327:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6325| # 6326| priv = gs_app_get_instance_private (app); # 6327|-> locker = g_mutex_locker_new (&priv->mutex); # 6328| # 6329| if (!origin_str) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6379:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6377| # 6378| priv = gs_app_get_instance_private (app); # 6379|-> locker = g_mutex_locker_new (&priv->mutex); # 6380| # 6381| if (origin_ui && !*origin_ui) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6521:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6519| g_autoptr(GMutexLocker) locker = NULL; # 6520| g_return_val_if_fail (GS_IS_APP (app), NULL); # 6521|-> locker = g_mutex_locker_new (&priv->mutex); # 6522| return priv->permissions ? g_object_ref (priv->permissions) : NULL; # 6523| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6546:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6544| g_return_if_fail (permissions == NULL || gs_app_permissions_is_sealed (permissions)); # 6545| # 6546|-> locker = g_mutex_locker_new (&priv->mutex); # 6547| if (priv->permissions == permissions) # 6548| return; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6575:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6573| g_autoptr(GMutexLocker) locker = NULL; # 6574| g_return_val_if_fail (GS_IS_APP (app), NULL); # 6575|-> locker = g_mutex_locker_new (&priv->mutex); # 6576| return priv->update_permissions ? g_object_ref (priv->update_permissions) : NULL; # 6577| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6600:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6598| g_return_if_fail (GS_IS_APP (app)); # 6599| g_return_if_fail (update_permissions == NULL || gs_app_permissions_is_sealed (update_permissions)); # 6600|-> locker = g_mutex_locker_new (&priv->mutex); # 6601| if (priv->update_permissions != update_permissions) { # 6602| g_clear_object (&priv->update_permissions); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6627:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6625| g_return_val_if_fail (GS_IS_APP (app), NULL); # 6626| # 6627|-> locker = g_mutex_locker_new (&priv->mutex); # 6628| if (priv->version_history == NULL) # 6629| return NULL; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6653:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6651| version_history = NULL; # 6652| # 6653|-> locker = g_mutex_locker_new (&priv->mutex); # 6654| _g_set_ptr_array (&priv->version_history, version_history); # 6655| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6682:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6680| # 6681| priv = gs_app_get_instance_private (app); # 6682|-> locker = g_mutex_locker_new (&priv->mutex); # 6683| # 6684| /* process all icons */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6728:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6726| g_return_val_if_fail (GS_IS_APP (app), NULL); # 6727| # 6728|-> locker = g_mutex_locker_new (&priv->mutex); # 6729| return (priv->relations != NULL) ? g_ptr_array_ref (priv->relations) : NULL; # 6730| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6752:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6750| g_return_if_fail (AS_IS_RELATION (relation)); # 6751| # 6752|-> locker = g_mutex_locker_new (&priv->mutex); # 6753| # 6754| if (priv->relations == NULL) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6782:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6780| g_return_if_fail (GS_IS_APP (app)); # 6781| # 6782|-> locker = g_mutex_locker_new (&priv->mutex); # 6783| # 6784| if (relations == NULL && priv->relations == NULL) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6788:3: warning[deadcode.DeadStores]: Value stored to 'old_relations' is never read # 6786| # 6787| if (priv->relations != NULL) # 6788|-> old_relations = g_steal_pointer (&priv->relations); # 6789| # 6790| if (relations != NULL) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6833:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6831| g_return_if_fail (GS_IS_APP (app)); # 6832| # 6833|-> locker = g_mutex_locker_new (&priv->mutex); # 6834| # 6835| if (priv->has_translations == has_translations) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-app.c:6912:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6910| g_return_if_fail (GS_IS_APP (app)); # 6911| # 6912|-> locker = g_mutex_locker_new (&priv->mutex); # 6913| # 6914| if (priv->icons_state == icons_state) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-appstream.c:1853:16: warning[core.NonNullParamChecker]: Null pointer passed to 2nd parameter expecting 'nonnull' # 1851| split[0], split[1]); # 1852| } # 1853|-> components = xb_silo_query (silo, xpath, 0, &error_local); # 1854| if (components == NULL) { # 1855| if (g_error_matches (error_local, G_IO_ERROR, G_IO_ERROR_NOT_FOUND)) Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: GCC_ANALYZER_WARNING (CWE-476): gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.c: scope_hint: In function ‘gs_category_new_for_desktop_data’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.c:716:61: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’ /usr/include/glib-2.0/glib/gmacros.h:1237:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.c:443:9: note: in expansion of macro ‘g_return_if_fail’ /usr/include/glib-2.0/gobject/gtype.h:1613:40: note: in definition of macro ‘G_DECLARE_FINAL_TYPE’ /usr/include/glib-2.0/gobject/gtype.h:541:66: note: in expansion of macro ‘_G_TYPE_CIT’ /usr/include/glib-2.0/gobject/gtype.h:1614:12: note: in expansion of macro ‘G_TYPE_CHECK_INSTANCE_TYPE’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.h:22:1: note: in expansion of macro ‘G_DECLARE_FINAL_TYPE’ /usr/include/glib-2.0/gobject/gtype.h:541:66: note: in expansion of macro ‘_G_TYPE_CIT’ /usr/include/glib-2.0/gobject/gtype.h:1614:12: note: in expansion of macro ‘G_TYPE_CHECK_INSTANCE_TYPE’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.h:22:1: note: in expansion of macro ‘G_DECLARE_FINAL_TYPE’ /usr/include/glib-2.0/glib/gmacros.h:1237:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.c:443:9: note: in expansion of macro ‘g_return_if_fail’ /usr/include/glib-2.0/glib/gmacros.h:1237:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.c:703:17: note: in expansion of macro ‘g_assert’ /usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.c:703:17: note: in expansion of macro ‘g_assert’ /usr/include/glib-2.0/glib.h:33: included_from: Included from here. gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.c:710:33: note: in expansion of macro ‘g_ptr_array_index’ /usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gmessages.h:664:9: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-category.c:301:9: note: in expansion of macro ‘g_return_val_if_fail’ # 714| /* add all desktop groups */ # 715| desktop_groups = gs_category_get_desktop_groups (child); # 716|-> for (guint j = 0; j < desktop_groups->len; j++) { # 717| const gchar *tmp = g_ptr_array_index (desktop_groups, j); # 718| gs_category_add_desktop_group (subcategory_all, tmp); Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-cmd.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-debug.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-download-utils.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-external-appstream-utils.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-fedora-third-party.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-fedora-third-party.c:382:2: warning[deadcode.DeadStores]: Value stored to 'executable' is never read # 380| # 381| g_mutex_lock (&self->lock); # 382|-> executable = gs_fedora_third_party_ensure_executable_locked (self, error); # 383| g_mutex_unlock (&self->lock); # 384| Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-icon.c:215:10: warning[deadcode.DeadStores]: Although the value stored to 'name_allocated' is used in the enclosing expression, the value is never actually read from 'name_allocated' # 213| * unnecessary size subdirectory in the icon name. */ # 214| if (g_str_has_prefix (name, "64x64/")) # 215|-> name = name_allocated = g_strdup (name + strlen ("64x64/")); # 216| else if (g_str_has_prefix (name, "128x128/")) # 217| name = name_allocated = g_strdup (name + strlen ("128x128/")); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-icon.c:217:10: warning[deadcode.DeadStores]: Although the value stored to 'name_allocated' is used in the enclosing expression, the value is never actually read from 'name_allocated' # 215| name = name_allocated = g_strdup (name + strlen ("64x64/")); # 216| else if (g_str_has_prefix (name, "128x128/")) # 217|-> name = name_allocated = g_strdup (name + strlen ("128x128/")); # 218| # 219| if (!g_str_has_suffix (filename, name)) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-job-manager.c:333:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 331| g_return_val_if_fail (GS_IS_PLUGIN_JOB (job), FALSE); # 332| # 333|-> locker = g_mutex_locker_new (&self->mutex); # 334| # 335| if (g_ptr_array_find (self->jobs, job, NULL)) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-job-manager.c:397:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 395| g_return_val_if_fail (GS_IS_PLUGIN_JOB (job), FALSE); # 396| # 397|-> locker = g_mutex_locker_new (&self->mutex); # 398| # 399| if (!g_ptr_array_remove_fast (self->jobs, job)) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-job-manager.c:464:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 462| g_return_val_if_fail (GS_IS_APP (app), NULL); # 463| # 464|-> locker = g_mutex_locker_new (&self->mutex); # 465| # 466| jobs_for_app = g_ptr_array_new_with_free_func (g_object_unref); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-job-manager.c:502:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 500| g_return_val_if_fail (g_type_is_a (pending_job_type, GS_TYPE_PLUGIN_JOB), FALSE); # 501| # 502|-> locker = g_mutex_locker_new (&self->mutex); # 503| # 504| for (gsize i = 0; i < self->jobs->len; i++) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-job-manager.c:568:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 566| g_return_val_if_fail (match_job_type == G_TYPE_INVALID || g_type_is_a (match_job_type, GS_TYPE_PLUGIN_JOB), 0); # 567| # 568|-> locker = g_mutex_locker_new (&self->mutex); # 569| # 570| g_assert (self->next_watch_id < G_MAXUINT); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-job-manager.c:610:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 608| g_return_if_fail (watch_id != 0); # 609| # 610|-> locker = g_mutex_locker_new (&self->mutex); # 611| # 612| for (guint i = 0; i < self->watches->len; i++) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-job-manager.c:690:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 688| g_task_set_source_tag (task, gs_job_manager_shutdown_async); # 689| # 690|-> locker = g_mutex_locker_new (&self->mutex); # 691| # 692| self->shut_down = TRUE; Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-key-colors.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-metered.c:98:2: warning[deadcode.DeadStores]: Value stored to 'pusher' is never read # 96| # 97| context = g_main_context_new (); # 98|-> pusher = g_main_context_pusher_new (context); # 99| # 100| gs_metered_block_on_download_scheduler_async (parameters, cancellable, async_result_cb, &result); Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-odrs-provider.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-odrs-provider.c:178:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 176| # 177| /* Update the shared state */ # 178|-> locker = g_mutex_locker_new (&self->ratings_mutex); # 179| g_clear_pointer (&self->ratings, g_array_unref); # 180| self->ratings = g_steal_pointer (&new_ratings); Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-os-release.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin-job-list-distro-upgrades.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin-job-manage-repository.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin-loader.c:602:3: warning[deadcode.DeadStores]: Value stored to 'refine_flags' is never read # 600| list = gs_plugin_job_get_list (helper->plugin_job); # 601| if (refine_flags == GS_PLUGIN_REFINE_FLAGS_NONE) # 602|-> refine_flags = gs_plugin_job_get_refine_flags (helper->plugin_job); # 603| # 604| /* set what plugin is running on the job */ Error: CPPCHECK_WARNING (CWE-758): gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin-types.h:169: error[shiftTooManyBitsSigned]: Shifting signed 32-bit value by 31 bits is undefined behaviour # 167| GS_PLUGIN_REFINE_FLAGS_REQUIRE_DEVELOPER_NAME = 1 << 29, # 168| GS_PLUGIN_REFINE_FLAGS_REQUIRE_KUDOS = 1 << 30, # 169|-> GS_PLUGIN_REFINE_FLAGS_REQUIRE_CONTENT_RATING = 1 << 31, # 170| GS_PLUGIN_REFINE_FLAGS_MASK = ~0, # 171| } GsPluginRefineFlags; Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin.c:1134:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1132| g_return_val_if_fail (key != NULL, NULL); # 1133| # 1134|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1135| app = g_hash_table_lookup (priv->cache, key); # 1136| if (app == NULL) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin.c:1167:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1165| # 1166| priv = gs_plugin_get_instance_private (plugin); # 1167|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1168| # 1169| g_hash_table_iter_init (&iter, priv->cache); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin.c:1197:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1195| g_return_if_fail (key != NULL); # 1196| # 1197|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1198| g_hash_table_remove (priv->cache, key); # 1199| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin.c:1221:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1219| g_return_if_fail (GS_IS_APP (app)); # 1220| # 1221|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1222| # 1223| /* the user probably doesn't want to do this */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin.c:1262:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1260| g_return_if_fail (GS_IS_PLUGIN (plugin)); # 1261| # 1262|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1263| g_hash_table_remove_all (priv->cache); # 1264| } Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin.c:1287:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1285| g_return_val_if_fail (GS_IS_PLUGIN (plugin), NULL); # 1286| # 1287|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1288| list = gs_app_list_new (); # 1289| Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-plugin.c:1910:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1908| repo_plugin = gs_app_dup_management_plugin (repository); # 1909| # 1910|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1911| # 1912| g_hash_table_iter_init (&iter, priv->cache); Error: COMPILER_WARNING (CWE-9001): gnome-software-46.2-build/gnome-software-46.2/lib/gs-profiler.h:93:1: warning[-Winline]: inlining failed in call to ‘gs_profiler_tracing_end’: call is unlikely and code size would grow # 93 | gs_profiler_tracing_end (GsProfilerHead *head) # | ^~~~~~~~~~~~~~~~~~~~~~~ gnome-software-46.2-build/gnome-software-46.2/lib/gs-profiler.h:108:17: note: called from here # 108 | gs_profiler_tracing_end (*head); # | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # 91| # 92| static inline void # 93|-> gs_profiler_tracing_end (GsProfilerHead *head) # 94| { # 95| sysprof_collector_mark (head->begin_time, Error: GCC_ANALYZER_WARNING (CWE-457): gnome-software-46.2-build/gnome-software-46.2/plugins/flatpak/gs-plugin-flatpak.c:39: included_from: Included from here. gnome-software-46.2-build/gnome-software-46.2/lib/gs-profiler.h: scope_hint: In function ‘gs_profiler_tracing_end’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-profiler.h:99:37: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘*head.description’ /usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here. /usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. /usr/include/flatpak/flatpak.h:26: included_from: Included from here. gnome-software-46.2-build/gnome-software-46.2/plugins/flatpak/gs-plugin-flatpak.c:29: included_from: Included from here. /usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.2-build/gnome-software-46.2/plugins/flatpak/gs-plugin-flatpak.c:70:9: note: in expansion of macro ‘g_assert’ gnome-software-46.2-build/gnome-software-46.2/plugins/flatpak/gs-plugin-flatpak.c:707:9: note: in expansion of macro ‘assert_in_worker’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-profiler.h:123:9: note: in expansion of macro ‘GS_PROFILER_BEGIN_SCOPED_TAKE’ gnome-software-46.2-build/gnome-software-46.2/plugins/flatpak/gs-plugin-flatpak.c:633:9: note: in expansion of macro ‘GS_PROFILER_BEGIN_SCOPED’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-profiler.h:123:9: note: in expansion of macro ‘GS_PROFILER_BEGIN_SCOPED_TAKE’ gnome-software-46.2-build/gnome-software-46.2/plugins/flatpak/gs-plugin-flatpak.c:633:9: note: in expansion of macro ‘GS_PROFILER_BEGIN_SCOPED’ gnome-software-46.2-build/gnome-software-46.2/lib/gs-profiler.h: scope_hint: In function ‘gs_profiler_tracing_end’ # 97| "gnome-software", # 98| head->name, # 99|-> head->description); # 100| # 101| g_clear_pointer (&head->name, g_free); Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-remote-icon.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-utils.c:1290:18: warning[core.uninitialized.Assign]: Assigned value is garbage or undefined # 1288| for (x = 0; x < width; x++) { # 1289| /* set as the mean of the kernel */ # 1290|-> p_dest_row[0] = div_kernel_size[r]; # 1291| p_dest_row[1] = div_kernel_size[g]; # 1292| p_dest_row[2] = div_kernel_size[b]; Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/gs-worker-thread.c:336:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 334| data->priority = priority; # 335| # 336|-> locker = g_mutex_locker_new (&self->queue_mutex); # 337| g_queue_insert_sorted (&self->queue, g_steal_pointer (&data), gs_worker_thread_cmp, NULL); # 338| g_main_context_wakeup (self->worker_context); Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/tools/profile-key-colors.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/lib/tools/profile-key-colors.c:62:13: warning[core.DivideZero]: Division by zero # 60| } # 61| # 62|-> mean = sum / n_measurements; # 63| # 64| for (guint i = 0; i < durations->len; i++) { Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c:567:2: warning[deadcode.DeadStores]: Value stored to 'writer_locker' is never read # 565| # 566| /* drat! silo needs regenerating */ # 567|-> writer_locker = g_rw_lock_writer_locker_new (&self->silo_lock); # 568| reload: # 569| g_clear_object (&self->silo); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c:802:2: warning[deadcode.DeadStores]: Value stored to 'writer_locker' is never read # 800| # 801| self = GS_PLUGIN_APPSTREAM (plugin); # 802|-> writer_locker = g_rw_lock_writer_locker_new (&self->silo_lock); # 803| if (self->silo != NULL) # 804| xb_silo_invalidate (self->silo); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c:926:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 924| return FALSE; # 925| # 926|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 927| # 928| return gs_appstream_url_to_app (plugin, self->silo, list, url, cancellable, error); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c:987:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 985| return TRUE; # 986| # 987|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 988| # 989| if (g_hash_table_contains (self->silo_installed_by_id, gs_app_get_id (app))) Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c:1012:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1010| return TRUE; # 1011| # 1012|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1013| # 1014| origin = gs_app_get_origin_appstream (app); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c:1064:3: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1062| g_autoptr(XbNode) component = NULL; # 1063| # 1064|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1065| # 1066| /* prefer actual apps and then fallback to anything else */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c:1157:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1155| apps_by_origin_and_id = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, (GDestroyNotify) g_ptr_array_unref); # 1156| # 1157|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1158| # 1159| components = xb_silo_query (self->silo, "components/component/id", 0, NULL); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c:1294:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1292| return TRUE; # 1293| # 1294|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1295| # 1296| components = g_hash_table_lookup (apps_by_id, id); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c:1381:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1379| } # 1380| # 1381|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1382| # 1383| if (!gs_appstream_refine_category_sizes (self->silo, data->list, cancellable, &local_error)) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-appstream.c:1492:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1490| } # 1491| # 1492|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1493| # 1494| if (released_since != NULL && Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/core/gs-plugin-provenance.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/dummy/gs-plugin-dummy.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/epiphany/gs-plugin-epiphany.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/fedora-pkgdb-collections/gs-plugin-fedora-pkgdb-collections.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/flatpak/gs-flatpak-transaction.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/flatpak/gs-flatpak-utils.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/fwupd/gs-fwupd-app.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/fwupd/gs-plugin-fwupd.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/fwupd/gs-plugin-fwupd.c:61:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 59| g_autoptr(GMutexLocker) locker = NULL; # 60| # 61|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 62| # 63| g_assert (self->cached_sources != NULL); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/fwupd/gs-plugin-fwupd.c:1837:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1835| if (remotes == NULL) # 1836| return FALSE; # 1837|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 1838| if (self->cached_sources == NULL) # 1839| self->cached_sources = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL); Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/malcontent/gs-plugin-malcontent.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/malcontent/gs-plugin-malcontent.c:229:3: warning[deadcode.DeadStores]: Value stored to 'old_app_filter' is never read # 227| { # 228| g_autoptr(GMutexLocker) locker = g_mutex_locker_new (&self->mutex); # 229|-> old_app_filter = g_steal_pointer (&self->app_filter); # 230| self->app_filter = g_steal_pointer (&new_app_filter); # 231| } Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/modalias/gs-plugin-modalias.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/packagekit/gs-markdown.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/packagekit/gs-packagekit-helper.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/packagekit/gs-plugin-packagekit.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/packagekit/gs-plugin-packagekit.c:112:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 110| g_autoptr(GMutexLocker) locker = NULL; # 111| # 112|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 113| # 114| g_assert (self->cached_sources != NULL); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/packagekit/gs-plugin-packagekit.c:329:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 327| if (!gs_plugin_packagekit_results_valid (results, cancellable, error)) # 328| return FALSE; # 329|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 330| if (self->cached_sources == NULL) # 331| self->cached_sources = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/packagekit/gs-plugin-packagekit.c:1278:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1276| # 1277| /* Update the shared state. */ # 1278|-> locker = g_mutex_locker_new (&self->prepared_updates_mutex); # 1279| g_clear_pointer (&self->prepared_updates, g_hash_table_unref); # 1280| self->prepared_updates = g_steal_pointer (&new_prepared_updates); Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/packagekit/packagekit-common.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/repos/gs-plugin-repos.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/repos/gs-plugin-repos.c:171:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 169| /* success; replace the hash table pointers in the object while the lock # 170| * is held */ # 171|-> locker = g_mutex_locker_new (&self->mutex); # 172| # 173| g_clear_pointer (&self->fns, g_hash_table_unref); Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/rpm-ostree/gs-plugin-rpm-ostree.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/rpm-ostree/gs-plugin-rpm-ostree.c:83:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 81| g_autoptr(GMutexLocker) locker = NULL; # 82| # 83|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 84| # 85| g_assert (self->cached_sources != NULL); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/rpm-ostree/gs-plugin-rpm-ostree.c:390:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 388| g_autoptr(GMutexLocker) locker = NULL; # 389| # 390|-> locker = g_mutex_locker_new (&self->mutex); # 391| # 392| return gs_rpmostree_ref_proxies_locked (self, interactive, out_os_proxy, out_sysroot_proxy, cancellable, error); Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/plugins/rpm-ostree/gs-plugin-rpm-ostree.c:2922:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2920| } # 2921| # 2922|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 2923| if (self->cached_sources == NULL) # 2924| self->cached_sources = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL); Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/redhat-linux-build/plugins/epiphany/gs-epiphany-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/redhat-linux-build/plugins/rpm-ostree/gs-rpmostree-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/redhat-linux-build/src/gs-packagekit-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/redhat-linux-build/src/gs-packagekit-modify2-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/redhat-linux-build/src/gs-shell-search-provider-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-age-rating-context-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-app-context-bar.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING (CWE-457): gnome-software-46.2-build/gnome-software-46.2/src/gs-app-context-bar.c:894: error[legacyUninitvar]: Uninitialized variable: dialog # 892| g_assert_not_reached (); # 893| # 894|-> gtk_window_set_transient_for (dialog, GTK_WINDOW (root)); # 895| gtk_widget_set_visible (GTK_WIDGET (dialog), TRUE); # 896| } Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-app-reviews-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-app-row.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-app-tile.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-application.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-category-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-common.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-css.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-dbus-helper.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-description-box.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-description-box.c:123:32: warning[core.NullDereference]: Access to field 'data' results in a dereference of a null pointer (loaded from variable 'opened_markup') # 121| if (box->text[start_index] == '<') { # 122| if (box->text[start_index + 1] == '/') { # 123|-> g_autofree gchar *value = opened_markup->data; # 124| opened_markup = g_slist_remove (opened_markup, value); # 125| } else { Error: GCC_ANALYZER_WARNING (CWE-476): gnome-software-46.2-build/gnome-software-46.2/src/gs-description-box.c: scope_hint: In function ‘gs_description_box_update_content’ gnome-software-46.2-build/gnome-software-46.2/src/gs-description-box.c:123:80: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘opened_markup’ # 121| if (box->text[start_index] == '<') { # 122| if (box->text[start_index + 1] == '/') { # 123|-> g_autofree gchar *value = opened_markup->data; # 124| opened_markup = g_slist_remove (opened_markup, value); # 125| } else { Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-details-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-extras-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-feature-tile.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-hardware-support-context-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-installed-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-language.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-license-tile.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-lozenge.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-overview-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-repos-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-restarter.c:195:3: warning[unix.Malloc]: Potential leak of memory pointed to by 'priv' # 193| priv = gs_restarter_private_new (); # 194| if (!gs_restarter_setup_watcher (priv, &error)) { # 195|-> g_warning ("Failed to set up: %s", error->message); # 196| return EXIT_FAILURE; # 197| } Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-review-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-safety-context-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-screenshot-image.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-shell-search-provider.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-shell.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-shell.c:1284:4: warning[deadcode.DeadStores]: Value stored to 'str_origin' is never read # 1282| toast_text = _("Unable to download updates"); # 1283| if (origin != NULL) { # 1284|-> str_origin = gs_shell_get_title_from_origin (origin); # 1285| if (gs_app_get_bundle_kind (origin) == AS_BUNDLE_KIND_CABINET) { # 1286| /* TRANSLATORS: failure text for the in-app notification */ Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-shell.c:1503:2: warning[deadcode.DeadStores]: Value stored to 'str_app' is never read # 1501| g_autofree gchar *str_origin = NULL; # 1502| # 1503|-> str_app = g_strdup_printf ("%s %s", gs_app_get_name (app), gs_app_get_version (app)); # 1504| # 1505| if (g_error_matches (error, GS_PLUGIN_ERROR, GS_PLUGIN_ERROR_DOWNLOAD_FAILED)) { Error: CLANG_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-shell.c:1507:4: warning[deadcode.DeadStores]: Value stored to 'str_origin' is never read # 1505| if (g_error_matches (error, GS_PLUGIN_ERROR, GS_PLUGIN_ERROR_DOWNLOAD_FAILED)) { # 1506| if (origin != NULL) { # 1507|-> str_origin = gs_shell_get_title_from_origin (origin); # 1508| /* TRANSLATORS: failure text for the in-app notification */ # 1509| toast_text = _("Unable to upgrade"); Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-storage-context-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-update-monitor.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-updates-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.2-build/gnome-software-46.2/src/gs-updates-paused-banner.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING (CWE-457): gnome-software-46.2-build/gnome-software-46.2/src/gs-updates-paused-banner.c:96: error[legacyUninitvar]: Uninitialized variable: title # 94| } # 95| # 96|-> adw_banner_set_title (ADW_BANNER (self->banner), title); # 97| } # 98|