bootc-202503212301.ge7eaf078f5-1

List of Findings

Error: CLIPPY_WARNING: [#def1]
bootc-202503212301.ge7eaf078f5-build/blockdev/src/blockdev.rs:53:9: warning: this `map_or` can be simplified
#     |
#  53 |         self.children.as_ref().map_or(false, |v| !v.is_empty())
#     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_some_and instead: `self.children.as_ref().is_some_and(|v| !v.is_empty())`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
#     = note: `#[warn(clippy::unnecessary_map_or)]` on by default

Error: COMPILER_WARNING (CWE-704): [#def2]
bootc-202503212301.ge7eaf078f5-build/bootc-202503212301.ge7eaf078f5/vendor/libz-sys/src/smoke.c: scope_hint: In function ‘main’
bootc-202503212301.ge7eaf078f5-build/bootc-202503212301.ge7eaf078f5/vendor/libz-sys/src/smoke.c:4:10: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
#    4 |   return (int) adler32;
#      |          ^
#    2|   
#    3|   int main() {
#    4|->   return (int) adler32;
#    5|   }

Error: CLIPPY_WARNING: [#def3]
bootc-202503212301.ge7eaf078f5-build/lib/src/cli.rs:754:35: warning: this `map_or` can be simplified
#      |
#  754 |           let booted_incompatible = host
#      |  ___________________________________^
#  755 | |             .status
#  756 | |             .booted
#  757 | |             .as_ref()
#  758 | |             .map_or(false, |b| b.incompatible);
#      | |______________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
#      = note: `#[warn(clippy::unnecessary_map_or)]` on by default
#  help: use is_some_and instead
#      |
#  754 ~         let booted_incompatible = host
#  755 +             .status
#  756 +             .booted
#  757 ~             .as_ref().is_some_and(|b| b.incompatible);
#      |

Error: CLIPPY_WARNING: [#def4]
bootc-202503212301.ge7eaf078f5-build/lib/src/cli.rs:760:35: warning: this `map_or` can be simplified
#      |
#  760 |           let staged_incompatible = host
#      |  ___________________________________^
#  761 | |             .status
#  762 | |             .staged
#  763 | |             .as_ref()
#  764 | |             .map_or(false, |b| b.incompatible);
#      | |______________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
#  help: use is_some_and instead
#      |
#  760 ~         let staged_incompatible = host
#  761 +             .status
#  762 +             .staged
#  763 ~             .as_ref().is_some_and(|b| b.incompatible);
#      |

Error: CLIPPY_WARNING: [#def5]
bootc-202503212301.ge7eaf078f5-build/lib/src/deploy.rs:142:1: warning: this function has too many arguments (9/7)
#      |
#  142 | / async fn handle_layer_progress_print(
#  143 | |     mut layers: tokio::sync::mpsc::Receiver<ostree_container::store::ImportProgress>,
#  144 | |     mut layer_bytes: tokio::sync::watch::Receiver<Option<ostree_container::store::LayerProgress>>,
#  145 | |     digest: Box<str>,
#  ...   |
#  151 | |     quiet: bool,
#  152 | | ) -> ProgressWriter {
#      | |___________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Error: CLIPPY_WARNING: [#def6]
bootc-202503212301.ge7eaf078f5-build/lib/src/deploy.rs:204:33: warning: useless use of `format!`
#      |
#  204 | ...                   id: format!("{short_digest}").clone().into(),
#      |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `short_digest.to_string()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
#      = note: `#[warn(clippy::useless_format)]` on by default

Error: CLIPPY_WARNING: [#def7]
bootc-202503212301.ge7eaf078f5-build/lib/src/fsck.rs:215:24: warning: using `clone` on type `bool` which implements the `Copy` trait
#      |
#  215 |         let expected = expected.clone();
#      |                        ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `expected`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
#      = note: `#[warn(clippy::clone_on_copy)]` on by default

Error: CLIPPY_WARNING: [#def8]
bootc-202503212301.ge7eaf078f5-build/lib/src/imgstorage.rs:296:16: warning: useless conversion to the same type: `anyhow::Error`
#      |
#  296 |            .await?
#      |   ________________^
#      |  |________________|
#  297 | ||         .map_err(Into::into)
#      | ||____________________________^
#  298 | |      }
#      | |_____- help: consider removing
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
#      = note: `#[warn(clippy::useless_conversion)]` on by default

Error: CLIPPY_WARNING: [#def9]
bootc-202503212301.ge7eaf078f5-build/lib/src/lints.rs:110:13: warning: redundant field names in struct initialization
#      |
#  110 |             name: name,
#      |             ^^^^^^^^^^ help: replace it with: `name`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
#      = note: `#[warn(clippy::redundant_field_names)]` on by default

Error: CLIPPY_WARNING: [#def10]
bootc-202503212301.ge7eaf078f5-build/lib/src/lints.rs:112:13: warning: redundant field names in struct initialization
#      |
#  112 |             f: f,
#      |             ^^^^ help: replace it with: `f`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Error: CLIPPY_WARNING: [#def11]
bootc-202503212301.ge7eaf078f5-build/lib/src/lints.rs:113:13: warning: redundant field names in struct initialization
#      |
#  113 |             description: description,
#      |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Error: CLIPPY_WARNING: [#def12]
bootc-202503212301.ge7eaf078f5-build/lib/src/lints.rs:124:13: warning: redundant field names in struct initialization
#      |
#  124 |             name: name,
#      |             ^^^^^^^^^^ help: replace it with: `name`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Error: CLIPPY_WARNING: [#def13]
bootc-202503212301.ge7eaf078f5-build/lib/src/lints.rs:126:13: warning: redundant field names in struct initialization
#      |
#  126 |             f: f,
#      |             ^^^^ help: replace it with: `f`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Error: CLIPPY_WARNING: [#def14]
bootc-202503212301.ge7eaf078f5-build/lib/src/lints.rs:127:13: warning: redundant field names in struct initialization
#      |
#  127 |             description: description,
#      |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Error: CLIPPY_WARNING: [#def15]
bootc-202503212301.ge7eaf078f5-build/lib/src/lints.rs:353:16: warning: this boolean expression can be simplified
#      |
#  353 |             if !target.to_str().is_some() {
#      |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target.to_str().is_none()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
#      = note: `#[warn(clippy::nonminimal_bool)]` on by default

Error: CLIPPY_WARNING: [#def16]
bootc-202503212301.ge7eaf078f5-build/lib/src/lints.rs:638:25: warning: useless use of `format!`
#      |
#  638 |         return lint_err(format!("Missing /boot directory"));
#      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Missing /boot directory".to_string()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

Error: CLIPPY_WARNING: [#def17]
bootc-202503212301.ge7eaf078f5-build/lib/src/store/mod.rs:113:42: warning: useless conversion to the same type: `anyhow::Error`
#      |
#  113 |                .context("update_timestamps")
#      |   __________________________________________^
#      |  |__________________________________________|
#  114 | ||             .map_err(Into::into)
#      | ||________________________________^
#  115 | |      }
#      | |_____- help: consider removing
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Error: CLIPPY_WARNING: [#def18]
bootc-202503212301.ge7eaf078f5-build/ostree-ext/src/container/store.rs:623:28: warning: this `map_or` can be simplified
#      |
#  623 |               let bootable = config_labels.map_or(false, |l| {
#      |  ____________________________^
#  624 | |                 l.contains_key(bootable_key.as_str()) || l.contains_key(BOOTC_LABEL)
#  625 | |             });
#      | |______________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
#      = note: `#[warn(clippy::unnecessary_map_or)]` on by default
#  help: use is_some_and instead
#      |
#  623 ~             let bootable = config_labels.is_some_and(|l| {
#  624 +                 l.contains_key(bootable_key.as_str()) || l.contains_key(BOOTC_LABEL)
#  625 ~             });
#      |

Error: CLIPPY_WARNING: [#def19]
bootc-202503212301.ge7eaf078f5-build/ostree-ext/src/tar/export.rs:88:9: warning: unneeded `return` statement
#     |
#  88 |         return p;
#     |         ^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#     = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#     |
#  88 -         return p;
#  88 +         p
#     |

Error: CLIPPY_WARNING: [#def20]
bootc-202503212301.ge7eaf078f5-build/ostree-ext/src/tar/import.rs:129:35: warning: needless call to `as_bytes()`
#      |
#  129 |     if !(parentname.is_ascii() && parentname.as_bytes().len() == 2) {
#      |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `parentname.len()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
#      = note: `#[warn(clippy::needless_as_bytes)]` on by default

Error: CLIPPY_WARNING: [#def21]
bootc-202503212301.ge7eaf078f5-build/ostree-ext/src/tar/import.rs:150:38: warning: needless call to `as_bytes()`
#      |
#  150 |     if !(checksum_rest.is_ascii() && checksum_rest.as_bytes().len() == 62) {
#      |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `checksum_rest.len()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes

Error: CLIPPY_WARNING: [#def22]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:60:38: warning: manual check for common ascii range
#     |
#  60 |         let r = if s.chars().all(|c| matches!(c, '0'..='9')) {
#     |                                      ^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()`
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check
#     = note: `#[warn(clippy::manual_is_ascii_check)]` on by default

Error: CLIPPY_WARNING: [#def23]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:102:32: warning: needless call to `as_bytes()`
#      |
#  102 |                     .unwrap_or(s.as_bytes().len());
#      |                                ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
#      = note: `#[warn(clippy::needless_as_bytes)]` on by default

Error: CLIPPY_WARNING: [#def24]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:106:17: warning: this `let...else` may be rewritten with the `?` operator
#      |
#  106 | /                 let Some(end) = rest.find(|c: char| c == '"') else {
#  107 | |                     return None;
#  108 | |                 };
#      | |__________________^ help: replace it with: `let end = rest.find(|c: char| c == '"')?;`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
#      = note: `#[warn(clippy::question_mark)]` on by default

Error: CLIPPY_WARNING: [#def25]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:106:43: warning: this manual char comparison can be written more succinctly
#      |
#  106 |                 let Some(end) = rest.find(|c: char| c == '"') else {
#      |                                           ^^^^^^^^^^^^^^^^^^ help: consider using a `char`: `'"'`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
#      = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default

Error: CLIPPY_WARNING: [#def26]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:135:57: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait
#      |
#  135 |         let (ftype, s) = Self::next_token(s).ok_or_else(err.clone())?;
#      |                                                         ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
#      = note: `#[warn(clippy::clone_on_copy)]` on by default

Error: CLIPPY_WARNING: [#def27]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:138:70: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait
#      |
#  138 |                 let (name, s) = Self::next_token_owned(s).ok_or_else(err.clone())?;
#      |                                                                      ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def28]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:139:71: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait
#      |
#  139 |                 let (id, s) = Self::next_optional_token(s).ok_or_else(err.clone())?;
#      |                                                                       ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def29]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:151:71: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait
#      |
#  151 |                 let (gecos, s) = Self::next_token_owned(s).ok_or_else(err.clone())?;
#      |                                                                       ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def30]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:164:70: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait
#      |
#  164 |                 let (name, s) = Self::next_token_owned(s).ok_or_else(err.clone())?;
#      |                                                                      ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def31]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:165:71: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait
#      |
#  165 |                 let (id, _) = Self::next_optional_token(s).ok_or_else(err.clone())?;
#      |                                                                       ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def32]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:170:70: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait
#      |
#  170 |                 let (_, s) = Self::next_optional_token(s).ok_or_else(err.clone())?;
#      |                                                                      ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def33]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:171:65: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait
#      |
#  171 |                 let (range, _) = Self::next_token(s).ok_or_else(err.clone())?;
#      |                                                                 ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def34]
bootc-202503212301.ge7eaf078f5-build/sysusers/src/lib.rs:172:69: warning: using `clone` on type `{closure@lib.rs:134:19}` which implements the `Copy` trait
#      |
#  172 |                 let (start, end) = range.split_once('-').ok_or_else(err.clone())?;
#      |                                                                     ^^^^^^^^^^^ help: try removing the `clone` call: `err`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Error: CLIPPY_WARNING: [#def35]
bootc-202503212301.ge7eaf078f5-build/tmpfiles/src/lib.rs:84:5: warning: matching on `Some` with `ok()` is redundant
#     |
#  84 |     if let Some(s) = path.as_os_str().as_str().ok() {
#     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok
#     = note: `#[warn(clippy::match_result_ok)]` on by default
#  help: consider matching on `Ok(s)` and removing the call to `ok` instead
#     |
#  84 |     if let Ok(s) = path.as_os_str().as_str() {
#     |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: CLIPPY_WARNING: [#def36]
bootc-202503212301.ge7eaf078f5-build/tmpfiles/src/lib.rs:140:21: warning: unnecessary closure used to substitute value for `Option::None`
#      |
#  140 | /                     src.next()
#  141 | |                         .ok_or_else(|| Error::MalformedTmpfilesPath)?
#      | |____________________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
#      = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
#  help: use `ok_or` instead
#      |
#  141 |                         .ok_or(Error::MalformedTmpfilesPath)?
#      |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: CLIPPY_WARNING: [#def37]
bootc-202503212301.ge7eaf078f5-build/tmpfiles/src/lib.rs:145:21: warning: unnecessary closure used to substitute value for `Option::None`
#      |
#  145 | /                     src.next()
#  146 | |                         .ok_or_else(|| Error::MalformedTmpfilesPath)?
#      | |____________________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
#  help: use `ok_or` instead
#      |
#  146 |                         .ok_or(Error::MalformedTmpfilesPath)?
#      |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: CLIPPY_WARNING: [#def38]
bootc-202503212301.ge7eaf078f5-build/tmpfiles/src/lib.rs:164:12: warning: redundant pattern matching, consider using `is_some()`
#      |
#  164 |     if let Some(_) = src.next_if_eq(&b'"') {
#      |     -------^^^^^^^------------------------ help: try: `if src.next_if_eq(&b'"').is_some()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
#      = note: `#[warn(clippy::redundant_pattern_matching)]` on by default

Error: CLIPPY_WARNING: [#def39]
bootc-202503212301.ge7eaf078f5-build/tmpfiles/src/lib.rs:325:1: warning: this function has too many arguments (8/7)
#      |
#  325 | / fn convert_path_to_tmpfiles_d_recurse<U: uzers::Users, G: uzers::Groups>(
#  326 | |     out_entries: &mut BTreeSet<String>,
#  327 | |     out_unsupported: &mut Vec<PathBuf>,
#  328 | |     users: &U,
#  ...   |
#  333 | |     readonly: bool,
#  334 | | ) -> Result<()> {
#      | |_______________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Error: CLIPPY_WARNING: [#def40]
bootc-202503212301.ge7eaf078f5-build/tmpfiles/src/lib.rs:356:28: warning: unnecessary closure used to substitute value for `Option::None`
#      |
#  356 |                   let user = users
#      |  ____________________________^
#  357 | |                     .get_user_by_uid(meta.uid())
#  358 | |                     .ok_or_else(|| Error::UserNotFound(uid))?;
#      | |____________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
#  help: use `ok_or` instead
#      |
#  358 |                     .ok_or(Error::UserNotFound(uid))?;
#      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: CLIPPY_WARNING: [#def41]
bootc-202503212301.ge7eaf078f5-build/tmpfiles/src/lib.rs:364:29: warning: unnecessary closure used to substitute value for `Option::None`
#      |
#  364 |                   let group = groups
#      |  _____________________________^
#  365 | |                     .get_group_by_gid(gid)
#  366 | |                     .ok_or_else(|| Error::GroupNotFound(gid))?;
#      | |_____________________________________________________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
#  help: use `ok_or` instead
#      |
#  366 |                     .ok_or(Error::GroupNotFound(gid))?;
#      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: CLIPPY_WARNING: [#def42]
bootc-202503212301.ge7eaf078f5-build/tmpfiles/src/lib.rs:501:15: warning: redundant pattern matching, consider using `is_some()`
#      |
#  501 |     while let Some(_) = it.next_if(|c| c.is_ascii_whitespace()) {}
#      |     ----------^^^^^^^------------------------------------------ help: try: `while it.next_if(|c| c.is_ascii_whitespace()).is_some()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching

Error: CLIPPY_WARNING: [#def43]
bootc-202503212301.ge7eaf078f5-build/tmpfiles/src/lib.rs:504:15: warning: redundant pattern matching, consider using `is_some()`
#      |
#  504 |     while let Some(_) = it.next_if(|c| !c.is_ascii_whitespace()) {
#      |     ----------^^^^^^^------------------------------------------- help: try: `while it.next_if(|c| !c.is_ascii_whitespace()).is_some()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching

Error: CLIPPY_WARNING: [#def44]
bootc-202503212301.ge7eaf078f5-build/tmpfiles/src/lib.rs:511:15: warning: redundant pattern matching, consider using `is_some()`
#      |
#  511 |     while let Some(_) = it.next_if(|c| c.is_ascii_whitespace()) {}
#      |     ----------^^^^^^^------------------------------------------ help: try: `while it.next_if(|c| c.is_ascii_whitespace()).is_some()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching

Error: CLIPPY_WARNING: [#def45]
bootc-202503212301.ge7eaf078f5-build/utils/src/path.rs:11:6: warning: the following explicit lifetimes could be elided: 'a
#     |
#  11 | impl<'a> Display for PathQuotedDisplay<'a> {
#     |      ^^                                ^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
#     = note: `#[warn(clippy::needless_lifetimes)]` on by default
#  help: elide the lifetimes
#     |
#  11 - impl<'a> Display for PathQuotedDisplay<'a> {
#  11 + impl Display for PathQuotedDisplay<'_> {
#     |

Error: CLIPPY_WARNING: [#def46]
bootc-202503212301.ge7eaf078f5-build/utils/src/path.rs:26:9: warning: unneeded `return` statement
#     |
#  26 |         return Err(std::fmt::Error);
#     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
#     |
#     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
#     = note: `#[warn(clippy::needless_return)]` on by default
#  help: remove `return`
#     |
#  26 -         return Err(std::fmt::Error);
#  26 +         Err(std::fmt::Error)
#     |

Scan Properties

analyzer-version-clippy1.85.1
analyzer-version-cppcheck2.17 dev
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-247.us-west-2.compute.internal
mock-configfedora-rawhide-x86_64
project-namebootc-202503212301.ge7eaf078f5-1
store-results-to/tmp/tmpabbkblxc/bootc-202503212301.ge7eaf078f5-1.tar.xz
time-created2025-03-21 23:39:36
time-finished2025-03-21 23:46:42
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,unicontrol,clippy,gcc,cppcheck' '-o' '/tmp/tmpabbkblxc/bootc-202503212301.ge7eaf078f5-1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmpabbkblxc/bootc-202503212301.ge7eaf078f5-1.src.rpm'
tool-versioncsmock-3.8.0-1.el9