stratisd-3.8.0~202503201944gitba5c9bed-D

List of Findings

Error: SHELLCHECK_WARNING (CWE-457): [#def1]
/usr/lib/dracut/modules.d/90stratis-clevis/module-setup.sh:27:3: warning[SC2154]: systemdutildir is referenced but not assigned.
#   25|   		clevis-luks-common-functions \
#   26|   		mktemp \
#   27|-> 		$systemdutildir/system-generators/stratis-clevis-setup-generator ||
#   28|   		return 1
#   29|   	require_any_binary tpm2_pcrread tpm2_pcrlist || return 1

Error: SHELLCHECK_WARNING: [#def2]
/usr/lib/dracut/modules.d/90stratis-clevis/module-setup.sh:41:23: error[SC2283]: Remove spaces around = to assign (or use [ ] to compare, or quote '=' if literal).
#   39|   # called by dracut
#   40|   installkernel() {
#   41|-> 	hostonly='' instmods =drivers/char/tpm
#   42|   }
#   43|   

Error: SHELLCHECK_WARNING (CWE-457): [#def3]
/usr/lib/dracut/modules.d/90stratis-clevis/module-setup.sh:72:15: warning[SC2154]: moddir is referenced but not assigned.
#   70|   	# Dracut dependencies
#   71|   	inst_multiple $systemdutildir/system-generators/stratis-clevis-setup-generator
#   72|-> 	inst_simple "$moddir/stratis-clevis-rootfs-setup" $systemdutildir/stratis-clevis-rootfs-setup
#   73|   }

Error: SHELLCHECK_WARNING (CWE-829): [#def4]
/usr/lib/dracut/modules.d/90stratis-clevis/stratis-clevis-rootfs-setup:18:4: warning[SC2091]: Remove surrounding $() to avoid executing output (or use eval if intentional).
#   16|   done
#   17|   
#   18|-> if $(stratis-min pool is-stopped "$STRATIS_ROOTFS_UUID"); then
#   19|   	if $(stratis-min pool is-encrypted "$STRATIS_ROOTFS_UUID"); then
#   20|   		if ! stratis-min pool start --token-slot=any "$STRATIS_ROOTFS_UUID"; then

Error: SHELLCHECK_WARNING (CWE-829): [#def5]
/usr/lib/dracut/modules.d/90stratis-clevis/stratis-clevis-rootfs-setup:19:5: warning[SC2091]: Remove surrounding $() to avoid executing output (or use eval if intentional).
#   17|   
#   18|   if $(stratis-min pool is-stopped "$STRATIS_ROOTFS_UUID"); then
#   19|-> 	if $(stratis-min pool is-encrypted "$STRATIS_ROOTFS_UUID"); then
#   20|   		if ! stratis-min pool start --token-slot=any "$STRATIS_ROOTFS_UUID"; then
#   21|   			echo Failed to start pool with UUID $STRATIS_ROOTFS_UUID using an unattended unlock method. >&2

Error: SHELLCHECK_WARNING (CWE-457): [#def6]
/usr/lib/dracut/modules.d/90stratis/module-setup.sh:7:3: warning[SC2154]: systemdutildir is referenced but not assigned.
#    5|   	require_binaries stratis-min \
#    6|   		/usr/libexec/stratisd-min \
#    7|-> 		$systemdutildir/system-generators/stratis-setup-generator \
#    8|   		thin_check \
#    9|   		thin_repair \

Error: SHELLCHECK_WARNING (CWE-457): [#def7]
/usr/lib/dracut/modules.d/90stratis/module-setup.sh:52:14: warning[SC2154]: moddir is referenced but not assigned.
#   50|   	inst_multiple $systemdutildir/system-generators/stratis-setup-generator
#   51|   
#   52|-> 	inst_rules "$moddir/61-stratisd.rules"
#   53|   	inst_simple "$moddir/stratisd-min.service" $systemdutildir/system/stratisd-min.service
#   54|   	inst_simple "$moddir/stratis-rootfs-setup" $systemdutildir/stratis-rootfs-setup

Error: SHELLCHECK_WARNING (CWE-829): [#def8]
/usr/lib/dracut/modules.d/90stratis/stratis-rootfs-setup:18:4: warning[SC2091]: Remove surrounding $() to avoid executing output (or use eval if intentional).
#   16|   done
#   17|   
#   18|-> if $(stratis-min pool is-stopped "$STRATIS_ROOTFS_UUID"); then
#   19|   	if $(stratis-min pool is-encrypted "$STRATIS_ROOTFS_UUID"); then
#   20|   		ATTEMPTS_REMAINING=3

Error: SHELLCHECK_WARNING (CWE-829): [#def9]
/usr/lib/dracut/modules.d/90stratis/stratis-rootfs-setup:19:5: warning[SC2091]: Remove surrounding $() to avoid executing output (or use eval if intentional).
#   17|   
#   18|   if $(stratis-min pool is-stopped "$STRATIS_ROOTFS_UUID"); then
#   19|-> 	if $(stratis-min pool is-encrypted "$STRATIS_ROOTFS_UUID"); then
#   20|   		ATTEMPTS_REMAINING=3
#   21|   		if

Error: SHELLCHECK_WARNING (CWE-829): [#def10]
/usr/lib/systemd/stratis-fstab-setup:20:4: warning[SC2091]: Remove surrounding $() to avoid executing output (or use eval if intentional).
#   18|   done
#   19|   
#   20|-> if $(stratis-min pool is-stopped "$POOL_UUID"); then
#   21|   	if $(stratis-min pool is-encrypted "$POOL_UUID"); then
#   22|   		if stratis-min pool start --token-slot=any "$POOL_UUID"; then

Error: SHELLCHECK_WARNING (CWE-829): [#def11]
/usr/lib/systemd/stratis-fstab-setup:21:5: warning[SC2091]: Remove surrounding $() to avoid executing output (or use eval if intentional).
#   19|   
#   20|   if $(stratis-min pool is-stopped "$POOL_UUID"); then
#   21|-> 	if $(stratis-min pool is-encrypted "$POOL_UUID"); then
#   22|   		if stratis-min pool start --token-slot=any "$POOL_UUID"; then
#   23|   			exit 0

Scan Properties