Newly introduced defects

List of Defects

Error: GCC_ANALYZER_WARNING (CWE-775): [#def1]
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-resources.c: scope_hint: In function 'update_cgroup_v1_resources'
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-resources.c:1076:21: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open(path_to_blkio, 2686976)'
# 1074|           return ret;
# 1075|   
# 1076|->       dirfd_blkio = open (path_to_blkio, O_DIRECTORY | O_PATH | O_CLOEXEC);
# 1077|         if (UNLIKELY (dirfd_blkio < 0))
# 1078|           return crun_make_error (err, errno, "open `%s`", path_to_blkio);

Error: GCC_ANALYZER_WARNING (CWE-775): [#def2]
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-resources.c:1101:24: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open(path_to_netclass, 2686976)'
# 1099|           return ret;
# 1100|   
# 1101|->       dirfd_netclass = open (path_to_netclass, O_DIRECTORY | O_PATH | O_CLOEXEC);
# 1102|         if (UNLIKELY (dirfd_netclass < 0))
# 1103|           return crun_make_error (err, errno, "open `%s`", path_to_netclass);

Error: GCC_ANALYZER_WARNING (CWE-775): [#def3]
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-resources.c:1105:23: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open(path_to_netprio, 2686976)'
# 1103|           return crun_make_error (err, errno, "open `%s`", path_to_netclass);
# 1104|   
# 1105|->       dirfd_netprio = open (path_to_netprio, O_DIRECTORY | O_PATH | O_CLOEXEC);
# 1106|         if (UNLIKELY (dirfd_netprio < 0))
# 1107|           return crun_make_error (err, errno, "open `%s`", path_to_netprio);

Error: GCC_ANALYZER_WARNING (CWE-775): [#def4]
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-resources.c:1122:20: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open(path_to_htlb, 2686976)'
# 1120|         if (UNLIKELY (ret < 0))
# 1121|           return ret;
# 1122|->       dirfd_htlb = open (path_to_htlb, O_DIRECTORY | O_PATH | O_CLOEXEC);
# 1123|         if (UNLIKELY (dirfd_htlb < 0))
# 1124|           return crun_make_error (err, errno, "open `%s`", path_to_htlb);

Error: GCC_ANALYZER_WARNING (CWE-775): [#def5]
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-setup.c: scope_hint: In function 'initialize_cpuset_subsystem_rec'
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-setup.c:53:11: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open(path, 2686976)'
#   51|     int b_len;
#   52|   
#   53|->   dirfd = open (path, O_DIRECTORY | O_PATH | O_CLOEXEC);
#   54|     if (UNLIKELY (dirfd < 0))
#   55|       return crun_make_error (err, errno, "open `%s`", path);

Error: GCC_ANALYZER_WARNING (CWE-775): [#def6]
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-systemd.c: scope_hint: In function 'setup_cpuset_for_systemd_v1'
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-systemd.c:269:22: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open(path_to_cpuset, 2686976)'
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-systemd.c: scope_hint: In function 'setup_cpuset_for_systemd_v1'
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-systemd.c: scope_hint: In function 'setup_cpuset_for_systemd_v1'
#  267|           return ret;
#  268|   
#  269|->       dirfd_cpuset = open (path_to_cpuset, O_DIRECTORY | O_PATH | O_CLOEXEC);
#  270|         if (UNLIKELY (dirfd_cpuset < 0))
#  271|           return crun_make_error (err, errno, "open `%s`", path_to_cpuset);

Error: GCC_ANALYZER_WARNING (CWE-775): [#def7]
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-utils.c: scope_hint: In function 'libcrun_get_cgroup_dirfd'
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-utils.c:963:17: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open(path_to_cgroup, 2818048)'
crun-1.16-build/crun-HEAD/src/libcrun/cgroup-utils.c: scope_hint: In function 'libcrun_get_cgroup_dirfd'
#  961|       return ret;
#  962|   
#  963|->   cgroupdirfd = open (path_to_cgroup, O_CLOEXEC | O_NOFOLLOW | O_DIRECTORY | O_PATH);
#  964|     if (UNLIKELY (cgroupdirfd < 0))
#  965|       return crun_make_error (err, errno, "open `%s`", path_to_cgroup);

Error: GCC_ANALYZER_WARNING (CWE-775): [#def8]
crun-1.16-build/crun-HEAD/src/libcrun/status.c: scope_hint: In function 'libcrun_container_delete_status'
crun-1.16-build/crun-HEAD/src/libcrun/status.c:535:36: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open(get_run_directory(state_root), 2686976)'
#  533|       return crun_make_error (err, 0, "cannot get state directory");
#  534|   
#  535|->   rundir_dfd = TEMP_FAILURE_RETRY (open (dir, O_DIRECTORY | O_PATH | O_CLOEXEC));
#  536|     if (UNLIKELY (rundir_dfd < 0))
#  537|       return crun_make_error (err, errno, "cannot open run directory `%s`", dir);

Scan Properties

analyzer-version-clippy1.80.0
analyzer-version-cppcheck2.14.2
analyzer-version-gcc14.1.1
analyzer-version-gcc-analyzer14.1.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.80.0
diffbase-analyzer-version-cppcheck2.14.2
diffbase-analyzer-version-gcc14.1.1
diffbase-analyzer-version-gcc-analyzer14.1.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-163.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namecrun-1.16-1.20240809123830688402.main.3.gf5912d1
diffbase-store-results-to/tmp/tmp0jhwoyue/crun-1.16-1.20240809123830688402.main.3.gf5912d1.tar.xz
diffbase-time-created2024-08-09 16:46:46
diffbase-time-finished2024-08-09 16:52:38
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'clippy,gcc,cppcheck,shellcheck,unicontrol' '-o' '/tmp/tmp0jhwoyue/crun-1.16-1.20240809123830688402.main.3.gf5912d1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '/tmp/tmp0jhwoyue/crun-1.16-1.20240809123830688402.main.3.gf5912d1.src.rpm'
diffbase-tool-versioncsmock-3.6.1-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-163.us-west-2.compute.internal
mock-configfedora-rawhide-x86_64
project-namecrun-1.16-1.20240809163914038421.pr1479.5.g8a508d9
store-results-to/tmp/tmpdszzbo37/crun-1.16-1.20240809163914038421.pr1479.5.g8a508d9.tar.xz
time-created2024-08-09 16:52:57
time-finished2024-08-09 16:58:21
titleNewly introduced defects
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'clippy,gcc,cppcheck,shellcheck,unicontrol' '-o' '/tmp/tmpdszzbo37/crun-1.16-1.20240809163914038421.pr1479.5.g8a508d9.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '/tmp/tmpdszzbo37/crun-1.16-1.20240809163914038421.pr1479.5.g8a508d9.src.rpm'
tool-versioncsmock-3.6.1-1.el9