Fixed findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-571): [#def1]
/usr/share/podman/test/system/220-healthcheck.bats:375:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  373|   
#  374|   @test "podman healthcheck --health-max-log-size 10" {
#  375|->     local msg="healthmsg-$(random_string)"
#  376|       local ctrname="c-h-$(safename)"
#  377|       _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthMaxLogSize}}" "--health-max-log-size 10" "10" "HealthMaxLogSize"

Error: SHELLCHECK_WARNING (CWE-571): [#def2]
/usr/share/podman/test/system/220-healthcheck.bats:391:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  389|       local s=$(printf "healthmsg-%1000s")
#  390|       local long_msg=${s// /$(random_string)}
#  391|->     local ctrname="c-h-$(safename)"
#  392|       _create_container_with_health_log_settings $ctrname $long_msg "{{.Config.HealthMaxLogSize}}" "--health-max-log-size 0" "0" "HealthMaxLogSize"
#  393|   

Error: SHELLCHECK_WARNING (CWE-571): [#def3]
/usr/share/podman/test/system/220-healthcheck.bats:405:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  403|   
#  404|   @test "podman healthcheck --health-max-log-size default value (500)" {
#  405|->     local s=$(printf "healthmsg-%1000s")
#  406|       local long_msg=${s// /$(random_string)}
#  407|       local ctrname="c-h-$(safename)"

Error: SHELLCHECK_WARNING (CWE-398): [#def4]
/usr/share/podman/test/system/220-healthcheck.bats:405:22: warning[SC2183]: This format string has 1 variable, but is passed 0 argument.
#  403|   
#  404|   @test "podman healthcheck --health-max-log-size default value (500)" {
#  405|->     local s=$(printf "healthmsg-%1000s")
#  406|       local long_msg=${s// /$(random_string)}
#  407|       local ctrname="c-h-$(safename)"

Error: SHELLCHECK_WARNING (CWE-571): [#def5]
/usr/share/podman/test/system/220-healthcheck.bats:407:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  405|       local s=$(printf "healthmsg-%1000s")
#  406|       local long_msg=${s// /$(random_string)}
#  407|->     local ctrname="c-h-$(safename)"
#  408|       _create_container_with_health_log_settings $ctrname $long_msg "{{.Config.HealthMaxLogSize}}" "" "500" "HealthMaxLogSize is the expected default"
#  409|   

Error: SHELLCHECK_WARNING (CWE-571): [#def6]
/usr/share/podman/test/system/220-healthcheck.bats:423:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  421|       local TMP_DIR_HEALTHCHECK="$PODMAN_TMPDIR/healthcheck"
#  422|       mkdir $TMP_DIR_HEALTHCHECK
#  423|->     local ctrname="c-h-$(safename)"
#  424|       local msg="healthmsg-$(random_string)"
#  425|       _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthLogDestination}}" "--health-log-destination $TMP_DIR_HEALTHCHECK" "$TMP_DIR_HEALTHCHECK" "HealthLogDestination"

Error: SHELLCHECK_WARNING (CWE-571): [#def7]
/usr/share/podman/test/system/220-healthcheck.bats:424:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  422|       mkdir $TMP_DIR_HEALTHCHECK
#  423|       local ctrname="c-h-$(safename)"
#  424|->     local msg="healthmsg-$(random_string)"
#  425|       _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthLogDestination}}" "--health-log-destination $TMP_DIR_HEALTHCHECK" "$TMP_DIR_HEALTHCHECK" "HealthLogDestination"
#  426|       cid="$output"

Error: SHELLCHECK_WARNING (CWE-571): [#def8]
/usr/share/podman/test/system/220-healthcheck.bats:447:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  445|       skip_if_journald_unavailable
#  446|   
#  447|->     local ctrname="c-h-$(safename)"
#  448|       local msg="healthmsg-$(random_string)"
#  449|       _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthLogDestination}}" "--health-log-destination events_logger" "events_logger" "HealthLogDestination"

Error: SHELLCHECK_WARNING (CWE-571): [#def9]
/usr/share/podman/test/system/220-healthcheck.bats:448:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  446|   
#  447|       local ctrname="c-h-$(safename)"
#  448|->     local msg="healthmsg-$(random_string)"
#  449|       _create_container_with_health_log_settings $ctrname $msg "{{.Config.HealthLogDestination}}" "--health-log-destination events_logger" "events_logger" "HealthLogDestination"
#  450|       cid="$output"

Scan Properties