Newly introduced findings

List of Findings

Error: SHELLCHECK_WARNING: [#def1]
/usr/bin/copr-backend-service:3:6: warning[SC3028]: In POSIX sh, EUID is undefined.
#    1|   #!/usr/bin/sh
#    2|   
#    3|-> if [ $EUID -ne 0 ]; then
#    4|      echo -e "This script must be run as root!\n"
#    5|      exit 1

Error: SHELLCHECK_WARNING: [#def2]
/usr/bin/copr-backend-service:4:9: warning[SC3037]: In POSIX sh, echo flags are undefined.
#    2|   
#    3|   if [ $EUID -ne 0 ]; then
#    4|->    echo -e "This script must be run as root!\n"
#    5|      exit 1
#    6|   fi

Error: SHELLCHECK_WARNING (CWE-156): [#def3]
/usr/bin/copr-backend-service:37:21: warning[SC2046]: Quote this to prevent word splitting.
#   35|   start() {
#   36|       echo "Starting Copr backend services..."
#   37|->     systemctl start $(copr_target_services)
#   38|       echo "Done."
#   39|       return 0

Error: SHELLCHECK_WARNING (CWE-252): [#def4]
/usr/bin/copr_find_obsolete_builds.sh:9:5: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
#    7|   if [ -d $CHROOT_PATH ]
#    8|   then
#    9|->     cd $CHROOT_PATH
#   10|   
#   11|       # query latest (successful) packages

Error: SHELLCHECK_WARNING (CWE-156): [#def5]
/usr/bin/copr_find_obsolete_builds.sh:15:12: warning[SC2046]: Quote this to prevent word splitting.
#   13|       ERR_LOG=$(mktemp)
#   14|       # "yum clean metadata" does not work on this custom repos
#   15|->     rm -rf $(find /var/tmp -name query &> /dev/null) &> /dev/null
#   16|       rm -rf /var/tmp/createrepo* &> /dev/null
#   17|       rm -rf /var/cache/yum/* &> /dev/null

Error: SHELLCHECK_WARNING (CWE-398): [#def6]
/usr/bin/copr_find_obsolete_builds.sh:23:20: warning[SC2044]: For loops over find output are fragile. Use find -exec or a while read loop.
#   21|   
#   22|       # Remove builds older then $DAYS days and which have newer builds available
#   23|->     for SUCCESS in $(find -name success -mtime +$DAYS); do
#   24|           DIR=$(basename $(dirname $SUCCESS))
#   25|           echo "# checking dir: " $DIR

Error: SHELLCHECK_WARNING (CWE-156): [#def7]
/usr/bin/copr_find_obsolete_builds.sh:24:24: warning[SC2046]: Quote this to prevent word splitting.
#   22|       # Remove builds older then $DAYS days and which have newer builds available
#   23|       for SUCCESS in $(find -name success -mtime +$DAYS); do
#   24|->         DIR=$(basename $(dirname $SUCCESS))
#   25|           echo "# checking dir: " $DIR
#   26|           for PACKAGE in $(ls $DIR); do

Error: SHELLCHECK_WARNING (CWE-398): [#def8]
/usr/bin/copr_find_obsolete_builds.sh:26:24: error[SC2045]: Iterating over ls output is fragile. Use globs.
#   24|           DIR=$(basename $(dirname $SUCCESS))
#   25|           echo "# checking dir: " $DIR
#   26|->         for PACKAGE in $(ls $DIR); do
#   27|               grep $PACKAGE $LATEST_PKGS >/dev/null && continue 2
#   28|           done

Scan Properties