Fixed findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-563): [#def1]
/usr/share/buildah/test/system/blobcache.bats:88:3: warning[SC2034]: cachedir appears unused. Verify use (or export if used externally).
#   86|   	if is_rootless;
#   87|   	then
#   88|-> 		cachedir=$HOME/.local/share
#   89|   	fi
#   90|   	run rm -rf $blobcachedir/*

Error: SHELLCHECK_WARNING (CWE-457): [#def2]
/usr/share/buildah/test/system/blobcache.bats:91:44: warning[SC2154]: cachefile is referenced but not assigned.
#   89|   	fi
#   90|   	run rm -rf $blobcachedir/*
#   91|-> 	assert "$status" -eq 0 "status of `run rm $cachefile` must be 0"
#   92|   
#   93|   	# In first push blob must be skipped after vendoring https://github.com/containers/image/pull/1645

Error: SHELLCHECK_WARNING (CWE-156): [#def3]
/usr/share/buildah/test/system/test_runner.sh:16:22: warning[SC2046]: Quote this to prevent word splitting.
#   14|   
#   15|   # Run the tests.
#   16|-> execute time bats -j $(nproc) --tap "${@:-.}"

Scan Properties

analyzer-version-clippy1.84.0
analyzer-version-cppcheck2.16.2
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.84.0
diffbase-analyzer-version-cppcheck2.16.2
diffbase-analyzer-version-gcc15.0.1
diffbase-analyzer-version-gcc-analyzer15.0.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-221.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namebuildah-1.38.0-1.20250129151204912287.pr5954.153.g7dd8114aa
diffbase-store-results-to/tmp/tmpmqfuwwkd/buildah-1.38.0-1.20250129151204912287.pr5954.153.g7dd8114aa.tar.xz
diffbase-time-created2025-01-29 16:02:05
diffbase-time-finished2025-01-29 16:15:36
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,unicontrol,clippy,cppcheck,gcc' '-o' '/tmp/tmpmqfuwwkd/buildah-1.38.0-1.20250129151204912287.pr5954.153.g7dd8114aa.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '/tmp/tmpmqfuwwkd/buildah-1.38.0-1.20250129151204912287.pr5954.153.g7dd8114aa.src.rpm'
diffbase-tool-versioncsmock-3.8.0-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-221.us-west-2.compute.internal
mock-configfedora-rawhide-x86_64
project-namebuildah-1.38.0-1.20250129122443652679.main.150.g607ca3065
store-results-to/tmp/tmpqq5akpgp/buildah-1.38.0-1.20250129122443652679.main.150.g607ca3065.tar.xz
time-created2025-01-29 15:48:01
time-finished2025-01-29 16:01:39
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,unicontrol,clippy,cppcheck,gcc' '-o' '/tmp/tmpqq5akpgp/buildah-1.38.0-1.20250129122443652679.main.150.g607ca3065.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '/tmp/tmpqq5akpgp/buildah-1.38.0-1.20250129122443652679.main.150.g607ca3065.src.rpm'
tool-versioncsmock-3.8.0-1.el9