Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-476): [#def1]
util-linux-2.41.devel-build/util-linux-2.41.devel/disk-utils/fdformat.c: scope_hint: In function ‘verify_disk’
util-linux-2.41.devel-build/util-linux-2.41.devel/disk-utils/fdformat.c:127:49: warning[-Wanalyzer-possible-null-dereference]: dereference of possibly-NULL ‘xmalloc((long unsigned int)track_size)’
util-linux-2.41.devel-build/util-linux-2.41.devel/disk-utils/fdformat.c:28: included_from: Included from here.
#  125|   				}
#  126|   				for (count = 0; count < track_size; count++)
#  127|-> 					if (data[count] != FD_FILL_BYTE) {
#  128|   						if (retries_left) {
#  129|   							format_begin(ctrl);

Error: GCC_ANALYZER_WARNING (CWE-476): [#def2]
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/cal.c: scope_hint: In function ‘monthly’
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/cal.c:1085:28: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc((long unsigned int)*ctl.months_in_row, 208) + (sizetype)i * 208’
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/cal.c:79: included_from: Included from here.
# 1083|   
# 1084|   	for (i = 0; i < ctl->months_in_row - 1; i++)
# 1085|-> 		ms[i].next = &ms[i + 1];
# 1086|   
# 1087|   	rows = (ctl->num_months - 1) / ctl->months_in_row;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def3]
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/hardlink.c: scope_hint: In function ‘get_sorted_xattr_name_table’
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/hardlink.c:529:26: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc((long unsigned int)n, 8)’
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/hardlink.c: scope_hint: In function ‘get_sorted_xattr_name_table’
util-linux-2.41.devel-build/util-linux-2.41.devel/include/optutils.h:8: included_from: Included from here.
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/hardlink.c:58: included_from: Included from here.
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/hardlink.c:55: included_from: Included from here.
#  527|   
#  528|   	for (i = 0; i < n; i++) {
#  529|-> 		table[i] = names;
#  530|   		names += strlen(names) + 1;
#  531|   	}

Error: GCC_ANALYZER_WARNING (CWE-476): [#def4]
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/waitpid.c: scope_hint: In function ‘parse_pids’
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/waitpid.c:54:25: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc(n_strings, 4)’
util-linux-2.41.devel-build/util-linux-2.41.devel/include/strutils.h:53:64: note: in definition of macro ‘strtopid_or_err’
util-linux-2.41.devel-build/util-linux-2.41.devel/misc-utils/waitpid.c:54:55: note: in expansion of macro ‘_’
#   52|   
#   53|   	for (size_t i = 0; i < n_strings; i++)
#   54|-> 		pids[i] = strtopid_or_err(strings[i], _("failed to parse pid"));
#   55|   
#   56|   	return pids;

Scan Properties

analyzer-version-clippy1.84.0
analyzer-version-cppcheck2.16.2
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.84.0
diffbase-analyzer-version-cppcheck2.16.2
diffbase-analyzer-version-gcc15.0.1
diffbase-analyzer-version-gcc-analyzer15.0.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-244.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-nameutil-linux-2.41.devel-1.20250125121706354264.pr3382.1033.g1004b08ce
diffbase-store-results-to/tmp/tmpe0fh1ytp/util-linux-2.41.devel-1.20250125121706354264.pr3382.1033.g1004b08ce.tar.xz
diffbase-time-created2025-01-25 13:41:41
diffbase-time-finished2025-01-25 13:50:05
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,shellcheck,clippy,unicontrol,cppcheck' '-o' '/tmp/tmpe0fh1ytp/util-linux-2.41.devel-1.20250125121706354264.pr3382.1033.g1004b08ce.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '/tmp/tmpe0fh1ytp/util-linux-2.41.devel-1.20250125121706354264.pr3382.1033.g1004b08ce.src.rpm'
diffbase-tool-versioncsmock-3.8.0-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-244.us-west-2.compute.internal
mock-configfedora-rawhide-x86_64
project-nameutil-linux-2.41.devel-1.20250122105814394406.master.1029.geba4f374f
store-results-to/tmp/tmp8jd6o6gq/util-linux-2.41.devel-1.20250122105814394406.master.1029.geba4f374f.tar.xz
time-created2025-01-25 13:32:28
time-finished2025-01-25 13:41:11
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,shellcheck,clippy,unicontrol,cppcheck' '-o' '/tmp/tmp8jd6o6gq/util-linux-2.41.devel-1.20250122105814394406.master.1029.geba4f374f.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '/tmp/tmp8jd6o6gq/util-linux-2.41.devel-1.20250122105814394406.master.1029.geba4f374f.src.rpm'
tool-versioncsmock-3.8.0-1.el9