Newly introduced findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-571): [#def1]
/usr/share/podman/test/system/450-interactive.bats:128:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  126|   
#  127|   @test "podman run detach keys" {
#  128|->     local cname1=c1-$(safename)
#  129|       local cname2=c2-$(safename)
#  130|   

Error: SHELLCHECK_WARNING (CWE-571): [#def2]
/usr/share/podman/test/system/450-interactive.bats:129:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  127|   @test "podman run detach keys" {
#  128|       local cname1=c1-$(safename)
#  129|->     local cname2=c2-$(safename)
#  130|   
#  131|       local msg=$(random_string)

Error: SHELLCHECK_WARNING (CWE-571): [#def3]
/usr/share/podman/test/system/450-interactive.bats:131:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  129|       local cname2=c2-$(safename)
#  130|   
#  131|->     local msg=$(random_string)
#  132|       # First "type" a command then send CTRL-p,CTRL-q sequence to the run command.
#  133|       # We must send that sequence in two echo commands if I use a single echo it

Error: SHELLCHECK_WARNING (CWE-569): [#def4]
/usr/share/podman/test/system/450-interactive.bats:143:33: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it.
#  141|   
#  142|       # The container should still be running
#  143|->     run_podman inspect --format {{.State.Status}} $cname1
#  144|       assert "$output" == "running" "container status"
#  145|   

Error: SHELLCHECK_WARNING (CWE-569): [#def5]
/usr/share/podman/test/system/450-interactive.bats:143:34: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it.
#  141|   
#  142|       # The container should still be running
#  143|->     run_podman inspect --format {{.State.Status}} $cname1
#  144|       assert "$output" == "running" "container status"
#  145|   

Error: SHELLCHECK_WARNING (CWE-569): [#def6]
/usr/share/podman/test/system/450-interactive.bats:143:48: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it.
#  141|   
#  142|       # The container should still be running
#  143|->     run_podman inspect --format {{.State.Status}} $cname1
#  144|       assert "$output" == "running" "container status"
#  145|   

Error: SHELLCHECK_WARNING (CWE-569): [#def7]
/usr/share/podman/test/system/450-interactive.bats:143:49: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it.
#  141|   
#  142|       # The container should still be running
#  143|->     run_podman inspect --format {{.State.Status}} $cname1
#  144|       assert "$output" == "running" "container status"
#  145|   

Error: SHELLCHECK_WARNING (CWE-571): [#def8]
/usr/share/podman/test/system/450-interactive.bats:157:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  155|       skip_if_remote "FIXME #25089: podman-remote exec detach broken"
#  156|   
#  157|->     local cname=c-$(safename)
#  158|       run_podman run -d --name $cname $IMAGE sleep inf
#  159|   

Error: SHELLCHECK_WARNING (CWE-571): [#def9]
/usr/share/podman/test/system/450-interactive.bats:160:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  158|       run_podman run -d --name $cname $IMAGE sleep inf
#  159|   
#  160|->     local msg=$(random_string)
#  161|       # First "type" a command then send CTRL-p,CTRL-q sequence to the exec command.
#  162|       # If the detach does not work podman exec will hang and timeout.

Scan Properties

analyzer-version-clippy1.84.0
analyzer-version-cppcheck2.16.2
analyzer-version-gcc15.0.1
analyzer-version-gcc-analyzer15.0.1
analyzer-version-shellcheck0.10.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.84.0
diffbase-analyzer-version-cppcheck2.16.2
diffbase-analyzer-version-gcc15.0.1
diffbase-analyzer-version-gcc-analyzer15.0.1
diffbase-analyzer-version-shellcheck0.10.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-195.us-west-2.compute.internal
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namepodman-5.4.0~dev-1.20250123192847963035.main.28.3b6c7665b
diffbase-store-results-to/tmp/tmp8fhnb5lm/podman-5.4.0~dev-1.20250123192847963035.main.28.3b6c7665b.tar.xz
diffbase-time-created2025-01-24 15:41:55
diffbase-time-finished2025-01-24 15:54:08
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,shellcheck,clippy,unicontrol,cppcheck' '-o' '/tmp/tmp8fhnb5lm/podman-5.4.0~dev-1.20250123192847963035.main.28.3b6c7665b.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '/tmp/tmp8fhnb5lm/podman-5.4.0~dev-1.20250123192847963035.main.28.3b6c7665b.src.rpm'
diffbase-tool-versioncsmock-3.8.0-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-195.us-west-2.compute.internal
mock-configfedora-rawhide-x86_64
project-namepodman-5.4.0~dev-1.20250124152712469090.pr25083.33.0314635b2
store-results-to/tmp/tmpupnhi5ot/podman-5.4.0~dev-1.20250124152712469090.pr25083.33.0314635b2.tar.xz
time-created2025-01-24 15:54:43
time-finished2025-01-24 16:06:50
titleNewly introduced findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,shellcheck,clippy,unicontrol,cppcheck' '-o' '/tmp/tmpupnhi5ot/podman-5.4.0~dev-1.20250124152712469090.pr25083.33.0314635b2.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '/tmp/tmpupnhi5ot/podman-5.4.0~dev-1.20250124152712469090.pr25083.33.0314635b2.src.rpm'
tool-versioncsmock-3.8.0-1.el9