Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
src/dbus/pool/pool_3_10/methods.rs:66:33: warning: relative drop order changing in Rust 2024
#      |
#   62 |                     let opt = manager.read().await.blockdev_get_path(&dev_uuid).cloned();
#      |                               --------------------
#      |                               |              |
#      |                               |              this value will be stored in a temporary; let us call it `#3`
#      |                               |              `#3` will be dropped later as of Edition 2024
#      |                               this value will be stored in a temporary; let us call it `#1`
#      |                               `#1` will be dropped later as of Edition 2024
#      |                               this value will be stored in a temporary; let us call it `#2`
#      |                               `#2` will be dropped later as of Edition 2024
#  ...
#   66 |                                 unregister_blockdev(connection, manager, &p.as_ref()).await
#      |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-----
#      |                                 |                                                     |
#      |                                 |                                                     this value will be stored in a temporary; let us call it `#7`
#      |                                 |                                                     up until Edition 2021 `#7` is dropped last but will be dropped earlier in Edition 2024
#      |                                 |                                                     this value will be stored in a temporary; let us call it `#5`
#      |                                 |                                                     `#5` will be dropped later as of Edition 2024
#      |                                 this value will be stored in a temporary; let us call it `#6`
#      |                                 up until Edition 2021 `#6` is dropped last but will be dropped earlier in Edition 2024
#      |                                 this value will be stored in a temporary; let us call it `#4`
#      |                                 `#4` will be dropped later as of Edition 2024
#  ...
#   72 |                         }
#      |                         - now the temporary value is dropped here, before the local variables in the block or statement
#      |
#  note: `#6` invokes this custom destructor
#     --> library/std/src/os/fd/owned.rs:196:0
#  note: `#6` invokes this custom destructor
#     --> library/std/src/sync/once_lock.rs:692:0
#      = note: `#6` may invoke a custom destructor because it contains a trait object
#  note: `#6` invokes this custom destructor
#     --> /usr/share/cargo/registry/semver-1.0.28/src/identifier.rs:240:1
#      |
#  240 | impl Drop for Identifier {
#      | ^^^^^^^^^^^^^^^^^^^^^^^^
#  note: `#1` invokes this custom destructor
#     --> src/engine/structures/lock.rs:43:1
#      |
#   43 | impl<G> Drop for SharedGuard<G> {
#      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#  note: `#3` invokes this custom destructor
#     --> src/engine/structures/lock.rs:43:1
#      |
#   43 | impl<G> Drop for SharedGuard<G> {
#      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#  note: `#5` invokes this custom destructor
#     --> library/std/src/os/fd/owned.rs:196:0
#  note: `#5` invokes this custom destructor
#     --> library/std/src/sync/once_lock.rs:692:0
#      = note: `#5` may invoke a custom destructor because it contains a trait object
#  note: `#5` invokes this custom destructor
#     --> /usr/share/cargo/registry/semver-1.0.28/src/identifier.rs:240:1
#      |
#  240 | impl Drop for Identifier {
#      | ^^^^^^^^^^^^^^^^^^^^^^^^
#      = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
#      = warning: this changes meaning in Rust 2024
#      = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
#      = note: `-D tail-expr-drop-order` implied by `-D rust-2024-compatibility`
#      = help: to override `-D rust-2024-compatibility` add `#[allow(tail_expr_drop_order)]`
#      = note: the `tail_expr_drop_order` lint ignores `-D warnings`

Scan Properties