Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-1341): [#def1]
crun-HEAD/src/libcrun/container.c:3891:23: warning[-Wanalyzer-fd-double-close]: double 'close' of file descriptor 'pipefd1'
crun-HEAD/src/libcrun/container.c: scope_hint: In function 'libcrun_container_exec_with_options'
crun-HEAD/src/libcrun/container.c: scope_hint: In function 'libcrun_container_exec_with_options'
crun-HEAD/src/libcrun/utils.h:57:40: note: in definition of macro 'UNLIKELY'
# 3889|       }
# 3890|   
# 3891|->   TEMP_FAILURE_RETRY (close (pipefd1));
# 3892|     pipefd1 = -1;
# 3893|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def2]
crun-HEAD/src/libcrun/criu.c: scope_hint: In function 'checkpoint_cgroup_v1_mount'
crun-HEAD/src/libcrun/criu.c:439:22: warning[-Wanalyzer-null-dereference]: dereference of NULL '0'
crun-HEAD/src/libcrun/utils.h:57:40: note: in definition of macro 'UNLIKELY'
#  437|         subsystem = strchr (from, ':') + 1;
#  438|         subpath = strchr (subsystem, ':') + 1;
#  439|->       *(subpath - 1) = '\0';
#  440|   
#  441|         if (subsystem[0] == '\0')

Error: GCC_ANALYZER_WARNING (CWE-476): [#def3]
crun-HEAD/src/libcrun/criu.c:441:20: warning[-Wanalyzer-null-dereference]: dereference of NULL '0'
crun-HEAD/src/libcrun/utils.h:57:40: note: in definition of macro 'UNLIKELY'
#  439|         *(subpath - 1) = '\0';
#  440|   
#  441|->       if (subsystem[0] == '\0')
#  442|           continue;
#  443|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def4]
crun-HEAD/src/libcrun/seccomp.c: scope_hint: In function 'store_seccomp_cache'
crun-HEAD/src/libcrun/seccomp.c:602:9: warning[-Wanalyzer-null-dereference]: dereference of NULL '**ctx.container.context'
crun-HEAD/src/libcrun/seccomp.c: scope_hint: In function 'store_seccomp_cache'
crun-HEAD/src/libcrun/seccomp.c: scope_hint: In function 'store_seccomp_cache'
#  600|   
#  601|     /* relative path to dirfd.  */
#  602|->   ret = append_paths (&src_path, err, container->context->id, "seccomp.bpf", NULL);
#  603|     if (UNLIKELY (ret < 0))
#  604|       return ret;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def5]
crun-HEAD/src/libcrun/seccomp.c:602:9: warning[-Wanalyzer-null-dereference]: dereference of NULL '*container.context'
crun-HEAD/src/libcrun/seccomp.c: scope_hint: In function 'store_seccomp_cache'
crun-HEAD/src/libcrun/seccomp.c: scope_hint: In function 'store_seccomp_cache'
#  600|   
#  601|     /* relative path to dirfd.  */
#  602|->   ret = append_paths (&src_path, err, container->context->id, "seccomp.bpf", NULL);
#  603|     if (UNLIKELY (ret < 0))
#  604|       return ret;

Error: GCC_ANALYZER_WARNING (CWE-1341): [#def6]
crun-HEAD/src/libcrun/utils.h:213:33: warning[-Wanalyzer-fd-double-close]: double 'close' of file descriptor 'own_seccomp_receiver_fd'
crun-HEAD/src/libcrun/container.c: scope_hint: In function 'close_and_reset.part.0'
crun-HEAD/src/libcrun/container.c: scope_hint: In function 'close_and_reset.part.0'
crun-HEAD/src/libcrun/utils.h:57:40: note: in definition of macro 'UNLIKELY'
crun-HEAD/src/libcrun/utils.h: scope_hint: In function 'close_and_reset.part.0'
#  211|     if (*fd >= 0)
#  212|       {
#  213|->       ret = TEMP_FAILURE_RETRY (close (*fd));
#  214|         if (LIKELY (ret == 0))
#  215|           *fd = -1;

Scan Properties