Task #133185 - rust-prefixdevname-0.2.0-8.fc44/scan-results.err
back to task #133185download
Error: CLIPPY_WARNING:
src/config.rs:87:12: warning: needless call to `as_bytes`
# |
# 87 | if name.as_bytes().len() > 16 {
# | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `name.len()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#needless_as_bytes
# = note: `#[warn(clippy::needless_as_bytes)]` on by default
Error: CLIPPY_WARNING:
src/config.rs:182:13: warning: redundant reference in `format!` argument
# |
# 182 | &(last_index + 1).to_string()
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the redundant `&`: `(last_index + 1).to_string()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting
# = note: `#[warn(clippy::useless_borrows_in_formatting)]` on by default
Error: CLIPPY_WARNING:
src/config.rs:214:13: warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
# |
# 214 | / match device.devtype() {
# 215 | | Some(t) => match t.to_str() {
# 216 | | Some("vlan") | Some("bond") | Some("bridge") => continue,
# 217 | | _ => {}
# 218 | | },
# 219 | | None => {}
# 220 | | }
# | |_____________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#single_match
# = note: `#[warn(clippy::single_match)]` on by default
# help: try
# |
# 214 ~ if let Some(t) = device.devtype() { match t.to_str() {
# 215 + Some("vlan") | Some("bond") | Some("bridge") => continue,
# 216 + _ => {}
# 217 + } }
# |
Error: CLIPPY_WARNING:
src/util.rs:46:16: warning: this manual char comparison can be written more succinctly
# |
# 46 | .split(|c| c == ':' || c == '-')
# | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[':', '-']`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#manual_pattern_char_comparison
# = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default