Fixed findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-563): [#def1]
/usr/lib64/tclConfig.sh:16:1: warning[SC2034]: TCL_PATCH_LEVEL appears unused. Verify use (or export if used externally).
#   14|   TCL_MAJOR_VERSION='9'
#   15|   TCL_MINOR_VERSION='0'
#   16|-> TCL_PATCH_LEVEL='.2'
#   17|   
#   18|   # C compiler to use for compilation.

Error: SHELLCHECK_WARNING (CWE-563): [#def2]
/usr/lib64/tclConfig.sh:39:1: warning[SC2034]: TCL_ZIP_FILE appears unused. Verify use (or export if used externally).
#   37|   
#   38|   # The name of a zip containing the /library and /encodings (may be either a .zip file or a shared library):
#   39|-> TCL_ZIP_FILE='libtcl9.0.2.zip'
#   40|   
#   41|   # Additional libraries to use when linking Tcl.

Error: GCC_ANALYZER_WARNING (CWE-476): [#def3]
tcl9.0.2/generic/regc_cvec.c:85:5: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
tcl9.0.2/generic/regcomp.c:1690:1: enter_function: entry to ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1701:13: call_function: calling ‘newstate’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1701:13: return_function: returning to ‘wordchrs’ from ‘newstate’
tcl9.0.2/generic/regcomp.c:1702:5: branch_false: following ‘false’ branch...
tcl9.0.2/generic/regcomp.c:1708:5: call_function: inlined call to ‘lexword’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1709:5: call_function: calling ‘next’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1709:5: return_function: returning to ‘wordchrs’ from ‘next’
tcl9.0.2/generic/regcomp.c:1711:5: call_function: calling ‘bracket’ from ‘wordchrs’
#   83|   {
#   84|       assert(cv->nchrs < cv->chrspace);
#   85|->     cv->chrs[cv->nchrs++] = (chr)c;
#   86|   }
#   87|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def4]
tcl9.0.2/generic/regc_cvec.c:85:5: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘cv’
tcl9.0.2/generic/regcomp.c:1690:1: enter_function: entry to ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1701:13: call_function: calling ‘newstate’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1701:13: return_function: returning to ‘wordchrs’ from ‘newstate’
tcl9.0.2/generic/regcomp.c:1702:5: branch_false: following ‘false’ branch...
tcl9.0.2/generic/regcomp.c:1708:5: call_function: inlined call to ‘lexword’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1709:5: call_function: calling ‘next’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1709:5: return_function: returning to ‘wordchrs’ from ‘next’
tcl9.0.2/generic/regcomp.c:1711:5: call_function: calling ‘bracket’ from ‘wordchrs’
#   83|   {
#   84|       assert(cv->nchrs < cv->chrspace);
#   85|->     cv->chrs[cv->nchrs++] = (chr)c;
#   86|   }
#   87|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def5]
tcl9.0.2/generic/regc_cvec.c:99:5: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
tcl9.0.2/generic/regcomp.c:1690:1: enter_function: entry to ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1701:13: call_function: calling ‘newstate’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1701:13: return_function: returning to ‘wordchrs’ from ‘newstate’
tcl9.0.2/generic/regcomp.c:1702:5: branch_false: following ‘false’ branch...
tcl9.0.2/generic/regcomp.c:1708:5: call_function: inlined call to ‘lexword’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1709:5: call_function: calling ‘next’ from ‘wordchrs’
#   97|   {
#   98|       assert(cv->nranges < cv->rangespace);
#   99|->     cv->ranges[cv->nranges*2] = (chr)from;
#  100|       cv->ranges[cv->nranges*2 + 1] = (chr)to;
#  101|       cv->nranges++;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def6]
tcl9.0.2/generic/regc_nfa.c:283:24: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘to’
tcl9.0.2/generic/regcomp.c:1690:1: enter_function: entry to ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1701:13: call_function: calling ‘newstate’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1701:13: return_function: returning to ‘wordchrs’ from ‘newstate’
tcl9.0.2/generic/regcomp.c:1702:5: branch_false: following ‘false’ branch...
tcl9.0.2/generic/regcomp.c:1708:5: call_function: inlined call to ‘lexword’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1709:5: call_function: calling ‘next’ from ‘wordchrs’
tcl9.0.2/generic/regcomp.c:1709:5: return_function: returning to ‘wordchrs’ from ‘next’
tcl9.0.2/generic/regcomp.c:1711:5: call_function: calling ‘bracket’ from ‘wordchrs’
#  281|   
#  282|       /* check for duplicate arc, using whichever chain is shorter */
#  283|->     if (from->nouts <= to->nins) {
#  284|   	for (a = from->outs; a != NULL; a = a->outchain) {
#  285|   	    if (a->to == to && a->co == co && a->type == t) {

Error: CPPCHECK_WARNING (CWE-457): [#def7]
tcl9.0.2/generic/tclObj.c:2155: error[uninitvar]: Uninitialized variable: cachePtr
# 2153|   	Tcl_Obj *msg;
# 2154|   
# 2155|-> 	TclNewLiteralStringObj(msg, "expected boolean value but got \"");
# 2156|   	Tcl_AppendLimitedToObj(msg, str, length, 50, "");
# 2157|   	Tcl_AppendToObj(msg, "\"", -1);

Error: CPPCHECK_WARNING (CWE-457): [#def8]
tcl9.0.2/generic/tclObj.c:2155: error[uninitvar]: Uninitialized variable: msg
# 2153|   	Tcl_Obj *msg;
# 2154|   
# 2155|-> 	TclNewLiteralStringObj(msg, "expected boolean value but got \"");
# 2156|   	Tcl_AppendLimitedToObj(msg, str, length, 50, "");
# 2157|   	Tcl_AppendToObj(msg, "\"", -1);

Error: GCC_ANALYZER_WARNING (CWE-465): [#def9]
tcl9.0.2/generic/tclZipfs.c:3484:8: warning[-Wanalyzer-deref-before-check]: check of ‘mappingList’ for NULL after already dereferencing it
tcl9.0.2/generic/tclZipfs.c:4020:1: enter_function: entry to ‘ZipFSLMkImgObjCmd’
tcl9.0.2/generic/tclZipfs.c:4032:8: branch_false: following ‘false’ branch...
tcl9.0.2/generic/tclZipfs.c:4038:18: branch_false: ...to here
tcl9.0.2/generic/tclZipfs.c:4038:18: branch_false: following ‘false’ branch (when ‘objc != 5’)...
tcl9.0.2/generic/tclZipfs.c:4039:16: branch_false: ...to here
tcl9.0.2/generic/tclZipfs.c:4039:16: branch_false: following ‘false’ branch (when ‘objc != 4’)...
tcl9.0.2/generic/tclZipfs.c:4040:12: branch_false: ...to here
tcl9.0.2/generic/tclZipfs.c:4040:12: call_function: calling ‘ZipFSMkZipOrImg’ from ‘ZipFSLMkImgObjCmd’
# 3482|   	return TCL_ERROR;
# 3483|       }
# 3484|->     if (mappingList && (lobjc % 2)) {
# 3485|   	Tcl_DecrRefCount(list);
# 3486|   	ZIPFS_ERROR(interp, "need even number of elements");

Scan Properties