Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-843): [#def1]
rygel-45.1/src/librygel-core/dlna150-hacks.vala: scope_hint: In function ‘rygel_dlna150_hacks_real_constructed’
rygel-45.1/src/librygel-core/dlna150-hacks.vala:24:30: warning[-Wincompatible-pointer-types]: passing argument 1 of ‘_vala_array_dup4’ from incompatible pointer type
#   24 |             var defaults = new Gee.ArrayList<string>.wrap (AGENTS, (Gee.EqualDataFunc<string>?)str_equal);
#      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~
#      |                              |
#      |                              const gchar ** {aka const char **}
rygel-45.1/redhat-linux-build/src/librygel-core/librygel-core-2.8.so.0.45.3.p/dlna150-hacks.c:69:27: note: expected ‘gchar **’ {aka ‘char **’} but argument is of type ‘const gchar **’ {aka ‘const char **’}
#   69 | _vala_array_dup4 (gchar** self,
#      |                   ~~~~~~~~^~~~
#   22|   
#   23|           if (Dlna150Hacks.agent_matcher == null) {
#   24|->             var defaults = new Gee.ArrayList<string>.wrap (AGENTS, (Gee.EqualDataFunc<string>?)str_equal);
#   25|               var config = MetaConfig.get_default ();
#   26|               var agents = config.get_string_list_with_default ("general", "force-downgrade-for", defaults);

Error: COMPILER_WARNING (CWE-843): [#def2]
rygel-45.1/src/librygel-core/dlna150-hacks.vala:24:30: warning[-Wincompatible-pointer-types]: passing argument 1 of ‘_vala_array_dup4’ from incompatible pointer type
#   22|   
#   23|           if (Dlna150Hacks.agent_matcher == null) {
#   24|->             var defaults = new Gee.ArrayList<string>.wrap (AGENTS, (Gee.EqualDataFunc<string>?)str_equal);
#   25|               var config = MetaConfig.get_default ();
#   26|               var agents = config.get_string_list_with_default ("general", "force-downgrade-for", defaults);

Error: GCC_ANALYZER_WARNING (CWE-476): [#def3]
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:356:2: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘g_string_new("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\012<bms:NSLookupResult xmlns:bms=\"urn:schemas-upnp-org:dm:bms\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"urn:schemas-upnp-org:dm:bms http://www.upnp.org/schemas/dm/bms.xsd\">\012")’
rygel-45.1/redhat-linux-build/rygel-basic-management-test-nslookup.c:1495:1: enter_function: entry to ‘rygel_basic_management_test_ns_lookup_get_results’
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:342:2: branch_true: following ‘true’ branch (when ‘self’ is non-NULL)...
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:347:11: branch_true: ...to here
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:349:23: branch_true: following ‘true’ branch (when ‘result_it < _tmp1__length1’)...
rygel-45.1/redhat-linux-build/rygel-basic-management-test-nslookup.c:1542:43: branch_true: ...to here
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:350:14: call_function: calling ‘rygel_basic_management_test_ns_lookup_result_to_xml_fragment’ from ‘rygel_basic_management_test_ns_lookup_get_results’
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:350:14: return_function: returning to ‘rygel_basic_management_test_ns_lookup_get_results’ from ‘rygel_basic_management_test_ns_lookup_result_to_xml_fragment’
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:350:5: call_function: inlined call to ‘g_string_append_len_inline’ from ‘rygel_basic_management_test_ns_lookup_get_results’
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:350:5: branch_true: following ‘true’ branch...
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:350:5: branch_true: ...to here
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:351:8: branch_true: following ‘true’ branch (when ‘<unknown> == 0’)...
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:352:6: branch_true: ...to here
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:349:5: call_function: calling ‘rygel_basic_management_test_ns_lookup_result_destroy’ from ‘rygel_basic_management_test_ns_lookup_get_results’
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:349:5: return_function: returning to ‘rygel_basic_management_test_ns_lookup_get_results’ from ‘rygel_basic_management_test_ns_lookup_result_destroy’
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:349:23: branch_false: following ‘false’ branch (when ‘result_it >= _tmp1__length1’)...
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:355:2: call_function: inlined call to ‘g_string_append_len_inline’ from ‘rygel_basic_management_test_ns_lookup_get_results’
rygel-45.1/src/librygel-core/rygel-basic-management-test-nslookup.vala:356:2: danger: dereference of NULL ‘g_string_new("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\012<bms:NSLookupResult xmlns:bms=\"urn:schemas-upnp-org:dm:bms\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"urn:schemas-upnp-org:dm:bms http://www.upnp.org/schemas/dm/bms.xsd\">\012")’
#  354|           }
#  355|           builder.append (FOOTER);
#  356|->         result_string = builder.str;
#  357|   
#  358|           status = this.generic_status.to_string ();

Error: GCC_ANALYZER_WARNING (CWE-476): [#def4]
rygel-45.1/src/librygel-core/rygel-basic-management-test.vala:242:19: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
rygel-45.1/redhat-linux-build/rygel-basic-management-test.c:939:1: enter_function: entry to ‘rygel_basic_management_test_real_run’
rygel-45.1/src/librygel-core/rygel-basic-management-test.vala:26:11: call_function: inlined call to ‘_g_object_ref0’ from ‘rygel_basic_management_test_real_run’
rygel-45.1/src/librygel-core/rygel-basic-management-test.vala:26:2: branch_false: ...to here
rygel-45.1/src/librygel-core/rygel-basic-management-test.vala:26:2: call_function: calling ‘rygel_basic_management_test_real_run_co’ from ‘rygel_basic_management_test_real_run’
#  240|   
#  241|       public async virtual void run () {
#  242|->         if (this.execution_state != ExecutionState.REQUESTED) {
#  243|               debug ("Not running test: already started");
#  244|   

Error: COMPILER_WARNING (CWE-843): [#def5]
rygel-45.1/src/librygel-core/rygel-v1-hacks.vala: scope_hint: In function ‘rygel_v1_hacks_real_constructed’
rygel-45.1/src/librygel-core/rygel-v1-hacks.vala:75:30: warning[-Wincompatible-pointer-types]: passing argument 1 of ‘_vala_array_dup2’ from incompatible pointer type
#   75 |             var defaults = new Gee.ArrayList<string>.wrap (AGENTS, (Gee.EqualDataFunc<string>?)str_equal);
#      |                              ^~~~~~~~~~~~~~~~~~~~~
#      |                              |
#      |                              const gchar ** {aka const char **}
rygel-v1-hacks.c:146:27: note: expected ‘gchar **’ {aka ‘char **’} but argument is of type ‘const gchar **’ {aka ‘const char **’}
#   73|   
#   74|           if (V1Hacks.agent_matcher == null) {
#   75|->             var defaults = new Gee.ArrayList<string>.wrap (AGENTS, (Gee.EqualDataFunc<string>?)str_equal);
#   76|               var config = MetaConfig.get_default ();
#   77|               var agents = config.get_string_list_with_default ("general", "force-downgrade-for", defaults);

Error: COMPILER_WARNING (CWE-843): [#def6]
rygel-45.1/src/librygel-core/rygel-v1-hacks.vala:75:30: warning[-Wincompatible-pointer-types]: passing argument 1 of ‘_vala_array_dup2’ from incompatible pointer type
#   73|   
#   74|           if (V1Hacks.agent_matcher == null) {
#   75|->             var defaults = new Gee.ArrayList<string>.wrap (AGENTS, (Gee.EqualDataFunc<string>?)str_equal);
#   76|               var config = MetaConfig.get_default ();
#   77|               var agents = config.get_string_list_with_default ("general", "force-downgrade-for", defaults);

Error: COMPILER_WARNING (CWE-681): [#def7]
rygel-45.1/src/librygel-ruih/rygel-ruih-icon-elem.vala: scope_hint: In function ‘icon_elem_construct’
rygel-45.1/src/librygel-ruih/rygel-ruih-icon-elem.vala:48:11: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#   48 |             string node_name = child_node->name;
#      |           ^
#   46|                   continue;
#   47|               }
#   48|->             string node_name = child_node->name;
#   49|               switch (node_name) {
#   50|               case MIMETYPE:

Error: COMPILER_WARNING (CWE-681): [#def8]
rygel-45.1/src/librygel-ruih/rygel-ruih-protocol-elem.vala: scope_hint: In function ‘protocol_elem_construct’
rygel-45.1/src/librygel-ruih/rygel-ruih-protocol-elem.vala:36:12: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#   36 |             var attr_name = prop->name;
#      |            ^
#   34|   
#   35|           for (var prop = node->properties; prop != null; prop = prop->next) {
#   36|->             var attr_name = prop->name;
#   37|               switch (attr_name) {
#   38|               case SHORT_NAME:

Error: COMPILER_WARNING (CWE-681): [#def9]
rygel-45.1/src/librygel-ruih/rygel-ruih-protocol-elem.vala:39:16: warning[-Wpointer-sign]: pointer targets in assignment from ‘xmlChar *’ {aka ‘unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#   39 |                 this.short_name = prop->children->content;
#      |                ^
#   37|               switch (attr_name) {
#   38|               case SHORT_NAME:
#   39|->                 this.short_name = prop->children->content;
#   40|                   break;
#   41|               default:

Error: COMPILER_WARNING (CWE-681): [#def10]
rygel-45.1/src/librygel-ruih/rygel-ruih-protocol-elem.vala:54:12: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#   54 |             var node_name = child_node->name;
#      |            ^
#   52|               }
#   53|   
#   54|->             var node_name = child_node->name;
#   55|               switch (node_name) {
#   56|               case URI:

Error: COMPILER_WARNING (CWE-681): [#def11]
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala: scope_hint: In function ‘rygel_ruih_service_manager_set_ui_list’
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala:134:11: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#  134 |         if (ui_list_node != null && ui_list_node->name == UILIST) {
#      |           ^
#  132|   
#  133|           var ui_list_node = doc->get_root_element ();
#  134|->         if (ui_list_node != null && ui_list_node->name == UILIST) {
#  135|               foreach (var node in new XMLUtils.ChildIterator (ui_list_node)) {
#  136|                   if (node->name == UI) {

Error: COMPILER_WARNING (CWE-681): [#def12]
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala:136:13: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#  136 |                 if (node->name == UI) {
#      |             ^
#  134|           if (ui_list_node != null && ui_list_node->name == UILIST) {
#  135|               foreach (var node in new XMLUtils.ChildIterator (ui_list_node)) {
#  136|->                 if (node->name == UI) {
#  137|                       this.ui_list.add (new UIElem (node));
#  138|                   }

Error: COMPILER_WARNING (CWE-681): [#def13]
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala: scope_hint: In function ‘rygel_ruih_service_manager_convert_device_profile_to_filter’
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala:202:10: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#  202 |         if (node == null || node->name != DEVICEPROFILE) {
#      |          ^
#  200|                                           (Xml.Node *node,
#  201|                                            Gee.List<FilterEntry> filter_entries) {
#  202|->         if (node == null || node->name != DEVICEPROFILE) {
#  203|               return;
#  204|           }

Error: COMPILER_WARNING (CWE-681): [#def14]
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala:212:12: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#  212 |             if (child_node->name == PROTOCOL) {
#      |            ^
#  210|               }
#  211|   
#  212|->             if (child_node->name == PROTOCOL) {
#  213|                   // Get shortName attribute
#  214|                   for (var prop = child_node->properties;

Error: COMPILER_WARNING (CWE-681): [#def15]
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala:217:16: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#  217 |                     if (prop->name == SHORT_NAME &&
#      |                ^
#  215|                        prop != null;
#  216|                        prop = prop->next) {
#  217|->                     if (prop->name == SHORT_NAME &&
#  218|                           prop->children->content != null) {
#  219|                           var entry = new FilterEntry (SHORT_NAME,

Error: COMPILER_WARNING (CWE-681): [#def16]
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala:218:17: warning[-Wpointer-sign]: pointer targets in assignment from ‘xmlChar *’ {aka ‘unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#  218 |                         prop->children->content != null) {
#      |                 ^
#  216|                        prop = prop->next) {
#  217|                       if (prop->name == SHORT_NAME &&
#  218|->                         prop->children->content != null) {
#  219|                           var entry = new FilterEntry (SHORT_NAME,
#  220|                                                        prop->children->content);

Error: COMPILER_WARNING (CWE-681): [#def17]
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala:219:17: warning[-Wpointer-sign]: pointer targets in assignment from ‘xmlChar *’ {aka ‘unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#  219 |                         var entry = new FilterEntry (SHORT_NAME,
#      |                 ^
#  217|                       if (prop->name == SHORT_NAME &&
#  218|                           prop->children->content != null) {
#  219|->                         var entry = new FilterEntry (SHORT_NAME,
#  220|                                                        prop->children->content);
#  221|                           filter_entries.add (entry);

Error: COMPILER_WARNING (CWE-681): [#def18]
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala:226:12: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#  226 |             if (child_node->name == PROTOCOL_INFO &&
#      |            ^
#  224|               }
#  225|   
#  226|->             if (child_node->name == PROTOCOL_INFO &&
#  227|                   child_node->content != null) {
#  228|                   var entry = new FilterEntry (PROTOCOL_INFO,

Error: COMPILER_WARNING (CWE-681): [#def19]
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala:227:13: warning[-Wpointer-sign]: pointer targets in assignment from ‘xmlChar *’ {aka ‘unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#  227 |                 child_node->content != null) {
#      |             ^
#  225|   
#  226|               if (child_node->name == PROTOCOL_INFO &&
#  227|->                 child_node->content != null) {
#  228|                   var entry = new FilterEntry (PROTOCOL_INFO,
#  229|                                                child_node->content);

Error: COMPILER_WARNING (CWE-681): [#def20]
rygel-45.1/src/librygel-ruih/rygel-ruih-servicemanager.vala:228:13: warning[-Wpointer-sign]: pointer targets in assignment from ‘xmlChar *’ {aka ‘unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#  228 |                 var entry = new FilterEntry (PROTOCOL_INFO,
#      |             ^
#  226|               if (child_node->name == PROTOCOL_INFO &&
#  227|                   child_node->content != null) {
#  228|->                 var entry = new FilterEntry (PROTOCOL_INFO,
#  229|                                                child_node->content);
#  230|                   filter_entries.add (entry);

Error: COMPILER_WARNING (CWE-681): [#def21]
rygel-45.1/src/librygel-ruih/rygel-ruih-ui-elem.vala: scope_hint: In function ‘ui_elem_construct’
rygel-45.1/src/librygel-ruih/rygel-ruih-ui-elem.vala:49:12: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#   49 |             var node_name = child_node->name;
#      |            ^
#   47|               }
#   48|   
#   49|->             var node_name = child_node->name;
#   50|               switch (node_name) {
#   51|               case UIID:

Error: COMPILER_WARNING (CWE-681): [#def22]
rygel-45.1/src/librygel-ruih/rygel-ruih-ui-elem.vala:63:17: warning[-Wpointer-sign]: pointer targets in assignment from ‘const xmlChar *’ {aka ‘const unsigned char *’} to ‘const gchar *’ {aka ‘const char *’} differ in signedness
#   63 |                     if (icon_node->name == ICON) {
#      |                 ^
#   61|                   var it = new Rygel.XMLUtils.ChildIterator (child_node);
#   62|                   foreach (var icon_node in it) {
#   63|->                     if (icon_node->name == ICON) {
#   64|                           this.icons.add (new IconElem (icon_node));
#   65|                       }

Scan Properties

analyzer-version-clippy1.97.1
analyzer-version-cppcheck2.21.1
analyzer-version-gcc16.1.1
analyzer-version-gcc-analyzer16.1.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.97.1
diffbase-analyzer-version-cppcheck2.21.1
diffbase-analyzer-version-gcc16.1.1
diffbase-analyzer-version-gcc-analyzer16.1.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-155.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namerygel-46~alpha-3.fc45
diffbase-store-results-to/tmp/tmpi52bmnz_/rygel-46~alpha-3.fc45.tar.xz
diffbase-time-created2026-08-03 20:47:45
diffbase-time-finished2026-08-03 20:53:19
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,clippy,unicontrol,shellcheck,cppcheck' '-o' '/tmp/tmpi52bmnz_/rygel-46~alpha-3.fc45.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpi52bmnz_/rygel-46~alpha-3.fc45.src.rpm'
diffbase-tool-versioncsmock-3.8.7.20260803.142340.gb75b18e-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-155.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namerygel-45.1-1.fc44
store-results-to/tmp/tmpj9p3ml4p/rygel-45.1-1.fc44.tar.xz
time-created2026-08-03 20:40:54
time-finished2026-08-03 20:47:35
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,clippy,unicontrol,shellcheck,cppcheck' '-o' '/tmp/tmpj9p3ml4p/rygel-45.1-1.fc44.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpj9p3ml4p/rygel-45.1-1.fc44.src.rpm'
tool-versioncsmock-3.8.7.20260803.142340.gb75b18e-1.el9