Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-704): [#def1]
pciutils-3.14.0/lib/ecam.c: scope_hint: In function ‘parse_next_addrs’
pciutils-3.14.0/lib/ecam.c:620:10: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  620 |   endptr = strchr(addrs, ',');
#      |          ^
#  618|       }
#  619|   
#  620|->   endptr = strchr(addrs, ',');
#  621|     if (endptr)
#  622|       addr_len = endptr - addrs;

Error: COMPILER_WARNING (CWE-704): [#def2]
pciutils-3.14.0/lib/ecam.c:620:10: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  618|       }
#  619|   
#  620|->   endptr = strchr(addrs, ',');
#  621|     if (endptr)
#  622|       addr_len = endptr - addrs;

Error: CPPCHECK_WARNING (CWE-476): [#def3]
pciutils-3.14.0/lib/sysfs.c:172: warning[nullPointerOutOfResources]: If resource allocation fails, then there is a possible null pointer dereference: file
#  170|       {
#  171|         unsigned long long start, end, size, flags;
#  172|->       if (!fgets(buf, sizeof(buf), file))
#  173|   	break;
#  174|         if (sscanf(buf, "%llx %llx %llx", &start, &end, &flags) != 3)

Error: GCC_ANALYZER_WARNING (CWE-775): [#def4]
pciutils-3.14.0/lib/sysfs.c:174:10: warning[-Wanalyzer-file-leak]: leak of FILE ‘fopen(&namebuf, "r")’
pciutils-3.14.0/lib/sysfs.c:337:1: enter_function: entry to ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:341:6: branch_true: following ‘true’ branch...
pciutils-3.14.0/lib/sysfs.c:348:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:383:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:385:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:386:11: call_function: calling ‘sysfs_get_resources’ from ‘sysfs_fill_info’
#  172|         if (!fgets(buf, sizeof(buf), file))
#  173|   	break;
#  174|->       if (sscanf(buf, "%llx %llx %llx", &start, &end, &flags) != 3)
#  175|   	a->error("Syntax error in %s", namebuf);
#  176|         if (end > start)

Error: GCC_ANALYZER_WARNING (CWE-401): [#def5]
pciutils-3.14.0/lib/sysfs.c:174:10: warning[-Wanalyzer-malloc-leak]: leak of ‘fopen(&namebuf, "r")’
pciutils-3.14.0/lib/sysfs.c:337:1: enter_function: entry to ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:341:6: branch_true: following ‘true’ branch...
pciutils-3.14.0/lib/sysfs.c:348:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:383:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:385:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:386:11: call_function: calling ‘sysfs_get_resources’ from ‘sysfs_fill_info’
#  172|         if (!fgets(buf, sizeof(buf), file))
#  173|   	break;
#  174|->       if (sscanf(buf, "%llx %llx %llx", &start, &end, &flags) != 3)
#  175|   	a->error("Syntax error in %s", namebuf);
#  176|         if (end > start)

Error: GCC_ANALYZER_WARNING (CWE-775): [#def6]
pciutils-3.14.0/lib/sysfs.c:176:11: warning[-Wanalyzer-file-leak]: leak of FILE ‘fopen(&namebuf, "r")’
pciutils-3.14.0/lib/sysfs.c:337:1: enter_function: entry to ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:341:6: branch_true: following ‘true’ branch...
pciutils-3.14.0/lib/sysfs.c:348:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:383:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:385:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:386:11: call_function: calling ‘sysfs_get_resources’ from ‘sysfs_fill_info’
#  174|         if (sscanf(buf, "%llx %llx %llx", &start, &end, &flags) != 3)
#  175|   	a->error("Syntax error in %s", namebuf);
#  176|->       if (end > start)
#  177|   	size = end - start + 1;
#  178|         else

Error: GCC_ANALYZER_WARNING (CWE-401): [#def7]
pciutils-3.14.0/lib/sysfs.c:176:11: warning[-Wanalyzer-malloc-leak]: leak of ‘fopen(&namebuf, "r")’
pciutils-3.14.0/lib/sysfs.c:337:1: enter_function: entry to ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:341:6: branch_true: following ‘true’ branch...
pciutils-3.14.0/lib/sysfs.c:348:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:383:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:385:11: call_function: inlined call to ‘want_fill’ from ‘sysfs_fill_info’
pciutils-3.14.0/lib/sysfs.c:386:11: call_function: calling ‘sysfs_get_resources’ from ‘sysfs_fill_info’
#  174|         if (sscanf(buf, "%llx %llx %llx", &start, &end, &flags) != 3)
#  175|   	a->error("Syntax error in %s", namebuf);
#  176|->       if (end > start)
#  177|   	size = end - start + 1;
#  178|         else

Error: COMPILER_WARNING (CWE-704): [#def8]
pciutils-3.14.0/setpci.c: scope_hint: In function ‘parse_options’
pciutils-3.14.0/setpci.c:513:19: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  513 |             if (e = strchr(opts, *c))
#      |                   ^
#  511|   	    break;
#  512|   	  default:
#  513|-> 	    if (e = strchr(opts, *c))
#  514|   	      {
#  515|   		char *arg;

Error: COMPILER_WARNING (CWE-704): [#def9]
pciutils-3.14.0/setpci.c:513:19: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  511|   	    break;
#  512|   	  default:
#  513|-> 	    if (e = strchr(opts, *c))
#  514|   	      {
#  515|   		char *arg;

Scan Properties