Newly introduced findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-398): [#def1]
/usr/share/netavark/test-dhcp/001-basic.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # basic netavark tests

Error: SHELLCHECK_WARNING (CWE-398): [#def2]
/usr/share/netavark/test-dhcp/002-setup.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # basic netavark tests

Error: SHELLCHECK_WARNING (CWE-156): [#def3]
/usr/share/netavark/test-dhcp/002-setup.bats:26:16: warning[SC2046]: Quote this to prevent word splitting.
#   24|           run_setup "$input_config"
#   25|           # Check that gateway provided is the first IP in the subnet
#   26|->         assert `echo "$output" | jq -r .siaddr` == $(gateway_from_subnet "$SUBNET_CIDR")
#   27|           container_ip=$(echo "$output" | jq -r .yiaddr)
#   28|           has_ip "$container_ip" veth0

Error: SHELLCHECK_WARNING (CWE-156): [#def4]
/usr/share/netavark/test-dhcp/002-setup.bats:26:52: warning[SC2046]: Quote this to prevent word splitting.
#   24|           run_setup "$input_config"
#   25|           # Check that gateway provided is the first IP in the subnet
#   26|->         assert `echo "$output" | jq -r .siaddr` == $(gateway_from_subnet "$SUBNET_CIDR")
#   27|           container_ip=$(echo "$output" | jq -r .yiaddr)
#   28|           has_ip "$container_ip" veth0

Error: SHELLCHECK_WARNING (CWE-156): [#def5]
/usr/share/netavark/test-dhcp/002-setup.bats:30:16: warning[SC2046]: Quote this to prevent word splitting.
#   28|           has_ip "$container_ip" veth0
#   29|           # Check that there was a hostname in the DHCP requests
#   30|->         assert `grep -c "client provides name: foobar" "$TMP_TESTDIR/dnsmasq.log"` == 3
#   31|   }
#   32|   

Error: SHELLCHECK_WARNING (CWE-156): [#def6]
/usr/share/netavark/test-dhcp/002-setup.bats:49:16: warning[SC2046]: Quote this to prevent word splitting.
#   47|   
#   48|           # Check that there was no hostname in the DHCP requests
#   49|->         assert `grep -c "client provides name" "$TMP_TESTDIR/dnsmasq.log"` == 0
#   50|   }
#   51|   

Error: SHELLCHECK_WARNING (CWE-398): [#def7]
/usr/share/netavark/test-dhcp/003-teardown.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # basic netavark tests

Error: SHELLCHECK_WARNING (CWE-398): [#def8]
/usr/share/netavark/test-dhcp/004-server.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # basic netavark tests

Error: SHELLCHECK_WARNING (CWE-563): [#def9]
/usr/share/netavark/test-dhcp/004-server.bats:27:17: warning[SC2034]: input_config appears unused. Verify use (or export if used externally).
#   25|   
#   26|   @test "SIGTERM Clean up" {
#   27|-> read -r -d '\0' input_config <<EOF
#   28|   {
#   29|       "iface": "veth0",

Error: SHELLCHECK_WARNING (CWE-398): [#def10]
/usr/share/netavark/test-dhcp/005-renew.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # Test that release is working after lease timeout

Error: SHELLCHECK_WARNING (CWE-156): [#def11]
/usr/share/netavark/test-dhcp/005-renew.bats:35:39: warning[SC2046]: Quote this to prevent word splitting.
#   33|       # stop dhcp and restart with new subnet to get a new ip on the next lease
#   34|       stop_dhcp
#   35|->     run_in_container_netns ip add del $(gateway_from_subnet "$SUBNET_CIDR")/24 dev br0
#   36|       run_in_container_netns ip addr
#   37|       run_in_container_netns ip route

Error: SHELLCHECK_WARNING (CWE-156): [#def12]
/usr/share/netavark/test-dhcp/005-renew.bats:41:40: warning[SC2046]: Quote this to prevent word splitting.
#   39|       # get new subnet
#   40|       SUBNET_CIDR=$(random_subnet)
#   41|->     run_in_container_netns ip addr add $(gateway_from_subnet "$SUBNET_CIDR")/24 dev br0
#   42|       stripped_subnet=$(strip_last_octet_from_subnet "$SUBNET_CIDR")
#   43|       run_dhcp

Error: SHELLCHECK_WARNING (CWE-563): [#def13]
/usr/share/netavark/test-dhcp/helpers.bash:4:1: warning[SC2034]: DNSMASQ_PIDFILE appears unused. Verify use (or export if used externally).
#    2|   
#    3|   CONTAINER_MAC=
#    4|-> DNSMASQ_PIDFILE=
#    5|   NS_NAME=
#    6|   NS_PATH=

Error: SHELLCHECK_WARNING (CWE-670): [#def14]
/usr/share/netavark/test-dhcp/helpers.bash:15:32: warning[SC2128]: Expanding an array without an index only gives the first element.
#   13|   NETAVARK=${NETAVARK:-./bin/netavark}
#   14|   NETAVARK_DHCP_PROXY_CLIENT=${NETAVARK_DHCP_PROXY_CLIENT:-./bin/netavark-dhcp-proxy-client}
#   15|-> TESTSDIR=${TESTSDIR:-$(dirname ${BASH_SOURCE})}
#   16|   
#   17|   # export RUST_BACKTRACE so that we get a helpful stack trace

Error: SHELLCHECK_WARNING (CWE-563): [#def15]
/usr/share/netavark/test-dhcp/helpers.bash:48:5: warning[SC2034]: MOST_RECENT_COMMAND appears unused. Verify use (or export if used externally).
#   46|       fi
#   47|       # Remember command args, for possible use in later diagnostic messages
#   48|->     MOST_RECENT_COMMAND="$*"
#   49|   
#   50|       # stdout is only emitted upon error; this echo is to help a debugger

Error: SHELLCHECK_WARNING (CWE-457): [#def16]
/usr/share/netavark/test-dhcp/helpers.bash:58:11: warning[SC2154]: status is referenced but not assigned.
#   56|           echo "$output"
#   57|       fi
#   58|->     if [ "$status" -ne 0 ]; then
#   59|           echo -n "[ rc=$status "
#   60|           if [ -n "$expected_rc" ]; then

Error: SHELLCHECK_WARNING (CWE-563): [#def17]
/usr/share/netavark/test-dhcp/helpers.bash:274:3: warning[SC2034]: CONTAINER_MAC appears unused. Verify use (or export if used externally).
#  272|     add_veth "veth0" "br0"
#  273|     run_in_container_netns ip -j link show veth0
#  274|->   CONTAINER_MAC=$(echo "$output" | jq -r .[0].address)
#  275|     add_veth "veth1" "br0"
#  276|     run_in_container_netns ip link set lo up

Error: SHELLCHECK_WARNING (CWE-571): [#def18]
/usr/share/netavark/test-dhcp/helpers.bash:286:9: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  284|   function add_bridge() {
#  285|     local bridge_name="$1"
#  286|->   local br_gw=$(gateway_from_subnet "$SUBNET_CIDR")
#  287|     run_in_container_netns ip link add $bridge_name type bridge
#  288|     run_in_container_netns ip addr add $br_gw/24 dev $bridge_name

Error: SHELLCHECK_WARNING (CWE-685): [#def19]
/usr/share/netavark/test-dhcp/helpers.bash:417:1: warning[SC2120]: random_subnet references arguments, but none are ever passed.
#  415|   # by default it will return a 10.x.x.0/24 ipv4 subnet
#  416|   # if "6" is given as first argument it will return a "fdx:x:x:x::/64" ipv6 subnet
#  417|-> function random_subnet() {
#  418|       if [[ "$1" == "6" ]]; then
#  419|           printf "fd%x:%x:%x:%x::/64" $((RANDOM % 256)) $((RANDOM % 65535)) $((RANDOM % 65535)) $((RANDOM % 65535))

Error: SHELLCHECK_WARNING (CWE-758): [#def20]
/usr/share/netavark/test-dhcp/setup.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
#    1|-> ip netns add new
#    2|   ip link add dev outside type veth peer name outsidebr
#    3|   ip link add dev inside type veth peer name insidebr

Error: SHELLCHECK_WARNING (CWE-398): [#def21]
/usr/share/netavark/test/001-basic.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # basic netavark tests

Error: SHELLCHECK_WARNING (CWE-156): [#def22]
/usr/share/netavark/test/001-basic.bats:28:49: warning[SC2046]: Quote this to prevent word splitting.
#   26|   
#   27|   @test "netavark error - invalid config path" {
#   28|->     expected_rc=1 run_netavark -f /test/1 setup $(get_container_netns_path)
#   29|       assert_json ".error" "failed to load network options: IO error: No such file or directory (os error 2)" "Config file does not exists"
#   30|   }

Error: SHELLCHECK_WARNING (CWE-398): [#def23]
/usr/share/netavark/test/200-bridge-firewalld.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # bridge firewalld nftables driver tests

Error: SHELLCHECK_WARNING (CWE-156): [#def24]
/usr/share/netavark/test/200-bridge-firewalld.bats:17:94: warning[SC2046]: Quote this to prevent word splitting.
#   15|   
#   16|   @test "check firewalld driver is in use" {
#   17|->     RUST_LOG=netavark=info run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#   18|       assert "${lines[0]}" "==" "[INFO  netavark::firewall] Using firewalld firewall driver" "firewalld driver is in use"
#   19|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def25]
/usr/share/netavark/test/200-bridge-firewalld.bats:22:71: warning[SC2046]: Quote this to prevent word splitting.
#   20|   
#   21|   @test "$fw_driver - simple bridge" {
#   22|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#   23|       result="$output"
#   24|       assert_json "$result" 'has("podman")' == "true" "object key exists"

Error: SHELLCHECK_WARNING (CWE-156): [#def26]
/usr/share/netavark/test/200-bridge-firewalld.bats:62:78: warning[SC2046]: Quote this to prevent word splitting.
#   60|       run_in_container_netns ip link set dummy0 up
#   61|   
#   62|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-staticroutes.json setup $(get_container_netns_path)
#   63|   
#   64|       # check static routes

Error: SHELLCHECK_WARNING (CWE-156): [#def27]
/usr/share/netavark/test/200-bridge-firewalld.bats:70:81: warning[SC2046]: Quote this to prevent word splitting.
#   68|       assert "$output" "=~" "10.92.0.0/24 via 10.91.0.1" "static route not set"
#   69|   
#   70|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-staticroutes.json teardown $(get_container_netns_path)
#   71|   
#   72|       # check static routes get removed

Error: SHELLCHECK_WARNING (CWE-156): [#def28]
/usr/share/netavark/test/200-bridge-firewalld.bats:79:81: warning[SC2046]: Quote this to prevent word splitting.
#   77|   
#   78|   @test "$fw_driver - bridge with blackhole routes" {
#   79|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-blackholeroutes.json setup $(get_container_netns_path)
#   80|   
#   81|       # check blackhole routes

Error: SHELLCHECK_WARNING (CWE-156): [#def29]
/usr/share/netavark/test/200-bridge-firewalld.bats:88:84: warning[SC2046]: Quote this to prevent word splitting.
#   86|       assert "$output" "=~" "10.91.0.0/24 via 10.88.0.3" "static route not set"
#   87|   
#   88|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-blackholeroutes.json teardown $(get_container_netns_path)
#   89|   
#   90|       # check routes get removed

Error: SHELLCHECK_WARNING (CWE-156): [#def30]
/usr/share/netavark/test/200-bridge-firewalld.bats:98:80: warning[SC2046]: Quote this to prevent word splitting.
#   96|   
#   97|   @test "$fw_driver - bridge with no default route" {
#   98|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-nodefaultroute.json setup $(get_container_netns_path)
#   99|   
#  100|       run_in_container_netns ip r

Error: SHELLCHECK_WARNING (CWE-156): [#def31]
/usr/share/netavark/test/200-bridge-firewalld.bats:106:83: warning[SC2046]: Quote this to prevent word splitting.
#  104|       assert "$output" "!~" "default" "default route exists"
#  105|   
#  106|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-nodefaultroute.json teardown $(get_container_netns_path)
#  107|       assert "" "no errors"
#  108|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def32]
/usr/share/netavark/test/200-bridge-firewalld.bats:118:70: warning[SC2046]: Quote this to prevent word splitting.
#  116|       # run_in_host_netns sh -c "echo 0 > /proc/sys/net/ipv6/conf/default/accept_ra"
#  117|   
#  118|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge.json setup $(get_container_netns_path)
#  119|       result="$output"
#  120|       assert_json "$result" 'has("podman1")' == "true" "object key exists"

Error: SHELLCHECK_WARNING (CWE-156): [#def33]
/usr/share/netavark/test/200-bridge-firewalld.bats:158:83: warning[SC2046]: Quote this to prevent word splitting.
#  156|       run_in_container_netns ip link set dummy0 up
#  157|   
#  158|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge-staticroutes.json setup $(get_container_netns_path)
#  159|   
#  160|       # check static routes

Error: SHELLCHECK_WARNING (CWE-156): [#def34]
/usr/share/netavark/test/200-bridge-firewalld.bats:166:86: warning[SC2046]: Quote this to prevent word splitting.
#  164|       assert "$output" "=~" "fd10:51:b::/64 via fd10:49:b::30" "static route not set"
#  165|   
#  166|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge-staticroutes.json teardown $(get_container_netns_path)
#  167|   
#  168|       # check static routes get removed

Error: SHELLCHECK_WARNING (CWE-156): [#def35]
/usr/share/netavark/test/200-bridge-firewalld.bats:178:86: warning[SC2046]: Quote this to prevent word splitting.
#  176|   
#  177|   @test "$fw_driver - ipv6 bridge with blackhole routes" {
#  178|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge-blackholeroutes.json setup $(get_container_netns_path)
#  179|   
#  180|       # check blackhole routes

Error: SHELLCHECK_WARNING (CWE-156): [#def36]
/usr/share/netavark/test/200-bridge-firewalld.bats:187:89: warning[SC2046]: Quote this to prevent word splitting.
#  185|       assert "$output" "=~" "fd10:51:b::/64 via fd10:88:a::ac02" "static route not set"
#  186|   
#  187|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge-blackholeroutes.json teardown $(get_container_netns_path)
#  188|   
#  189|       # check routes get removed

Error: SHELLCHECK_WARNING (CWE-156): [#def37]
/usr/share/netavark/test/200-bridge-firewalld.bats:202:15: warning[SC2046]: Quote this to prevent word splitting.
#  200|       NETAVARK_DNS_PORT="$dns_port" \
#  201|           run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge.json \
#  202|->         setup $(get_container_netns_path)
#  203|   
#  204|       # check iptables

Error: SHELLCHECK_WARNING (CWE-457): [#def38]
/usr/share/netavark/test/200-bridge-firewalld.bats:218:13: warning[SC2154]: ardvark_pid is referenced but not assigned (did you mean 'aardvark_pid'?).
#  216|   
#  217|       aardvark_pid=$(cat "$NETAVARK_TMPDIR/config/aardvark-dns/aardvark.pid")
#  218|->     assert "$ardvark_pid" =~ "[0-9]*" "aardvark pid not found"
#  219|       run_helper ps "$aardvark_pid"
#  220|       assert "${lines[1]}" =~ ".*aardvark-dns --config $NETAVARK_TMPDIR/config/aardvark-dns -p $dns_port run" "aardvark not running or bad options"

Error: SHELLCHECK_WARNING (CWE-156): [#def39]
/usr/share/netavark/test/200-bridge-firewalld.bats:232:18: warning[SC2046]: Quote this to prevent word splitting.
#  230|       NETAVARK_DNS_PORT="$dns_port" \
#  231|           run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge.json \
#  232|->         teardown $(get_container_netns_path)
#  233|   
#  234|       # check iptables got removed

Error: SHELLCHECK_WARNING (CWE-156): [#def40]
/usr/share/netavark/test/200-bridge-firewalld.bats:247:85: warning[SC2046]: Quote this to prevent word splitting.
#  245|       run_in_container_netns ip link add eth0 type dummy
#  246|   
#  247|->     expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#  248|       assert_json ".error" "create veth pair: interface eth0 already exists on container namespace: Netlink error: File exists (os error 17)" "interface exists on netns"
#  249|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def41]
/usr/share/netavark/test/200-bridge-firewalld.bats:420:81: warning[SC2046]: Quote this to prevent word splitting.
#  418|   
#  419|   @test "netavark error - invalid host_ip in port mappings" {
#  420|->     expected_rc=1 run_netavark -f ${TESTSDIR}/testfiles/invalid-port.json setup $(get_container_netns_path)
#  421|       assert_json ".error" "invalid host ip \"abcd\" provided for port 8080" "host ip error"
#  422|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def42]
/usr/share/netavark/test/200-bridge-firewalld.bats:436:121: warning[SC2046]: Quote this to prevent word splitting.
#  434|       assert "$output" == "success"
#  435|   
#  436|->     expected_rc=1 run_netavark --firewall-driver $fw_driver --file ${TESTSDIR}/testfiles/bridge-port-tcp-udp.json setup $(get_container_netns_path)
#  437|       assert_json ".error" "Port forwarding not possible as firewalld StrictForwardPorts enabled"
#  438|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def43]
/usr/share/netavark/test/200-bridge-firewalld.bats:452:107: warning[SC2046]: Quote this to prevent word splitting.
#  450|       assert "$output" == "success"
#  451|   
#  452|->     run_netavark --firewall-driver $fw_driver --file ${TESTSDIR}/testfiles/bridge-port-tcp-udp.json setup $(get_container_netns_path)
#  453|       run_netavark --firewall-driver $fw_driver --file ${TESTSDIR}/testfiles/bridge-port-tcp-udp.json teardown $(get_container_netns_path)
#  454|   

Error: SHELLCHECK_WARNING (CWE-156): [#def44]
/usr/share/netavark/test/200-bridge-firewalld.bats:453:110: warning[SC2046]: Quote this to prevent word splitting.
#  451|   
#  452|       run_netavark --firewall-driver $fw_driver --file ${TESTSDIR}/testfiles/bridge-port-tcp-udp.json setup $(get_container_netns_path)
#  453|->     run_netavark --firewall-driver $fw_driver --file ${TESTSDIR}/testfiles/bridge-port-tcp-udp.json teardown $(get_container_netns_path)
#  454|   
#  455|       test_port_fw hostip="127.0.0.1" proto=tcp

Error: SHELLCHECK_WARNING (CWE-156): [#def45]
/usr/share/netavark/test/200-bridge-firewalld.bats:471:130: warning[SC2046]: Quote this to prevent word splitting.
#  469|       assert "$output" == "success"
#  470|   
#  471|->     RUST_LOG=netavark=warn run_netavark --firewall-driver $fw_driver --file ${TESTSDIR}/testfiles/bridge-port-tcp-udp.json setup $(get_container_netns_path)
#  472|       assert "$output" =~ "unexpected value from StrictForwardPorts property: invalid-value"
#  473|   

Error: SHELLCHECK_WARNING (CWE-156): [#def46]
/usr/share/netavark/test/200-bridge-firewalld.bats:474:110: warning[SC2046]: Quote this to prevent word splitting.
#  472|       assert "$output" =~ "unexpected value from StrictForwardPorts property: invalid-value"
#  473|   
#  474|->     run_netavark --firewall-driver $fw_driver --file ${TESTSDIR}/testfiles/bridge-port-tcp-udp.json teardown $(get_container_netns_path)
#  475|   
#  476|       test_port_fw hostip="127.0.0.1" proto=tcp

Error: SHELLCHECK_WARNING (CWE-398): [#def47]
/usr/share/netavark/test/250-bridge-nftables.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # bridge driver tests with nftables firewall driver

Error: SHELLCHECK_WARNING (CWE-563): [#def48]
/usr/share/netavark/test/250-bridge-nftables.bats:8:1: warning[SC2034]: fw_driver appears unused. Verify use (or export if used externally).
#    6|   load helpers
#    7|   
#    8|-> fw_driver=nftables
#    9|   export NETAVARK_FW=nftables
#   10|   

Error: SHELLCHECK_WARNING (CWE-156): [#def49]
/usr/share/netavark/test/250-bridge-nftables.bats:12:94: warning[SC2046]: Quote this to prevent word splitting.
#   10|   
#   11|   @test "check nftables driver is in use" {
#   12|->     RUST_LOG=netavark=info run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#   13|       assert "${lines[0]}" "==" "[INFO  netavark::firewall] Using nftables firewall driver" "nftables driver is in use"
#   14|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def50]
/usr/share/netavark/test/250-bridge-nftables.bats:22:66: warning[SC2046]: Quote this to prevent word splitting.
#   20|      before="$output"
#   21|   
#   22|->    run_netavark --file ${TESTSDIR}/testfiles/internal.json setup $(get_container_netns_path)
#   23|   
#   24|      run_in_host_netns nft list table inet netavark

Error: SHELLCHECK_WARNING (CWE-156): [#def51]
/usr/share/netavark/test/250-bridge-nftables.bats:32:69: warning[SC2046]: Quote this to prevent word splitting.
#   30|      run_in_container_netns ping -c 1 10.88.0.1
#   31|   
#   32|->    run_netavark --file ${TESTSDIR}/testfiles/internal.json teardown $(get_container_netns_path)
#   33|   }
#   34|   

Error: SHELLCHECK_WARNING (CWE-156): [#def52]
/usr/share/netavark/test/250-bridge-nftables.bats:36:71: warning[SC2046]: Quote this to prevent word splitting.
#   34|   
#   35|   @test "$fw_driver - simple bridge" {
#   36|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#   37|       result="$output"
#   38|       assert_json "$result" 'has("podman")' == "true" "object key exists"

Error: SHELLCHECK_WARNING (CWE-156): [#def53]
/usr/share/netavark/test/250-bridge-nftables.bats:76:74: warning[SC2046]: Quote this to prevent word splitting.
#   74|       check_simple_bridge_nftables
#   75|   
#   76|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json teardown $(get_container_netns_path)
#   77|   
#   78|       # now check that nftables rules are gone

Error: SHELLCHECK_WARNING (CWE-156): [#def54]
/usr/share/netavark/test/250-bridge-nftables.bats:103:78: warning[SC2046]: Quote this to prevent word splitting.
#  101|       run_in_container_netns ip link set dummy0 up
#  102|   
#  103|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-staticroutes.json setup $(get_container_netns_path)
#  104|   
#  105|       # check static routes

Error: SHELLCHECK_WARNING (CWE-156): [#def55]
/usr/share/netavark/test/250-bridge-nftables.bats:111:81: warning[SC2046]: Quote this to prevent word splitting.
#  109|       assert "$output" "=~" "10.92.0.0/24 via 10.91.0.1" "static route not set"
#  110|   
#  111|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-staticroutes.json teardown $(get_container_netns_path)
#  112|   
#  113|       # check static routes get removed

Error: SHELLCHECK_WARNING (CWE-156): [#def56]
/usr/share/netavark/test/250-bridge-nftables.bats:120:81: warning[SC2046]: Quote this to prevent word splitting.
#  118|   
#  119|   @test "$fw_driver - bridge with blackhole routes" {
#  120|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-blackholeroutes.json setup $(get_container_netns_path)
#  121|   
#  122|       # check blackhole routes

Error: SHELLCHECK_WARNING (CWE-156): [#def57]
/usr/share/netavark/test/250-bridge-nftables.bats:129:84: warning[SC2046]: Quote this to prevent word splitting.
#  127|       assert "$output" "=~" "10.91.0.0/24 via 10.88.0.3" "static route not set"
#  128|   
#  129|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-blackholeroutes.json teardown $(get_container_netns_path)
#  130|   
#  131|       # check routes get removed

Error: SHELLCHECK_WARNING (CWE-156): [#def58]
/usr/share/netavark/test/250-bridge-nftables.bats:139:80: warning[SC2046]: Quote this to prevent word splitting.
#  137|   
#  138|   @test "$fw_driver - bridge with no default route" {
#  139|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-nodefaultroute.json setup $(get_container_netns_path)
#  140|   
#  141|       run_in_container_netns ip r

Error: SHELLCHECK_WARNING (CWE-156): [#def59]
/usr/share/netavark/test/250-bridge-nftables.bats:147:83: warning[SC2046]: Quote this to prevent word splitting.
#  145|       assert "$output" "!~" "default" "default route exists"
#  146|   
#  147|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-nodefaultroute.json teardown $(get_container_netns_path)
#  148|       assert "" "no errors"
#  149|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def60]
/usr/share/netavark/test/250-bridge-nftables.bats:156:15: warning[SC2046]: Quote this to prevent word splitting.
#  154|   
#  155|       NETAVARK_DNS_PORT="$dns_port" run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge-network-container-dns-server.json \
#  156|->         setup $(get_container_netns_path)
#  157|   
#  158|       # check aardvark config and running

Error: SHELLCHECK_WARNING (CWE-457): [#def61]
/usr/share/netavark/test/250-bridge-nftables.bats:165:13: warning[SC2154]: ardvark_pid is referenced but not assigned (did you mean 'aardvark_pid'?).
#  163|   
#  164|       aardvark_pid=$(cat "$NETAVARK_TMPDIR/config/aardvark-dns/aardvark.pid")
#  165|->     assert "$ardvark_pid" =~ "[0-9]*" "aardvark pid not found"
#  166|       run_helper ps "$aardvark_pid"
#  167|       assert "${lines[1]}" =~ ".*aardvark-dns --config $NETAVARK_TMPDIR/config/aardvark-dns -p $dns_port run" "aardvark not running or bad options"

Error: SHELLCHECK_WARNING (CWE-457): [#def62]
/usr/share/netavark/test/250-bridge-nftables.bats:171:103: warning[SC2154]: rootless is referenced but not assigned.
#  169|       # Use run_helper instead of run_netavark here to check network namespace detection logic.
#  170|       # See https://github.com/containers/netavark/issues/911 for details.
#  171|->     NETAVARK_DNS_PORT="$dns_port" run_helper $NETAVARK --config "$NETAVARK_TMPDIR/config" --rootless "$rootless" --file ${TESTSDIR}/testfiles/dualstack-bridge-network-container-dns-server.json \
#  172|           update podman1 --network-dns-servers 8.8.8.8
#  173|       assert "$output" = ""

Error: SHELLCHECK_WARNING (CWE-156): [#def63]
/usr/share/netavark/test/250-bridge-nftables.bats:207:70: warning[SC2046]: Quote this to prevent word splitting.
#  205|   
#  206|   @test "$fw_driver - ipv6 bridge" {
#  207|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge.json setup $(get_container_netns_path)
#  208|       result="$output"
#  209|       assert_json "$result" 'has("podman1")' == "true" "object key exists"

Error: SHELLCHECK_WARNING (CWE-156): [#def64]
/usr/share/netavark/test/250-bridge-nftables.bats:240:73: warning[SC2046]: Quote this to prevent word splitting.
#  238|       run_in_host_netns ping6 -c 1 fd10:88:a::2
#  239|   
#  240|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge.json teardown $(get_container_netns_path)
#  241|   }
#  242|   

Error: SHELLCHECK_WARNING (CWE-156): [#def65]
/usr/share/netavark/test/250-bridge-nftables.bats:249:83: warning[SC2046]: Quote this to prevent word splitting.
#  247|       run_in_container_netns ip link set dummy0 up
#  248|   
#  249|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge-staticroutes.json setup $(get_container_netns_path)
#  250|   
#  251|       # check static routes

Error: SHELLCHECK_WARNING (CWE-156): [#def66]
/usr/share/netavark/test/250-bridge-nftables.bats:257:86: warning[SC2046]: Quote this to prevent word splitting.
#  255|       assert "$output" "=~" "fd10:51:b::/64 via fd10:49:b::30" "static route not set"
#  256|   
#  257|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge-staticroutes.json teardown $(get_container_netns_path)
#  258|   
#  259|       # check static routes get removed

Error: SHELLCHECK_WARNING (CWE-156): [#def67]
/usr/share/netavark/test/250-bridge-nftables.bats:269:86: warning[SC2046]: Quote this to prevent word splitting.
#  267|   
#  268|   @test "$fw_driver - ipv6 bridge with blackhole routes" {
#  269|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge-blackholeroutes.json setup $(get_container_netns_path)
#  270|   
#  271|       # check blackhole routes

Error: SHELLCHECK_WARNING (CWE-156): [#def68]
/usr/share/netavark/test/250-bridge-nftables.bats:278:89: warning[SC2046]: Quote this to prevent word splitting.
#  276|       assert "$output" "=~" "fd10:51:b::/64 via fd10:88:a::ac02" "static route not set"
#  277|   
#  278|->     run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge-blackholeroutes.json teardown $(get_container_netns_path)
#  279|   
#  280|       # check routes get removed

Error: SHELLCHECK_WARNING (CWE-156): [#def69]
/usr/share/netavark/test/250-bridge-nftables.bats:289:15: warning[SC2046]: Quote this to prevent word splitting.
#  287|   @test "$fw_driver - bridge driver must generate config for aardvark with custom dns server" {
#  288|       run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge-custom-dns-server.json \
#  289|->         setup $(get_container_netns_path)
#  290|   
#  291|       # check nftables

Error: SHELLCHECK_WARNING (CWE-156): [#def70]
/usr/share/netavark/test/250-bridge-nftables.bats:310:15: warning[SC2046]: Quote this to prevent word splitting.
#  308|       # force failure with invalid aardvark-dns binary
#  309|       expected_rc=1 run_netavark --aardvark-binary ${TESTSDIR} --file ${TESTSDIR}/testfiles/dualstack-bridge-custom-dns-server.json \
#  310|->         setup $(get_container_netns_path)
#  311|       assert "$output" =~ "aardvark-dns failed to start: Failed to find executable" "netavark error"
#  312|   

Error: SHELLCHECK_WARNING (CWE-156): [#def71]
/usr/share/netavark/test/250-bridge-nftables.bats:323:15: warning[SC2046]: Quote this to prevent word splitting.
#  321|   
#  322|       NETAVARK_DNS_PORT="$dns_port" run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge-multiple-custom-dns-server.json \
#  323|->         setup $(get_container_netns_path)
#  324|   
#  325|       # check aardvark config and running

Error: SHELLCHECK_WARNING (CWE-156): [#def72]
/usr/share/netavark/test/250-bridge-nftables.bats:342:15: warning[SC2046]: Quote this to prevent word splitting.
#  340|   
#  341|       NETAVARK_DNS_PORT="$dns_port" run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge-network-container-dns-server.json \
#  342|->         setup $(get_container_netns_path)
#  343|   
#  344|       # check aardvark config and running

Error: SHELLCHECK_WARNING (CWE-156): [#def73]
/usr/share/netavark/test/250-bridge-nftables.bats:361:15: warning[SC2046]: Quote this to prevent word splitting.
#  359|   
#  360|       NETAVARK_DNS_PORT="$dns_port" run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge.json \
#  361|->         setup $(get_container_netns_path)
#  362|   
#  363|       # check nftables

Error: SHELLCHECK_WARNING (CWE-156): [#def74]
/usr/share/netavark/test/250-bridge-nftables.bats:388:18: warning[SC2046]: Quote this to prevent word splitting.
#  386|   
#  387|       NETAVARK_DNS_PORT="$dns_port" run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge.json \
#  388|->         teardown $(get_container_netns_path)
#  389|   
#  390|       # check nftables rules were removed

Error: SHELLCHECK_WARNING (CWE-156): [#def75]
/usr/share/netavark/test/250-bridge-nftables.bats:401:15: warning[SC2046]: Quote this to prevent word splitting.
#  399|   @test "$fw_driver - dns with default drop policy" {
#  400|       run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge.json \
#  401|->         setup $(get_container_netns_path)
#  402|   
#  403|       run_in_host_netns nft add chain inet netavark INPUT \{ type filter hook input priority 0 \; policy drop \; \}

Error: SHELLCHECK_WARNING (CWE-156): [#def76]
/usr/share/netavark/test/250-bridge-nftables.bats:427:18: warning[SC2046]: Quote this to prevent word splitting.
#  425|   
#  426|       run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge.json \
#  427|->         teardown $(get_container_netns_path)
#  428|   
#  429|       # check nftables rules were removed

Error: SHELLCHECK_WARNING (CWE-156): [#def77]
/usr/share/netavark/test/250-bridge-nftables.bats:443:15: warning[SC2046]: Quote this to prevent word splitting.
#  441|   
#  442|       NETAVARK_DNS_PORT="$dns_port" run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge.json \
#  443|->         setup $(get_container_netns_path)
#  444|   
#  445|       # check that random DNS port was added to nftables rules

Error: SHELLCHECK_WARNING (CWE-156): [#def78]
/usr/share/netavark/test/250-bridge-nftables.bats:476:18: warning[SC2046]: Quote this to prevent word splitting.
#  474|   
#  475|       NETAVARK_DNS_PORT="$dns_port" run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge.json \
#  476|->         teardown $(get_container_netns_path)
#  477|   
#  478|       # check nftables rules were removed

Error: SHELLCHECK_WARNING (CWE-156): [#def79]
/usr/share/netavark/test/250-bridge-nftables.bats:491:85: warning[SC2046]: Quote this to prevent word splitting.
#  489|       run_in_container_netns ip link add eth0 type dummy
#  490|   
#  491|->     expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#  492|       assert_json ".error" "create veth pair: interface eth0 already exists on container namespace: Netlink error: File exists (os error 17)" "interface exists on netns"
#  493|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def80]
/usr/share/netavark/test/250-bridge-nftables.bats:625:71: warning[SC2046]: Quote this to prevent word splitting.
#  623|       add_dummy_interface_on_host dummy0 "10.0.0.1/24"
#  624|   
#  625|->     run_netavark --file ${TESTSDIR}/testfiles/two-networks.json setup $(get_container_netns_path)
#  626|       result="$output"
#  627|   

Error: SHELLCHECK_WARNING (CWE-156): [#def81]
/usr/share/netavark/test/250-bridge-nftables.bats:670:24: warning[SC2046]: Quote this to prevent word splitting.
#  668|   EOF
#  669|   
#  670|->     run_netavark setup $(get_container_netns_path) <<<"$config"
#  671|       result="$output"
#  672|   

Error: SHELLCHECK_WARNING (CWE-156): [#def82]
/usr/share/netavark/test/250-bridge-nftables.bats:716:38: warning[SC2046]: Quote this to prevent word splitting.
#  714|   EOF
#  715|   
#  716|->     expected_rc=1 run_netavark setup $(get_container_netns_path) <<<"$config"
#  717|       assert_json ".error" "unsupported ipam driver someDriver" "Driver is not supported error"
#  718|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def83]
/usr/share/netavark/test/250-bridge-nftables.bats:724:67: warning[SC2046]: Quote this to prevent word splitting.
#  722|   
#  723|       # isolate1: 10.89.0.2/24, fd90::2, isolate=true
#  724|->     run_netavark --file ${TESTSDIR}/testfiles/isolate1.json setup $(get_container_netns_path)
#  725|   
#  726|       # isolate2: 10.89.1.2/24, fd99::2, isolate=true

Error: SHELLCHECK_WARNING (CWE-156): [#def84]
/usr/share/netavark/test/250-bridge-nftables.bats:728:67: warning[SC2046]: Quote this to prevent word splitting.
#  726|       # isolate2: 10.89.1.2/24, fd99::2, isolate=true
#  727|       create_container_ns
#  728|->     run_netavark --file ${TESTSDIR}/testfiles/isolate2.json setup $(get_container_netns_path 1)
#  729|   
#  730|       # isolate3: 10.89.2.2/24, fd92::2, isolate=strict

Error: SHELLCHECK_WARNING (CWE-156): [#def85]
/usr/share/netavark/test/250-bridge-nftables.bats:732:67: warning[SC2046]: Quote this to prevent word splitting.
#  730|       # isolate3: 10.89.2.2/24, fd92::2, isolate=strict
#  731|       create_container_ns
#  732|->     run_netavark --file ${TESTSDIR}/testfiles/isolate3.json setup $(get_container_netns_path 2)
#  733|   
#  734|       # isolate4: 10.89.3.2/24, fd93::2, isolate=strict

Error: SHELLCHECK_WARNING (CWE-156): [#def86]
/usr/share/netavark/test/250-bridge-nftables.bats:736:67: warning[SC2046]: Quote this to prevent word splitting.
#  734|       # isolate4: 10.89.3.2/24, fd93::2, isolate=strict
#  735|       create_container_ns
#  736|->     run_netavark --file ${TESTSDIR}/testfiles/isolate4.json setup $(get_container_netns_path 3)
#  737|   
#  738|       # check nftables NETAVARK-ISOLATION-1 chain

Error: SHELLCHECK_WARNING (CWE-156): [#def87]
/usr/share/netavark/test/250-bridge-nftables.bats:835:85: warning[SC2046]: Quote this to prevent word splitting.
#  833|       # podman: 10.88.0.2/16
#  834|       create_container_ns
#  835|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge-isolate-false.json setup $(get_container_netns_path 4)
#  836|   
#  837|       # check nftables NETAVARK-ISOLATION-3 chain

Error: SHELLCHECK_WARNING (CWE-156): [#def88]
/usr/share/netavark/test/250-bridge-nftables.bats:855:88: warning[SC2046]: Quote this to prevent word splitting.
#  853|   
#  854|       # teardown all networks
#  855|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge-isolate-false.json teardown $(get_container_netns_path 4)
#  856|       run_netavark --file ${TESTSDIR}/testfiles/isolate4.json teardown $(get_container_netns_path 3)
#  857|       run_netavark --file ${TESTSDIR}/testfiles/isolate3.json teardown $(get_container_netns_path 2)

Error: SHELLCHECK_WARNING (CWE-156): [#def89]
/usr/share/netavark/test/250-bridge-nftables.bats:856:70: warning[SC2046]: Quote this to prevent word splitting.
#  854|       # teardown all networks
#  855|       run_netavark --file ${TESTSDIR}/testfiles/simplebridge-isolate-false.json teardown $(get_container_netns_path 4)
#  856|->     run_netavark --file ${TESTSDIR}/testfiles/isolate4.json teardown $(get_container_netns_path 3)
#  857|       run_netavark --file ${TESTSDIR}/testfiles/isolate3.json teardown $(get_container_netns_path 2)
#  858|       run_netavark --file ${TESTSDIR}/testfiles/isolate2.json teardown $(get_container_netns_path 1)

Error: SHELLCHECK_WARNING (CWE-156): [#def90]
/usr/share/netavark/test/250-bridge-nftables.bats:857:70: warning[SC2046]: Quote this to prevent word splitting.
#  855|       run_netavark --file ${TESTSDIR}/testfiles/simplebridge-isolate-false.json teardown $(get_container_netns_path 4)
#  856|       run_netavark --file ${TESTSDIR}/testfiles/isolate4.json teardown $(get_container_netns_path 3)
#  857|->     run_netavark --file ${TESTSDIR}/testfiles/isolate3.json teardown $(get_container_netns_path 2)
#  858|       run_netavark --file ${TESTSDIR}/testfiles/isolate2.json teardown $(get_container_netns_path 1)
#  859|       run_netavark --file ${TESTSDIR}/testfiles/isolate1.json teardown $(get_container_netns_path)

Error: SHELLCHECK_WARNING (CWE-156): [#def91]
/usr/share/netavark/test/250-bridge-nftables.bats:858:70: warning[SC2046]: Quote this to prevent word splitting.
#  856|       run_netavark --file ${TESTSDIR}/testfiles/isolate4.json teardown $(get_container_netns_path 3)
#  857|       run_netavark --file ${TESTSDIR}/testfiles/isolate3.json teardown $(get_container_netns_path 2)
#  858|->     run_netavark --file ${TESTSDIR}/testfiles/isolate2.json teardown $(get_container_netns_path 1)
#  859|       run_netavark --file ${TESTSDIR}/testfiles/isolate1.json teardown $(get_container_netns_path)
#  860|   

Error: SHELLCHECK_WARNING (CWE-156): [#def92]
/usr/share/netavark/test/250-bridge-nftables.bats:859:70: warning[SC2046]: Quote this to prevent word splitting.
#  857|       run_netavark --file ${TESTSDIR}/testfiles/isolate3.json teardown $(get_container_netns_path 2)
#  858|       run_netavark --file ${TESTSDIR}/testfiles/isolate2.json teardown $(get_container_netns_path 1)
#  859|->     run_netavark --file ${TESTSDIR}/testfiles/isolate1.json teardown $(get_container_netns_path)
#  860|   
#  861|       # check that isolation rule is deleted

Error: SHELLCHECK_WARNING (CWE-156): [#def93]
/usr/share/netavark/test/250-bridge-nftables.bats:883:71: warning[SC2046]: Quote this to prevent word splitting.
#  881|       run_in_host_netns mount -t proc -o ro,nosuid,nodev,noexec proc /proc
#  882|   
#  883|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#  884|       run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json teardown $(get_container_netns_path)
#  885|   

Error: SHELLCHECK_WARNING (CWE-156): [#def94]
/usr/share/netavark/test/250-bridge-nftables.bats:884:74: warning[SC2046]: Quote this to prevent word splitting.
#  882|   
#  883|       run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#  884|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json teardown $(get_container_netns_path)
#  885|   
#  886|       run_in_host_netns mount -t proc -o remount,rw /proc

Error: SHELLCHECK_WARNING (CWE-156): [#def95]
/usr/share/netavark/test/250-bridge-nftables.bats:890:85: warning[SC2046]: Quote this to prevent word splitting.
#  888|       run_in_host_netns mount -t proc -o remount,ro /proc
#  889|   
#  890|->     expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#  891|       assert_json ".error" "set sysctl net/ipv4/ip_forward: IO error: Read-only file system (os error 30)" "Sysctl error because fs is read only"
#  892|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def96]
/usr/share/netavark/test/250-bridge-nftables.bats:934:23: warning[SC2046]: Quote this to prevent word splitting.
#  932|   EOF
#  933|   
#  934|->    run_netavark setup $(get_container_netns_path) <<<"$config"
#  935|      result="$output"
#  936|   

Error: SHELLCHECK_WARNING (CWE-156): [#def97]
/usr/share/netavark/test/250-bridge-nftables.bats:991:24: warning[SC2046]: Quote this to prevent word splitting.
#  989|       done
#  990|   
#  991|->     run_netavark setup $(get_container_netns_path) <<<"${configs[0]}"
#  992|   
#  993|       local sysctl_content="# autogenerated by netavark

Error: SHELLCHECK_WARNING (CWE-156): [#def98]
/usr/share/netavark/test/250-bridge-nftables.bats:1000:24: warning[SC2046]: Quote this to prevent word splitting.
#  998|       assert "$output" == "$sysctl_content" "sysctl.d file content"
#  999|   
# 1000|->     run_netavark setup $(get_container_netns_path 1) <<<"${configs[1]}"
# 1001|   
# 1002|       # content must still be the same after second setup

Error: SHELLCHECK_WARNING (CWE-156): [#def99]
/usr/share/netavark/test/250-bridge-nftables.bats:1006:27: warning[SC2046]: Quote this to prevent word splitting.
# 1004|       assert "$output" == "$sysctl_content" "sysctl.d file content"
# 1005|   
# 1006|->     run_netavark teardown $(get_container_netns_path) <<<"${configs[0]}"
# 1007|       # bridge should still exist
# 1008|       run_in_host_netns ip link show podman1

Error: SHELLCHECK_WARNING (CWE-156): [#def100]
/usr/share/netavark/test/250-bridge-nftables.bats:1034:27: warning[SC2046]: Quote this to prevent word splitting.
# 1032|       assert "${#lines[@]}" = 9 "too many FORWARD rules"
# 1033|   
# 1034|->     run_netavark teardown $(get_container_netns_path 1) <<<"${configs[1]}"
# 1035|       # bridge should be removed
# 1036|       expected_rc=1 run_in_host_netns ip link show podman1

Error: SHELLCHECK_WARNING (CWE-156): [#def101]
/usr/share/netavark/test/250-bridge-nftables.bats:1050:71: warning[SC2046]: Quote this to prevent word splitting.
# 1048|   
# 1049|   @test "$fw_driver - two networks" {
# 1050|->     run_netavark --file ${TESTSDIR}/testfiles/two-networks.json setup $(get_container_netns_path)
# 1051|       result="$output"
# 1052|       assert_json "$result" 'has("t1")' == "true" "t1 object key exists"

Error: SHELLCHECK_WARNING (CWE-156): [#def102]
/usr/share/netavark/test/250-bridge-nftables.bats:1075:88: warning[SC2046]: Quote this to prevent word splitting.
# 1073|       assert "$output" =~ "jump nv_fae505bb_10_89_1_0_nm24_dnat" "network 2 fw rule exists"
# 1074|   
# 1075|->     expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/two-networks.json teardown $(get_container_netns_path)
# 1076|       # order is not deterministic so we match twice with different eth name
# 1077|       assert "$output" =~ 'failed to delete container veth eth0\: Netlink error\: No such device \(os error 19\)' "correct eth0 error message"

Error: SHELLCHECK_WARNING (CWE-156): [#def103]
/usr/share/netavark/test/250-bridge-nftables.bats:1088:101: warning[SC2046]: Quote this to prevent word splitting.
# 1086|   @test "$fw_driver - two networks reversed" {
# 1087|       # reverse the two networks to ensure the order is indeed depended on the array
# 1088|->     run_netavark --file <(jq  ".networks |= reverse" ${TESTSDIR}/testfiles/two-networks.json) setup $(get_container_netns_path)
# 1089|   
# 1090|       # verify the setup order of the contianer interfaces by checking the interface index

Error: SHELLCHECK_WARNING (CWE-156): [#def104]
/usr/share/netavark/test/250-bridge-nftables.bats:1107:84: warning[SC2046]: Quote this to prevent word splitting.
# 1105|        run_in_host_netns sysctl net.ipv6.conf.all.disable_ipv6=1
# 1106|   
# 1107|->     expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/ipv6-bridge.json setup $(get_container_netns_path)
# 1108|       assert '{"error":"add ip addr to bridge: failed to add ipv6 address, is ipv6 enabled in the kernel?: Netlink error: Permission denied (os error 13)"}' "error message"
# 1109|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def105]
/usr/share/netavark/test/250-bridge-nftables.bats:1112:65: warning[SC2046]: Quote this to prevent word splitting.
# 1110|   
# 1111|   @test "$fw_driver - route metric from config" {
# 1112|->     run_netavark --file ${TESTSDIR}/testfiles/metric.json setup $(get_container_netns_path)
# 1113|   
# 1114|       run_in_container_netns ip -j route list match 0.0.0.0

Error: SHELLCHECK_WARNING (CWE-156): [#def106]
/usr/share/netavark/test/250-bridge-nftables.bats:1126:75: warning[SC2046]: Quote this to prevent word splitting.
# 1124|   
# 1125|   @test "$fw_driver - default route metric" {
# 1126|->     run_netavark --file ${TESTSDIR}/testfiles/dualstack-bridge.json setup $(get_container_netns_path)
# 1127|   
# 1128|       run_in_container_netns ip -j route list match 0.0.0.0

Error: SHELLCHECK_WARNING (CWE-156): [#def107]
/usr/share/netavark/test/250-bridge-nftables.bats:1140:81: warning[SC2046]: Quote this to prevent word splitting.
# 1138|   
# 1139|   @test "netavark error - invalid host_ip in port mappings" {
# 1140|->     expected_rc=1 run_netavark -f ${TESTSDIR}/testfiles/invalid-port.json setup $(get_container_netns_path)
# 1141|       assert_json ".error" "invalid host ip \"abcd\" provided for port 8080" "host ip error"
# 1142|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def108]
/usr/share/netavark/test/250-bridge-nftables.bats:1147:71: warning[SC2046]: Quote this to prevent word splitting.
# 1145|       setup_firewalld
# 1146|   
# 1147|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
# 1148|   
# 1149|       check_simple_bridge_nftables

Error: SHELLCHECK_WARNING (CWE-156): [#def109]
/usr/share/netavark/test/250-bridge-nftables.bats:1181:71: warning[SC2046]: Quote this to prevent word splitting.
# 1179|   @test "$fw_driver - test firewall-reload" {
# 1180|       # setup a simple bridge network
# 1181|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
# 1182|   
# 1183|       # verify the rules are there initially

Error: SHELLCHECK_WARNING (CWE-156): [#def110]
/usr/share/netavark/test/250-bridge-nftables.bats:1206:74: warning[SC2046]: Quote this to prevent word splitting.
# 1204|   
# 1205|       # teardown the network
# 1206|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json teardown $(get_container_netns_path)
# 1207|   }
# 1208|   

Error: SHELLCHECK_WARNING (CWE-156): [#def111]
/usr/share/netavark/test/250-bridge-nftables.bats:1236:78: warning[SC2046]: Quote this to prevent word splitting.
# 1234|   # regression test for https://github.com/containers/netavark/issues/1068
# 1235|   @test "$fw_driver - port firewall rule cleanup port protocol" {
# 1236|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-port-tcp-udp.json setup $(get_container_netns_path)
# 1237|   
# 1238|       local chain="nv_2f259bab_10_88_0_0_nm16_dnat"

Error: SHELLCHECK_WARNING (CWE-156): [#def112]
/usr/share/netavark/test/250-bridge-nftables.bats:1249:81: warning[SC2046]: Quote this to prevent word splitting.
# 1247|       assert "$output" =~ "ip daddr 192.168.188.25 udp dport 8080 dnat ip to 10.88.0.14:8080"
# 1248|   
# 1249|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-port-tcp-udp.json teardown $(get_container_netns_path)
# 1250|   
# 1251|       expected_rc=1 run_in_host_netns nft list chain inet netavark $chain

Error: SHELLCHECK_WARNING (CWE-156): [#def113]
/usr/share/netavark/test/250-bridge-nftables.bats:1256:77: warning[SC2046]: Quote this to prevent word splitting.
# 1254|   # regression test for https://github.com/containers/netavark/issues/1129
# 1255|   @test "$fw_driver - port firewall rule cleanup host ip" {
# 1256|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-port-hostip.json setup $(get_container_netns_path)
# 1257|   
# 1258|       local chain="nv_2f259bab_10_88_0_0_nm16_dnat"

Error: SHELLCHECK_WARNING (CWE-156): [#def114]
/usr/share/netavark/test/250-bridge-nftables.bats:1271:80: warning[SC2046]: Quote this to prevent word splitting.
# 1269|       assert "$output" =~ "ip daddr 192.168.188.24 tcp dport 8080 dnat ip to 10.88.0.14:8080"
# 1270|   
# 1271|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-port-hostip.json teardown $(get_container_netns_path)
# 1272|   
# 1273|       expected_rc=1 run_in_host_netns nft list chain inet netavark $chain

Error: SHELLCHECK_WARNING (CWE-156): [#def115]
/usr/share/netavark/test/250-bridge-nftables.bats:1279:80: warning[SC2046]: Quote this to prevent word splitting.
# 1277|   
# 1278|   @test "$fw_driver - bridge with outbound addr4" {
# 1279|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-outbound-addr4.json setup $(get_container_netns_path)
# 1280|   
# 1281|       # Check that the nftables rules were created with SNAT

Error: SHELLCHECK_WARNING (CWE-156): [#def116]
/usr/share/netavark/test/250-bridge-nftables.bats:1285:83: warning[SC2046]: Quote this to prevent word splitting.
# 1283|       assert "${lines[3]}" =~ "ip daddr != 224.0.0.0/4 snat ip to 100.1.100.1"
# 1284|   
# 1285|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-outbound-addr4.json teardown $(get_container_netns_path)
# 1286|   
# 1287|       # Check that the chain is removed

Error: SHELLCHECK_WARNING (CWE-156): [#def117]
/usr/share/netavark/test/250-bridge-nftables.bats:1292:80: warning[SC2046]: Quote this to prevent word splitting.
# 1290|   
# 1291|   @test "$fw_driver - bridge with outbound addr6" {
# 1292|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-outbound-addr6.json setup $(get_container_netns_path)
# 1293|   
# 1294|       # Check that the nftables rules were created with SNAT for IPv6

Error: SHELLCHECK_WARNING (CWE-156): [#def118]
/usr/share/netavark/test/250-bridge-nftables.bats:1298:83: warning[SC2046]: Quote this to prevent word splitting.
# 1296|       assert "${lines[3]}" =~ "ip6 daddr != ff00::/8 snat ip6 to fd20:100:200::1"
# 1297|   
# 1298|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-outbound-addr6.json teardown $(get_container_netns_path)
# 1299|   
# 1300|       # Check that the chain is removed

Error: SHELLCHECK_WARNING (CWE-156): [#def119]
/usr/share/netavark/test/250-bridge-nftables.bats:1305:125: warning[SC2046]: Quote this to prevent word splitting.
# 1303|   
# 1304|   @test "$fw_driver - aardvark-dns error cleanup" {
# 1305|->     expected_rc=1 run_netavark -a /usr/bin/false --file ${TESTSDIR}/testfiles/dualstack-bridge-custom-dns-server.json setup $(get_container_netns_path)
# 1306|       assert_json ".error" "error while applying dns entries: aardvark-dns exited unexpectedly without error message" "aardvark-dns error"
# 1307|   

Error: SHELLCHECK_WARNING (CWE-156): [#def120]
/usr/share/netavark/test/250-bridge-nftables.bats:1316:15: warning[SC2046]: Quote this to prevent word splitting.
# 1314|   @test "$fw_driver - invalid dns names" {
# 1315|       RUST_LOG=netavark=warn run_netavark --file ${TESTSDIR}/testfiles/dns-invalid-names.json \
# 1316|->         setup $(get_container_netns_path)
# 1317|       assert "${#lines[@]}" = 4 "4 output lines, three warnings + result"
# 1318|       assert "${lines[0]}" =~ 'invalid network alias "space 1"' "space triggers warning"

Error: SHELLCHECK_WARNING (CWE-156): [#def121]
/usr/share/netavark/test/250-bridge-nftables.bats:1344:115: warning[SC2046]: Quote this to prevent word splitting.
# 1342|       chmod +x $nft
# 1343|   
# 1344|->     PATH="$NETAVARK_TMPDIR:$PATH" expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
# 1345|       assert_json ".error" 'nftables error: "nft" did not return successfully while getting the current ruleset: nft custom error message' "error message from nft is included"
# 1346|   }

Error: SHELLCHECK_WARNING (CWE-398): [#def122]
/usr/share/netavark/test/300-macvlan.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # macvlan driver test

Error: SHELLCHECK_WARNING (CWE-156): [#def123]
/usr/share/netavark/test/300-macvlan.bats:16:66: warning[SC2046]: Quote this to prevent word splitting.
#   14|   
#   15|   @test "simple macvlan setup" {
#   16|->     run_netavark --file ${TESTSDIR}/testfiles/macvlan.json setup $(get_container_netns_path)
#   17|       result="$output"
#   18|   

Error: SHELLCHECK_WARNING (CWE-156): [#def124]
/usr/share/netavark/test/300-macvlan.bats:45:69: warning[SC2046]: Quote this to prevent word splitting.
#   43|       assert "0" "autoconf is disabled"
#   44|   
#   45|->     run_netavark --file ${TESTSDIR}/testfiles/macvlan.json teardown $(get_container_netns_path)
#   46|       assert "" "no errors"
#   47|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def125]
/usr/share/netavark/test/300-macvlan.bats:55:79: warning[SC2046]: Quote this to prevent word splitting.
#   53|       run_in_container_netns ip link set dummy0 up
#   54|   
#   55|->     run_netavark --file ${TESTSDIR}/testfiles/macvlan-staticroutes.json setup $(get_container_netns_path)
#   56|   
#   57|       # check static routes

Error: SHELLCHECK_WARNING (CWE-156): [#def126]
/usr/share/netavark/test/300-macvlan.bats:65:82: warning[SC2046]: Quote this to prevent word splitting.
#   63|       assert "$output" "=~" "fd:2f2f::/64 via fd:1f1f::20" "static route not set"
#   64|   
#   65|->     run_netavark --file ${TESTSDIR}/testfiles/macvlan-staticroutes.json teardown $(get_container_netns_path)
#   66|       assert "" "no errors"
#   67|   

Error: SHELLCHECK_WARNING (CWE-156): [#def127]
/usr/share/netavark/test/300-macvlan.bats:80:81: warning[SC2046]: Quote this to prevent word splitting.
#   78|   
#   79|   @test "macvlan setup no default route" {
#   80|->     run_netavark --file ${TESTSDIR}/testfiles/macvlan-nodefaultroute.json setup $(get_container_netns_path)
#   81|   
#   82|       run_in_container_netns ip r

Error: SHELLCHECK_WARNING (CWE-156): [#def128]
/usr/share/netavark/test/300-macvlan.bats:88:84: warning[SC2046]: Quote this to prevent word splitting.
#   86|       assert "$output" "!~" "default" "default route exists"
#   87|   
#   88|->     run_netavark --file ${TESTSDIR}/testfiles/macvlan-nodefaultroute.json teardown $(get_container_netns_path)
#   89|       assert "" "no errors"
#   90|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def129]
/usr/share/netavark/test/300-macvlan.bats:93:75: warning[SC2046]: Quote this to prevent word splitting.
#   91|   
#   92|   @test "macvlan setup internal" {
#   93|->     run_netavark --file ${TESTSDIR}/testfiles/macvlan-internal.json setup $(get_container_netns_path)
#   94|       result="$output"
#   95|   

Error: SHELLCHECK_WARNING (CWE-156): [#def130]
/usr/share/netavark/test/300-macvlan.bats:115:70: warning[SC2046]: Quote this to prevent word splitting.
#  113|   
#  114|   @test "macvlan setup with mtu" {
#  115|->     run_netavark --file ${TESTSDIR}/testfiles/macvlan-mtu.json setup $(get_container_netns_path)
#  116|       result="$output"
#  117|   

Error: SHELLCHECK_WARNING (CWE-156): [#def131]
/usr/share/netavark/test/300-macvlan.bats:178:24: warning[SC2046]: Quote this to prevent word splitting.
#  176|   EOF
#  177|   
#  178|->     run_netavark setup $(get_container_netns_path) <<<"$config"
#  179|       run_in_container_netns ip -j --details link show eth0
#  180|       link_info="$output"

Error: SHELLCHECK_WARNING (CWE-156): [#def132]
/usr/share/netavark/test/300-macvlan.bats:186:27: warning[SC2046]: Quote this to prevent word splitting.
#  184|       assert_json "$link_info" ".[].linkinfo.info_data.mode" "==" "$mode" "Container interface has correct macvlan mode"
#  185|   
#  186|->     run_netavark teardown $(get_container_netns_path) <<<"$config"
#  187|       done
#  188|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def133]
/usr/share/netavark/test/300-macvlan.bats:218:24: warning[SC2046]: Quote this to prevent word splitting.
#  216|   EOF
#  217|   
#  218|->     run_netavark setup $(get_container_netns_path) <<<"$config"
#  219|       result="$output"
#  220|   

Error: SHELLCHECK_WARNING (CWE-156): [#def134]
/usr/share/netavark/test/300-macvlan.bats:276:23: warning[SC2046]: Quote this to prevent word splitting.
#  274|   EOF
#  275|   
#  276|->    run_netavark setup $(get_container_netns_path) <<<"$config"
#  277|      result="$output"
#  278|   

Error: SHELLCHECK_WARNING (CWE-156): [#def135]
/usr/share/netavark/test/300-macvlan.bats:328:23: warning[SC2046]: Quote this to prevent word splitting.
#  326|      run_in_host_netns ip link add eth0 type dummy
#  327|   
#  328|->    run_netavark setup $(get_container_netns_path) <<<"$config"
#  329|   
#  330|      run_in_container_netns ip link show eth0

Error: SHELLCHECK_WARNING (CWE-156): [#def136]
/usr/share/netavark/test/300-macvlan.bats:332:26: warning[SC2046]: Quote this to prevent word splitting.
#  330|      run_in_container_netns ip link show eth0
#  331|   
#  332|->    run_netavark teardown $(get_container_netns_path) <<<"$config"
#  333|   }
#  334|   

Error: SHELLCHECK_WARNING (CWE-156): [#def137]
/usr/share/netavark/test/300-macvlan.bats:374:37: warning[SC2046]: Quote this to prevent word splitting.
#  372|      run_in_container_netns ip link add eth0 type dummy
#  373|   
#  374|->    expected_rc=1 run_netavark setup $(get_container_netns_path) <<<"$config"
#  375|   
#  376|      # make sure the tmp interface is not leaked on the host or netns

Error: SHELLCHECK_WARNING (CWE-156): [#def138]
/usr/share/netavark/test/300-macvlan.bats:385:73: warning[SC2046]: Quote this to prevent word splitting.
#  383|   
#  384|   @test "macvlan route metric from config" {
#  385|->     run_netavark --file ${TESTSDIR}/testfiles/metric-macvlan.json setup $(get_container_netns_path)
#  386|   
#  387|       run_in_container_netns ip -j route list match 0.0.0.0

Error: SHELLCHECK_WARNING (CWE-398): [#def139]
/usr/share/netavark/test/400-ipvlan.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # macvlan driver test

Error: SHELLCHECK_WARNING (CWE-156): [#def140]
/usr/share/netavark/test/400-ipvlan.bats:16:65: warning[SC2046]: Quote this to prevent word splitting.
#   14|   
#   15|   @test "simple ipvlan setup" {
#   16|->     run_netavark --file ${TESTSDIR}/testfiles/ipvlan.json setup $(get_container_netns_path)
#   17|       result="$output"
#   18|   

Error: SHELLCHECK_WARNING (CWE-156): [#def141]
/usr/share/netavark/test/400-ipvlan.bats:40:68: warning[SC2046]: Quote this to prevent word splitting.
#   38|       assert "0" "autoconf is disabled"
#   39|   
#   40|->     run_netavark --file ${TESTSDIR}/testfiles/ipvlan.json teardown $(get_container_netns_path)
#   41|       assert "" "no errors"
#   42|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def142]
/usr/share/netavark/test/400-ipvlan.bats:50:78: warning[SC2046]: Quote this to prevent word splitting.
#   48|       run_in_container_netns ip link set dummy0 up
#   49|   
#   50|->     run_netavark --file ${TESTSDIR}/testfiles/ipvlan-staticroutes.json setup $(get_container_netns_path)
#   51|   
#   52|       # check static routes

Error: SHELLCHECK_WARNING (CWE-156): [#def143]
/usr/share/netavark/test/400-ipvlan.bats:60:81: warning[SC2046]: Quote this to prevent word splitting.
#   58|       assert "$output" "=~" "fd:2f2f::/64 via fd:1f1f::20" "static route not set"
#   59|   
#   60|->     run_netavark --file ${TESTSDIR}/testfiles/ipvlan-staticroutes.json teardown $(get_container_netns_path)
#   61|       assert "" "no errors"
#   62|   

Error: SHELLCHECK_WARNING (CWE-156): [#def144]
/usr/share/netavark/test/400-ipvlan.bats:75:80: warning[SC2046]: Quote this to prevent word splitting.
#   73|   
#   74|   @test "ipvlan setup no default route" {
#   75|->     run_netavark --file ${TESTSDIR}/testfiles/ipvlan-nodefaultroute.json setup $(get_container_netns_path)
#   76|   
#   77|       run_in_container_netns ip r

Error: SHELLCHECK_WARNING (CWE-156): [#def145]
/usr/share/netavark/test/400-ipvlan.bats:83:83: warning[SC2046]: Quote this to prevent word splitting.
#   81|       assert "$output" "!~" "default" "default route exists"
#   82|   
#   83|->     run_netavark --file ${TESTSDIR}/testfiles/ipvlan-nodefaultroute.json teardown $(get_container_netns_path)
#   84|       assert "" "no errors"
#   85|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def146]
/usr/share/netavark/test/400-ipvlan.bats:88:74: warning[SC2046]: Quote this to prevent word splitting.
#   86|   
#   87|   @test "ipvlan setup internal" {
#   88|->     run_netavark --file ${TESTSDIR}/testfiles/ipvlan-internal.json setup $(get_container_netns_path)
#   89|       result="$output"
#   90|   

Error: SHELLCHECK_WARNING (CWE-156): [#def147]
/usr/share/netavark/test/400-ipvlan.bats:110:69: warning[SC2046]: Quote this to prevent word splitting.
#  108|   
#  109|   @test "ipvlan setup with mtu" {
#  110|->     run_netavark --file ${TESTSDIR}/testfiles/ipvlan-mtu.json setup $(get_container_netns_path)
#  111|       result="$output"
#  112|   

Error: SHELLCHECK_WARNING (CWE-156): [#def148]
/usr/share/netavark/test/400-ipvlan.bats:173:24: warning[SC2046]: Quote this to prevent word splitting.
#  171|   EOF
#  172|   
#  173|->     run_netavark setup $(get_container_netns_path) <<<"$config"
#  174|       run_in_container_netns ip -j --details link show eth0
#  175|       link_info="$output"

Error: SHELLCHECK_WARNING (CWE-156): [#def149]
/usr/share/netavark/test/400-ipvlan.bats:181:27: warning[SC2046]: Quote this to prevent word splitting.
#  179|       assert_json "$link_info" ".[].linkinfo.info_data.mode" "==" "$mode" "Container interface has correct ipvlan mode"
#  180|   
#  181|->     run_netavark teardown $(get_container_netns_path) <<<"$config"
#  182|       done
#  183|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def150]
/usr/share/netavark/test/400-ipvlan.bats:213:24: warning[SC2046]: Quote this to prevent word splitting.
#  211|   EOF
#  212|   
#  213|->     run_netavark setup $(get_container_netns_path) <<<"$config"
#  214|       result="$output"
#  215|   

Error: SHELLCHECK_WARNING (CWE-156): [#def151]
/usr/share/netavark/test/400-ipvlan.bats:271:23: warning[SC2046]: Quote this to prevent word splitting.
#  269|      run_in_host_netns ip link add eth0 type dummy
#  270|   
#  271|->    run_netavark setup $(get_container_netns_path) <<<"$config"
#  272|   
#  273|      run_in_container_netns ip link show eth0

Error: SHELLCHECK_WARNING (CWE-156): [#def152]
/usr/share/netavark/test/400-ipvlan.bats:275:26: warning[SC2046]: Quote this to prevent word splitting.
#  273|      run_in_container_netns ip link show eth0
#  274|   
#  275|->    run_netavark teardown $(get_container_netns_path) <<<"$config"
#  276|   }
#  277|   

Error: SHELLCHECK_WARNING (CWE-156): [#def153]
/usr/share/netavark/test/400-ipvlan.bats:317:37: warning[SC2046]: Quote this to prevent word splitting.
#  315|      run_in_container_netns ip link add eth0 type dummy
#  316|   
#  317|->    expected_rc=1 run_netavark setup $(get_container_netns_path) <<<"$config"
#  318|   
#  319|      # make sure the tmp interface is not leaked on the host or netns

Error: SHELLCHECK_WARNING (CWE-398): [#def154]
/usr/share/netavark/test/500-bridge-fwnone.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # bridge driver tests with none firewall driver

Error: SHELLCHECK_WARNING (CWE-563): [#def155]
/usr/share/netavark/test/500-bridge-fwnone.bats:8:1: warning[SC2034]: fw_driver appears unused. Verify use (or export if used externally).
#    6|   load helpers
#    7|   
#    8|-> fw_driver=none
#    9|   
#   10|   @test "check none firewall driver is in use" {

Error: SHELLCHECK_WARNING (CWE-156): [#def156]
/usr/share/netavark/test/500-bridge-fwnone.bats:11:113: warning[SC2046]: Quote this to prevent word splitting.
#    9|   
#   10|   @test "check none firewall driver is in use" {
#   11|->     RUST_LOG=netavark=info NETAVARK_FW="none" run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#   12|       assert "${lines[0]}" "==" "[INFO  netavark::firewall] Not using firewall" "none firewall driver is in use"
#   13|   }

Error: SHELLCHECK_WARNING (CWE-398): [#def157]
/usr/share/netavark/test/500-plugin.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # macvlan driver test

Error: SHELLCHECK_WARNING (CWE-156): [#def158]
/usr/share/netavark/test/500-plugin.bats:42:46: warning[SC2046]: Quote this to prevent word splitting.
#   40|       config=$(get_conf error-plugin)
#   41|   
#   42|->     expected_rc=1 run_netavark_plugins setup $(get_container_netns_path) <<<"$config"
#   43|       assert '{"error":"plugin \"error-plugin\" failed: exit code 1, message: setup error"}'
#   44|   

Error: SHELLCHECK_WARNING (CWE-156): [#def159]
/usr/share/netavark/test/500-plugin.bats:45:49: warning[SC2046]: Quote this to prevent word splitting.
#   43|       assert '{"error":"plugin \"error-plugin\" failed: exit code 1, message: setup error"}'
#   44|   
#   45|->     expected_rc=1 run_netavark_plugins teardown $(get_container_netns_path) <<<"$config"
#   46|       assert '{"error":"plugin \"error-plugin\" failed: exit code 1, message: teardown error"}'
#   47|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def160]
/usr/share/netavark/test/500-plugin.bats:54:32: warning[SC2046]: Quote this to prevent word splitting.
#   52|       run_in_host_netns ip link add dummy0 type dummy
#   53|   
#   54|->     run_netavark_plugins setup $(get_container_netns_path) <<<"$config"
#   55|       assert  "$output" =~ '"interfaces"\:\{"dummy0"\:' "status block with interface name"
#   56|   

Error: SHELLCHECK_WARNING (CWE-156): [#def161]
/usr/share/netavark/test/500-plugin.bats:59:35: warning[SC2046]: Quote this to prevent word splitting.
#   57|       run_in_container_netns ip link show dummy0
#   58|   
#   59|->     run_netavark_plugins teardown $(get_container_netns_path) <<<"$config"
#   60|       assert '' "no error output"
#   61|   

Error: SHELLCHECK_WARNING (CWE-156): [#def162]
/usr/share/netavark/test/500-plugin.bats:69:32: warning[SC2046]: Quote this to prevent word splitting.
#   67|       config=$(get_conf stderr-plugin)
#   68|   
#   69|->     run_netavark_plugins setup $(get_container_netns_path) <<<"$config"
#   70|       assert "${lines[0]}" == "stderr setup" "stderr log on first line"
#   71|       assert "${lines[1]}" =~ '"interfaces"' "status block"

Error: SHELLCHECK_WARNING (CWE-156): [#def163]
/usr/share/netavark/test/500-plugin.bats:73:35: warning[SC2046]: Quote this to prevent word splitting.
#   71|       assert "${lines[1]}" =~ '"interfaces"' "status block"
#   72|   
#   73|->     run_netavark_plugins teardown $(get_container_netns_path) <<<"$config"
#   74|       assert 'stderr teardown' "stderr log"
#   75|   }

Error: SHELLCHECK_WARNING (CWE-398): [#def164]
/usr/share/netavark/test/600-bridge-vrf.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # bridge driver tests with vrf

Error: SHELLCHECK_WARNING (CWE-156): [#def165]
/usr/share/netavark/test/600-bridge-vrf.bats:12:75: warning[SC2046]: Quote this to prevent word splitting.
#   10|       run_in_host_netns ip link set dev test-vrf up
#   11|   
#   12|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge-vrf.json setup $(get_container_netns_path)
#   13|   
#   14|       # check if vrf exists

Error: SHELLCHECK_WARNING (CWE-156): [#def166]
/usr/share/netavark/test/600-bridge-vrf.bats:22:71: warning[SC2046]: Quote this to prevent word splitting.
#   20|   
#   21|   @test vrf - simple bridge {
#   22|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
#   23|       run_in_host_netns ip -j --details link show podman0
#   24|       result="$output"

Error: SHELLCHECK_WARNING (CWE-156): [#def167]
/usr/share/netavark/test/600-bridge-vrf.bats:29:89: warning[SC2046]: Quote this to prevent word splitting.
#   27|   
#   28|   @test vrf - non existent vrf {
#   29|->     expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/simplebridge-vrf.json setup $(get_container_netns_path)
#   30|       result="$output"
#   31|       assert_json "$result" ".error" "==" "get vrf to set up bridge interface: Netlink error: No such device (os error 19)" "Attempt to set a non existent vrf"

Error: SHELLCHECK_WARNING (CWE-398): [#def168]
/usr/share/netavark/test/610-bridge-vethname.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # bridge driver tests with static veth names

Error: SHELLCHECK_WARNING (CWE-156): [#def169]
/usr/share/netavark/test/610-bridge-vethname.bats:9:74: warning[SC2046]: Quote this to prevent word splitting.
#    7|   
#    8|   @test bridge - valid veth name {
#    9|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-vethname.json setup $(get_container_netns_path)
#   10|   
#   11|       run_in_host_netns ip -j --details link show my-veth

Error: SHELLCHECK_WARNING (CWE-156): [#def170]
/usr/share/netavark/test/610-bridge-vethname.bats:17:77: warning[SC2046]: Quote this to prevent word splitting.
#   15|       assert_json "$link_info" ".[].master" "==" "podman0" "veth is part of the correct bridge"
#   16|   
#   17|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-vethname.json teardown $(get_container_netns_path)
#   18|   
#   19|       # check if the interface gets removed

Error: SHELLCHECK_WARNING (CWE-156): [#def171]
/usr/share/netavark/test/610-bridge-vethname.bats:25:95: warning[SC2046]: Quote this to prevent word splitting.
#   23|   
#   24|   @test bridge - existing veth name {
#   25|->     expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/bridge-vethname-exists.json setup $(get_container_netns_path)
#   26|       assert_json ".error" "create veth pair: interface eth0 already exists on container namespace or podman0 exists on host namespace: Netlink error: File exists (os error 17)"
#   27|   

Error: SHELLCHECK_WARNING (CWE-398): [#def172]
/usr/share/netavark/test/620-bridge-mode.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # bridge driver tests with explicit modes

Error: SHELLCHECK_WARNING (CWE-156): [#def173]
/usr/share/netavark/test/620-bridge-mode.bats:9:73: warning[SC2046]: Quote this to prevent word splitting.
#    7|   
#    8|   @test bridge - managed mode {
#    9|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-managed.json setup $(get_container_netns_path)
#   10|   
#   11|       run_in_host_netns ip -j --details link show podman0

Error: SHELLCHECK_WARNING (CWE-156): [#def174]
/usr/share/netavark/test/620-bridge-mode.bats:15:76: warning[SC2046]: Quote this to prevent word splitting.
#   13|       assert_json "$link_info" '.[].flags[] | select(.=="UP")' == "UP" "Host bridge interface is up"
#   14|   
#   15|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-managed.json teardown $(get_container_netns_path)
#   16|   
#   17|       # make sure, that the bridge was removed

Error: SHELLCHECK_WARNING (CWE-156): [#def175]
/usr/share/netavark/test/620-bridge-mode.bats:23:89: warning[SC2046]: Quote this to prevent word splitting.
#   21|   
#   22|   @test bridge - unmanaged mode {
#   23|->     expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/bridge-unmanaged.json setup $(get_container_netns_path)
#   24|       assert_json ".error" "in unmanaged mode, the bridge must already exist on the host: Netlink error: No such device (os error 19)"
#   25|   

Error: SHELLCHECK_WARNING (CWE-156): [#def176]
/usr/share/netavark/test/620-bridge-mode.bats:29:75: warning[SC2046]: Quote this to prevent word splitting.
#   27|       run_in_host_netns ip link set brtest0 up
#   28|   
#   29|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-unmanaged.json setup $(get_container_netns_path)
#   30|   
#   31|       run_in_host_netns ip -j --details link show brtest0

Error: SHELLCHECK_WARNING (CWE-156): [#def177]
/usr/share/netavark/test/620-bridge-mode.bats:35:78: warning[SC2046]: Quote this to prevent word splitting.
#   33|       assert_json "$link_info" '.[].flags[] | select(.=="UP")' == "UP" "Host bridge interface is up"
#   34|   
#   35|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-unmanaged.json teardown $(get_container_netns_path)
#   36|   
#   37|       # make sure, that the bridge was NOT removed

Error: SHELLCHECK_WARNING (CWE-156): [#def178]
/usr/share/netavark/test/620-bridge-mode.bats:44:92: warning[SC2046]: Quote this to prevent word splitting.
#   42|   
#   43|   @test "bridge - managed mode with dhcp" {
#   44|->     expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/bridge-managed-dhcp.json setup $(get_container_netns_path)
#   45|       assert_json ".error" "cannot use dhcp ipam driver without using the option mode=unmanaged" "dhcp error"
#   46|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def179]
/usr/share/netavark/test/620-bridge-mode.bats:55:93: warning[SC2046]: Quote this to prevent word splitting.
#   53|       assert_json "$link_info" '.[].flags[] | select(.=="UP")' == "UP" "Host bridge interface is up"
#   54|   
#   55|->     expected_rc=1 run_netavark --file ${TESTSDIR}/testfiles/bridge-unmanaged-dns.json setup $(get_container_netns_path)
#   56|       assert_json ".error" "bridge 'brtest0' in unmanaged mode has no usable IP addresses. Aardvark-dns requires at least one address (should not be an IPv6 link-local address) to bind to. Please add an IP address or disable DNS for this network (--disable-dns)."
#   57|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def180]
/usr/share/netavark/test/620-bridge-mode.bats:69:79: warning[SC2046]: Quote this to prevent word splitting.
#   67|       run_in_host_netns ip addr add 10.88.0.100/16 dev brtest0
#   68|       run_in_host_netns ip addr add 2001:db8:abcd:000a:50a6:6bff:fe84:255a dev brtest0
#   69|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-unmanaged-dns.json setup $(get_container_netns_path)
#   70|   
#   71|       run_helper cat "$NETAVARK_TMPDIR/config/aardvark-dns/podman"

Error: SHELLCHECK_WARNING (CWE-398): [#def181]
/usr/share/netavark/test/630-bridge-vlan.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # bridge driver tests with explicit modes

Error: SHELLCHECK_WARNING (CWE-571): [#def182]
/usr/share/netavark/test/630-bridge-vlan.bats:58:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#   56|   @test "bridge - vlan create bridge" {
#   57|       local vlan=20
#   58|->     local config=$(createVlanConfig managed $vlan)
#   59|   
#   60|       run_netavark setup $(get_container_netns_path) <<<"$config"

Error: SHELLCHECK_WARNING (CWE-156): [#def183]
/usr/share/netavark/test/630-bridge-vlan.bats:60:24: warning[SC2046]: Quote this to prevent word splitting.
#   58|       local config=$(createVlanConfig managed $vlan)
#   59|   
#   60|->     run_netavark setup $(get_container_netns_path) <<<"$config"
#   61|   
#   62|       run_in_host_netns ip -j --details link show podman0

Error: SHELLCHECK_WARNING (CWE-156): [#def184]
/usr/share/netavark/test/630-bridge-vlan.bats:76:27: warning[SC2046]: Quote this to prevent word splitting.
#   74|   ]' "vlan flags"
#   75|   
#   76|->     run_netavark teardown $(get_container_netns_path) <<<"$config"
#   77|   }
#   78|   

Error: SHELLCHECK_WARNING (CWE-571): [#def185]
/usr/share/netavark/test/630-bridge-vlan.bats:81:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#   79|   @test "bridge - vlan with existing bridge" {
#   80|       local vlan=99
#   81|->     local config=$(createVlanConfig unmanaged $vlan)
#   82|   
#   83|       # pre create bridge in managed mode to ensure to code still enabled vlan_filtering

Error: SHELLCHECK_WARNING (CWE-156): [#def186]
/usr/share/netavark/test/630-bridge-vlan.bats:87:24: warning[SC2046]: Quote this to prevent word splitting.
#   85|       run_in_host_netns ip link set up podman0
#   86|   
#   87|->     run_netavark setup $(get_container_netns_path) <<<"$config"
#   88|   
#   89|       run_in_host_netns ip -j --details link show podman0

Error: SHELLCHECK_WARNING (CWE-156): [#def187]
/usr/share/netavark/test/630-bridge-vlan.bats:103:27: warning[SC2046]: Quote this to prevent word splitting.
#  101|   ]' "vlan flags"
#  102|   
#  103|->     run_netavark teardown $(get_container_netns_path) <<<"$config"
#  104|   }
#  105|   

Error: SHELLCHECK_WARNING (CWE-571): [#def188]
/usr/share/netavark/test/630-bridge-vlan.bats:108:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  106|   @test "bridge - two vlan's on same bridge" {
#  107|       local vlan1=10
#  108|->     local config1=$(createVlanConfig managed $vlan1)
#  109|   
#  110|       run_netavark setup $(get_container_netns_path) <<<"$config1"

Error: SHELLCHECK_WARNING (CWE-156): [#def189]
/usr/share/netavark/test/630-bridge-vlan.bats:110:24: warning[SC2046]: Quote this to prevent word splitting.
#  108|       local config1=$(createVlanConfig managed $vlan1)
#  109|   
#  110|->     run_netavark setup $(get_container_netns_path) <<<"$config1"
#  111|   
#  112|       run_in_host_netns bridge -j vlan show

Error: SHELLCHECK_WARNING (CWE-571): [#def190]
/usr/share/netavark/test/630-bridge-vlan.bats:123:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  121|   
#  122|       local vlan2=10
#  123|->     local config2=$(createVlanConfig unmanaged $vlan2)
#  124|       create_container_ns
#  125|   

Error: SHELLCHECK_WARNING (CWE-156): [#def191]
/usr/share/netavark/test/630-bridge-vlan.bats:126:24: warning[SC2046]: Quote this to prevent word splitting.
#  124|       create_container_ns
#  125|   
#  126|->     run_netavark setup $(get_container_netns_path 1) <<<"$config2"
#  127|   
#  128|       # the second setup should have used veth1 as name

Error: SHELLCHECK_WARNING (CWE-156): [#def192]
/usr/share/netavark/test/630-bridge-vlan.bats:140:27: warning[SC2046]: Quote this to prevent word splitting.
#  138|   ]' "vlan flags"
#  139|   
#  140|->     run_netavark teardown $(get_container_netns_path) <<<"$config1"
#  141|       run_netavark teardown $(get_container_netns_path 1) <<<"$config2"
#  142|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def193]
/usr/share/netavark/test/630-bridge-vlan.bats:141:27: warning[SC2046]: Quote this to prevent word splitting.
#  139|   
#  140|       run_netavark teardown $(get_container_netns_path) <<<"$config1"
#  141|->     run_netavark teardown $(get_container_netns_path 1) <<<"$config2"
#  142|   }

Error: SHELLCHECK_WARNING (CWE-398): [#def194]
/usr/share/netavark/test/640-bridge-mtu.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # bridge driver tests with explicit modes

Error: SHELLCHECK_WARNING (CWE-156): [#def195]
/usr/share/netavark/test/640-bridge-mtu.bats:74:73: warning[SC2046]: Quote this to prevent word splitting.
#   72|   @test "bridge - mtu from default route" {
#   73|       add_default_route
#   74|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-managed.json setup $(get_container_netns_path)
#   75|       check_mtu 9000
#   76|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def196]
/usr/share/netavark/test/640-bridge-mtu.bats:88:73: warning[SC2046]: Quote this to prevent word splitting.
#   86|       add_default_route mtu=3000 ifname=def-table900 table=900
#   87|   
#   88|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-managed.json setup $(get_container_netns_path)
#   89|       check_mtu 2000
#   90|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def197]
/usr/share/netavark/test/640-bridge-mtu.bats:94:73: warning[SC2046]: Quote this to prevent word splitting.
#   92|   @test "bridge - mtu from existing bridge" {
#   93|       add_bridge
#   94|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-managed.json setup $(get_container_netns_path)
#   95|       check_mtu 9001
#   96|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def198]
/usr/share/netavark/test/640-bridge-mtu.bats:100:69: warning[SC2046]: Quote this to prevent word splitting.
#   98|   @test "bridge - mtu from config with default route" {
#   99|       add_default_route
#  100|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-mtu.json setup $(get_container_netns_path)
#  101|       check_mtu 9002
#  102|   }

Error: SHELLCHECK_WARNING (CWE-156): [#def199]
/usr/share/netavark/test/640-bridge-mtu.bats:106:69: warning[SC2046]: Quote this to prevent word splitting.
#  104|   @test "bridge - mtu from config with existing bridge" {
#  105|       add_bridge
#  106|->     run_netavark --file ${TESTSDIR}/testfiles/bridge-mtu.json setup $(get_container_netns_path)
#  107|       check_iface_mtu container eth0 9002
#  108|       check_iface_mtu host veth0 9002

Error: SHELLCHECK_WARNING (CWE-156): [#def200]
/usr/share/netavark/test/640-bridge-mtu.bats:120:75: warning[SC2046]: Quote this to prevent word splitting.
#  118|       add_default_route mtu=3000 ifname=eth-vrf vrf=test-vrf table=100
#  119|   
#  120|->     run_netavark --file ${TESTSDIR}/testfiles/simplebridge-vrf.json setup $(get_container_netns_path)
#  121|   
#  122|       # check if vrf exists

Error: SHELLCHECK_WARNING (CWE-398): [#def201]
/usr/share/netavark/test/700-create.bats:1:1: error[SC2096]: On most OS, shebangs can only specify a single parameter.
#    1|-> #!/usr/bin/env bats   -*- bats -*-
#    2|   #
#    3|   # netavark create command tests

Error: SHELLCHECK_WARNING (CWE-670): [#def202]
/usr/share/netavark/test/helpers.bash:8:32: warning[SC2128]: Expanding an array without an index only gives the first element.
#    6|   TEST_PLUGINS=${TEST_PLUGINS:-./targets/release/examples}
#    7|   
#    8|-> TESTSDIR=${TESTSDIR:-$(dirname ${BASH_SOURCE})}
#    9|   
#   10|   # export RUST_BACKTRACE so that we get a helpful stack trace

Error: SHELLCHECK_WARNING (CWE-457): [#def203]
/usr/share/netavark/test/helpers.bash:87:15: warning[SC2154]: status is referenced but not assigned.
#   85|           # query firewalld with firewall-cmd
#   86|           expected_rc="?" run_in_host_netns firewall-cmd --state
#   87|->         if [ "$status" -eq 0 ]; then
#   88|               break
#   89|           fi

Error: SHELLCHECK_WARNING (CWE-563): [#def204]
/usr/share/netavark/test/helpers.bash:208:5: warning[SC2034]: MOST_RECENT_COMMAND appears unused. Verify use (or export if used externally).
#  206|       fi
#  207|       # Remember command args, for possible use in later diagnostic messages
#  208|->     MOST_RECENT_COMMAND="$*"
#  209|   
#  210|       # stdout is only emitted upon error; this echo is to help a debugger

Error: SHELLCHECK_WARNING (CWE-571): [#def205]
/usr/share/netavark/test/helpers.bash:470:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  468|       fi
#  469|   
#  470|->     local container_id=$(random_string 64)
#  471|       local container_name="name-$(random_string 10)"
#  472|   

Error: SHELLCHECK_WARNING (CWE-571): [#def206]
/usr/share/netavark/test/helpers.bash:471:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  469|   
#  470|       local container_id=$(random_string 64)
#  471|->     local container_name="name-$(random_string 10)"
#  472|   
#  473|       local static_ips=""

Error: SHELLCHECK_WARNING (CWE-156): [#def207]
/usr/share/netavark/test/helpers.bash:548:24: warning[SC2046]: Quote this to prevent word splitting.
#  546|       fi
#  547|   
#  548|->     run_netavark setup $(get_container_netns_path) <<<"$config"
#  549|       result="$output"
#  550|   

Error: SHELLCHECK_WARNING (CWE-156): [#def208]
/usr/share/netavark/test/helpers.bash:597:27: warning[SC2046]: Quote this to prevent word splitting.
#  595|       done
#  596|   
#  597|->     run_netavark teardown $(get_container_netns_path) <<<"$config"
#  598|   }
#  599|   

Error: SHELLCHECK_WARNING (CWE-457): [#def209]
/usr/share/netavark/test/helpers.bash:639:13: warning[SC2154]: lines is referenced but not assigned (did you mean 'line'?).
#  637|       data=$(random_string)
#  638|       run_in_host_netns $NETAVARK_CONNECTION_TESTER --$proto  "$(get_container_netns_path $container_ns)" "$connect_ip:$host_port" $container_port <<<"$data"
#  639|->     assert "${lines[1]}" == "Message: $data" "Logged message"
#  640|   }
#  641|   

Error: SHELLCHECK_WARNING (CWE-571): [#def210]
/usr/share/netavark/test/helpers.bash:785:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  783|       fi
#  784|   
#  785|->     local container_id=$(random_string 64)
#  786|       local container_name="name-$(random_string 10)"
#  787|   

Error: SHELLCHECK_WARNING (CWE-571): [#def211]
/usr/share/netavark/test/helpers.bash:786:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  784|   
#  785|       local container_id=$(random_string 64)
#  786|->     local container_name="name-$(random_string 10)"
#  787|   
#  788|       read -r -d '\0' config <<EOF

Error: SHELLCHECK_WARNING (CWE-156): [#def212]
/usr/share/netavark/test/helpers.bash:818:28: warning[SC2046]: Quote this to prevent word splitting.
#  816|       if [ "$expected_rc" -eq 0 ]; then
#  817|           # Success case
#  818|->         run_netavark setup $(get_container_netns_path) <<<"$config"
#  819|           result="$output"
#  820|   

Error: SHELLCHECK_WARNING (CWE-563): [#def213]
/usr/share/netavark/test/helpers.bash:819:9: warning[SC2034]: result appears unused. Verify use (or export if used externally).
#  817|           # Success case
#  818|           run_netavark setup $(get_container_netns_path) <<<"$config"
#  819|->         result="$output"
#  820|   
#  821|           local ips_to_check=$(echo "$static_ips" | sed 's/"//g' | tr ',' '\n' | tr -d ' ')

Error: SHELLCHECK_WARNING (CWE-571): [#def214]
/usr/share/netavark/test/helpers.bash:821:15: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  819|           result="$output"
#  820|   
#  821|->         local ips_to_check=$(echo "$static_ips" | sed 's/"//g' | tr ',' '\n' | tr -d ' ')
#  822|   
#  823|           run_in_container_netns ip addr show eth0

Error: SHELLCHECK_WARNING (CWE-156): [#def215]
/usr/share/netavark/test/helpers.bash:832:31: warning[SC2046]: Quote this to prevent word splitting.
#  830|           done <<< "$ips_to_check"
#  831|   
#  832|->         run_netavark teardown $(get_container_netns_path) <<<"$config"
#  833|       else
#  834|           # Error case

Error: SHELLCHECK_WARNING (CWE-156): [#def216]
/usr/share/netavark/test/helpers.bash:835:53: warning[SC2046]: Quote this to prevent word splitting.
#  833|       else
#  834|           # Error case
#  835|->         expected_rc=$expected_rc run_netavark setup $(get_container_netns_path) <<<"$config"
#  836|           if [[ -n "$error_match" ]]; then
#  837|               assert "$output" "=~" "$error_match" "error message should match pattern"

Scan Properties

analyzer-version-clippy1.97.1
analyzer-version-cppcheck2.21.1
analyzer-version-gcc16.1.1
analyzer-version-gcc-analyzer16.1.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.97.1
diffbase-analyzer-version-cppcheck2.21.1
diffbase-analyzer-version-gcc16.1.1
diffbase-analyzer-version-gcc-analyzer16.1.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-227.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namenetavark-1.17.2-1.fc44
diffbase-store-results-to/tmp/tmp0a9c1ube/netavark-1.17.2-1.fc44.tar.xz
diffbase-time-created2026-08-03 18:35:43
diffbase-time-finished2026-08-03 18:41:24
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,clippy,unicontrol,shellcheck,cppcheck' '-o' '/tmp/tmp0a9c1ube/netavark-1.17.2-1.fc44.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmp0a9c1ube/netavark-1.17.2-1.fc44.src.rpm'
diffbase-tool-versioncsmock-3.8.7.20260803.142340.gb75b18e-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-227.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namenetavark-2.0.0-3.fc45
store-results-to/tmp/tmpre1mut0y/netavark-2.0.0-3.fc45.tar.xz
time-created2026-08-03 18:41:53
time-finished2026-08-03 18:50:09
titleNewly introduced findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,clippy,unicontrol,shellcheck,cppcheck' '-o' '/tmp/tmpre1mut0y/netavark-2.0.0-3.fc45.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpre1mut0y/netavark-2.0.0-3.fc45.src.rpm'
tool-versioncsmock-3.8.7.20260803.142340.gb75b18e-1.el9