Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-476): [#def1]
modulemd-2.15.2/modulemd/modulemd-module-index.c:1522:15: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘nested_error’
modulemd-2.15.2/modulemd/modulemd-module-index.c:1463:1: enter_function: entry to ‘modulemd_module_index_merge’
modulemd-2.15.2/modulemd/modulemd-module-index.c:1486:22: release_memory: ‘nested_error’ is NULL
modulemd-2.15.2/modulemd/modulemd-module-index.c:1496:10: branch_true: following ‘true’ branch...
modulemd-2.15.2/modulemd/modulemd-module-index.c:1498:7: branch_true: ...to here
modulemd-2.15.2/modulemd/modulemd-module-index.c:1519:16: call_function: calling ‘modulemd_module_index_add_module_stream’ from ‘modulemd_module_index_merge’
modulemd-2.15.2/modulemd/modulemd-module-index.c:1519:16: return_function: returning to ‘modulemd_module_index_merge’ from ‘modulemd_module_index_add_module_stream’
modulemd-2.15.2/modulemd/modulemd-module-index.c:1519:14: branch_true: following ‘true’ branch...
modulemd-2.15.2/modulemd/modulemd-module-index.c:1522:15: branch_true: ...to here
modulemd-2.15.2/modulemd/modulemd-module-index.c:1522:15: release_memory: ‘nested_error’ is NULL
modulemd-2.15.2/modulemd/modulemd-module-index.c:1522:15: danger: dereference of NULL ‘nested_error’
# 1520|                   into, stream, &nested_error))
# 1521|               {
# 1522|->               g_info ("Could not add stream %s due to %s",
# 1523|                         nsvca,
# 1524|                         nested_error->message);

Error: GCC_ANALYZER_WARNING (CWE-476): [#def2]
modulemd-2.15.2/modulemd/modulemd-translation.c:617:7: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘nested_error’
modulemd-2.15.2/modulemd/modulemd-translation.c:484:22: release_memory: ‘nested_error’ is NULL
modulemd-2.15.2/modulemd/modulemd-translation.c:490:6: branch_false: following ‘false’ branch...
modulemd-2.15.2/modulemd/modulemd-translation.c:496:3: branch_false: ...to here
modulemd-2.15.2/modulemd/modulemd-translation.c:502:3: branch_false: following ‘false’ branch...
modulemd-2.15.2/modulemd/modulemd-translation.c:502:3: branch_false: ...to here
modulemd-2.15.2/modulemd/modulemd-translation.c:503:6: branch_false: following ‘false’ branch...
modulemd-2.15.2/modulemd/modulemd-translation.c:503:6: branch_false: ...to here
modulemd-2.15.2/modulemd/modulemd-translation.c:509:10: branch_true: following ‘true’ branch (when ‘done == 0’)...
modulemd-2.15.2/modulemd/modulemd-translation.c:511:7: branch_true: ...to here
modulemd-2.15.2/modulemd/modulemd-translation.c:511:7: branch_false: following ‘false’ branch...
modulemd-2.15.2/modulemd/modulemd-translation.c:511:7: branch_false: ...to here
modulemd-2.15.2/modulemd/modulemd-translation.c:615:6: branch_true: following ‘true’ branch...
modulemd-2.15.2/modulemd/modulemd-translation.c:617:7: branch_true: ...to here
modulemd-2.15.2/modulemd/modulemd-translation.c:617:7: release_memory: ‘nested_error’ is NULL
modulemd-2.15.2/modulemd/modulemd-translation.c:617:7: danger: dereference of NULL ‘nested_error’
#  615|     if (!modulemd_translation_validate (t, &nested_error))
#  616|       {
#  617|->       MMD_YAML_ERROR_EVENT_EXIT (error,
#  618|                                    event,
#  619|                                    "Unable to validate translation object: %s",

Error: GCC_ANALYZER_WARNING (CWE-688): [#def3]
modulemd-2.15.2/modulemd/modulemd-util.c:383:15: warning[-Wanalyzer-null-argument]: use of NULL ‘nevra’ where non-null expected
modulemd-2.15.2/modulemd/modulemd-util.c:380:1: enter_function: entry to ‘modulemd_validate_nevra’
modulemd-2.15.2/modulemd/modulemd-util.c:382:21: release_memory: ‘nevra’ is NULL
modulemd-2.15.2/modulemd/modulemd-util.c:383:15: danger: argument 1 (‘nevra’) NULL where non-null expected
#  381|   {
#  382|     g_autofree gchar *tmp = g_strdup (nevra);
#  383|->   gsize len = strlen (nevra);
#  384|     gchar *i;
#  385|     gchar *endptr;

Error: GCC_ANALYZER_WARNING (CWE-688): [#def4]
modulemd-2.15.2/modulemd/tests/test-modulemd-compression.c:136:12: warning[-Wanalyzer-null-argument]: use of NULL ‘fopen(g_strdup_printf("%s/compression/%s", g_getenv("TEST_DATA_PATH"), expected_magic[j].filename), "rbe")’ where non-null expected
modulemd-2.15.2/modulemd/tests/test-modulemd-compression.c:94:22: branch_true: following ‘true’ branch...
modulemd-2.15.2/modulemd/tests/test-modulemd-compression.c:96:18: branch_true: ...to here
modulemd-2.15.2/modulemd/tests/test-modulemd-compression.c:108:7: branch_true: following ‘true’ branch...
modulemd-2.15.2/modulemd/tests/test-modulemd-compression.c:128:22: branch_true: following ‘true’ branch...
modulemd-2.15.2/modulemd/tests/test-modulemd-compression.c:130:18: branch_true: ...to here
modulemd-2.15.2/modulemd/tests/test-modulemd-compression.c:134:20: acquire_memory: allocated here
modulemd-2.15.2/modulemd/tests/test-modulemd-compression.c:135:7: release_memory: assuming ‘fopen(g_strdup_printf("%s/compression/%s", g_getenv("TEST_DATA_PATH"), expected_magic[j].filename), "rbe")’ is NULL
modulemd-2.15.2/modulemd/tests/test-modulemd-compression.c:136:12: danger: argument 1 (‘fopen(g_strdup_printf("%s/compression/%s", g_getenv("TEST_DATA_PATH"), expected_magic[j].filename), "rbe")’) NULL where non-null expected
#  134|         filestream = g_fopen (filename, "rbe");
#  135|         g_assert_nonnull (filestream);
#  136|->       fd = fileno (filestream);
#  137|         result = modulemd_detect_compression (filename, fd, &error);
#  138|         g_assert_no_error (error);

Scan Properties