Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-775): [#def1]
libei-1.5.0/src/util-io.h:119:16: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘xdup(eisfd)’
libei-1.5.0/src/liboeffis.c:332:1: enter_function: entry to ‘connect_to_eis_returned’
libei-1.5.0/src/liboeffis.c:344:12: branch_false: following ‘false’ branch...
libei-1.5.0/src/liboeffis.c:350:14: branch_false: ...to here
libei-1.5.0/src/liboeffis.c:350:14: call_function: calling ‘xdup’ from ‘connect_to_eis_returned’
libei-1.5.0/src/liboeffis.c:350:14: return_function: returning to ‘connect_to_eis_returned’ from ‘xdup’
libei-1.5.0/src/liboeffis.c:350:14: call_function: inlined call to ‘xerrno’ from ‘connect_to_eis_returned’
#  117|   static inline int
#  118|   xerrno(int value) {
#  119|-> 	return value < 0 ? -errno : value;
#  120|   }
#  121|   

Error: GCC_ANALYZER_WARNING (CWE-401): [#def2]
libei-1.5.0/src/util-strings.c:189:30: warning[-Wanalyzer-malloc-leak]: leak of ‘xalloc(max + 1)’
libei-1.5.0/src/util-strings.c:164:1: enter_function: entry to ‘strreplace’
libei-1.5.0/src/util-strings.c:166:9: branch_true: following ‘true’ branch (when ‘string’ is non-NULL)...
libei-1.5.0/src/util-strings.c:167:9: branch_true: ...to here
libei-1.5.0/src/util-strings.c:167:9: branch_true: following ‘true’ branch...
libei-1.5.0/src/util-strings.c:173:23: branch_true: ...to here
libei-1.5.0/src/util-strings.c:180:12: branch_false: following ‘false’ branch (when ‘next’ is non-NULL)...
libei-1.5.0/src/util-strings.c:183:23: branch_false: ...to here
libei-1.5.0/src/util-strings.c:185:19: call_function: calling ‘xalloc’ from ‘strreplace’
libei-1.5.0/src/util-strings.c:185:19: return_function: returning to ‘strreplace’ from ‘xalloc’
libei-1.5.0/src/util-strings.c:188:16: branch_true: following ‘true’ branch (when ‘next’ is non-NULL)...
libei-1.5.0/src/util-strings.c:189:30: branch_true: ...to here
libei-1.5.0/src/util-strings.c:192:20: branch_false: following ‘false’ branch...
libei-1.5.0/src/util-strings.c:196:17: branch_false: ...to here
libei-1.5.0/src/util-strings.c:198:20: branch_false: following ‘false’ branch...
libei-1.5.0/src/util-strings.c:200:17: branch_false: ...to here
libei-1.5.0/src/util-strings.c:204:20: branch_false: following ‘false’ branch...
libei-1.5.0/src/util-strings.c:206:24: branch_false: ...to here
libei-1.5.0/src/util-strings.c:188:16: branch_true: following ‘true’ branch (when ‘next’ is non-NULL)...
libei-1.5.0/src/util-strings.c:189:30: branch_true: ...to here
libei-1.5.0/src/util-strings.c:192:20: branch_false: following ‘false’ branch...
libei-1.5.0/src/util-strings.c:196:17: branch_false: ...to here
libei-1.5.0/src/util-strings.c:198:20: branch_true: following ‘true’ branch...
libei-1.5.0/src/util-strings.c:210:22: branch_true: ...to here
libei-1.5.0/src/util-strings.c:213:12: branch_false: following ‘false’ branch...
libei-1.5.0/src/util-strings.c:218:32: branch_false: ...to here
libei-1.5.0/src/util-strings.c:189:30: danger: ‘xalloc(max + 1)’ leaks here; was allocated at [(13)](sarif:/runs/0/results/1/codeFlows/0/threadFlows/0/locations/12)
#  187|   
#  188|   	while (next) {
#  189|-> 		size_t len = next - current;
#  190|   		/* silently truncate because we really don't care about this
#  191|   		 * case */

Scan Properties