Task #131194 - fixed.err

back to task #131194
download
Error: GCC_ANALYZER_WARNING (CWE-457):
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:463:12: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘keyPair’
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:440:8: branch_false: following ‘false’ branch (when ‘size != 44’)...
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:443:15: branch_false: ...to here
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:443:15: branch_false: following ‘false’ branch (when ‘size != 65’)...
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:446:15: branch_false: ...to here
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:446:15: branch_false: following ‘false’ branch (when ‘size != 87’)...
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:450:9: branch_false: ...to here
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:463:12: danger: use of uninitialized value ‘keyPair’ here
#  461|   
#  462|   finish:
#  463|->     return keyPair;
#  464|   #else
#  465|       return NULL;

Error: COMPILER_WARNING (CWE-457):
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c: scope_hint: In function ‘Java_org_mozilla_jss_pkcs11_PK11KeyPairGenerator_generateMLDSAKeyPair’
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:463:12: warning[-Wmaybe-uninitialized]: ‘keyPair’ may be used uninitialized
#  463 |     return keyPair;
#      |            ^~~~~~~
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:454:13: note: ‘keyPair’ was declared here
#  454 |     jobject keyPair=NULL;
#      |             ^~~~~~~
#  461|   
#  462|   finish:
#  463|->     return keyPair;
#  464|   #else
#  465|       return NULL;

Error: GCC_ANALYZER_WARNING (CWE-457):
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:507:12: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘keyPair’
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:482:8: branch_false: following ‘false’ branch (when ‘size != 44’)...
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:485:15: branch_false: ...to here
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:485:15: branch_false: following ‘false’ branch (when ‘size != 65’)...
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:488:15: branch_false: ...to here
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:488:15: branch_false: following ‘false’ branch (when ‘size != 87’)...
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:492:9: branch_false: ...to here
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:507:12: danger: use of uninitialized value ‘keyPair’ here
#  505|   
#  506|   finish:
#  507|->     return keyPair;
#  508|   #else
#  509|       return NULL;

Error: COMPILER_WARNING (CWE-457):
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c: scope_hint: In function ‘Java_org_mozilla_jss_pkcs11_PK11KeyPairGenerator_generateMLDSAKeyPairWithOpFlags’
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:507:12: warning[-Wmaybe-uninitialized]: ‘keyPair’ may be used uninitialized
#  507 |     return keyPair;
#      |            ^~~~~~~
jss-5.9.0/native/src/main/native/org/mozilla/jss/pkcs11/PK11KeyPairGenerator.c:496:13: note: ‘keyPair’ was declared here
#  496 |     jobject keyPair=NULL;
#      |             ^~~~~~~
cc1: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
#  505|   
#  506|   finish:
#  507|->     return keyPair;
#  508|   #else
#  509|       return NULL;

Error: COMPILER_WARNING (CWE-674):
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SessionKey.cpp: scope_hint: In function ‘JSS_PK11_wrapSymKey(JNIEnv_*, PK11SymKeyStr**)’
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SessionKey.cpp:120:1: warning[-Winfinite-recursion]: infinite recursion detected
#  120 | JSS_PK11_wrapSymKey(JNIEnv *env, PK11SymKey **symKey)
#      | ^~~~~~~~~~~~~~~~~~~
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SessionKey.cpp:124:31: note: recursive call
#  124 |     return JSS_PK11_wrapSymKey(env, symKey);
#      |            ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
#  118|    */
#  119|   jobject
#  120|-> JSS_PK11_wrapSymKey(JNIEnv *env, PK11SymKey **symKey)
#  121|   {
#  122|   //    return JSS_PK11_wrapSymKey(env, symKey, NULL);

Error: COMPILER_WARNING:
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SessionKey.cpp: scope_hint: In function ‘Java_org_mozilla_jss_symkey_SessionKey_ComputeSessionKeySCP02’
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SessionKey.cpp:857:16: warning[-Wstringop-truncation]: ‘strncpy’ specified bound 135 equals destination size
#  857 |         strncpy(keyname,keyNameChars,KEYNAMELENGTH);
#      |                ^
#  855|       {
#  856|           keyNameChars = (char *)(env)->GetStringUTFChars(keyName, NULL);
#  857|->         strncpy(keyname,keyNameChars,KEYNAMELENGTH);
#  858|           (env)->ReleaseStringUTFChars(keyName, (const char *)keyNameChars);
#  859|       }else

Error: COMPILER_WARNING:
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SessionKey.cpp: scope_hint: In function ‘Java_org_mozilla_jss_symkey_SessionKey_ComputeSessionKey’
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SessionKey.cpp:1317:16: warning[-Wstringop-truncation]: ‘strncpy’ specified bound 135 equals destination size
# 1317 |         strncpy(keyname,keyNameChars,KEYNAMELENGTH);
#      |                ^
# 1315|       {
# 1316|           keyNameChars = (char *)(env)->GetStringUTFChars(keyName, NULL);
# 1317|->         strncpy(keyname,keyNameChars,KEYNAMELENGTH);
# 1318|           (env)->ReleaseStringUTFChars(keyName, (const char *)keyNameChars);
# 1319|       }else

Error: COMPILER_WARNING:
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SessionKey.cpp: scope_hint: In function ‘Java_org_mozilla_jss_symkey_SessionKey_ComputeEncSessionKey’
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SessionKey.cpp:1718:16: warning[-Wstringop-truncation]: ‘strncpy’ specified bound 135 equals destination size
# 1718 |         strncpy(keyname,keyNameChars,KEYNAMELENGTH);
#      |                ^
# 1716|       {
# 1717|           keyNameChars = (char *)(env)->GetStringUTFChars(keyName, NULL);
# 1718|->         strncpy(keyname,keyNameChars,KEYNAMELENGTH);
# 1719|           (env)->ReleaseStringUTFChars(keyName, (const char *)keyNameChars);
# 1720|       }

Error: COMPILER_WARNING:
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SymKey.cpp: scope_hint: In function ‘_jstring* Java_org_mozilla_jss_symkey_SessionKey_DeleteKey(JNIEnv*, jclass, jstring, jstring)’
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SymKey.cpp:298:17: warning[-Wunused-but-set-variable=]: variable ‘count’ set but not used
#  298 |     int         count        = 0;
#      |                 ^~~~~
#  296|       char *tokenNameChars;
#  297|       char *keyNameChars;
#  298|->     int         count        = 0;
#  299|       int         keys_deleted = 0;
#  300|       PK11SymKey *symKey       = NULL;

Error: COMPILER_WARNING:
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SymKey.cpp: scope_hint: In function ‘_jstring* Java_org_mozilla_jss_symkey_SessionKey_ListSymmetricKeys(JNIEnv*, jclass, jstring)’
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SymKey.cpp:427:14: warning[-Wunused-but-set-variable=]: variable ‘count’ set but not used
#  427 |         int  count = 0;
#      |              ^~~~~
#  425|       while (symKey != NULL)
#  426|       {
#  427|->         int  count = 0;
#  428|           char *name = NULL;
#  429|           char *temp = NULL;

Error: COMPILER_WARNING:
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SymKey.cpp: scope_hint: In function ‘GetSharedSecretKeyName(char*)’
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SymKey.cpp:1087:19: warning[-Wstringop-truncation]: ‘strncpy’ specified bound 135 equals destination size
# 1087 |            strncpy( sharedSecretSymKeyName, newKeyName, KEYNAMELENGTH);
#      |                   ^
# 1085|       if ( newKeyName && strlen( newKeyName ) > 0 ) {
# 1086|          if( strlen( sharedSecretSymKeyName) == 0) {
# 1087|->            strncpy( sharedSecretSymKeyName, newKeyName, KEYNAMELENGTH);
# 1088|          }
# 1089|       }

Error: COMPILER_WARNING (CWE-697):
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SymKey.cpp: scope_hint: In function ‘_jbyteArray* Java_org_mozilla_jss_symkey_SessionKey_DiversifyKey(JNIEnv*, jclass, jstring, jstring, jstring, jstring, jbyteArray, jbyteArray, jbyte, jboolean, jbyteArray, jbyteArray, jbyteArray, jstring, jstring, jbyte)’
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SymKey.cpp:1457:30: warning[-Waddress]: the address of ‘fullNewMasterKeyName’ will never be NULL
# 1457 |     if (fullNewMasterKeyName != NULL && strcmp(fullNewMasterKeyName, "#01#01") == 0)
#      |                              ^
jss-5.9.0/symkey/src/main/native/org/mozilla/jss/symkey/SymKey.cpp:1133:10: note: ‘fullNewMasterKeyName’ declared here
# 1133 |     char fullNewMasterKeyName[KEYNAMELENGTH];
#      |          ^~~~~~~~~~~~~~~~~~~~
# 1455|   
# 1456|       /* special case #01#01 */
# 1457|->     if (fullNewMasterKeyName != NULL && strcmp(fullNewMasterKeyName, "#01#01") == 0)
# 1458|       {
# 1459|           Buffer empty = Buffer();

Error: COMPILER_WARNING:
jss-5.9.0/tools/src/main/native/p7tool/p7tool.c: scope_hint: In function ‘DecodeAndPrintFile’
jss-5.9.0/tools/src/main/native/p7tool/p7tool.c:261:17: warning[-Wunused-but-set-variable=]: variable ‘nb’ set but not used
#  261 |             int nb = 0;
#      |                 ^~
#  259|               FILE *outFile;
#  260|               char filename[256];
#  261|->             int nb = 0;
#  262|   
#  263|               sprintf(filename, "%s%d.der", prefix, i);

Error: COMPILER_WARNING (CWE-704):
jss-5.9.0/tools/src/main/native/p7tool/p7tool.c: scope_hint: In function ‘main’
jss-5.9.0/tools/src/main/native/p7tool/p7tool.c:341:16: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  341 |         prefix = optstate->value;
#      |                ^
#  339|   
#  340|         case 'p':
#  341|->         prefix = optstate->value;
#  342|           break;
#  343|   

Error: COMPILER_WARNING (CWE-704):
jss-5.9.0/tools/src/main/native/p7tool/p7tool.c:341:16: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  339|   
#  340|         case 'p':
#  341|->         prefix = optstate->value;
#  342|           break;
#  343|   

Error: COMPILER_WARNING (CWE-252):
jss-5.9.0/tools/src/main/native/p7tool/secpwd.c: scope_hint: In function ‘SEC_GetPassword’
jss-5.9.0/tools/src/main/native/p7tool/secpwd.c:69:21: warning[-Wunused-result]: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’
#   69 | #define QUIET_FGETS fgets
#      |                     ^
jss-5.9.0/tools/src/main/native/p7tool/secpwd.c:117:9: note: in expansion of macro ‘QUIET_FGETS’
#  117 |         QUIET_FGETS ( phrase, sizeof(phrase), input);
#      |         ^~~~~~~~~~~
#   67|   static char * quiet_fgets (char *buf, int length, FILE *input);
#   68|   #else
#   69|-> #define QUIET_FGETS fgets
#   70|   #endif
#   71|   

Error: COMPILER_WARNING:
jss-5.9.0/tools/src/main/native/p7tool/secutil.c: scope_hint: In function ‘SECU_ChangePW’
jss-5.9.0/tools/src/main/native/p7tool/secutil.c:378:15: warning[-Wunused-but-set-variable=]: variable ‘rv’ set but not used
#  378 |     SECStatus rv;
#      |               ^~
#  376|   SECU_ChangePW(PK11SlotInfo *slot, char *passwd, char *pwFile)
#  377|   {
#  378|->     SECStatus rv;
#  379|       secuPWData pwdata, newpwdata;
#  380|       char *oldpw = NULL, *newpw = NULL;

Error: COMPILER_WARNING (CWE-477):
jss-5.9.0/tools/src/main/native/p7tool/secutil.c: scope_hint: In function ‘printflags’
jss-5.9.0/tools/src/main/native/p7tool/secutil.c:2153:5: warning[-Wdeprecated-declarations]: ‘__CERTDB_VALID_PEER’ is deprecated: CERTDB_VALID_PEER is now CERTDB_TERMINAL_RECORD
# 2153 |     if (flags & CERTDB_VALID_PEER)
#      |     ^~
# 2151|   	    !(flags & CERTDB_TRUSTED_CLIENT_CA))
# 2152|   	    PORT_Strcat(trusts, "c");
# 2153|->     if (flags & CERTDB_VALID_PEER)
# 2154|   	if (!(flags & CERTDB_TRUSTED))
# 2155|   	    PORT_Strcat(trusts, "p");

Error: COMPILER_WARNING (CWE-477):
jss-5.9.0/tools/src/main/native/p7tool/secutil.c:2153:5: warning[-Wdeprecated-declarations]: ‘__CERTDB_VALID_PEER’ is deprecated: CERTDB_VALID_PEER is now CERTDB_TERMINAL_RECORD
# 2151|   	    !(flags & CERTDB_TRUSTED_CLIENT_CA))
# 2152|   	    PORT_Strcat(trusts, "c");
# 2153|->     if (flags & CERTDB_VALID_PEER)
# 2154|   	if (!(flags & CERTDB_TRUSTED))
# 2155|   	    PORT_Strcat(trusts, "p");

Error: COMPILER_WARNING (CWE-477):
jss-5.9.0/tools/src/main/native/p7tool/secutil.c: scope_hint: In function ‘printFlags’
jss-5.9.0/tools/src/main/native/p7tool/secutil.c:2953:5: warning[-Wdeprecated-declarations]: ‘__CERTDB_VALID_PEER’ is deprecated: CERTDB_VALID_PEER is now CERTDB_TERMINAL_RECORD
# 2953 |     if ( flags & CERTDB_VALID_PEER ) {
#      |     ^~
# 2951|   printFlags(FILE *out, unsigned int flags, int level)
# 2952|   {
# 2953|->     if ( flags & CERTDB_VALID_PEER ) {
# 2954|   	SECU_Indent(out, level); fprintf(out, "Valid Peer\n");
# 2955|       }

Error: COMPILER_WARNING (CWE-477):
jss-5.9.0/tools/src/main/native/p7tool/secutil.c:2953:5: warning[-Wdeprecated-declarations]: ‘__CERTDB_VALID_PEER’ is deprecated: CERTDB_VALID_PEER is now CERTDB_TERMINAL_RECORD
# 2951|   printFlags(FILE *out, unsigned int flags, int level)
# 2952|   {
# 2953|->     if ( flags & CERTDB_VALID_PEER ) {
# 2954|   	SECU_Indent(out, level); fprintf(out, "Valid Peer\n");
# 2955|       }

Error: COMPILER_WARNING (CWE-704):
jss-5.9.0/tools/src/main/native/p7tool/secutil.c: scope_hint: In function ‘SECU_printCertProblems’
jss-5.9.0/tools/src/main/native/p7tool/secutil.c:3291:25: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
# 3291 |                 flags = (unsigned int)node->arg;
#      |                         ^
# 3289|   	    switch (node->error) {
# 3290|   	    case SEC_ERROR_INADEQUATE_KEY_USAGE:
# 3291|-> 		flags = (unsigned int)node->arg;
# 3292|   		switch (flags) {
# 3293|   		case KU_DIGITAL_SIGNATURE:

Error: COMPILER_WARNING (CWE-704):
jss-5.9.0/tools/src/main/native/p7tool/secutil.c:3291:25: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
# 3289|   	    switch (node->error) {
# 3290|   	    case SEC_ERROR_INADEQUATE_KEY_USAGE:
# 3291|-> 		flags = (unsigned int)node->arg;
# 3292|   		switch (flags) {
# 3293|   		case KU_DIGITAL_SIGNATURE:

Error: COMPILER_WARNING (CWE-704):
jss-5.9.0/tools/src/main/native/p7tool/secutil.c:3307:25: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
# 3307 |                 flags = (unsigned int)node->arg;
#      |                         ^
# 3305|   		}
# 3306|   	    case SEC_ERROR_INADEQUATE_CERT_TYPE:
# 3307|-> 		flags = (unsigned int)node->arg;
# 3308|   		switch (flags) {
# 3309|   		case NS_CERT_TYPE_SSL_CLIENT:

Error: COMPILER_WARNING (CWE-704):
jss-5.9.0/tools/src/main/native/p7tool/secutil.c:3307:25: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
# 3305|   		}
# 3306|   	    case SEC_ERROR_INADEQUATE_CERT_TYPE:
# 3307|-> 		flags = (unsigned int)node->arg;
# 3308|   		switch (flags) {
# 3309|   		case NS_CERT_TYPE_SSL_CLIENT:

Error: COMPILER_WARNING (CWE-704):
jss-5.9.0/tools/src/main/native/sslget/sslget.c: scope_hint: In function ‘my_GetClientAuthData’
jss-5.9.0/tools/src/main/native/sslget/sslget.c:218:59: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
#  218 |     FPRINTF(stderr,"   mygetclientauthdata - cert = %x\n",(unsigned int)cert);
#      |                                                           ^
#  216|     if (chosenNickName) {
#  217|       cert = PK11_FindCertFromNickname(chosenNickName, proto_win);
#  218|->     FPRINTF(stderr,"   mygetclientauthdata - cert = %x\n",(unsigned int)cert);
#  219|       if ( cert ) {
#  220|         privkey = PK11_FindKeyByAnyCert(cert, proto_win);

Error: COMPILER_WARNING (CWE-704):
jss-5.9.0/tools/src/main/native/sslget/sslget.c:218:59: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
#  216|     if (chosenNickName) {
#  217|       cert = PK11_FindCertFromNickname(chosenNickName, proto_win);
#  218|->     FPRINTF(stderr,"   mygetclientauthdata - cert = %x\n",(unsigned int)cert);
#  219|       if ( cert ) {
#  220|         privkey = PK11_FindKeyByAnyCert(cert, proto_win);

Error: COMPILER_WARNING (CWE-704):
jss-5.9.0/tools/src/main/native/sslget/sslget.c:221:64: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
#  221 |       FPRINTF(stderr,"   mygetclientauthdata - privkey = %x\n",(unsigned int)privkey);
#      |                                                                ^
#  219|       if ( cert ) {
#  220|         privkey = PK11_FindKeyByAnyCert(cert, proto_win);
#  221|->       FPRINTF(stderr,"   mygetclientauthdata - privkey = %x\n",(unsigned int)privkey);
#  222|         if ( privkey ) {
#  223|       rv = SECSuccess;

Error: COMPILER_WARNING (CWE-704):
jss-5.9.0/tools/src/main/native/sslget/sslget.c:221:64: warning[-Wpointer-to-int-cast]: cast from pointer to integer of different size
#  219|       if ( cert ) {
#  220|         privkey = PK11_FindKeyByAnyCert(cert, proto_win);
#  221|->       FPRINTF(stderr,"   mygetclientauthdata - privkey = %x\n",(unsigned int)privkey);
#  222|         if ( privkey ) {
#  223|       rv = SECSuccess;

Error: COMPILER_WARNING:
jss-5.9.0/tools/src/main/native/sslget/sslget.c: scope_hint: In function ‘do_connect’
jss-5.9.0/tools/src/main/native/sslget/sslget.c:485:25: warning[-Wunused-but-set-variable=]: variable ‘result’ set but not used
#  485 |     SECStatus           result;
#      |                         ^~~~~~
#  483|       PRFileDesc *        tcp_sock;
#  484|       PRStatus            prStatus;
#  485|->     SECStatus           result;
#  486|       int                 rv = SECSuccess;
#  487|       PRSocketOptionData  opt;

Error: COMPILER_WARNING (CWE-1164):
jss-5.9.0/tools/src/main/native/sslget/sslget.c: scope_hint: At top level
jss-5.9.0/tools/src/main/native/sslget/sslget.c:548:1: warning[-Wunused-function]: ‘getIPAddress’ defined but not used
#  548 | getIPAddress(const char * hostName)
#      | ^~~~~~~~~~~~
#  546|   */
#  547|   static PRUint32
#  548|-> getIPAddress(const char * hostName) 
#  549|   {
#  550|       const unsigned char *p;