Newly introduced findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-477): [#def1]
/usr/bin/iscsi-gen-initiatorname:137:23: warning[SC2166]: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
#  135|   
#  136|   # if we have a local initiator name and "force" is not set end it now
#  137|-> if [ "$InitiatorName" -a -z "$FORCE" ] ; then
#  138|       echo "Error: you cannot overwrite the current InitiatorName unless 'force' is set." 1>&2
#  139|       usage_and_exit 1

Error: SHELLCHECK_WARNING (CWE-477): [#def2]
/usr/bin/iscsi-gen-initiatorname:158:20: warning[SC2166]: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
#  156|   # if we have both iBFT and kernel command line initiator names that
#  157|   # do not match end it now
#  158|-> if [ "$IBFT_INAME" -a "$KERNEL_INAME" -a "$IBFT_INAME" != "$KERNEL_INAME" ] ; then
#  159|       echo "Error: Kernel cmdline Initiator Name: $KERNEL_INAME" 1>&2
#  160|       echo "  does not match iBFT Initiator Name: $IBFT_INAME" 1>&2

Error: SHELLCHECK_WARNING (CWE-477): [#def3]
/usr/bin/iscsi-gen-initiatorname:158:39: warning[SC2166]: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
#  156|   # if we have both iBFT and kernel command line initiator names that
#  157|   # do not match end it now
#  158|-> if [ "$IBFT_INAME" -a "$KERNEL_INAME" -a "$IBFT_INAME" != "$KERNEL_INAME" ] ; then
#  159|       echo "Error: Kernel cmdline Initiator Name: $KERNEL_INAME" 1>&2
#  160|       echo "  does not match iBFT Initiator Name: $IBFT_INAME" 1>&2

Error: COMPILER_WARNING (CWE-704): [#def4]
open-iscsi-7e00642c40123e0b3f949e74c3945872c17a407e/usr/initiator_common.c: scope_hint: In function ‘iqn_name_valid’
open-iscsi-7e00642c40123e0b3f949e74c3945872c17a407e/usr/initiator_common.c:771:17: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  771 |         for (cp = name; *cp != '\0'; cp++)
#      |                 ^
#  769|   
#  770|   	/* ensure no invalid characters */
#  771|-> 	for (cp = name; *cp != '\0'; cp++)
#  772|   		if ((*cp <= '\x2c') ||
#  773|   		    (*cp == '\x2f') ||

Error: COMPILER_WARNING (CWE-704): [#def5]
open-iscsi-7e00642c40123e0b3f949e74c3945872c17a407e/usr/initiator_common.c:771:17: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  769|   
#  770|   	/* ensure no invalid characters */
#  771|-> 	for (cp = name; *cp != '\0'; cp++)
#  772|   		if ((*cp <= '\x2c') ||
#  773|   		    (*cp == '\x2f') ||

Scan Properties