Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-477): [#def1]
gnome-software-50.0/lib/gs-appstream.c: scope_hint: In function ‘gs_appstream_do_search’
gnome-software-50.0/lib/gs-appstream.c:1773:9: warning[-Wdeprecated-declarations]: ‘xb_silo_lookup_query’ is deprecated: Use 'xb_silo_lookup_query_full' instead
# 1773 |         extends_query = xb_silo_lookup_query (silo, "extends");
#      |         ^~~~~~~~~~~~~
/usr/include/libxmlb-2/libxmlb/xb-builder.h:13: included_from: Included from here.
/usr/include/libxmlb-2/xmlb.h:15: included_from: Included from here.
gnome-software-50.0/lib/gs-silo-wrapper.h:13: included_from: Included from here.
gnome-software-50.0/lib/gnome-software.h:54: included_from: Included from here.
gnome-software-50.0/lib/gs-appstream.c:14: included_from: Included from here.
/usr/include/libxmlb-2/libxmlb/xb-silo.h:115:1: note: declared here
#  115 | xb_silo_lookup_query(XbSilo *self, const gchar *xpath) G_GNUC_NON_NULL(1, 2);
#      | ^~~~~~~~~~~~~~~~~~~~
# 1771|   		gs_appstream_read_silo_info_from_component (g_ptr_array_index (components, 0), &silo_filename, &default_scope);
# 1772|   
# 1773|-> 	extends_query = xb_silo_lookup_query (silo, "extends");
# 1774|   
# 1775|   	for (guint i = 0; i < components->len; i++) {

Error: COMPILER_WARNING (CWE-477): [#def2]
gnome-software-50.0/lib/gs-appstream.c:1773:9: warning[-Wdeprecated-declarations]: ‘xb_silo_lookup_query’ is deprecated: Use 'xb_silo_lookup_query_full' instead
# 1771|   		gs_appstream_read_silo_info_from_component (g_ptr_array_index (components, 0), &silo_filename, &default_scope);
# 1772|   
# 1773|-> 	extends_query = xb_silo_lookup_query (silo, "extends");
# 1774|   
# 1775|   	for (guint i = 0; i < components->len; i++) {

Error: COMPILER_WARNING (CWE-704): [#def3]
gnome-software-50.0/plugins/fedora-langpacks/gs-plugin-fedora-langpacks.c: scope_hint: In function ‘find_langpack’
gnome-software-50.0/plugins/fedora-langpacks/gs-plugin-fedora-langpacks.c:89:19: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#   89 |         separator = strpbrk (locale, ".@");
#      |                   ^
#   87|   	 * Get the locale without codeset and modifier as required for langpacks.
#   88|   	 */
#   89|-> 	separator = strpbrk (locale, ".@");
#   90|   	if (separator != NULL)
#   91|   		*separator = '\0';

Error: COMPILER_WARNING (CWE-704): [#def4]
gnome-software-50.0/plugins/fedora-langpacks/gs-plugin-fedora-langpacks.c:89:19: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#   87|   	 * Get the locale without codeset and modifier as required for langpacks.
#   88|   	 */
#   89|-> 	separator = strpbrk (locale, ".@");
#   90|   	if (separator != NULL)
#   91|   		*separator = '\0';

Error: COMPILER_WARNING (CWE-477): [#def5]
gnome-software-50.0/plugins/flatpak/gs-flatpak.c: scope_hint: In function ‘get_renamed_component’
gnome-software-50.0/plugins/flatpak/gs-flatpak.c:3349:9: warning[-Wdeprecated-declarations]: ‘xb_silo_lookup_query’ is deprecated: Use 'xb_silo_lookup_query_full' instead
# 3349 |         query = xb_silo_lookup_query (silo, "components[@origin=?]/component/bundle[@type='flatpak'][text()=?]/..");
#      |         ^~~~~
/usr/include/libxmlb-2/libxmlb/xb-builder.h:13: included_from: Included from here.
/usr/include/libxmlb-2/xmlb.h:15: included_from: Included from here.
gnome-software-50.0/plugins/flatpak/gs-flatpak.c:38: included_from: Included from here.
/usr/include/libxmlb-2/libxmlb/xb-silo.h:115:1: note: declared here
#  115 | xb_silo_lookup_query(XbSilo *self, const gchar *xpath) G_GNUC_NON_NULL(1, 2);
#      | ^~~~~~~~~~~~~~~~~~~~
# 3347|   		return NULL;
# 3348|   
# 3349|-> 	query = xb_silo_lookup_query (silo, "components[@origin=?]/component/bundle[@type='flatpak'][text()=?]/..");
# 3350|   	xb_value_bindings_bind_str (xb_query_context_get_bindings (&context), 0, origin, NULL);
# 3351|   	xb_value_bindings_bind_str (xb_query_context_get_bindings (&context), 1, renamed_to, NULL);

Error: COMPILER_WARNING (CWE-477): [#def6]
gnome-software-50.0/plugins/flatpak/gs-flatpak.c:3349:9: warning[-Wdeprecated-declarations]: ‘xb_silo_lookup_query’ is deprecated: Use 'xb_silo_lookup_query_full' instead
# 3347|   		return NULL;
# 3348|   
# 3349|-> 	query = xb_silo_lookup_query (silo, "components[@origin=?]/component/bundle[@type='flatpak'][text()=?]/..");
# 3350|   	xb_value_bindings_bind_str (xb_query_context_get_bindings (&context), 0, origin, NULL);
# 3351|   	xb_value_bindings_bind_str (xb_query_context_get_bindings (&context), 1, renamed_to, NULL);

Error: COMPILER_WARNING (CWE-704): [#def7]
gnome-software-50.0/plugins/packagekit/gs-markdown.c: scope_hint: In function ‘gs_markdown_strstr_spaces’
gnome-software-50.0/plugins/packagekit/gs-markdown.c:274:15: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  274 |         found = strstr (haystack_new, needle);
#      |               ^
#  272|   retry:
#  273|   	/* don't find if surrounded by spaces */
#  274|-> 	found = strstr (haystack_new, needle);
#  275|   	if (found == NULL)
#  276|   		return NULL;

Error: COMPILER_WARNING (CWE-704): [#def8]
gnome-software-50.0/plugins/packagekit/gs-markdown.c:274:15: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  272|   retry:
#  273|   	/* don't find if surrounded by spaces */
#  274|-> 	found = strstr (haystack_new, needle);
#  275|   	if (found == NULL)
#  276|   		return NULL;

Error: COMPILER_WARNING (CWE-704): [#def9]
gnome-software-50.0/plugins/packagekit/gs-markdown.c: scope_hint: In function ‘gs_markdown_to_text_line_format’
gnome-software-50.0/plugins/packagekit/gs-markdown.c:398:14: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  398 |         text = strstr (line, "`");
#      |              ^
#  396|   
#  397|   	/* optimise the trivial case where we don't have any code tags */
#  398|-> 	text = strstr (line, "`");
#  399|   	if (text == NULL)
#  400|   		return gs_markdown_to_text_line_format_sections (self, line);

Error: COMPILER_WARNING (CWE-704): [#def10]
gnome-software-50.0/plugins/packagekit/gs-markdown.c:398:14: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  396|   
#  397|   	/* optimise the trivial case where we don't have any code tags */
#  398|-> 	text = strstr (line, "`");
#  399|   	if (text == NULL)
#  400|   		return gs_markdown_to_text_line_format_sections (self, line);

Error: COMPILER_WARNING (CWE-704): [#def11]
gnome-software-50.0/plugins/rpm-ostree/gs-rpm-ostree-utils.c: scope_hint: In function ‘split_changelogs’
gnome-software-50.0/plugins/rpm-ostree/gs-rpm-ostree-utils.c:260:56: warning[-Wdiscarded-qualifiers]: initialization discards ‘const’ qualifier from pointer target type
#  260 |                                         gchar *space = strchr (package_line, ' ');
#      |                                                        ^~~~~~
#  258|   				if (app == NULL) {
#  259|   					/* it should look like 'name version_from -> version_to'*/
#  260|-> 					gchar *space = strchr (package_line, ' ');
#  261|   					if (space != NULL)
#  262|   						*space = '\0';

Error: COMPILER_WARNING (CWE-704): [#def12]
gnome-software-50.0/plugins/rpm-ostree/gs-rpm-ostree-utils.c:260:56: warning[-Wdiscarded-qualifiers]: initialization discards ‘const’ qualifier from pointer target type
#  258|   				if (app == NULL) {
#  259|   					/* it should look like 'name version_from -> version_to'*/
#  260|-> 					gchar *space = strchr (package_line, ' ');
#  261|   					if (space != NULL)
#  262|   						*space = '\0';

Error: COMPILER_WARNING (CWE-704): [#def13]
gnome-software-50.0/plugins/rpm-ostree/gs-rpm-ostree-utils.c:304:48: warning[-Wdiscarded-qualifiers]: initialization discards ‘const’ qualifier from pointer target type
#  304 |                                 gchar *space = strchr (package_line, ' ');
#      |                                                ^~~~~~
#  302|   			} else if (state == GS_APP_STATE_UPDATABLE_LIVE) {
#  303|   				/* it should look like 'name version_from -> version_to'*/
#  304|-> 				gchar *space = strchr (package_line, ' ');
#  305|   				if (space != NULL) {
#  306|   					gchar *tmp;

Error: COMPILER_WARNING (CWE-704): [#def14]
gnome-software-50.0/plugins/rpm-ostree/gs-rpm-ostree-utils.c:304:48: warning[-Wdiscarded-qualifiers]: initialization discards ‘const’ qualifier from pointer target type
#  302|   			} else if (state == GS_APP_STATE_UPDATABLE_LIVE) {
#  303|   				/* it should look like 'name version_from -> version_to'*/
#  304|-> 				gchar *space = strchr (package_line, ' ');
#  305|   				if (space != NULL) {
#  306|   					gchar *tmp;

Scan Properties

analyzer-version-clippy1.97.1
analyzer-version-cppcheck2.21.1
analyzer-version-gcc16.1.1
analyzer-version-gcc-analyzer16.1.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.97.1
diffbase-analyzer-version-cppcheck2.21.1
diffbase-analyzer-version-gcc16.1.1
diffbase-analyzer-version-gcc-analyzer16.1.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-245.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namegnome-software-51~beta-1.fc45
diffbase-store-results-to/tmp/tmp6nv6x3em/gnome-software-51~beta-1.fc45.tar.xz
diffbase-time-created2026-08-03 14:43:21
diffbase-time-finished2026-08-03 14:51:09
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,clippy,unicontrol,shellcheck,cppcheck' '-o' '/tmp/tmp6nv6x3em/gnome-software-51~beta-1.fc45.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmp6nv6x3em/gnome-software-51~beta-1.fc45.src.rpm'
diffbase-tool-versioncsmock-3.8.7.HEAD-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-245.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namegnome-software-50.0-2.fc44
store-results-to/tmp/tmpagy6umun/gnome-software-50.0-2.fc44.tar.xz
time-created2026-08-03 14:35:20
time-finished2026-08-03 14:43:08
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,clippy,unicontrol,shellcheck,cppcheck' '-o' '/tmp/tmpagy6umun/gnome-software-50.0-2.fc44.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpagy6umun/gnome-software-50.0-2.fc44.src.rpm'
tool-versioncsmock-3.8.7.HEAD-1.el9