Fixed findings

List of Findings

Error: SHELLCHECK_WARNING: [#def1]
/usr/bin/e2scrub:185:35: warning[SC2319]: This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten.
#  183|   	# Remove and wait for removal to succeed.
#  184|   	${DBG} lvremove -f "${LVM2_VG_NAME}/${snap}"
#  185|-> 	while [ -e "${snap_dev}" ] && [ "$?" -eq "5" ]; do
#  186|   		sleep 0.5
#  187|   		${DBG} lvremove -f "${LVM2_VG_NAME}/${snap}"

Error: SHELLCHECK_WARNING: [#def2]
/usr/bin/e2scrub:213:35: warning[SC2319]: This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten.
#  211|   	lvremove_deadline="$(( $(date "+%s") + 30))"
#  212|   	${DBG} lvremove -f "${LVM2_VG_NAME}/${snap}" 2>/dev/null
#  213|-> 	while [ -e "${snap_dev}" ] && [ "$?" -eq "5" ] &&
#  214|   	      [ "$(date "+%s")" -lt "${lvremove_deadline}" ]; do
#  215|   		sleep 0.5

Scan Properties

analyzer-version-clippy1.97.1
analyzer-version-cppcheck2.21.1
analyzer-version-gcc16.1.1
analyzer-version-gcc-analyzer16.1.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.97.1
diffbase-analyzer-version-cppcheck2.21.1
diffbase-analyzer-version-gcc16.1.1
diffbase-analyzer-version-gcc-analyzer16.1.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-198.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namee2fsprogs-1.47.4-2.fc45
diffbase-store-results-to/tmp/tmpzdt6klzi/e2fsprogs-1.47.4-2.fc45.tar.xz
diffbase-time-created2026-08-03 13:57:54
diffbase-time-finished2026-08-03 14:00:25
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,clippy,unicontrol,shellcheck,cppcheck' '-o' '/tmp/tmpzdt6klzi/e2fsprogs-1.47.4-2.fc45.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpzdt6klzi/e2fsprogs-1.47.4-2.fc45.src.rpm'
diffbase-tool-versioncsmock-3.8.7.HEAD-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-198.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namee2fsprogs-1.47.3-4.fc44
store-results-to/tmp/tmp966crtck/e2fsprogs-1.47.3-4.fc44.tar.xz
time-created2026-08-03 13:54:08
time-finished2026-08-03 13:57:32
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'gcc,clippy,unicontrol,shellcheck,cppcheck' '-o' '/tmp/tmp966crtck/e2fsprogs-1.47.3-4.fc44.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmp966crtck/e2fsprogs-1.47.3-4.fc44.src.rpm'
tool-versioncsmock-3.8.7.HEAD-1.el9