Newly introduced findings

List of Findings

Error: COMPILER_WARNING (CWE-195): [#def1]
LibRaw-0.22.2/src/decoders/fp_dng.cpp: scope_hint: In member function 'void LibRaw::convertFloatToInt(float, float, float)'
LibRaw-0.22.2/src/decoders/fp_dng.cpp:560:24: warning[-Wsign-compare]: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'INT64' {aka 'long long int'}
#  560 |   for (size_t i = 0; i < pixcnt; ++i)
#      |                      ~~^~~~~~~~
#  558|       imgdata.rawdata.color.fnorm = imgdata.color.fnorm = 0.f;
#  559|   
#  560|->   for (size_t i = 0; i < pixcnt; ++i)
#  561|     {
#  562|       float val = MAX(data[i], 0.f);

Error: COMPILER_WARNING (CWE-195): [#def2]
LibRaw-0.22.2/src/decoders/unpack_thumb.cpp: scope_hint: In member function 'int LibRaw::unpack_thumb()'
LibRaw-0.22.2/src/decoders/unpack_thumb.cpp:70:27: warning[-Wsign-compare]: comparison of integer expressions of different signedness: 'INT64' {aka 'long long int'} and 'long long unsigned int'
#   70 |     if (INT64(W)*INT64(H) > 1024ULL * 1024ULL * LIBRAW_MAX_THUMBNAIL_MB) return LIBRAW_UNSUPPORTED_THUMBNAIL; \
LibRaw-0.22.2/src/decoders/unpack_thumb.cpp:383:17: note: in expansion of macro 'THUMB_SIZE_CHECKWH'
#  383 |                 THUMB_SIZE_CHECKWH(T.twidth, (INT64(T.theight)*INT64(o_bps)));
#      |                 ^~~~~~~~~~~~~~~~~~
#   68|   #define THUMB_SIZE_CHECKWH(W,H) \

#   69|     do { \

#   70|->     if (INT64(W)*INT64(H) > 1024ULL * 1024ULL * LIBRAW_MAX_THUMBNAIL_MB) return LIBRAW_UNSUPPORTED_THUMBNAIL; \

#   71|       if (INT64(W)*INT64(H) < 64ULL)        return LIBRAW_NO_THUMBNAIL; \

#   72|     } while (0)


Error: COMPILER_WARNING (CWE-195): [#def3]
LibRaw-0.22.2/src/decoders/unpack_thumb.cpp:71:27: warning[-Wsign-compare]: comparison of integer expressions of different signedness: 'INT64' {aka 'long long int'} and 'long long unsigned int'
#   71 |     if (INT64(W)*INT64(H) < 64ULL)        return LIBRAW_NO_THUMBNAIL; \
#      |         ~~~~~~~~~~~~~~~~~~^~~~~~~
LibRaw-0.22.2/src/decoders/unpack_thumb.cpp:383:17: note: in expansion of macro 'THUMB_SIZE_CHECKWH'
#  383 |                 THUMB_SIZE_CHECKWH(T.twidth, (INT64(T.theight)*INT64(o_bps)));
#      |                 ^~~~~~~~~~~~~~~~~~
#   69|     do { \

#   70|       if (INT64(W)*INT64(H) > 1024ULL * 1024ULL * LIBRAW_MAX_THUMBNAIL_MB) return LIBRAW_UNSUPPORTED_THUMBNAIL; \

#   71|->     if (INT64(W)*INT64(H) < 64ULL)        return LIBRAW_NO_THUMBNAIL; \

#   72|     } while (0)

#   73|   


Error: COMPILER_WARNING (CWE-195): [#def4]
LibRaw-0.22.2/src/metadata/sony.cpp: scope_hint: In member function 'void LibRaw::parseSonySRF(unsigned int)'
LibRaw-0.22.2/src/metadata/sony.cpp:2339:27: warning[-Wsign-compare]: comparison of integer expressions of different signedness: 'int' and 'unsigned int'
# 2339 |           if (ioffset + 3 >= len)
#      |               ~~~~~~~~~~~~^~~~~~
# 2337|   	  int ioffset = int(offset);
# 2338|   	  
# 2339|-> 	  if (ioffset + 3 >= len)
# 2340|           goto restore_after_parseSonySRF;
# 2341|         /* master key is stored in big endian */

Error: COMPILER_WARNING (CWE-457): [#def5]
LibRaw-0.22.2/src/postprocessing/postprocessing_aux.cpp: scope_hint: In member function 'LibRaw::wavelet_denoise()'
LibRaw-0.22.2/src/postprocessing/postprocessing_aux.cpp:150:32: warning[-Wmaybe-uninitialized]: 'size' may be used uninitialized
#  150 |   fimg = (float *)malloc((size * 3 + iheight + iwidth) * sizeof *fimg);
#      |                           ~~~~~^~~
LibRaw-0.22.2/src/postprocessing/postprocessing_aux.cpp:135:18: note: 'size' was declared here
#  135 |   int scale = 1, size, lev, hpass, lpass, row, col, nc, c, i, wlast, blk[2];
#      |                  ^~~~
#  148|     black <<= scale;
#  149|     FORC4 cblack[c] <<= scale;
#  150|->   fimg = (float *)malloc((size * 3 + iheight + iwidth) * sizeof *fimg);
#  151|     temp = fimg + size * 3;
#  152|     if ((nc = colors) == 3 && filters)

Scan Properties