Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/lib/src/deploy.rs:781:9: warning: unnecessary use of `to_string`
#      |
#  781 |         &pull_result.manifest_digest.to_string(),
#      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_to_owned

Error: CLIPPY_WARNING: [#def2]
crates/lib/src/image.rs:200:14: warning: this `.filter_map(..)` can be written more simply using `.map(..)`
#      |
#  200 |               .filter_map(|(tag, manifest_digest)| {
#      |  ______________^
#  201 | |                 // Derive a human-readable name from the OCI config label, just
#  202 | |                 // like inspect_unified_storage does.  Fall back to the tag.
#  203 | |                 let display_name =
#  ...   |
#  216 | |                 })
#  217 | |             })
#      | |______________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_filter_map
#      = note: `#[warn(clippy::unnecessary_filter_map)]` on by default

Error: CLIPPY_WARNING: [#def3]
crates/lib/src/image.rs:991:30: warning: manual implementation of `ok`
#      |
#  991 |       let reflinks_supported = match sysroot.reflinks_supported() {
#      |  ______________________________^
#  992 | |         Ok(v) => Some(v),
#  993 | |         Err(_) => None,
#  994 | |     };
#      | |_____^ help: replace with: `sysroot.reflinks_supported().ok()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#manual_ok_err
#      = note: `#[warn(clippy::manual_ok_err)]` on by default

Error: CLIPPY_WARNING: [#def4]
crates/lib/src/image.rs:1801:5: warning: you seem to be trying to use `match` for an equality check. Consider using `if`
#       |
#  1801 | /     match crate::deploy::binding_state(&storage)? {
#  1802 | |         crate::deploy::BindingState::BoundOnly => {
#  1803 | |             println!(
#  1804 | |                 "ostree\u{2194}composefs binding is enabled but containers-storage participation is not; nothing to reconcile."
#  ...    |
#  1811 | |         _ => {}
#  1812 | |     }
#       | |_____^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#single_match
#       = note: `#[warn(clippy::single_match)]` on by default
#  help: try
#       |
#  1801 ~     if crate::deploy::binding_state(&storage)? == crate::deploy::BindingState::BoundOnly {
#  1802 +         println!(
#  1803 +             "ostree\u{2194}composefs binding is enabled but containers-storage participation is not; nothing to reconcile."
#  1804 +         );
#  1805 +         println!(
#  1806 +             "Run `bootc image set-unified full` to enable containers-storage participation."
#  1807 +         );
#  1808 +         return Ok(());
#  1809 +     }
#       |

Error: CLIPPY_WARNING: [#def5]
crates/lib/src/image.rs:2274:13: warning: unnecessary use of `to_string`
#       |
#  2274 |             &pull_result.manifest_digest.to_string(),
#       |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_to_owned

Error: CLIPPY_WARNING: [#def6]
crates/ostree-ext/src/container/composefs_import.rs:150:17: warning: this `map_or` can be simplified
#      |
#  150 |             && !value.last().copied().map_or(true, |b| b == 0)
#      |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_map_or
#      = note: `#[warn(clippy::unnecessary_map_or)]` on by default
#  help: use `is_none_or` instead
#      |
#  150 -             && !value.last().copied().map_or(true, |b| b == 0)
#  150 +             && !value.last().copied().is_none_or(|b| b == 0)
#      |

Error: CLIPPY_WARNING: [#def7]
crates/ostree-ext/src/container/composefs_import.rs:503:25: warning: this `map_or` can be simplified
#      |
#  503 |                     && !value.last().copied().map_or(true, |b| b == 0)
#      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_map_or
#  help: use `is_none_or` instead
#      |
#  503 -                     && !value.last().copied().map_or(true, |b| b == 0)
#  503 +                     && !value.last().copied().is_none_or(|b| b == 0)
#      |

Error: CLIPPY_WARNING: [#def8]
crates/xtask/src/tmt.rs:1268:9: warning: this `if` statement can be collapsed
#       |
#  1268 | /         if let serde_yaml::Value::Mapping(map) = &test.tmt {
#  1269 | |             if let Some(adjust) = map.get(&serde_yaml::Value::String(FIELD_ADJUST.to_string())) {
#  1270 | |                 plan_value.insert(
#  1271 | |                     serde_yaml::Value::String(FIELD_ADJUST.to_string()),
#  ...    |
#  1275 | |         }
#       | |_________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#collapsible_if
#  help: collapse nested if block
#       |
#  1268 ~         if let serde_yaml::Value::Mapping(map) = &test.tmt
#  1269 ~             && let Some(adjust) = map.get(&serde_yaml::Value::String(FIELD_ADJUST.to_string())) {
#  1270 |                 plan_value.insert(
#   ...
#  1273 |                 );
#  1274 ~             }
#       |

Scan Properties