Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/lib/src/deploy.rs:637:62: warning: unnecessary use of `to_string`
#      |
#  637 |         crate::bootc_composefs::repo::bootc_tag_for_manifest(&pull_result.manifest_digest.to_string());
#      |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_to_owned

Error: CLIPPY_WARNING: [#def2]
crates/lib/src/image.rs:339:30: warning: manual implementation of `ok`
#      |
#  339 |       let reflinks_supported = match sysroot.reflinks_supported() {
#      |  ______________________________^
#  340 | |         Ok(v) => Some(v),
#  341 | |         Err(_) => None,
#  342 | |     };
#      | |_____^ help: replace with: `sysroot.reflinks_supported().ok()`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#manual_ok_err
#      = note: `#[warn(clippy::manual_ok_err)]` on by default

Error: CLIPPY_WARNING: [#def3]
crates/lib/src/image.rs:1189:13: warning: unnecessary use of `to_string`
#       |
#  1189 |             &pull_result.manifest_digest.to_string(),
#       |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_to_owned

Error: CLIPPY_WARNING: [#def4]
crates/ostree-ext/src/container/composefs_import.rs:150:17: warning: this `map_or` can be simplified
#      |
#  150 |             && !value.last().copied().map_or(true, |b| b == 0)
#      |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_map_or
#      = note: `#[warn(clippy::unnecessary_map_or)]` on by default
#  help: use `is_none_or` instead
#      |
#  150 -             && !value.last().copied().map_or(true, |b| b == 0)
#  150 +             && !value.last().copied().is_none_or(|b| b == 0)
#      |

Error: CLIPPY_WARNING: [#def5]
crates/ostree-ext/src/container/composefs_import.rs:503:25: warning: this `map_or` can be simplified
#      |
#  503 |                     && !value.last().copied().map_or(true, |b| b == 0)
#      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_map_or
#  help: use `is_none_or` instead
#      |
#  503 -                     && !value.last().copied().map_or(true, |b| b == 0)
#  503 +                     && !value.last().copied().is_none_or(|b| b == 0)
#      |

Error: CLIPPY_WARNING: [#def6]
crates/xtask/src/tmt.rs:1239:9: warning: this `if` statement can be collapsed
#       |
#  1239 | /         if let serde_yaml::Value::Mapping(map) = &test.tmt {
#  1240 | |             if let Some(adjust) = map.get(&serde_yaml::Value::String(FIELD_ADJUST.to_string())) {
#  1241 | |                 plan_value.insert(
#  1242 | |                     serde_yaml::Value::String(FIELD_ADJUST.to_string()),
#  ...    |
#  1246 | |         }
#       | |_________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#collapsible_if
#  help: collapse nested if block
#       |
#  1239 ~         if let serde_yaml::Value::Mapping(map) = &test.tmt
#  1240 ~             && let Some(adjust) = map.get(&serde_yaml::Value::String(FIELD_ADJUST.to_string())) {
#  1241 |                 plan_value.insert(
#   ...
#  1244 |                 );
#  1245 ~             }
#       |

Scan Properties